Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13910/?format=api
{ "id": 13910, "url": "http://patches.dpdk.org/api/patches/13910/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1466080236-112618-4-git-send-email-david.hunt@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1466080236-112618-4-git-send-email-david.hunt@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1466080236-112618-4-git-send-email-david.hunt@intel.com", "date": "2016-06-16T12:30:36", "name": "[dpdk-dev,v13,3/3] mbuf: make default mempool ops configurable at build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06020189601a9439f1ae69f717bffd69ae1670a2", "submitter": { "id": 342, "url": "http://patches.dpdk.org/api/people/342/?format=api", "name": "Hunt, David", "email": "david.hunt@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1466080236-112618-4-git-send-email-david.hunt@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/13910/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/13910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 56611C6E0;\n\tThu, 16 Jun 2016 14:30:55 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 0B963C6B2\n\tfor <dev@dpdk.org>; Thu, 16 Jun 2016 14:30:46 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 16 Jun 2016 05:30:47 -0700", "from sie-lab-214-251.ir.intel.com (HELO silpixa373510.ir.intel.com)\n\t([10.237.214.251])\n\tby FMSMGA003.fm.intel.com with ESMTP; 16 Jun 2016 05:30:45 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,480,1459839600\"; d=\"scan'208\";a=\"720053752\"", "From": "David Hunt <david.hunt@intel.com>", "To": "dev@dpdk.org", "Cc": "olivier.matz@6wind.com, viktorin@rehivetech.com,\n\tjerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com,\n\tDavid Hunt <david.hunt@intel.com>", "Date": "Thu, 16 Jun 2016 13:30:36 +0100", "Message-Id": "<1466080236-112618-4-git-send-email-david.hunt@intel.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1466080236-112618-1-git-send-email-david.hunt@intel.com>", "References": "<1465976824-83823-1-git-send-email-david.hunt@intel.com>\n\t<1466080236-112618-1-git-send-email-david.hunt@intel.com>", "Subject": "[dpdk-dev] [PATCH v13 3/3] mbuf: make default mempool ops\n\tconfigurable at build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "By default, the mempool ops used for mbuf allocations is a multi\nproducer and multi consumer ring. We could imagine a target (maybe some\nnetwork processors?) that provides an hardware-assisted pool\nmechanism. In this case, the default configuration for this architecture\nwould contain a different value for RTE_MBUF_DEFAULT_MEMPOOL_OPS.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nSigned-off-by: David Hunt <david.hunt@intel.com>\nAcked-by: Shreyansh Jain <shreyansh.jain@nxp.com>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n config/common_base | 1 +\n lib/librte_mbuf/rte_mbuf.c | 26 ++++++++++++++++++++++----\n 2 files changed, 23 insertions(+), 4 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex b9ba405..13ad4dd 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -394,6 +394,7 @@ CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG=n\n #\n CONFIG_RTE_LIBRTE_MBUF=y\n CONFIG_RTE_LIBRTE_MBUF_DEBUG=n\n+CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS=\"ring_mp_mc\"\n CONFIG_RTE_MBUF_REFCNT_ATOMIC=y\n CONFIG_RTE_PKTMBUF_HEADROOM=128\n \ndiff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex eec1456..e72eb6b 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -153,6 +153,7 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,\n \tunsigned cache_size, uint16_t priv_size, uint16_t data_room_size,\n \tint socket_id)\n {\n+\tstruct rte_mempool *mp;\n \tstruct rte_pktmbuf_pool_private mbp_priv;\n \tunsigned elt_size;\n \n@@ -167,10 +168,27 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,\n \tmbp_priv.mbuf_data_room_size = data_room_size;\n \tmbp_priv.mbuf_priv_size = priv_size;\n \n-\treturn rte_mempool_create(name, n, elt_size,\n-\t\tcache_size, sizeof(struct rte_pktmbuf_pool_private),\n-\t\trte_pktmbuf_pool_init, &mbp_priv, rte_pktmbuf_init, NULL,\n-\t\tsocket_id, 0);\n+\tmp = rte_mempool_create_empty(name, n, elt_size, cache_size,\n+\t\t sizeof(struct rte_pktmbuf_pool_private), socket_id, 0);\n+\tif (mp == NULL)\n+\t\treturn NULL;\n+\n+\trte_errno = rte_mempool_set_ops_byname(mp,\n+\t\t\tRTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL);\n+\tif (rte_errno != 0) {\n+\t\tRTE_LOG(ERR, MBUF, \"error setting mempool handler\\n\");\n+\t\treturn NULL;\n+\t}\n+\trte_pktmbuf_pool_init(mp, &mbp_priv);\n+\n+\tif (rte_mempool_populate_default(mp) < 0) {\n+\t\trte_mempool_free(mp);\n+\t\treturn NULL;\n+\t}\n+\n+\trte_mempool_obj_iter(mp, rte_pktmbuf_init, NULL);\n+\n+\treturn mp;\n }\n \n /* do some sanity checks on a mbuf: panic if it fails */\n", "prefixes": [ "dpdk-dev", "v13", "3/3" ] }