Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139022/?format=api
{ "id": 139022, "url": "http://patches.dpdk.org/api/patches/139022/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-02T16:55:48", "name": "build: exclude rather than include libs in MSVC build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "17cf56571fbe3524a4d955801864433514507ac0", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31656, "url": "http://patches.dpdk.org/api/series/31656/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31656", "date": "2024-04-02T16:55:48", "name": "build: exclude rather than include libs in MSVC build", "version": 1, "mbox": "http://patches.dpdk.org/series/31656/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139022/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139022/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7773243DC3;\n\tTue, 2 Apr 2024 18:55:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 045D6402D5;\n\tTue, 2 Apr 2024 18:55:52 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id E23B64028C\n for <dev@dpdk.org>; Tue, 2 Apr 2024 18:55:49 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 3859E20E8BF3; Tue, 2 Apr 2024 09:55:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 3859E20E8BF3", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1712076949;\n bh=DYZCD2o+C8tFAEQ24MYme/mJCOJp2GLcBWUJtomM7cg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=bPpLvByejNYncXb77+b56Ea3wxBlLnUE+RNP5CXUeDRqDHUFR9h47nhJrlDZ9Y7TL\n 7ZLPRR7NOYsESyTqrJWDTqYiJ2ErokVyKaY4dmKK4HoeEuP6dMiLJ9MapJQiwB8GgO\n smm6ai4R+DQmBS7K6Yubtkcn7+v9+d89TmQZHQOY=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH] build: exclude rather than include libs in MSVC build", "Date": "Tue, 2 Apr 2024 09:55:48 -0700", "Message-Id": "<1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some libraries that could be built with MSVC were not being built.\n\nSwitch from explicit include to exclude of libs to get immediate CI\ncoverage of libraries that already work with MSVC Windows builds.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/argparse/meson.build | 6 ++++++\n lib/dmadev/meson.build | 6 ++++++\n lib/mbuf/meson.build | 6 ++++++\n lib/mempool/meson.build | 6 ++++++\n lib/meson.build | 10 ----------\n lib/rcu/meson.build | 6 ++++++\n lib/stack/meson.build | 6 ++++++\n 7 files changed, 36 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build\nindex b6a08ca..8ab4c40 100644\n--- a/lib/argparse/meson.build\n+++ b/lib/argparse/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2024 HiSilicon Limited.\n \n+if is_ms_compiler\n+ build = false\n+ reason = 'not supported building with Visual Studio Toolset'\n+ subdir_done()\n+endif\n+\n sources = files('rte_argparse.c')\n headers = files('rte_argparse.h')\n \ndiff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build\nindex 62b0650..e66dcb6 100644\n--- a/lib/dmadev/meson.build\n+++ b/lib/dmadev/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2021 HiSilicon Limited.\n \n+if is_ms_compiler\n+ build = false\n+ reason = 'not supported building with Visual Studio Toolset'\n+ subdir_done()\n+endif\n+\n sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c')\n headers = files('rte_dmadev.h')\n indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h')\ndiff --git a/lib/mbuf/meson.build b/lib/mbuf/meson.build\nindex 0435c5e..2cee905 100644\n--- a/lib/mbuf/meson.build\n+++ b/lib/mbuf/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n+if is_ms_compiler\n+ build = false\n+ reason = 'not supported building with Visual Studio Toolset'\n+ subdir_done()\n+endif\n+\n sources = files(\n 'rte_mbuf.c',\n 'rte_mbuf_ptype.c',\ndiff --git a/lib/mempool/meson.build b/lib/mempool/meson.build\nindex 8099a56..acce66c 100644\n--- a/lib/mempool/meson.build\n+++ b/lib/mempool/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n+if is_ms_compiler\n+ build = false\n+ reason = 'not supported building with Visual Studio Toolset'\n+ subdir_done()\n+endif\n+\n extra_flags = []\n \n foreach flag: extra_flags\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 179a272..94d2b72 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -68,16 +68,6 @@ libraries = [\n 'node',\n ]\n \n-if is_ms_compiler\n- libraries = [\n- 'log',\n- 'kvargs',\n- 'telemetry',\n- 'eal',\n- 'ring',\n- ]\n-endif\n-\n always_enable = [\n 'cmdline',\n 'eal',\ndiff --git a/lib/rcu/meson.build b/lib/rcu/meson.build\nindex 09abc52..71143f5 100644\n--- a/lib/rcu/meson.build\n+++ b/lib/rcu/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Arm Limited\n \n+if is_ms_compiler\n+ build = false\n+ reason = 'not supported building with Visual Studio Toolset'\n+ subdir_done()\n+endif\n+\n sources = files('rte_rcu_qsbr.c')\n headers = files('rte_rcu_qsbr.h')\n \ndiff --git a/lib/stack/meson.build b/lib/stack/meson.build\nindex 18177a7..7631a14 100644\n--- a/lib/stack/meson.build\n+++ b/lib/stack/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2019 Intel Corporation\n \n+if is_ms_compiler\n+ build = false\n+ reason = 'not supported building with Visual Studio Toolset'\n+ subdir_done()\n+endif\n+\n sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c')\n headers = files('rte_stack.h')\n # subheaders, not for direct inclusion by apps\n", "prefixes": [] }