Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138923/?format=api
{ "id": 138923, "url": "http://patches.dpdk.org/api/patches/138923/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711580958-20808-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711580958-20808-3-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T23:09:05", "name": "[v2,02/15] eal: pack structures when building with MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "34cfe7a4fbdd904403458c8dfb2be7b8dda05a85", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711580958-20808-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31634, "url": "http://patches.dpdk.org/api/series/31634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31634", "date": "2024-03-27T23:09:03", "name": "fix packing of structs when building with MSVC", "version": 2, "mbox": "http://patches.dpdk.org/series/31634/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138923/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138923/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CEB8343D5B;\n\tThu, 28 Mar 2024 00:09:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9147F410FC;\n\tThu, 28 Mar 2024 00:09:23 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 17960402D8\n for <dev@dpdk.org>; Thu, 28 Mar 2024 00:09:20 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4210C20E67DF; Wed, 27 Mar 2024 16:09:19 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4210C20E67DF", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711580959;\n bh=kp0voLVlsgnm3SiFtSQj+udwRi2MiyRQcwM5S0HhLJY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pZhkPPPlwz5L7khcjeJNjjIQnOp9IggSmUw6R/ArJzoDQPnYOcnEWNVbWmsxx5taP\n WMp5fbhV9e4ylQkWOACpGfRpxL1bSYVHC72sJtf1jw1SjidjivyjNsUA/20RXd3RiJ\n N8CbjeLHK1Q5Sj3UzoTBxd0ZMbxV5fnTPwk2BMps=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Conor Walsh <conor.walsh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Hunt <david.hunt@intel.com>, Jerin Jacob <jerinj@marvell.com>,\n Jingjing Wu <jingjing.wu@intel.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Radu Nicolau <radu.nicolau@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 02/15] eal: pack structures when building with MSVC", "Date": "Wed, 27 Mar 2024 16:09:05 -0700", "Message-Id": "<1711580958-20808-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>\n <1711580958-20808-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add __rte_msvc_pack to all __rte_packed structs to cause packing\nwhen building with MSVC.\n\nRemove __rte_packed where it appears natural alignment without\npacking would produce the same layout or the struct is internal.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/common/eal_private.h | 2 +-\n lib/eal/include/rte_memory.h | 1 +\n lib/eal/include/rte_memzone.h | 1 +\n lib/eal/include/rte_trace_point.h | 2 +-\n lib/eal/x86/include/rte_memcpy.h | 3 +++\n 5 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h\nindex 71523cf..4c929fb 100644\n--- a/lib/eal/common/eal_private.h\n+++ b/lib/eal/common/eal_private.h\n@@ -62,7 +62,7 @@ struct rte_config {\n \t * DPDK instances\n \t */\n \tstruct rte_mem_config *mem_config;\n-} __rte_packed;\n+};\n \n /**\n * Get the global configuration structure.\ndiff --git a/lib/eal/include/rte_memory.h b/lib/eal/include/rte_memory.h\nindex 842362d..73bb00d 100644\n--- a/lib/eal/include/rte_memory.h\n+++ b/lib/eal/include/rte_memory.h\n@@ -46,6 +46,7 @@\n /**\n * Physical memory segment descriptor.\n */\n+__rte_msvc_pack\n struct rte_memseg {\n \trte_iova_t iova; /**< Start IO address. */\n \tunion {\ndiff --git a/lib/eal/include/rte_memzone.h b/lib/eal/include/rte_memzone.h\nindex 931497f..ca312c0 100644\n--- a/lib/eal/include/rte_memzone.h\n+++ b/lib/eal/include/rte_memzone.h\n@@ -45,6 +45,7 @@\n * A structure describing a memzone, which is a contiguous portion of\n * physical memory identified by a name.\n */\n+__rte_msvc_pack\n struct rte_memzone {\n \n #define RTE_MEMZONE_NAMESIZE 32 /**< Maximum length of memory zone name.*/\ndiff --git a/lib/eal/include/rte_trace_point.h b/lib/eal/include/rte_trace_point.h\nindex 41e2a7f..e786ee3 100644\n--- a/lib/eal/include/rte_trace_point.h\n+++ b/lib/eal/include/rte_trace_point.h\n@@ -297,7 +297,7 @@ struct __rte_trace_stream_header {\n \trte_uuid_t uuid;\n \tuint32_t lcore_id;\n \tchar thread_name[__RTE_TRACE_EMIT_STRING_LEN_MAX];\n-} __rte_packed;\n+};\n \n struct __rte_trace_header {\n \tuint32_t offset;\ndiff --git a/lib/eal/x86/include/rte_memcpy.h b/lib/eal/x86/include/rte_memcpy.h\nindex 72a9229..fdc5df0 100644\n--- a/lib/eal/x86/include/rte_memcpy.h\n+++ b/lib/eal/x86/include/rte_memcpy.h\n@@ -57,12 +57,15 @@\n \t * Use the following structs to avoid violating C standard\n \t * alignment requirements and to avoid strict aliasing bugs\n \t */\n+\t__rte_msvc_pack\n \tstruct rte_uint64_alias {\n \t\tuint64_t val;\n \t} __rte_packed __rte_may_alias;\n+\t__rte_msvc_pack\n \tstruct rte_uint32_alias {\n \t\tuint32_t val;\n \t} __rte_packed __rte_may_alias;\n+\t__rte_msvc_pack\n \tstruct rte_uint16_alias {\n \t\tuint16_t val;\n \t} __rte_packed __rte_may_alias;\n", "prefixes": [ "v2", "02/15" ] }