Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138905/?format=api
{ "id": 138905, "url": "http://patches.dpdk.org/api/patches/138905/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-30-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711579078-10624-30-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711579078-10624-30-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T22:37:42", "name": "[v3,29/45] common/idpf: use rte stdatomic API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "31710b446b2d48f52893d5d45112447dbe3825f6", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-30-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31633, "url": "http://patches.dpdk.org/api/series/31633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31633", "date": "2024-03-27T22:37:13", "name": "use stdatomic API", "version": 3, "mbox": "http://patches.dpdk.org/series/31633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138905/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 21AE543D55;\n\tWed, 27 Mar 2024 23:41:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E2AC542E1A;\n\tWed, 27 Mar 2024 23:38:41 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 77591427E3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 23:38:07 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id DC87220E6F10; Wed, 27 Mar 2024 15:38:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com DC87220E6F10", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711579081;\n bh=ki5ngfqY5VqkiL94wrdSaMmkqnwwJeErn0uwjuqXlfQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=bc3Z6DwH6wXa70umA0vImLLedTKmf0KugPzzgyfJSDx8j0cYJrb6PH48jzIG/+Jw7\n 1bj7dEQidolsVK9BFaGkc1xBjEsjdG45iwr1FEBRteYyx/SWeygwn1JrNo+YmYajaK\n wkMaV4t19UBmQr2CHnuQcOZJkVQacxKQL/70Rwgg=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Abdullah Sevincer <abdullah.sevincer@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Alok Prasad <palok@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Chenbo Xia <chenbox@nvidia.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Ciara Loftus <ciara.loftus@intel.com>, Ciara Power <ciara.power@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jakub Grajciar <jgrajcia@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jeroen de Borst <jeroendb@google.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jie Hai <haijie1@huawei.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Joshua Washington <joshwash@google.com>,\n Joyce Kong <joyce.kong@arm.com>, Junfeng Guo <junfeng.guo@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Liang Ma <liangma@liangbit.com>, Long Li <longli@microsoft.com>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Peter Mccarthy <peter.mccarthy@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Rosen Xu <rosen.xu@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Rushil Gupta <rushilg@google.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 29/45] common/idpf: use rte stdatomic API", "Date": "Wed, 27 Mar 2024 15:37:42 -0700", "Message-Id": "<1711579078-10624-30-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com>\n <1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional rte stdatomic API.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/idpf/idpf_common_device.h | 6 +++---\n drivers/common/idpf/idpf_common_rxtx.c | 14 ++++++++------\n drivers/common/idpf/idpf_common_rxtx.h | 2 +-\n drivers/common/idpf/idpf_common_rxtx_avx512.c | 16 ++++++++--------\n 4 files changed, 20 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_device.h b/drivers/common/idpf/idpf_common_device.h\nindex 2b94f03..6a44cec 100644\n--- a/drivers/common/idpf/idpf_common_device.h\n+++ b/drivers/common/idpf/idpf_common_device.h\n@@ -48,7 +48,7 @@ struct idpf_adapter {\n \tstruct idpf_hw hw;\n \tstruct virtchnl2_version_info virtchnl_version;\n \tstruct virtchnl2_get_capabilities caps;\n-\tvolatile uint32_t pend_cmd; /* pending command not finished */\n+\tvolatile RTE_ATOMIC(uint32_t) pend_cmd; /* pending command not finished */\n \tuint32_t cmd_retval; /* return value of the cmd response from cp */\n \tuint8_t *mbx_resp; /* buffer to store the mailbox response from cp */\n \n@@ -179,8 +179,8 @@ struct idpf_cmd_info {\n atomic_set_cmd(struct idpf_adapter *adapter, uint32_t ops)\n {\n \tuint32_t op_unk = VIRTCHNL2_OP_UNKNOWN;\n-\tbool ret = __atomic_compare_exchange(&adapter->pend_cmd, &op_unk, &ops,\n-\t\t\t\t\t 0, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE);\n+\tbool ret = rte_atomic_compare_exchange_strong_explicit(&adapter->pend_cmd, &op_unk, ops,\n+\t\t\t\t\t rte_memory_order_acquire, rte_memory_order_acquire);\n \n \tif (!ret)\n \t\tDRV_LOG(ERR, \"There is incomplete cmd %d\", adapter->pend_cmd);\ndiff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c\nindex 83b131e..b09c58c 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.c\n+++ b/drivers/common/idpf/idpf_common_rxtx.c\n@@ -592,8 +592,8 @@\n \t\t\tnext_avail = 0;\n \t\t\trx_bufq->nb_rx_hold -= delta;\n \t\t} else {\n-\t\t\t__atomic_fetch_add(&rx_bufq->rx_stats.mbuf_alloc_failed,\n-\t\t\t\t\t nb_desc - next_avail, __ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(&rx_bufq->rx_stats.mbuf_alloc_failed,\n+\t\t\t\t\t nb_desc - next_avail, rte_memory_order_relaxed);\n \t\t\tRX_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u queue_id=%u\",\n \t\t\t rx_bufq->port_id, rx_bufq->queue_id);\n \t\t\treturn;\n@@ -612,8 +612,8 @@\n \t\t\tnext_avail += nb_refill;\n \t\t\trx_bufq->nb_rx_hold -= nb_refill;\n \t\t} else {\n-\t\t\t__atomic_fetch_add(&rx_bufq->rx_stats.mbuf_alloc_failed,\n-\t\t\t\t\t nb_desc - next_avail, __ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(&rx_bufq->rx_stats.mbuf_alloc_failed,\n+\t\t\t\t\t nb_desc - next_avail, rte_memory_order_relaxed);\n \t\t\tRX_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u queue_id=%u\",\n \t\t\t rx_bufq->port_id, rx_bufq->queue_id);\n \t\t}\n@@ -1093,7 +1093,8 @@\n \n \t\tnmb = rte_mbuf_raw_alloc(rxq->mp);\n \t\tif (unlikely(nmb == NULL)) {\n-\t\t\t__atomic_fetch_add(&rxq->rx_stats.mbuf_alloc_failed, 1, __ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(&rxq->rx_stats.mbuf_alloc_failed, 1,\n+\t\t\t rte_memory_order_relaxed);\n \t\t\tRX_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u \"\n \t\t\t \"queue_id=%u\", rxq->port_id, rxq->queue_id);\n \t\t\tbreak;\n@@ -1203,7 +1204,8 @@\n \n \t\tnmb = rte_mbuf_raw_alloc(rxq->mp);\n \t\tif (unlikely(!nmb)) {\n-\t\t\t__atomic_fetch_add(&rxq->rx_stats.mbuf_alloc_failed, 1, __ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(&rxq->rx_stats.mbuf_alloc_failed, 1,\n+\t\t\t rte_memory_order_relaxed);\n \t\t\tRX_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u \"\n \t\t\t \"queue_id=%u\", rxq->port_id, rxq->queue_id);\n \t\t\tbreak;\ndiff --git a/drivers/common/idpf/idpf_common_rxtx.h b/drivers/common/idpf/idpf_common_rxtx.h\nindex b49b1ed..eeeeed1 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.h\n+++ b/drivers/common/idpf/idpf_common_rxtx.h\n@@ -97,7 +97,7 @@\n #define IDPF_RX_SPLIT_BUFQ2_ID\t2\n \n struct idpf_rx_stats {\n-\tuint64_t mbuf_alloc_failed;\n+\tRTE_ATOMIC(uint64_t) mbuf_alloc_failed;\n };\n \n struct idpf_rx_queue {\ndiff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c b/drivers/common/idpf/idpf_common_rxtx_avx512.c\nindex f65e8d5..3b5e124 100644\n--- a/drivers/common/idpf/idpf_common_rxtx_avx512.c\n+++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c\n@@ -38,8 +38,8 @@\n \t\t\t\t\t\tdma_addr0);\n \t\t\t}\n \t\t}\n-\t\t__atomic_fetch_add(&rxq->rx_stats.mbuf_alloc_failed,\n-\t\t\t\t IDPF_RXQ_REARM_THRESH, __ATOMIC_RELAXED);\n+\t\trte_atomic_fetch_add_explicit(&rxq->rx_stats.mbuf_alloc_failed,\n+\t\t\t\t IDPF_RXQ_REARM_THRESH, rte_memory_order_relaxed);\n \t\treturn;\n \t}\n \tstruct rte_mbuf *mb0, *mb1, *mb2, *mb3;\n@@ -168,8 +168,8 @@\n \t\t\t\t\t\t\t dma_addr0);\n \t\t\t\t}\n \t\t\t}\n-\t\t\t__atomic_fetch_add(&rxq->rx_stats.mbuf_alloc_failed,\n-\t\t\t\t\t IDPF_RXQ_REARM_THRESH, __ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(&rxq->rx_stats.mbuf_alloc_failed,\n+\t\t\t\t\t IDPF_RXQ_REARM_THRESH, rte_memory_order_relaxed);\n \t\t\treturn;\n \t\t}\n \t}\n@@ -564,8 +564,8 @@\n \t\t\t\t\t\tdma_addr0);\n \t\t\t}\n \t\t}\n-\t__atomic_fetch_add(&rx_bufq->rx_stats.mbuf_alloc_failed,\n-\t\t\t IDPF_RXQ_REARM_THRESH, __ATOMIC_RELAXED);\n+\trte_atomic_fetch_add_explicit(&rx_bufq->rx_stats.mbuf_alloc_failed,\n+\t\t\t IDPF_RXQ_REARM_THRESH, rte_memory_order_relaxed);\n \t\treturn;\n \t}\n \n@@ -638,8 +638,8 @@\n \t\t\t\t\t\t\t dma_addr0);\n \t\t\t\t}\n \t\t\t}\n-\t\t__atomic_fetch_add(&rx_bufq->rx_stats.mbuf_alloc_failed,\n-\t\t\t\t IDPF_RXQ_REARM_THRESH, __ATOMIC_RELAXED);\n+\t\trte_atomic_fetch_add_explicit(&rx_bufq->rx_stats.mbuf_alloc_failed,\n+\t\t\t\t IDPF_RXQ_REARM_THRESH, rte_memory_order_relaxed);\n \t\t\treturn;\n \t\t}\n \t}\n", "prefixes": [ "v3", "29/45" ] }