Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138897/?format=api
{ "id": 138897, "url": "http://patches.dpdk.org/api/patches/138897/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-22-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711579078-10624-22-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711579078-10624-22-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T22:37:34", "name": "[v3,21/45] vdpa/mlx5: use rte stdatomic API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "723aeaa2dda9ff4a60bef32358b6e28a1f8d52b3", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-22-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31633, "url": "http://patches.dpdk.org/api/series/31633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31633", "date": "2024-03-27T22:37:13", "name": "use stdatomic API", "version": 3, "mbox": "http://patches.dpdk.org/series/31633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138897/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138897/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 862E243D55;\n\tWed, 27 Mar 2024 23:40:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C77B242DF5;\n\tWed, 27 Mar 2024 23:38:32 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 2E79C41153\n for <dev@dpdk.org>; Wed, 27 Mar 2024 23:38:05 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4E16D20E6AF8; Wed, 27 Mar 2024 15:38:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4E16D20E6AF8", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711579081;\n bh=bXbpoIMxIj3jZgJ/gx07ssZhwBmz2bAQUHgoqZIGlFI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=aq20Jp2xtQjHQZrMvqEyCFAHc9xBx/vPLR0I2g/6GMcA5jaK40iLZmFhPBcArfkv5\n HL36r6ZOfGLmFoTkuAoQYxZ9F/QxMxHmv7t2u2jFqTDtl3WucXoYkqJB0YBvbXpIs6\n OC+yFfq5oYhPQeCiWVe3douSURAu9Q5t93ovGdjI=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Abdullah Sevincer <abdullah.sevincer@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Alok Prasad <palok@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Chenbo Xia <chenbox@nvidia.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Ciara Loftus <ciara.loftus@intel.com>, Ciara Power <ciara.power@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jakub Grajciar <jgrajcia@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jeroen de Borst <jeroendb@google.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jie Hai <haijie1@huawei.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Joshua Washington <joshwash@google.com>,\n Joyce Kong <joyce.kong@arm.com>, Junfeng Guo <junfeng.guo@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Liang Ma <liangma@liangbit.com>, Long Li <longli@microsoft.com>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Peter Mccarthy <peter.mccarthy@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Rosen Xu <rosen.xu@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Rushil Gupta <rushilg@google.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 21/45] vdpa/mlx5: use rte stdatomic API", "Date": "Wed, 27 Mar 2024 15:37:34 -0700", "Message-Id": "<1711579078-10624-22-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com>\n <1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional rte stdatomic API.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 24 +++++++++---------\n drivers/vdpa/mlx5/mlx5_vdpa.h | 14 +++++------\n drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 46 +++++++++++++++++------------------\n drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 4 ++-\n drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 4 ++-\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 4 ++-\n 6 files changed, 52 insertions(+), 44 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex f900384..98c39a5 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -261,8 +261,8 @@\n \tuint32_t timeout = 0;\n \n \t/* Check and wait all close tasks done. */\n-\twhile (__atomic_load_n(&priv->dev_close_progress,\n-\t\t__ATOMIC_RELAXED) != 0 && timeout < 1000) {\n+\twhile (rte_atomic_load_explicit(&priv->dev_close_progress,\n+\t\trte_memory_order_relaxed) != 0 && timeout < 1000) {\n \t\trte_delay_us_sleep(10000);\n \t\ttimeout++;\n \t}\n@@ -294,8 +294,8 @@\n \t\t\tpriv->last_c_thrd_idx = 0;\n \t\telse\n \t\t\tpriv->last_c_thrd_idx++;\n-\t\t__atomic_store_n(&priv->dev_close_progress,\n-\t\t\t1, __ATOMIC_RELAXED);\n+\t\trte_atomic_store_explicit(&priv->dev_close_progress,\n+\t\t\t1, rte_memory_order_relaxed);\n \t\tif (mlx5_vdpa_task_add(priv,\n \t\t\tpriv->last_c_thrd_idx,\n \t\t\tMLX5_VDPA_TASK_DEV_CLOSE_NOWAIT,\n@@ -319,8 +319,8 @@\n \tif (!priv->connected)\n \t\tmlx5_vdpa_dev_cache_clean(priv);\n \tpriv->vid = 0;\n-\t__atomic_store_n(&priv->dev_close_progress, 0,\n-\t\t__ATOMIC_RELAXED);\n+\trte_atomic_store_explicit(&priv->dev_close_progress, 0,\n+\t\trte_memory_order_relaxed);\n \tpriv->state = MLX5_VDPA_STATE_PROBED;\n \tDRV_LOG(INFO, \"vDPA device %d was closed.\", vid);\n \treturn ret;\n@@ -664,7 +664,9 @@\n static int\n mlx5_vdpa_virtq_resource_prepare(struct mlx5_vdpa_priv *priv)\n {\n-\tuint32_t remaining_cnt = 0, err_cnt = 0, task_num = 0;\n+\tRTE_ATOMIC(uint32_t) remaining_cnt = 0;\n+\tRTE_ATOMIC(uint32_t) err_cnt = 0;\n+\tuint32_t task_num = 0;\n \tuint32_t max_queues, index, thrd_idx, data[1];\n \tstruct mlx5_vdpa_virtq *virtq;\n \n@@ -847,8 +849,8 @@\n \t\tif (conf_thread_mng.initializer_priv == priv)\n \t\t\tif (mlx5_vdpa_mult_threads_create())\n \t\t\t\tgoto error;\n-\t\t__atomic_fetch_add(&conf_thread_mng.refcnt, 1,\n-\t\t\t__ATOMIC_RELAXED);\n+\t\trte_atomic_fetch_add_explicit(&conf_thread_mng.refcnt, 1,\n+\t\t\trte_memory_order_relaxed);\n \t}\n \tif (mlx5_vdpa_create_dev_resources(priv))\n \t\tgoto error;\n@@ -937,8 +939,8 @@\n \tif (priv->vdev)\n \t\trte_vdpa_unregister_device(priv->vdev);\n \tif (priv->use_c_thread)\n-\t\tif (__atomic_fetch_sub(&conf_thread_mng.refcnt,\n-\t\t\t1, __ATOMIC_RELAXED) == 1)\n+\t\tif (rte_atomic_fetch_sub_explicit(&conf_thread_mng.refcnt,\n+\t\t\t1, rte_memory_order_relaxed) == 1)\n \t\t\tmlx5_vdpa_mult_threads_destroy(true);\n \trte_free(priv);\n }\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h\nindex 7b37c98..0cc67ed 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.h\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.h\n@@ -93,8 +93,8 @@ enum mlx5_vdpa_task_type {\n struct mlx5_vdpa_task {\n \tstruct mlx5_vdpa_priv *priv;\n \tenum mlx5_vdpa_task_type type;\n-\tuint32_t *remaining_cnt;\n-\tuint32_t *err_cnt;\n+\tRTE_ATOMIC(uint32_t) *remaining_cnt;\n+\tRTE_ATOMIC(uint32_t) *err_cnt;\n \tuint32_t idx;\n } __rte_packed __rte_aligned(4);\n \n@@ -107,7 +107,7 @@ struct mlx5_vdpa_c_thread {\n \n struct mlx5_vdpa_conf_thread_mng {\n \tvoid *initializer_priv;\n-\tuint32_t refcnt;\n+\tRTE_ATOMIC(uint32_t) refcnt;\n \tuint32_t max_thrds;\n \tpthread_mutex_t cthrd_lock;\n \tstruct mlx5_vdpa_c_thread cthrd[MLX5_VDPA_MAX_C_THRD];\n@@ -212,7 +212,7 @@ struct mlx5_vdpa_priv {\n \tuint64_t features; /* Negotiated features. */\n \tuint16_t log_max_rqt_size;\n \tuint16_t last_c_thrd_idx;\n-\tuint16_t dev_close_progress;\n+\tRTE_ATOMIC(uint16_t) dev_close_progress;\n \tuint16_t num_mrs; /* Number of memory regions. */\n \tstruct mlx5_vdpa_steer steer;\n \tstruct mlx5dv_var *var;\n@@ -581,13 +581,13 @@ int mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv *priv, uint64_t log_base,\n mlx5_vdpa_task_add(struct mlx5_vdpa_priv *priv,\n \t\tuint32_t thrd_idx,\n \t\tenum mlx5_vdpa_task_type task_type,\n-\t\tuint32_t *remaining_cnt, uint32_t *err_cnt,\n+\t\tRTE_ATOMIC(uint32_t) *remaining_cnt, RTE_ATOMIC(uint32_t) *err_cnt,\n \t\tvoid **task_data, uint32_t num);\n int\n mlx5_vdpa_register_mr(struct mlx5_vdpa_priv *priv, uint32_t idx);\n bool\n-mlx5_vdpa_c_thread_wait_bulk_tasks_done(uint32_t *remaining_cnt,\n-\t\tuint32_t *err_cnt, uint32_t sleep_time);\n+mlx5_vdpa_c_thread_wait_bulk_tasks_done(RTE_ATOMIC(uint32_t) *remaining_cnt,\n+\t\tRTE_ATOMIC(uint32_t) *err_cnt, uint32_t sleep_time);\n int\n mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, int index, bool reg_kick);\n void\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c b/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c\nindex 68ed841..84f611c 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c\n@@ -48,7 +48,7 @@\n mlx5_vdpa_task_add(struct mlx5_vdpa_priv *priv,\n \t\tuint32_t thrd_idx,\n \t\tenum mlx5_vdpa_task_type task_type,\n-\t\tuint32_t *remaining_cnt, uint32_t *err_cnt,\n+\t\tRTE_ATOMIC(uint32_t) *remaining_cnt, RTE_ATOMIC(uint32_t) *err_cnt,\n \t\tvoid **task_data, uint32_t num)\n {\n \tstruct rte_ring *rng = conf_thread_mng.cthrd[thrd_idx].rng;\n@@ -70,8 +70,8 @@\n \t\treturn -1;\n \tfor (i = 0 ; i < num; i++)\n \t\tif (task[i].remaining_cnt)\n-\t\t\t__atomic_fetch_add(task[i].remaining_cnt, 1,\n-\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(task[i].remaining_cnt, 1,\n+\t\t\t\trte_memory_order_relaxed);\n \t/* wake up conf thread. */\n \tpthread_mutex_lock(&conf_thread_mng.cthrd_lock);\n \tpthread_cond_signal(&conf_thread_mng.cthrd[thrd_idx].c_cond);\n@@ -80,16 +80,16 @@\n }\n \n bool\n-mlx5_vdpa_c_thread_wait_bulk_tasks_done(uint32_t *remaining_cnt,\n-\t\tuint32_t *err_cnt, uint32_t sleep_time)\n+mlx5_vdpa_c_thread_wait_bulk_tasks_done(RTE_ATOMIC(uint32_t) *remaining_cnt,\n+\t\tRTE_ATOMIC(uint32_t) *err_cnt, uint32_t sleep_time)\n {\n \t/* Check and wait all tasks done. */\n-\twhile (__atomic_load_n(remaining_cnt,\n-\t\t__ATOMIC_RELAXED) != 0) {\n+\twhile (rte_atomic_load_explicit(remaining_cnt,\n+\t\trte_memory_order_relaxed) != 0) {\n \t\trte_delay_us_sleep(sleep_time);\n \t}\n-\tif (__atomic_load_n(err_cnt,\n-\t\t__ATOMIC_RELAXED)) {\n+\tif (rte_atomic_load_explicit(err_cnt,\n+\t\trte_memory_order_relaxed)) {\n \t\tDRV_LOG(ERR, \"Tasks done with error.\");\n \t\treturn true;\n \t}\n@@ -137,8 +137,8 @@\n \t\t\tif (ret) {\n \t\t\t\tDRV_LOG(ERR,\n \t\t\t\t\"Failed to register mr %d.\", task.idx);\n-\t\t\t\t__atomic_fetch_add(task.err_cnt, 1,\n-\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\t\trte_atomic_fetch_add_explicit(task.err_cnt, 1,\n+\t\t\t\trte_memory_order_relaxed);\n \t\t\t}\n \t\t\tbreak;\n \t\tcase MLX5_VDPA_TASK_SETUP_VIRTQ:\n@@ -149,8 +149,8 @@\n \t\t\tif (ret) {\n \t\t\t\tDRV_LOG(ERR,\n \t\t\t\t\t\"Failed to setup virtq %d.\", task.idx);\n-\t\t\t\t__atomic_fetch_add(\n-\t\t\t\t\ttask.err_cnt, 1, __ATOMIC_RELAXED);\n+\t\t\t\trte_atomic_fetch_add_explicit(\n+\t\t\t\t\ttask.err_cnt, 1, rte_memory_order_relaxed);\n \t\t\t}\n \t\t\tvirtq->enable = 1;\n \t\t\tpthread_mutex_unlock(&virtq->virtq_lock);\n@@ -164,9 +164,9 @@\n \t\t\t\tDRV_LOG(ERR,\n \t\t\t\t\"Failed to stop virtq %d.\",\n \t\t\t\ttask.idx);\n-\t\t\t\t__atomic_fetch_add(\n+\t\t\t\trte_atomic_fetch_add_explicit(\n \t\t\t\t\ttask.err_cnt, 1,\n-\t\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\t\t\trte_memory_order_relaxed);\n \t\t\t\tpthread_mutex_unlock(&virtq->virtq_lock);\n \t\t\t\tbreak;\n \t\t\t}\n@@ -176,9 +176,9 @@\n \t\t\t\tDRV_LOG(ERR,\n \t\t\"Failed to get negotiated features virtq %d.\",\n \t\t\t\ttask.idx);\n-\t\t\t\t__atomic_fetch_add(\n+\t\t\t\trte_atomic_fetch_add_explicit(\n \t\t\t\t\ttask.err_cnt, 1,\n-\t\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\t\t\trte_memory_order_relaxed);\n \t\t\t\tpthread_mutex_unlock(&virtq->virtq_lock);\n \t\t\t\tbreak;\n \t\t\t}\n@@ -200,9 +200,9 @@\n \t\t\tif (!priv->connected)\n \t\t\t\tmlx5_vdpa_dev_cache_clean(priv);\n \t\t\tpriv->vid = 0;\n-\t\t\t__atomic_store_n(\n+\t\t\trte_atomic_store_explicit(\n \t\t\t\t&priv->dev_close_progress, 0,\n-\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\t\trte_memory_order_relaxed);\n \t\t\tbreak;\n \t\tcase MLX5_VDPA_TASK_PREPARE_VIRTQ:\n \t\t\tret = mlx5_vdpa_virtq_single_resource_prepare(\n@@ -211,9 +211,9 @@\n \t\t\t\tDRV_LOG(ERR,\n \t\t\t\t\"Failed to prepare virtq %d.\",\n \t\t\t\ttask.idx);\n-\t\t\t\t__atomic_fetch_add(\n+\t\t\t\trte_atomic_fetch_add_explicit(\n \t\t\t\ttask.err_cnt, 1,\n-\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\t\trte_memory_order_relaxed);\n \t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n@@ -222,8 +222,8 @@\n \t\t\tbreak;\n \t\t}\n \t\tif (task.remaining_cnt)\n-\t\t\t__atomic_fetch_sub(task.remaining_cnt,\n-\t\t\t1, __ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_sub_explicit(task.remaining_cnt,\n+\t\t\t1, rte_memory_order_relaxed);\n \t}\n \treturn 0;\n }\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c\nindex 0fa671f..a207734 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c\n@@ -92,7 +92,9 @@\n int\n mlx5_vdpa_lm_log(struct mlx5_vdpa_priv *priv)\n {\n-\tuint32_t remaining_cnt = 0, err_cnt = 0, task_num = 0;\n+\tRTE_ATOMIC(uint32_t) remaining_cnt = 0;\n+\tRTE_ATOMIC(uint32_t) err_cnt = 0;\n+\tuint32_t task_num = 0;\n \tuint32_t i, thrd_idx, data[1];\n \tstruct mlx5_vdpa_virtq *virtq;\n \tuint64_t features;\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c\nindex e333f0b..4dfe800 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c\n@@ -279,7 +279,9 @@\n \tuint8_t mode = 0;\n \tint ret = -rte_errno;\n \tuint32_t i, thrd_idx, data[1];\n-\tuint32_t remaining_cnt = 0, err_cnt = 0, task_num = 0;\n+\tRTE_ATOMIC(uint32_t) remaining_cnt = 0;\n+\tRTE_ATOMIC(uint32_t) err_cnt = 0;\n+\tuint32_t task_num = 0;\n \tstruct rte_vhost_memory *mem = mlx5_vdpa_vhost_mem_regions_prepare\n \t\t\t(priv->vid, &mode, &priv->vmem_info.size,\n \t\t\t&priv->vmem_info.gcd, &priv->vmem_info.entries_num);\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\nindex 607e290..093cdd0 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n@@ -666,7 +666,9 @@\n {\n \tint ret = rte_vhost_get_negotiated_features(priv->vid, &priv->features);\n \tuint16_t nr_vring = rte_vhost_get_vring_num(priv->vid);\n-\tuint32_t remaining_cnt = 0, err_cnt = 0, task_num = 0;\n+\tRTE_ATOMIC(uint32_t) remaining_cnt = 0;\n+\tRTE_ATOMIC(uint32_t) err_cnt = 0;\n+\tuint32_t task_num = 0;\n \tuint32_t i, thrd_idx, data[1];\n \tstruct mlx5_vdpa_virtq *virtq;\n \tstruct rte_vhost_vring vq;\n", "prefixes": [ "v3", "21/45" ] }