Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138886/?format=api
{ "id": 138886, "url": "http://patches.dpdk.org/api/patches/138886/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-10-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711579078-10624-10-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711579078-10624-10-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T22:37:22", "name": "[v3,09/45] net/af_xdp: use rte stdatomic API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b4d2aa51236136b83c1de1225262956c36c3ae56", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-10-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31633, "url": "http://patches.dpdk.org/api/series/31633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31633", "date": "2024-03-27T22:37:13", "name": "use stdatomic API", "version": 3, "mbox": "http://patches.dpdk.org/series/31633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138886/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138886/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86D4043D55;\n\tWed, 27 Mar 2024 23:39:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 46D9242D89;\n\tWed, 27 Mar 2024 23:38:19 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4AF94410E3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 23:38:02 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 6CF1B20E695F; Wed, 27 Mar 2024 15:38:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 6CF1B20E695F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711579080;\n bh=wONaNFbTIxe7eFVCknq4cizkaGgbzHLBrxyTBXHcU0g=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gDC4yY5I2kqgpBKxzP9TWEHvNf6X1iNHwq8w6gdI+beb61sOFX44VhlRA/UjLZJ4g\n TNOxbA9zLr0GS9R3pHk9gk9OtH0WzCPJTNzKUnXqiOiIy402mfMSNZXRh4m/PZFuYn\n 7alrDxf2YfqKfyTke2d8j37q/NcuDYVF/LI9K2NU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Abdullah Sevincer <abdullah.sevincer@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Alok Prasad <palok@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Chenbo Xia <chenbox@nvidia.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Ciara Loftus <ciara.loftus@intel.com>, Ciara Power <ciara.power@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jakub Grajciar <jgrajcia@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jeroen de Borst <jeroendb@google.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jie Hai <haijie1@huawei.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Joshua Washington <joshwash@google.com>,\n Joyce Kong <joyce.kong@arm.com>, Junfeng Guo <junfeng.guo@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Liang Ma <liangma@liangbit.com>, Long Li <longli@microsoft.com>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Peter Mccarthy <peter.mccarthy@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Rosen Xu <rosen.xu@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Rushil Gupta <rushilg@google.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 09/45] net/af_xdp: use rte stdatomic API", "Date": "Wed, 27 Mar 2024 15:37:22 -0700", "Message-Id": "<1711579078-10624-10-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com>\n <1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional rte stdatomic API.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 268a130..4833180 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -116,7 +116,7 @@ struct xsk_umem_info {\n \tconst struct rte_memzone *mz;\n \tstruct rte_mempool *mb_pool;\n \tvoid *buffer;\n-\tuint8_t refcnt;\n+\tRTE_ATOMIC(uint8_t) refcnt;\n \tuint32_t max_xsks;\n };\n \n@@ -995,7 +995,8 @@ static int link_xdp_prog_with_dev(int ifindex, int fd, __u32 flags)\n \t\t\tbreak;\n \t\txsk_socket__delete(rxq->xsk);\n \n-\t\tif (__atomic_fetch_sub(&rxq->umem->refcnt, 1, __ATOMIC_ACQUIRE) - 1 == 0)\n+\t\tif (rte_atomic_fetch_sub_explicit(&rxq->umem->refcnt, 1,\n+\t\t rte_memory_order_acquire) - 1 == 0)\n \t\t\txdp_umem_destroy(rxq->umem);\n \n \t\t/* free pkt_tx_queue */\n@@ -1097,8 +1098,8 @@ static inline uintptr_t get_base_addr(struct rte_mempool *mp, uint64_t *align)\n \t\t\t\t\tret = -1;\n \t\t\t\t\tgoto out;\n \t\t\t\t}\n-\t\t\t\tif (__atomic_load_n(&internals->rx_queues[i].umem->refcnt,\n-\t\t\t\t\t\t __ATOMIC_ACQUIRE)) {\n+\t\t\t\tif (rte_atomic_load_explicit(&internals->rx_queues[i].umem->refcnt,\n+\t\t\t\t\t\t rte_memory_order_acquire)) {\n \t\t\t\t\t*umem = internals->rx_queues[i].umem;\n \t\t\t\t\tgoto out;\n \t\t\t\t}\n@@ -1131,11 +1132,11 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \t\t\treturn NULL;\n \n \t\tif (umem != NULL &&\n-\t\t\t__atomic_load_n(&umem->refcnt, __ATOMIC_ACQUIRE) <\n+\t\t\trte_atomic_load_explicit(&umem->refcnt, rte_memory_order_acquire) <\n \t\t\t\t\tumem->max_xsks) {\n \t\t\tAF_XDP_LOG(INFO, \"%s,qid%i sharing UMEM\\n\",\n \t\t\t\t\tinternals->if_name, rxq->xsk_queue_idx);\n-\t\t\t__atomic_fetch_add(&umem->refcnt, 1, __ATOMIC_ACQUIRE);\n+\t\t\trte_atomic_fetch_add_explicit(&umem->refcnt, 1, rte_memory_order_acquire);\n \t\t}\n \t}\n \n@@ -1177,7 +1178,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \t\t\t\t\t\tmb_pool->name, umem->max_xsks);\n \t\t}\n \n-\t\t__atomic_store_n(&umem->refcnt, 1, __ATOMIC_RELEASE);\n+\t\trte_atomic_store_explicit(&umem->refcnt, 1, rte_memory_order_release);\n \t}\n \n \treturn umem;\n@@ -1606,7 +1607,8 @@ struct msg_internal {\n \tif (rxq->umem == NULL)\n \t\treturn -ENOMEM;\n \ttxq->umem = rxq->umem;\n-\treserve_before = __atomic_load_n(&rxq->umem->refcnt, __ATOMIC_ACQUIRE) <= 1;\n+\treserve_before = rte_atomic_load_explicit(&rxq->umem->refcnt,\n+\t rte_memory_order_acquire) <= 1;\n \n #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)\n \tret = rte_pktmbuf_alloc_bulk(rxq->umem->mb_pool, fq_bufs, reserve_size);\n@@ -1723,7 +1725,7 @@ struct msg_internal {\n out_xsk:\n \txsk_socket__delete(rxq->xsk);\n out_umem:\n-\tif (__atomic_fetch_sub(&rxq->umem->refcnt, 1, __ATOMIC_ACQUIRE) - 1 == 0)\n+\tif (rte_atomic_fetch_sub_explicit(&rxq->umem->refcnt, 1, rte_memory_order_acquire) - 1 == 0)\n \t\txdp_umem_destroy(rxq->umem);\n \n \treturn ret;\n", "prefixes": [ "v3", "09/45" ] }