Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138877/?format=api
{ "id": 138877, "url": "http://patches.dpdk.org/api/patches/138877/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711579078-10624-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711579078-10624-3-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T22:37:15", "name": "[v3,02/45] net/ixgbe: use rte stdatomic API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8639167cfcb088e91d5dcb14956eb5107c923d17", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1711579078-10624-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31633, "url": "http://patches.dpdk.org/api/series/31633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31633", "date": "2024-03-27T22:37:13", "name": "use stdatomic API", "version": 3, "mbox": "http://patches.dpdk.org/series/31633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138877/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/138877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EDACB43D55;\n\tWed, 27 Mar 2024 23:38:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A486A410FD;\n\tWed, 27 Mar 2024 23:38:03 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id CE9F3410E3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 23:38:00 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E5FF220E67DF; Wed, 27 Mar 2024 15:37:59 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E5FF220E67DF", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711579079;\n bh=dxp55qJQmUVSd6Q5nO4z9Ip8U1+23bi+k4gk1Cgci8s=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=KKHbHp42x0th6csoTJvXCOv4Jr16Y5EUiSPSs2g9LTIP12Qn1XPvWG0NgI7ZUtcZT\n nszsA0OYoYS0SYxCOMGmw9AAfwl5e1upNCbVmWx6sn6X/tsAiUw6x4rYvmkieiWvy1\n I//4BiCEI/1zWPgUbKuh5nFigCOKXgyUVjW5YLQI=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Abdullah Sevincer <abdullah.sevincer@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Alok Prasad <palok@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Chenbo Xia <chenbox@nvidia.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Ciara Loftus <ciara.loftus@intel.com>, Ciara Power <ciara.power@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jakub Grajciar <jgrajcia@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jeroen de Borst <jeroendb@google.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jie Hai <haijie1@huawei.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Joshua Washington <joshwash@google.com>,\n Joyce Kong <joyce.kong@arm.com>, Junfeng Guo <junfeng.guo@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Liang Ma <liangma@liangbit.com>, Long Li <longli@microsoft.com>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Peter Mccarthy <peter.mccarthy@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Rosen Xu <rosen.xu@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Rushil Gupta <rushilg@google.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 02/45] net/ixgbe: use rte stdatomic API", "Date": "Wed, 27 Mar 2024 15:37:15 -0700", "Message-Id": "<1711579078-10624-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com>\n <1711579078-10624-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional rte stdatomic API.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++------\n drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-\n drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--\n 3 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex c61c52b..e63ae1a 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1130,7 +1130,7 @@ struct rte_ixgbe_xstats_name_off {\n \t}\n \n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);\n+\trte_atomic_store_explicit(&ad->link_thread_running, 0, rte_memory_order_seq_cst);\n \tixgbe_parse_devargs(eth_dev->data->dev_private,\n \t\t\t pci_dev->device.devargs);\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n@@ -1638,7 +1638,7 @@ static int ixgbe_l2_tn_filter_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);\n+\trte_atomic_store_explicit(&ad->link_thread_running, 0, rte_memory_order_seq_cst);\n \tixgbevf_parse_devargs(eth_dev->data->dev_private,\n \t\t\t pci_dev->device.devargs);\n \n@@ -4203,7 +4203,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \tuint32_t timeout = timeout_ms ? timeout_ms : WARNING_TIMEOUT;\n \n \t/* NOTE: review for potential ordering optimization */\n-\twhile (__atomic_load_n(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {\n+\twhile (rte_atomic_load_explicit(&ad->link_thread_running, rte_memory_order_seq_cst)) {\n \t\tmsec_delay(1);\n \t\ttimeout--;\n \n@@ -4240,7 +4240,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tintr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;\n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);\n+\trte_atomic_store_explicit(&ad->link_thread_running, 0, rte_memory_order_seq_cst);\n \treturn 0;\n }\n \n@@ -4336,7 +4336,8 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n \t\t\tixgbe_dev_wait_setup_link_complete(dev, 0);\n \t\t\t/* NOTE: review for potential ordering optimization */\n-\t\t\tif (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {\n+\t\t\tif (!rte_atomic_exchange_explicit(&ad->link_thread_running, 1,\n+\t\t\t rte_memory_order_seq_cst)) {\n \t\t\t\t/* To avoid race condition between threads, set\n \t\t\t\t * the IXGBE_FLAG_NEED_LINK_CONFIG flag only\n \t\t\t\t * when there is no link thread running.\n@@ -4348,7 +4349,8 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \t\t\t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t\t\t\"Create link thread failed!\");\n \t\t\t\t\t/* NOTE: review for potential ordering optimization */\n-\t\t\t\t\t__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);\n+\t\t\t\t\trte_atomic_store_explicit(&ad->link_thread_running, 0,\n+\t\t\t\t\t rte_memory_order_seq_cst);\n \t\t\t\t}\n \t\t\t} else {\n \t\t\t\tPMD_DRV_LOG(ERR,\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h\nindex 22fc3be..8ad841e 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.h\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.h\n@@ -511,7 +511,7 @@ struct ixgbe_adapter {\n \t */\n \tuint8_t pflink_fullchk;\n \tuint8_t mac_ctrl_frame_fwd;\n-\tbool link_thread_running;\n+\tRTE_ATOMIC(bool) link_thread_running;\n \trte_thread_t link_thread_tid;\n };\n \ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex f6c17d4..e7dfd6f 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -1831,7 +1831,7 @@\n \t\t * Use acquire fence to ensure that status_error which includes\n \t\t * DD bit is loaded before loading of other descriptor words.\n \t\t */\n-\t\trte_atomic_thread_fence(__ATOMIC_ACQUIRE);\n+\t\trte_atomic_thread_fence(rte_memory_order_acquire);\n \n \t\trxd = *rxdp;\n \n@@ -2114,7 +2114,7 @@\n \t\t * Use acquire fence to ensure that status_error which includes\n \t\t * DD bit is loaded before loading of other descriptor words.\n \t\t */\n-\t\trte_atomic_thread_fence(__ATOMIC_ACQUIRE);\n+\t\trte_atomic_thread_fence(rte_memory_order_acquire);\n \n \t\trxd = *rxdp;\n \n", "prefixes": [ "v3", "02/45" ] }