Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138831/?format=api
{ "id": 138831, "url": "http://patches.dpdk.org/api/patches/138831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240326190422.577028-6-luca.vizzarro@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326190422.577028-6-luca.vizzarro@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326190422.577028-6-luca.vizzarro@arm.com", "date": "2024-03-26T19:04:21", "name": "[5/6] dts: add statefulness to InteractiveShell", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "faceb8ab99b52441d948b2a74e0f4ff892178e6b", "submitter": { "id": 3197, "url": "http://patches.dpdk.org/api/people/3197/?format=api", "name": "Luca Vizzarro", "email": "luca.vizzarro@arm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240326190422.577028-6-luca.vizzarro@arm.com/mbox/", "series": [ { "id": 31622, "url": "http://patches.dpdk.org/api/series/31622/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31622", "date": "2024-03-26T19:04:16", "name": "dts: add testpmd params and statefulness", "version": 1, "mbox": "http://patches.dpdk.org/series/31622/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138831/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D004A43D5B;\n\tTue, 26 Mar 2024 20:05:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 30195427DA;\n\tTue, 26 Mar 2024 20:04:42 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id EEF334161A\n for <dev@dpdk.org>; Tue, 26 Mar 2024 20:04:37 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2546B2F4;\n Tue, 26 Mar 2024 12:05:11 -0700 (PDT)", "from localhost.localdomain (unknown [10.57.16.115])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7EAC23F64C;\n Tue, 26 Mar 2024 12:04:36 -0700 (PDT)" ], "From": "Luca Vizzarro <luca.vizzarro@arm.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>,\n Luca Vizzarro <luca.vizzarro@arm.com>,\n Jack Bond-Preston <jack.bond-preston@arm.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Subject": "[PATCH 5/6] dts: add statefulness to InteractiveShell", "Date": "Tue, 26 Mar 2024 19:04:21 +0000", "Message-Id": "<20240326190422.577028-6-luca.vizzarro@arm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240326190422.577028-1-luca.vizzarro@arm.com>", "References": "<20240326190422.577028-1-luca.vizzarro@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The InteractiveShell class can be started in privileged mode, but this\nis not saved for reference to the tests developer. Moreover, originally\na command timeout could only be set at initialisation, this can now be\namended and reset back as needed.\n\nSigned-off-by: Luca Vizzarro <luca.vizzarro@arm.com>\nReviewed-by: Jack Bond-Preston <jack.bond-preston@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n .../remote_session/interactive_shell.py | 18 +++++++++++++++++-\n 1 file changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/framework/remote_session/interactive_shell.py\nindex a2c7b30d9f..5d80061e8d 100644\n--- a/dts/framework/remote_session/interactive_shell.py\n+++ b/dts/framework/remote_session/interactive_shell.py\n@@ -41,8 +41,10 @@ class InteractiveShell(ABC):\n _stdout: channel.ChannelFile\n _ssh_channel: Channel\n _logger: DTSLogger\n+ __default_timeout: float\n _timeout: float\n _app_args: Params | None\n+ _is_privileged: bool = False\n \n #: Prompt to expect at the end of output when sending a command.\n #: This is often overridden by subclasses.\n@@ -88,7 +90,7 @@ def __init__(\n self._ssh_channel.settimeout(timeout)\n self._ssh_channel.set_combine_stderr(True) # combines stdout and stderr streams\n self._logger = logger\n- self._timeout = timeout\n+ self._timeout = self.__default_timeout = timeout\n self._app_args = app_args\n self._start_application(get_privileged_command)\n \n@@ -105,6 +107,7 @@ def _start_application(self, get_privileged_command: Callable[[str], str] | None\n start_command = f\"{self.path} {self._app_args or ''}\"\n if get_privileged_command is not None:\n start_command = get_privileged_command(start_command)\n+ self._is_privileged = True\n self.send_command(start_command)\n \n def send_command(self, command: str, prompt: str | None = None) -> str:\n@@ -150,3 +153,16 @@ def close(self) -> None:\n def __del__(self) -> None:\n \"\"\"Make sure the session is properly closed before deleting the object.\"\"\"\n self.close()\n+\n+ @property\n+ def is_privileged(self) -> bool:\n+ \"\"\"Property specifying if the interactive shell is running in privileged mode.\"\"\"\n+ return self._is_privileged\n+\n+ def set_timeout(self, timeout: float):\n+ \"\"\"Set the timeout to use with the next commands.\"\"\"\n+ self._timeout = timeout\n+\n+ def reset_timeout(self):\n+ \"\"\"Reset the timeout to the default setting.\"\"\"\n+ self._timeout = self.__default_timeout\n", "prefixes": [ "5/6" ] }