Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 138655,
    "url": "http://patches.dpdk.org/api/patches/138655/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240321083502.30552-1-arkadiuszx.kusztal@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240321083502.30552-1-arkadiuszx.kusztal@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240321083502.30552-1-arkadiuszx.kusztal@intel.com",
    "date": "2024-03-21T08:35:02",
    "name": "[v3] app/test: fix rsa tests in qat suite",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "d69554f295f86ce1466e8ceab301d8bba558fc46",
    "submitter": {
        "id": 452,
        "url": "http://patches.dpdk.org/api/people/452/?format=api",
        "name": "Arkadiusz Kusztal",
        "email": "arkadiuszx.kusztal@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240321083502.30552-1-arkadiuszx.kusztal@intel.com/mbox/",
    "series": [
        {
            "id": 31582,
            "url": "http://patches.dpdk.org/api/series/31582/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31582",
            "date": "2024-03-21T08:35:02",
            "name": "[v3] app/test: fix rsa tests in qat suite",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/31582/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/138655/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/138655/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3186443D11;\n\tThu, 21 Mar 2024 09:35:10 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 15FED427E1;\n\tThu, 21 Mar 2024 09:35:10 +0100 (CET)",
            "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by mails.dpdk.org (Postfix) with ESMTP id 224AF427DC;\n Thu, 21 Mar 2024 09:35:07 +0100 (CET)",
            "from orviesa006.jf.intel.com ([10.64.159.146])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Mar 2024 01:35:08 -0700",
            "from silpixa00400308.ir.intel.com ([10.237.214.154])\n by orviesa006.jf.intel.com with ESMTP; 21 Mar 2024 01:35:06 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1711010109; x=1742546109;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=p7gk5VsadbAeVknTaotv6t9NqhY/ycfmS4z7zqUY1SA=;\n b=Ps+WZ9e6iQPFUMjUxMdYSDvQS7/MKx9Zg8myNuoxjNAeQB8XS/CZ06mS\n dm3tk5+kPVlJNNvhNB+VCOsqL6WukbHWYplHu2hJKJHIV3YBWJHJntd76\n e4FVMpDg1CXQvjrIg/uLeWPYxUUdqpCQIvfM6maCe7wKUadqqF5N2En/m\n GhKEMcvUe9PDPoi4Rpnqk0mXb7VsyKSCYHowD1v5b9xaF2icF3KhzK7/I\n QsM/pBFEg+Yp3s/5esYy1DguD0ZZnInQ50f83NA9M1RF2utaOnmpiPW1K\n tTvvai8bmblOMMOc4zOhbElGidzTuzr2KSXISe/Ld8ewSa8vAZt50agKF A==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,11019\"; a=\"6099877\"",
            "E=Sophos;i=\"6.07,142,1708416000\";\n   d=\"scan'208\";a=\"6099877\"",
            "E=Sophos;i=\"6.07,142,1708416000\"; d=\"scan'208\";a=\"14835952\""
        ],
        "X-ExtLoop1": "1",
        "From": "Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "gakhil@marvell.com, ciara.power@intel.com,\n Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>, stable@dpdk.org",
        "Subject": "[PATCH v3] app/test: fix rsa tests in qat suite",
        "Date": "Thu, 21 Mar 2024 08:35:02 +0000",
        "Message-Id": "<20240321083502.30552-1-arkadiuszx.kusztal@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20240313091347.25207-1-arkadiuszx.kusztal@intel.com>",
        "References": "<20240313091347.25207-1-arkadiuszx.kusztal@intel.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "This commit fixes following issues in the QAT testsuite for\nthe RSA algorithm:\n\n1) Incorrectly set keys in the internal functions are now\nset in the calling function.\n2) Camel case functions were changed to the snake case.\n\nFixes: 9b5465867fb8 (\"test/crypto: add RSA none padding cases\")\nCc: stable@dpdk.org\n\nSigned-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>\n---\nv2:\n- removed camel case\nv3:\n- changed commit description\n\n app/test/test_cryptodev_asym.c             | 102 ++++++++++++++---------------\n app/test/test_cryptodev_rsa_test_vectors.h |   2 +-\n 2 files changed, 52 insertions(+), 52 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 17daf734e8..2c745a7f7c 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -3292,11 +3292,8 @@ modular_multiplicative_inverse(const void *test_data)\n \targ.qt.coef.data = coef; \\\n \targ.qt.coef.length = vector->coef.len\n \n-typedef void (*rsa_key_init_t)(struct rte_crypto_asym_xform *,\n-\tconst struct rsa_test_data_2 *);\n-\n static int\n-RSA_Encrypt(const struct rsa_test_data_2 *vector, uint8_t *cipher_buf)\n+rsa_encrypt(const struct rsa_test_data_2 *vector, uint8_t *cipher_buf)\n {\n \tself->result_op = NULL;\n \t/* Compute encryption on the test vector */\n@@ -3314,7 +3311,7 @@ RSA_Encrypt(const struct rsa_test_data_2 *vector, uint8_t *cipher_buf)\n }\n \n static int\n-RSA_Decrypt(const struct rsa_test_data_2 *vector, uint8_t *plaintext,\n+rsa_decrypt(const struct rsa_test_data_2 *vector, uint8_t *plaintext,\n \t\tconst int use_op)\n {\n \tuint8_t cipher[TEST_DATA_SIZE] = { 0 };\n@@ -3335,41 +3332,14 @@ RSA_Decrypt(const struct rsa_test_data_2 *vector, uint8_t *plaintext,\n \treturn 0;\n }\n \n-static void\n-RSA_key_init_Exp(struct rte_crypto_asym_xform *xform,\n-\t\tconst struct rsa_test_data_2 *vector)\n-{\n-\tSET_RSA_PARAM(xform->rsa, vector, n);\n-\tSET_RSA_PARAM(xform->rsa, vector, e);\n-\tSET_RSA_PARAM(xform->rsa, vector, d);\n-\txform->rsa.key_type = RTE_RSA_KEY_TYPE_EXP;\n-}\n-\n-static void\n-RSA_key_init_CRT(struct rte_crypto_asym_xform *xform,\n-\t\tconst struct rsa_test_data_2 *vector)\n-{\n-\tSET_RSA_PARAM(xform->rsa, vector, n);\n-\tSET_RSA_PARAM(xform->rsa, vector, e);\n-\tSET_RSA_PARAM_QT(xform->rsa, vector, p);\n-\tSET_RSA_PARAM_QT(xform->rsa, vector, q);\n-\tSET_RSA_PARAM_QT(xform->rsa, vector, dP);\n-\tSET_RSA_PARAM_QT(xform->rsa, vector, dQ);\n-\tSET_RSA_PARAM_QT(xform->rsa, vector, qInv);\n-\txform->rsa.key_type = RTE_RSA_KEY_TYPE_QT;\n-}\n-\n static int\n-RSA_Init_Session(const struct rsa_test_data_2 *vector,\n-\trsa_key_init_t key_init)\n+rsa_init_session(struct rte_crypto_asym_xform *xform)\n {\n \tconst uint8_t dev_id = params->valid_devs[0];\n \tstruct rte_cryptodev_info dev_info;\n-\tstruct rte_crypto_asym_xform xform = { };\n \tint ret = 0;\n \n-\tkey_init(&xform, vector);\n-\txform.xform_type = RTE_CRYPTO_ASYM_XFORM_RSA;\n+\txform->xform_type = RTE_CRYPTO_ASYM_XFORM_RSA;\n \n \trte_cryptodev_info_get(dev_id, &dev_info);\n \tif (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT)) {\n@@ -3377,7 +3347,7 @@ RSA_Init_Session(const struct rsa_test_data_2 *vector,\n \t\t\t\"Device doesn't support decrypt op with quintuple key type. Test skipped\\n\");\n \t\treturn TEST_SKIPPED;\n \t}\n-\tret = rte_cryptodev_asym_session_create(dev_id, &xform,\n+\tret = rte_cryptodev_asym_session_create(dev_id, xform,\n \t\tparams->session_mpool, &self->sess);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, USER1,\n@@ -3388,17 +3358,23 @@ RSA_Init_Session(const struct rsa_test_data_2 *vector,\n }\n \n static int\n-KAT_RSA_Encrypt(const void *data)\n+kat_rsa_encrypt(const void *data)\n {\n \tuint8_t cipher_buf[TEST_DATA_SIZE] = {0};\n \tconst struct rsa_test_data_2 *vector = data;\n-\tint ret = RSA_Init_Session(vector, RSA_key_init_Exp);\n+\tstruct rte_crypto_asym_xform xform = { };\n+\n+\tSET_RSA_PARAM(xform.rsa, vector, n);\n+\tSET_RSA_PARAM(xform.rsa, vector, e);\n+\tSET_RSA_PARAM(xform.rsa, vector, d);\n+\txform.rsa.key_type = RTE_RSA_KEY_TYPE_EXP;\n+\tint ret = rsa_init_session(&xform);\n \n \tif (ret) {\n \t\tRTE_LOG(ERR, USER1, \"Failed to init session for RSA\\n\");\n \t\treturn ret;\n \t}\n-\tTEST_ASSERT_SUCCESS(RSA_Encrypt(vector, cipher_buf),\n+\tTEST_ASSERT_SUCCESS(rsa_encrypt(vector, cipher_buf),\n \t\t\"RSA: Failed to encrypt\");\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(vector->cipher.data,\n \t\tself->result_op->asym->rsa.cipher.data,\n@@ -3408,17 +3384,26 @@ KAT_RSA_Encrypt(const void *data)\n }\n \n static int\n-KAT_RSA_Encrypt_CRT(const void *data)\n+kat_rsa_encrypt_crt(const void *data)\n {\n \tuint8_t cipher_buf[TEST_DATA_SIZE] = {0};\n \tconst struct rsa_test_data_2 *vector = data;\n-\tint ret = RSA_Init_Session(vector, RSA_key_init_CRT);\n+\tstruct rte_crypto_asym_xform xform = { };\n \n+\tSET_RSA_PARAM(xform.rsa, vector, n);\n+\tSET_RSA_PARAM(xform.rsa, vector, e);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, p);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, q);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, dP);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, dQ);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, qInv);\n+\txform.rsa.key_type = RTE_RSA_KEY_TYPE_QT;\n+\tint ret = rsa_init_session(&xform);\n \tif (ret) {\n \t\tRTE_LOG(ERR, USER1, \"Failed to init session for RSA\\n\");\n \t\treturn ret;\n \t}\n-\tTEST_ASSERT_SUCCESS(RSA_Encrypt(vector, cipher_buf),\n+\tTEST_ASSERT_SUCCESS(rsa_encrypt(vector, cipher_buf),\n \t\t\"RSA: Failed to encrypt\");\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(vector->cipher.data,\n \t\tself->result_op->asym->rsa.cipher.data,\n@@ -3428,17 +3413,23 @@ KAT_RSA_Encrypt_CRT(const void *data)\n }\n \n static int\n-KAT_RSA_Decrypt(const void *data)\n+kat_rsa_decrypt(const void *data)\n {\n \tuint8_t message[TEST_DATA_SIZE] = {0};\n \tconst struct rsa_test_data_2 *vector = data;\n-\tint ret = RSA_Init_Session(vector, RSA_key_init_Exp);\n+\tstruct rte_crypto_asym_xform xform = { };\n+\n+\tSET_RSA_PARAM(xform.rsa, vector, n);\n+\tSET_RSA_PARAM(xform.rsa, vector, e);\n+\tSET_RSA_PARAM(xform.rsa, vector, d);\n+\txform.rsa.key_type = RTE_RSA_KEY_TYPE_EXP;\n+\tint ret = rsa_init_session(&xform);\n \n \tif (ret) {\n \t\tRTE_LOG(ERR, USER1, \"Failed to init session for RSA\\n\");\n \t\treturn ret;\n \t}\n-\tTEST_ASSERT_SUCCESS(RSA_Decrypt(vector, message, 0),\n+\tTEST_ASSERT_SUCCESS(rsa_decrypt(vector, message, 0),\n \t\t\"RSA: Failed to encrypt\");\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(vector->message.data,\n \t\tself->result_op->asym->rsa.message.data,\n@@ -3448,17 +3439,26 @@ KAT_RSA_Decrypt(const void *data)\n }\n \n static int\n-KAT_RSA_Decrypt_CRT(const void *data)\n+kat_rsa_decrypt_crt(const void *data)\n {\n \tuint8_t message[TEST_DATA_SIZE] = {0};\n \tconst struct rsa_test_data_2 *vector = data;\n-\tint ret = RSA_Init_Session(vector, RSA_key_init_CRT);\n+\tstruct rte_crypto_asym_xform xform = { };\n \n+\tSET_RSA_PARAM(xform.rsa, vector, n);\n+\tSET_RSA_PARAM(xform.rsa, vector, e);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, p);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, q);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, dP);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, dQ);\n+\tSET_RSA_PARAM_QT(xform.rsa, vector, qInv);\n+\txform.rsa.key_type = RTE_RSA_KEY_TYPE_QT;\n+\tint ret = rsa_init_session(&xform);\n \tif (ret) {\n \t\tRTE_LOG(ERR, USER1, \"Failed to init session for RSA\\n\");\n \t\treturn ret;\n \t}\n-\tTEST_ASSERT_SUCCESS(RSA_Decrypt(vector, message, 0),\n+\tTEST_ASSERT_SUCCESS(rsa_decrypt(vector, message, 0),\n \t\t\"RSA: Failed to encrypt\");\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(vector->message.data,\n \t\tself->result_op->asym->rsa.message.data,\n@@ -3535,20 +3535,20 @@ static struct unit_test_suite cryptodev_qat_asym_testsuite  = {\n \t\tTEST_CASE_NAMED_WITH_DATA(\n \t\t\t\"RSA Encryption (n=128, pt=20, e=3) EXP, Padding: NONE\",\n \t\t\tut_setup_asym, ut_teardown_asym,\n-\t\t\tKAT_RSA_Encrypt, &RSA_vector_128_20_3_None),\n+\t\t\tkat_rsa_encrypt, &rsa_vector_128_20_3_none),\n \t\tTEST_CASE_NAMED_WITH_DATA(\n \t\t\t\"RSA Decryption (n=128, pt=20, e=3) EXP, Padding: NONE\",\n \t\t\tut_setup_asym, ut_teardown_asym,\n-\t\t\tKAT_RSA_Decrypt, &RSA_vector_128_20_3_None),\n+\t\t\tkat_rsa_decrypt, &rsa_vector_128_20_3_none),\n \t\t/* RSA CRT */\n \t\tTEST_CASE_NAMED_WITH_DATA(\n \t\t\t\"RSA Encryption (n=128, pt=20, e=3) CRT, Padding: NONE\",\n \t\t\tut_setup_asym, ut_teardown_asym,\n-\t\t\tKAT_RSA_Encrypt_CRT, &RSA_vector_128_20_3_None),\n+\t\t\tkat_rsa_encrypt_crt, &rsa_vector_128_20_3_none),\n \t\tTEST_CASE_NAMED_WITH_DATA(\n \t\t\t\"RSA Decryption (n=128, pt=20, e=3) CRT, Padding: NONE\",\n \t\t\tut_setup_asym, ut_teardown_asym,\n-\t\t\tKAT_RSA_Decrypt_CRT, &RSA_vector_128_20_3_None),\n+\t\t\tkat_rsa_decrypt_crt, &rsa_vector_128_20_3_none),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\ndiff --git a/app/test/test_cryptodev_rsa_test_vectors.h b/app/test/test_cryptodev_rsa_test_vectors.h\nindex b4982014a2..89981f13f0 100644\n--- a/app/test/test_cryptodev_rsa_test_vectors.h\n+++ b/app/test/test_cryptodev_rsa_test_vectors.h\n@@ -72,7 +72,7 @@ struct rsa_test_data_2 {\n };\n \n static const struct\n-rsa_test_data_2 RSA_vector_128_20_3_None = {\n+rsa_test_data_2 rsa_vector_128_20_3_none = {\n \t.description =\n \t\t\"RSA Encryption Decryption (n=128, pt=20, e=3) EXP, QT\",\n \t.xform_type = RTE_CRYPTO_ASYM_XFORM_RSA,\n",
    "prefixes": [
        "v3"
    ]
}