Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138373/?format=api
{ "id": 138373, "url": "http://patches.dpdk.org/api/patches/138373/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314093630.1066948-3-mingjinx.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314093630.1066948-3-mingjinx.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314093630.1066948-3-mingjinx.ye@intel.com", "date": "2024-03-14T09:36:29", "name": "[2/3] bus/vdev: revert fix devargs after multi-process bus scan", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9d66f9b158cda5c18b2c272f3608c3547a067189", "submitter": { "id": 2862, "url": "http://patches.dpdk.org/api/people/2862/?format=api", "name": "Mingjin Ye", "email": "mingjinx.ye@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314093630.1066948-3-mingjinx.ye@intel.com/mbox/", "series": [ { "id": 31507, "url": "http://patches.dpdk.org/api/series/31507/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31507", "date": "2024-03-14T09:36:27", "name": "fix insert dev core dump", "version": 1, "mbox": "http://patches.dpdk.org/series/31507/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138373/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138373/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64AFF43CB2;\n\tThu, 14 Mar 2024 10:54:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5701742E65;\n\tThu, 14 Mar 2024 10:54:39 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n by mails.dpdk.org (Postfix) with ESMTP id C118342E41;\n Thu, 14 Mar 2024 10:54:36 +0100 (CET)", "from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2024 02:54:36 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.253])\n by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2024 02:54:35 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1710410077; x=1741946077;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=4bdO8xet3X+hWNwGP2f+QsQ4X3+CWxzsnW5SvbU6ADk=;\n b=aB1h8jCLnvztxJGIAuWmpNND25iFOPzUGyI+KkxaHHQPwkA0ojZx3tcx\n 4DOWXPeYDCoPnpDZ0JaNY4veObmQr3xyNHImNUykDKAzzA/oQsLCZ+Pi+\n 7y8xpfS1b9uQneJV1klpsj2S0ddBF9Y1STRS/u32lCJFUcVmTumWhhgzq\n Zttp90xdqD8FK+7wIVFJZVwxXvWFN+w/K3I6qfkDmY1BQuCcWRPmUI4gG\n oy7paazb4lZwGFIjTzaPlOo5eRlAhISqVNPRXlV7qioT8hEbP97mcX3YM\n 05wbkVYD/pH+L6sXjfGZG8FhRS1AsFD/gEFDbEpjz9EXSeXqf5XRF1uxt w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11012\"; a=\"5339886\"", "E=Sophos;i=\"6.07,125,1708416000\";\n d=\"scan'208\";a=\"5339886\"", "E=Sophos;i=\"6.07,125,1708416000\"; d=\"scan'208\";a=\"12125211\"" ], "X-ExtLoop1": "1", "From": "Mingjin Ye <mingjinx.ye@intel.com>", "To": "dev@dpdk.org", "Cc": "Mingjin Ye <mingjinx.ye@intel.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus scan", "Date": "Thu, 14 Mar 2024 09:36:29 +0000", "Message-Id": "<20240314093630.1066948-3-mingjinx.ye@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240314093630.1066948-1-mingjinx.ye@intel.com>", "References": "<20240314093630.1066948-1-mingjinx.ye@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The asan tool detected a memory leak in the vdev driver alloc_devargs.\nThe previous commit does not insert device arguments into devargs_list\nwhen attaching a device during a bus scan of a secondary process.\nThis resulted in an existing memory leak when removing a vdev device,\nsince rte_devargs_remove actually does nothing.\n\nTherefore the following commit was reverted accordingly.\n\nFixes: f5b2eff0847d (\"bus/vdev: fix devargs after multi-process bus scan\")\n\nRestoring this commit will fix the memory leak. There was an issue with\ndevice parameters using free devargs when inserting a vdev device when\ndevargs_list already existed, resulting in a core dump. A new patch\nwill fix this issue.\n\nFixes: f5b2eff0847d (\"bus/vdev: fix devargs after multi-process bus scan\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mingjin Ye <mingjinx.ye@intel.com>\n---\n drivers/bus/vdev/vdev.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 38d05a9fe9..1a6cc7d12d 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -264,9 +264,7 @@ alloc_devargs(const char *name, const char *args)\n }\n \n static int\n-insert_vdev(const char *name, const char *args,\n-\t\tstruct rte_vdev_device **p_dev,\n-\t\tbool init)\n+insert_vdev(const char *name, const char *args, struct rte_vdev_device **p_dev)\n {\n \tstruct rte_vdev_device *dev;\n \tstruct rte_devargs *devargs;\n@@ -300,8 +298,7 @@ insert_vdev(const char *name, const char *args,\n \t\tgoto fail;\n \t}\n \n-\tif (init)\n-\t\trte_devargs_insert(&devargs);\n+\trte_devargs_insert(&devargs);\n \tdev->device.devargs = devargs;\n \tTAILQ_INSERT_TAIL(&vdev_device_list, dev, next);\n \n@@ -323,7 +320,7 @@ rte_vdev_init(const char *name, const char *args)\n \tint ret;\n \n \trte_spinlock_recursive_lock(&vdev_device_list_lock);\n-\tret = insert_vdev(name, args, &dev, true);\n+\tret = insert_vdev(name, args, &dev);\n \tif (ret == 0) {\n \t\tret = vdev_probe_all_drivers(dev);\n \t\tif (ret) {\n@@ -449,7 +446,7 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void *peer)\n \t\tbreak;\n \tcase VDEV_SCAN_ONE:\n \t\tVDEV_LOG(INFO, \"receive vdev, %s\", in->name);\n-\t\tret = insert_vdev(in->name, NULL, NULL, false);\n+\t\tret = insert_vdev(in->name, NULL, NULL);\n \t\tif (ret == -EEXIST)\n \t\t\tVDEV_LOG(DEBUG, \"device already exist, %s\", in->name);\n \t\telse if (ret < 0)\n", "prefixes": [ "2/3" ] }