Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138367/?format=api
{ "id": 138367, "url": "http://patches.dpdk.org/api/patches/138367/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240314091708.1542769-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314091708.1542769-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314091708.1542769-4-david.marchand@redhat.com", "date": "2024-03-14T09:17:04", "name": "[v2,3/6] app/testpmd: fix error message for invalid option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f76cbb59aefbfc4bb57a2d496a4642bc6dc9032", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240314091708.1542769-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 31506, "url": "http://patches.dpdk.org/api/series/31506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31506", "date": "2024-03-14T09:17:01", "name": "testpmd options parsing cleanup", "version": 2, "mbox": "http://patches.dpdk.org/series/31506/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138367/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138367/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 67A1443CB2;\n\tThu, 14 Mar 2024 10:17:32 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9E3442E6A;\n\tThu, 14 Mar 2024 10:17:31 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 13BBF42E62\n for <dev@dpdk.org>; Thu, 14 Mar 2024 10:17:29 +0100 (CET)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-eYsierN9MzuueXcJ7B0C1Q-1; Thu,\n 14 Mar 2024 05:17:25 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF54838035AF;\n Thu, 14 Mar 2024 09:17:24 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.27])\n by smtp.corp.redhat.com (Postfix) with ESMTP id A6918492BD0;\n Thu, 14 Mar 2024 09:17:23 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1710407849;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5osJIglxlv+2JBjL59M7DN3gmxYf0EIJUxx+Ps8jgXQ=;\n b=YNPK6eHZy1PL1BT/HqdJg+EgxteYWbH7gi6bCVFXj+Tt+fyb0VUDqUh1gWurifiCTTM1cX\n M5OxE0X7iHQu/E/WZjP9GkKMloAex5fXF7Hh85zcewxEV7Yp1T7BquZjSQdAhbuTVbbQeZ\n 8jk7SWC61HDOWNUFGw+OhPh66MOsO4Y=", "X-MC-Unique": "eYsierN9MzuueXcJ7B0C1Q-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Subject": "[PATCH v2 3/6] app/testpmd: fix error message for invalid option", "Date": "Thu, 14 Mar 2024 10:17:04 +0100", "Message-ID": "<20240314091708.1542769-4-david.marchand@redhat.com>", "In-Reply-To": "<20240314091708.1542769-1-david.marchand@redhat.com>", "References": "<20240308144841.3615262-1-david.marchand@redhat.com>\n <20240314091708.1542769-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "\"\"\"\nThe variable optind is the index of the next element to be processed in\nargv. The system initializes this value to 1. The caller can reset it\nto 1 to restart scanning of the same argv, or when scanning a new\nargument vector.\n\"\"\"\n\nHence, if an invalid option is passed through testpmd cmdline, getopt\nreturns '?' and increments optind to the next index in argv for a\nsubsequent call.\nThe message should log the previous index.\n\nFixes: 8fad2e5ab2c5 (\"app/testpmd: report invalid command line parameter\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test-pmd/parameters.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 3414a0d38c..a4c09e2a2b 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -1497,7 +1497,7 @@ launch_args_parse(int argc, char** argv)\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tusage(argv[0]);\n-\t\t\tfprintf(stderr, \"Invalid option: %s\\n\", argv[optind]);\n+\t\t\tfprintf(stderr, \"Invalid option: %s\\n\", argv[optind - 1]);\n \t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t \"Command line is incomplete or incorrect\\n\");\n \t\t\tbreak;\n", "prefixes": [ "v2", "3/6" ] }