Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138210/?format=api
{ "id": 138210, "url": "http://patches.dpdk.org/api/patches/138210/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240312104849.667036-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240312104849.667036-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240312104849.667036-2-maxime.coquelin@redhat.com", "date": "2024-03-12T10:48:48", "name": "[1/2] net/virtio: fix vDPA device init advertising control queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0b94f15ea46427500ce99d6513d62cd8c27a73d4", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240312104849.667036-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 31476, "url": "http://patches.dpdk.org/api/series/31476/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31476", "date": "2024-03-12T10:48:47", "name": "net/virtio: vhost-vdpa fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/31476/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138210/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7704343C90;\n\tTue, 12 Mar 2024 11:49:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EFAFD40ECF;\n\tTue, 12 Mar 2024 11:49:00 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 01985402ED\n for <dev@dpdk.org>; Tue, 12 Mar 2024 11:48:57 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-392-jEAShpxIMVmMihAIZCSYhw-1; Tue, 12 Mar 2024 06:48:56 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com\n [10.11.54.8])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3CFD84B061;\n Tue, 12 Mar 2024 10:48:55 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.24])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3FD92C478A1;\n Tue, 12 Mar 2024 10:48:54 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1710240537;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BZnsRPxmXNP5QP+umVlkkEIP0TA7F2XNcYpKu8xzw1I=;\n b=JHbIEwBIoGqJVxcY/VUNEDsnU327p4FRotyIB+h6wWxbVVullHLhzYWLAIQfp+Lt5sQu1h\n 5qAmlppjQIRpr2Z4NlIrBDsGbtCXE1S5wSXVZz8Iz5xlc/8vh0Y4IXTDBzQUafSwvDFDPX\n xoVvJOre0udgCBh6QG12votkEhUI4GU=", "X-MC-Unique": "jEAShpxIMVmMihAIZCSYhw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbox@nvidia.com,\n schalla@marvell.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 1/2] net/virtio: fix vDPA device init advertising control\n queue", "Date": "Tue, 12 Mar 2024 11:48:48 +0100", "Message-ID": "<20240312104849.667036-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20240312104849.667036-1-maxime.coquelin@redhat.com>", "References": "<20240312104849.667036-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If the vDPA device advertises control queue support, but\nthe user neither passes \"cq=1\" as devarg nor requests\nmultiple queues, the initialization fails because the\ndriver tries to setup the control queue without negotiating\nrelated feature.\n\nThis patch enables the control queue at driver level as\nsoon as the device claims to support it, and not only when\nmultiple queue pairs are requested.\n\nFixes: b277308e8868 (\"net/virtio-user: advertise control VQ support with vDPA\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex d395fc1676..0b5db12886 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -752,7 +752,7 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues,\n \tif (virtio_user_dev_init_max_queue_pairs(dev, queues))\n \t\tdev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ);\n \n-\tif (dev->max_queue_pairs > 1)\n+\tif (dev->max_queue_pairs > 1 || dev->hw_cvq)\n \t\tcq = 1;\n \n \tif (!mrg_rxbuf)\n@@ -770,8 +770,9 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues,\n \t\tdev->unsupported_features |= (1ull << VIRTIO_NET_F_MAC);\n \n \tif (cq) {\n-\t\t/* device does not really need to know anything about CQ,\n-\t\t * so if necessary, we just claim to support CQ\n+\t\t/* Except for vDPA, the device does not really need to know\n+\t\t * anything about CQ, so if necessary, we just claim to support\n+\t\t * control queue.\n \t\t */\n \t\tdev->frontend_features |= (1ull << VIRTIO_NET_F_CTRL_VQ);\n \t} else {\n", "prefixes": [ "1/2" ] }