Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138160/?format=api
{ "id": 138160, "url": "http://patches.dpdk.org/api/patches/138160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240311154405.13269-3-jspewock@iol.unh.edu/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240311154405.13269-3-jspewock@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20240311154405.13269-3-jspewock@iol.unh.edu", "date": "2024-03-11T15:44:00", "name": "[v9,2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "81a33ca4e88734ced8796a3a5c3b713555354870", "submitter": { "id": 2772, "url": "http://patches.dpdk.org/api/people/2772/?format=api", "name": "Jeremy Spewock", "email": "jspewock@iol.unh.edu" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240311154405.13269-3-jspewock@iol.unh.edu/mbox/", "series": [ { "id": 31463, "url": "http://patches.dpdk.org/api/series/31463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31463", "date": "2024-03-11T15:43:58", "name": "dts: Port scatter suite over", "version": 9, "mbox": "http://patches.dpdk.org/series/31463/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138160/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138160/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE91043C89;\n\tMon, 11 Mar 2024 16:45:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DC69240DC9;\n\tMon, 11 Mar 2024 16:44:57 +0100 (CET)", "from mail-qv1-f98.google.com (mail-qv1-f98.google.com\n [209.85.219.98]) by mails.dpdk.org (Postfix) with ESMTP id 7672A40A8A\n for <dev@dpdk.org>; Mon, 11 Mar 2024 16:44:54 +0100 (CET)", "by mail-qv1-f98.google.com with SMTP id\n 6a1803df08f44-68ee2c0a237so29514506d6.1\n for <dev@dpdk.org>; Mon, 11 Mar 2024 08:44:54 -0700 (PDT)", "from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84])\n by smtp-relay.gmail.com with ESMTPS id\n kl18-20020a056214519200b0068fa33effcbsm262128qvb.39.2024.03.11.08.44.53\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 11 Mar 2024 08:44:53 -0700 (PDT)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f])\n by postal.iol.unh.edu (Postfix) with ESMTP id 6E9E66052471;\n Mon, 11 Mar 2024 11:44:53 -0400 (EDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=iol.unh.edu; s=unh-iol; t=1710171894; x=1710776694; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2ugSq6yZnVJ/8C03p8ipTsvI2OSe9gLyymNSwNRkdc8=;\n b=D1ugAS1lw7xK9kbWwpuvQIy7fvIGK+MDa5tJ5SPyN3zsy5ViCqjZxk516mymrobHzK\n 1nL2T8UuHiYHixvo6Vdis1GGgIlcuMgcNSW8veTWGuqH48GCcu7fkYLJf74gqMHeroFP\n fAzd20GnAXzQiJJMVisSJJrykvz/iWsy+758w=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1710171894; x=1710776694;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2ugSq6yZnVJ/8C03p8ipTsvI2OSe9gLyymNSwNRkdc8=;\n b=KJ6kkQgTvkhd9BTE9UWZUz5m2mkiRmpa1T+glPHLp/nV5ZG3SzmE1WgoFwPswQuNHD\n LDxMuqRVDbT6koJjQONfDRrFpuGq0pnMOL08l8XS46OEzanVoVplHUZeGNOyZ3qqTFRt\n NWxfKhY27Ii9VSo8Voleym+N/R/zVzAmXkmzQbg9/VZ43ofD6vZ9fu8K4HVOIrruQhzr\n vZJoY0J4RixWxFxGwZrKuw+EZ5QvEVWSPRfDLiG8+Aj68SiLtWQdgILzennBqDZ4M6NX\n CCAYWuyJp7Dor2h59AE04XMSwVf9YdtclgqRGyn/pl8F7ZYswnDK1F9VRntYD4GAIVGk\n VKLA==", "X-Gm-Message-State": "AOJu0YwwmpGQocrYbxBOXWC67dVCxuBceAHagjJell/F+fY9q6sBlznl\n Ug12OYSGiuJGC0pP3J/vJwtkIQI1avEia262QHF7NMcr01LO93T01im6/39F7zabEJRc4HydHdO\n fKk+ulqGDrllqHR1agUw6y1VhNQhFs6Ew", "X-Google-Smtp-Source": "\n AGHT+IFREV2lsIzAdI6Pg8JwRAl5A9f2gIDsFn3ELB4kfMScQqP0Y219h1hzkVbXbXupIkuTr/xpUiily8xe", "X-Received": "by 2002:a05:6214:2501:b0:690:c56b:5878 with SMTP id\n gf1-20020a056214250100b00690c56b5878mr14051156qvb.16.1710171893881;\n Mon, 11 Mar 2024 08:44:53 -0700 (PDT)", "X-Relaying-Domain": "iol.unh.edu", "From": "jspewock@iol.unh.edu", "To": "Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech,\n thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu,\n paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, ferruh.yigit@amd.com,\n andrew.rybchenko@oktetlabs.ru", "Cc": "dev@dpdk.org,\n\tJeremy Spewock <jspewock@iol.unh.edu>", "Subject": "[PATCH v9 2/7] dts: limit EAL parameters to DPDK apps and add\n parameters to all apps", "Date": "Mon, 11 Mar 2024 11:44:00 -0400", "Message-ID": "<20240311154405.13269-3-jspewock@iol.unh.edu>", "X-Mailer": "git-send-email 2.43.2", "In-Reply-To": "<20240311154405.13269-1-jspewock@iol.unh.edu>", "References": "<20240110144249.20719-1-jspewock@iol.unh.edu>\n <20240311154405.13269-1-jspewock@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jeremy Spewock <jspewock@iol.unh.edu>\n\nChanged the factory method for creating interactive apps in the SUT Node\nso that EAL parameters would only be passed into DPDK apps since\nnon-DPDK apps wouldn't be able to process them. Also modified\ninteractive apps to allow for the ability to pass parameters into the\napp on startup so that the applications can be started with certain\nconfiguration steps passed on the command line.\n\nSigned-off-by: Jeremy Spewock <jspewock@iol.unh.edu>\n---\n dts/framework/remote_session/testpmd_shell.py | 2 +-\n dts/framework/testbed_model/sut_node.py | 16 ++++++++++------\n 2 files changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py\nindex 3a66907394..cb2ab6bd00 100644\n--- a/dts/framework/remote_session/testpmd_shell.py\n+++ b/dts/framework/remote_session/testpmd_shell.py\n@@ -118,7 +118,7 @@ def _start_application(self, get_privileged_command: Callable[[str], str] | None\n Also find the number of pci addresses which were allowed on the command line when the app\n was started.\n \"\"\"\n- self._app_args += \" -- -i --mask-event intr_lsc\"\n+ self._app_args += \" -i --mask-event intr_lsc\"\n self.number_of_ports = self._app_args.count(\"-a \")\n super()._start_application(get_privileged_command)\n \ndiff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py\nindex c4acea38d1..909394e756 100644\n--- a/dts/framework/testbed_model/sut_node.py\n+++ b/dts/framework/testbed_model/sut_node.py\n@@ -430,7 +430,8 @@ def create_interactive_shell(\n shell_cls: Type[InteractiveShellType],\n timeout: float = SETTINGS.timeout,\n privileged: bool = False,\n- eal_parameters: EalParameters | str | None = None,\n+ app_parameters: str = \"\",\n+ eal_parameters: EalParameters | None = None,\n ) -> InteractiveShellType:\n \"\"\"Extend the factory for interactive session handlers.\n \n@@ -449,20 +450,23 @@ def create_interactive_shell(\n eal_parameters: List of EAL parameters to use to launch the app. If this\n isn't provided or an empty string is passed, it will default to calling\n :meth:`create_eal_parameters`.\n+ app_parameters: Additional arguments to pass into the application on the\n+ command-line.\n \n Returns:\n An instance of the desired interactive application shell.\n \"\"\"\n- if not eal_parameters:\n- eal_parameters = self.create_eal_parameters()\n-\n- # We need to append the build directory for DPDK apps\n+ # We need to append the build directory and add EAL parameters for DPDK apps\n if shell_cls.dpdk_app:\n+ if not eal_parameters:\n+ eal_parameters = self.create_eal_parameters()\n+ app_parameters = f\"{eal_parameters} -- {app_parameters}\"\n+\n shell_cls.path = self.main_session.join_remote_path(\n self.remote_dpdk_build_dir, shell_cls.path\n )\n \n- return super().create_interactive_shell(shell_cls, timeout, privileged, str(eal_parameters))\n+ return super().create_interactive_shell(shell_cls, timeout, privileged, app_parameters)\n \n def bind_ports_to_driver(self, for_dpdk: bool = True) -> None:\n \"\"\"Bind all ports on the SUT to a driver.\n", "prefixes": [ "v9", "2/7" ] }