Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 137965,
    "url": "http://patches.dpdk.org/api/patches/137965/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240305072213.283205-6-asasidharan@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240305072213.283205-6-asasidharan@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240305072213.283205-6-asasidharan@marvell.com",
    "date": "2024-03-05T07:21:57",
    "name": "[05/21] test/security: unit test for TLS packet corruption",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2652bec653d1b2aedda74edcdf0084495aaae2a5",
    "submitter": {
        "id": 2800,
        "url": "http://patches.dpdk.org/api/people/2800/?format=api",
        "name": "Aakash Sasidharan",
        "email": "asasidharan@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240305072213.283205-6-asasidharan@marvell.com/mbox/",
    "series": [
        {
            "id": 31370,
            "url": "http://patches.dpdk.org/api/series/31370/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31370",
            "date": "2024-03-05T07:21:52",
            "name": "Improvements and new test cases",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/31370/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/137965/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/137965/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A1EF43C4C;\n\tTue,  5 Mar 2024 08:22:49 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9597A4111C;\n\tTue,  5 Mar 2024 08:22:35 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id D6F50410FA\n for <dev@dpdk.org>; Tue,  5 Mar 2024 08:22:33 +0100 (CET)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 4254UEuP025179; Mon, 4 Mar 2024 23:22:33 -0800",
            "from dc6wp-exch02.marvell.com ([4.21.29.225])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wm4gmr8xx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 04 Mar 2024 23:22:33 -0800 (PST)",
            "from DC6WP-EXCH02.marvell.com (10.76.176.209) by\n DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Mon, 4 Mar 2024 23:22:32 -0800",
            "from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com\n (10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Mon, 4 Mar 2024 23:22:32 -0800",
            "from localhost.localdomain (unknown [10.28.36.177])\n by maili.marvell.com (Postfix) with ESMTP id A4B553F7045;\n Mon,  4 Mar 2024 23:22:29 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=0clGZWmA5Zim68FClcGZ0Fyi8lQbS9XI0yUH4Qf4sAc=; b=K3z\n cDxNYz4mrk6HFoNVNRE00DJ1ef2IpzbI3cF+9vhZabwhrfgTx7ADVotw8u3c4Cqh\n FBV/iEN5KuIxaaaYFJnvJ66Mg4gsHPRJpB4ZBhLN+NCbYOWm8GLPbFmzORwN8lCp\n T8u9/i1rOefXn/udfFr7XdaSjzXodqP7Nh7iKY+tZcNe5aPPLHitKv2vyKrgqFcl\n Aicuse43hlfXsnEG0Y+7GAlypW+N9ZEA7PIeV7GoG+mP+qvB73qChWH1XDre+iEs\n rCYqBCgN+4KmJw5AebUV51qTD+YmNM2XneVbLq3fF3WByyqbK8soZSnzZVwGOk9w\n ise04tljKzEqG0Mr/pg==",
        "From": "Aakash Sasidharan <asasidharan@marvell.com>",
        "To": "Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>",
        "CC": "<jerinj@marvell.com>, <anoobj@marvell.com>, <vvelumuri@marvell.com>,\n <asasidharan@marvell.com>, <dev@dpdk.org>",
        "Subject": "[PATCH 05/21] test/security: unit test for TLS packet corruption",
        "Date": "Tue, 5 Mar 2024 12:51:57 +0530",
        "Message-ID": "<20240305072213.283205-6-asasidharan@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20240305072213.283205-1-asasidharan@marvell.com>",
        "References": "<20240305072213.283205-1-asasidharan@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-ORIG-GUID": "k7p6GZIGkhNLJ4YSM1Gs_kzgNAl8H824",
        "X-Proofpoint-GUID": "k7p6GZIGkhNLJ4YSM1Gs_kzgNAl8H824",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-03-05_04,2024-03-04_01,2023-05-22_02",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n\nAdd test to verify the corrupted TLS packet header\n\nSigned-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n---\n app/test/test_cryptodev.c                     | 27 +++++++++++++++++--\n app/test/test_cryptodev_security_tls_record.c |  4 +++\n app/test/test_cryptodev_security_tls_record.h |  1 +\n 3 files changed, 30 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 5922c2162a..04737147e1 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -12000,8 +12000,13 @@ test_tls_record_proto_all(const struct tls_record_test_flags *flags)\n \t\tif (ret == TEST_SKIPPED)\n \t\t\tcontinue;\n \n-\t\tif (ret == TEST_FAILED)\n-\t\t\treturn TEST_FAILED;\n+\t\tif (flags->pkt_corruption) {\n+\t\t\tif (ret == TEST_SUCCESS)\n+\t\t\t\treturn TEST_FAILED;\n+\t\t} else {\n+\t\t\tif (ret == TEST_FAILED)\n+\t\t\t\treturn TEST_FAILED;\n+\t\t}\n \n \t\tif (flags->data_walkthrough && (++payload_len <= max_payload_len))\n \t\t\tgoto again;\n@@ -12089,6 +12094,20 @@ test_tls_1_2_record_proto_sgl_data_walkthrough(void)\n \treturn test_tls_record_proto_sgl_data_walkthrough(RTE_SECURITY_VERSION_TLS_1_2);\n }\n \n+static int\n+test_tls_record_proto_corrupt_pkt(void)\n+{\n+\tstruct tls_record_test_flags flags = {\n+\t\t.pkt_corruption = 1\n+\t};\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct rte_cryptodev_info dev_info;\n+\n+\trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n+\n+\treturn test_tls_record_proto_all(&flags);\n+}\n+\n static int\n test_dtls_1_2_record_proto_data_walkthrough(void)\n {\n@@ -17209,6 +17228,10 @@ static struct unit_test_suite tls12_record_proto_testsuite  = {\n \t\t\t\"Multi-segmented mode data walkthrough\",\n \t\t\tut_setup_security, ut_teardown,\n \t\t\ttest_tls_1_2_record_proto_sgl_data_walkthrough),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"TLS packet header corruption\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_tls_record_proto_corrupt_pkt),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\ndiff --git a/app/test/test_cryptodev_security_tls_record.c b/app/test/test_cryptodev_security_tls_record.c\nindex 92bcbff842..93ff7f36fa 100644\n--- a/app/test/test_cryptodev_security_tls_record.c\n+++ b/app/test/test_cryptodev_security_tls_record.c\n@@ -185,6 +185,10 @@ test_tls_record_td_update(struct tls_record_test_data td_inb[],\n \t\t       td_outb[i].input_text.len);\n \t\ttd_inb[i].output_text.len = td_outb->input_text.len;\n \n+\t\t/* Corrupt the content type in the TLS header of encrypted packet */\n+\t\tif (flags->pkt_corruption)\n+\t\t\ttd_inb[i].input_text.data[0] = ~td_inb[i].input_text.data[0];\n+\n \t\t/* Clear outbound specific flags */\n \t\ttd_inb[i].tls_record_xform.options.iv_gen_disable = 0;\n \t}\ndiff --git a/app/test/test_cryptodev_security_tls_record.h b/app/test/test_cryptodev_security_tls_record.h\nindex 34758fb0e1..5faa277740 100644\n--- a/app/test/test_cryptodev_security_tls_record.h\n+++ b/app/test/test_cryptodev_security_tls_record.h\n@@ -88,6 +88,7 @@ struct tls_record_test_flags {\n \tuint8_t nb_segs_in_mbuf;\n \tbool data_walkthrough;\n \tenum rte_security_tls_version tls_version;\n+\tbool pkt_corruption;\n };\n \n extern struct tls_record_test_data tls_test_data_aes_128_gcm_v1;\n",
    "prefixes": [
        "05/21"
    ]
}