Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137919/?format=api
{ "id": 137919, "url": "http://patches.dpdk.org/api/patches/137919/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-6-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709574764-9041-6-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709574764-9041-6-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-04T17:52:10", "name": "[v7,05/39] ring: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3202b0333570b81af695ec8c716c0c34b3b06dbb", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709574764-9041-6-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31365, "url": "http://patches.dpdk.org/api/series/31365/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31365", "date": "2024-03-04T17:52:05", "name": "use C11 alignas", "version": 7, "mbox": "http://patches.dpdk.org/series/31365/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137919/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137919/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9418843B9B;\n\tMon, 4 Mar 2024 18:53:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C53C5427E0;\n\tMon, 4 Mar 2024 18:52:59 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id AA27F40695\n for <dev@dpdk.org>; Mon, 4 Mar 2024 18:52:51 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4E3DE20B74C5; Mon, 4 Mar 2024 09:52:50 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4E3DE20B74C5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709574770;\n bh=waLp9S8LDY5sxabQBZjrYLI5Iaamv/o8fF3084OtYpU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Dem9XLVdBYs3wx8W10SAW1Yk1jAanlqXk80SYZ9EG+2g4Zz7PNfk3Z1z5TvLJ/XTz\n viuL4V1bAoZHQwoNy2I+gGcrxL2LRG7WR2QpHcgkqrobv7FIUevw1a/k4msG6ylrNR\n wuOpQmhXUn+artT8ygs8mlexg+9w6kkzeo403KPs=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v7 05/39] ring: use C11 alignas", "Date": "Mon, 4 Mar 2024 09:52:10 -0800", "Message-Id": "<1709574764-9041-6-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n lib/ring/rte_ring_core.h | 16 +++++++++-------\n lib/ring/rte_ring_peek_zc.h | 4 ++--\n 2 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h\nindex b770873..f958064 100644\n--- a/lib/ring/rte_ring_core.h\n+++ b/lib/ring/rte_ring_core.h\n@@ -19,6 +19,8 @@\n * instead.\n */\n \n+#include <stdalign.h>\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -78,7 +80,7 @@ struct rte_ring_headtail {\n \n union __rte_ring_rts_poscnt {\n \t/** raw 8B value to read/write *cnt* and *pos* as one atomic op */\n-\tRTE_ATOMIC(uint64_t) raw __rte_aligned(8);\n+\talignas(sizeof(uint64_t)) RTE_ATOMIC(uint64_t) raw;\n \tstruct {\n \t\tuint32_t cnt; /**< head/tail reference counter */\n \t\tuint32_t pos; /**< head/tail position */\n@@ -94,7 +96,7 @@ struct rte_ring_rts_headtail {\n \n union __rte_ring_hts_pos {\n \t/** raw 8B value to read/write *head* and *tail* as one atomic op */\n-\tRTE_ATOMIC(uint64_t) raw __rte_aligned(8);\n+\talignas(sizeof(uint64_t)) RTE_ATOMIC(uint64_t) raw;\n \tstruct {\n \t\tRTE_ATOMIC(uint32_t) head; /**< head position */\n \t\tRTE_ATOMIC(uint32_t) tail; /**< tail position */\n@@ -117,7 +119,7 @@ struct rte_ring_hts_headtail {\n * a problem.\n */\n struct rte_ring {\n-\tchar name[RTE_RING_NAMESIZE] __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) char name[RTE_RING_NAMESIZE];\n \t/**< Name of the ring. */\n \tint flags; /**< Flags supplied at creation. */\n \tconst struct rte_memzone *memzone;\n@@ -129,20 +131,20 @@ struct rte_ring {\n \tRTE_CACHE_GUARD;\n \n \t/** Ring producer status. */\n-\tunion {\n+\tunion __rte_cache_aligned {\n \t\tstruct rte_ring_headtail prod;\n \t\tstruct rte_ring_hts_headtail hts_prod;\n \t\tstruct rte_ring_rts_headtail rts_prod;\n-\t} __rte_cache_aligned;\n+\t};\n \n \tRTE_CACHE_GUARD;\n \n \t/** Ring consumer status. */\n-\tunion {\n+\tunion __rte_cache_aligned {\n \t\tstruct rte_ring_headtail cons;\n \t\tstruct rte_ring_hts_headtail hts_cons;\n \t\tstruct rte_ring_rts_headtail rts_cons;\n-\t} __rte_cache_aligned;\n+\t};\n \n \tRTE_CACHE_GUARD;\n };\ndiff --git a/lib/ring/rte_ring_peek_zc.h b/lib/ring/rte_ring_peek_zc.h\nindex 8fb279c..0b5e34b 100644\n--- a/lib/ring/rte_ring_peek_zc.h\n+++ b/lib/ring/rte_ring_peek_zc.h\n@@ -79,7 +79,7 @@\n * This structure contains the pointers and length of the space\n * reserved on the ring storage.\n */\n-struct rte_ring_zc_data {\n+struct __rte_cache_aligned rte_ring_zc_data {\n \t/* Pointer to the first space in the ring */\n \tvoid *ptr1;\n \t/* Pointer to the second space in the ring if there is wrap-around.\n@@ -92,7 +92,7 @@ struct rte_ring_zc_data {\n \t * will give the number of elements available at ptr2.\n \t */\n \tunsigned int n1;\n-} __rte_cache_aligned;\n+};\n \n static __rte_always_inline void\n __rte_ring_get_elem_addr(struct rte_ring *r, uint32_t head,\n", "prefixes": [ "v7", "05/39" ] }