Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137147/?format=api
{ "id": 137147, "url": "http://patches.dpdk.org/api/patches/137147/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708715054-22386-39-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708715054-22386-39-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708715054-22386-39-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-23T19:04:13", "name": "[v5,38/39] graph: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4d9a6da760e8b0ca50365b94ac4e2f90c0db14e8", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708715054-22386-39-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31207, "url": "http://patches.dpdk.org/api/series/31207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31207", "date": "2024-02-23T19:03:37", "name": "use C11 alignas", "version": 5, "mbox": "http://patches.dpdk.org/series/31207/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137147/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EBCEA43BA4;\n\tFri, 23 Feb 2024 20:08:34 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CF5AB42E38;\n\tFri, 23 Feb 2024 20:05:08 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4CC9A4029A\n for <dev@dpdk.org>; Fri, 23 Feb 2024 20:04:20 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4EE5020B57B4; Fri, 23 Feb 2024 11:04:17 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4EE5020B57B4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708715058;\n bh=HNtYpDJtyctWDIEOylE0dlXFgkZyNbiSYVwzVzEUPX0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Y9SHYg8Z9oZoBfSS8AStu1dQE2f5p0vRIR72AM3/BoG+OmT9qZvI0ZtHR4bgL39mw\n owYTcNb4v7BgCdX8RCbVrGEI7ntyF7+e8i8AOAXsw7jjByHxW5wyxqLID4qynO/O9e\n FRQD7Kw+Hf2cRikk8L2dtP0kQ7u0UMeM2kT2pnSY=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 38/39] graph: use C11 alignas", "Date": "Fri, 23 Feb 2024 11:04:13 -0800", "Message-Id": "<1708715054-22386-39-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708715054-22386-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708715054-22386-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/graph/graph_private.h | 4 ++--\n lib/graph/graph_stats.c | 4 ++--\n lib/graph/rte_graph.h | 4 ++--\n lib/graph/rte_graph_worker_common.h | 17 ++++++++++-------\n 4 files changed, 16 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h\nindex fb88d4b..7e4d9f8 100644\n--- a/lib/graph/graph_private.h\n+++ b/lib/graph/graph_private.h\n@@ -71,11 +71,11 @@ struct node {\n * Structure that holds the graph scheduling workqueue node stream.\n * Used for mcore dispatch model.\n */\n-struct graph_mcore_dispatch_wq_node {\n+struct __rte_cache_aligned graph_mcore_dispatch_wq_node {\n \trte_graph_off_t node_off;\n \tuint16_t nb_objs;\n \tvoid *objs[RTE_GRAPH_BURST_SIZE];\n-} __rte_cache_aligned;\n+};\n \n /**\n * @internal\ndiff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c\nindex cc32245..2fb808b 100644\n--- a/lib/graph/graph_stats.c\n+++ b/lib/graph/graph_stats.c\n@@ -28,7 +28,7 @@ struct cluster_node {\n \tstruct rte_node *nodes[];\n };\n \n-struct rte_graph_cluster_stats {\n+struct __rte_cache_aligned rte_graph_cluster_stats {\n \t/* Header */\n \trte_graph_cluster_stats_cb_t fn;\n \tuint32_t cluster_node_size; /* Size of struct cluster_node */\n@@ -38,7 +38,7 @@ struct rte_graph_cluster_stats {\n \tsize_t sz;\n \n \tstruct cluster_node clusters[];\n-} __rte_cache_aligned;\n+};\n \n #define boarder_model_dispatch() \\\n \tfprintf(f, \"+-------------------------------+---------------+--------\" \\\ndiff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h\nindex 2d37d5e..ecfec20 100644\n--- a/lib/graph/rte_graph.h\n+++ b/lib/graph/rte_graph.h\n@@ -200,7 +200,7 @@ struct rte_graph_cluster_stats_param {\n *\n * @see struct rte_graph_cluster_stats_param::fn\n */\n-struct rte_graph_cluster_node_stats {\n+struct __rte_cache_aligned rte_graph_cluster_node_stats {\n \tuint64_t ts;\t /**< Current timestamp. */\n \tuint64_t calls;\t /**< Current number of calls made. */\n \tuint64_t objs; /**< Current number of objs processed. */\n@@ -225,7 +225,7 @@ struct rte_graph_cluster_node_stats {\n \trte_node_t id;\t/**< Node identifier of stats. */\n \tuint64_t hz;\t/**< Cycles per seconds. */\n \tchar name[RTE_NODE_NAMESIZE];\t/**< Name of the node. */\n-} __rte_cache_aligned;\n+};\n \n /**\n * Create Graph.\ndiff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h\nindex 4045a7a..36d864e 100644\n--- a/lib/graph/rte_graph_worker_common.h\n+++ b/lib/graph/rte_graph_worker_common.h\n@@ -12,6 +12,8 @@\n * process, enqueue and move streams of objects to the next nodes.\n */\n \n+#include <stdalign.h>\n+\n #include <rte_common.h>\n #include <rte_cycles.h>\n #include <rte_prefetch.h>\n@@ -43,7 +45,7 @@\n *\n * Data structure to hold graph data.\n */\n-struct rte_graph {\n+struct __rte_cache_aligned rte_graph {\n \t/* Fast path area. */\n \tuint32_t tail;\t\t /**< Tail of circular buffer. */\n \tuint32_t head;\t\t /**< Head of circular buffer. */\n@@ -57,7 +59,8 @@ struct rte_graph {\n \tunion {\n \t\t/* Fast schedule area for mcore dispatch model */\n \t\tstruct {\n-\t\t\tstruct rte_graph_rq_head *rq __rte_cache_aligned; /* The run-queue */\n+\t\t\talignas(RTE_CACHE_LINE_SIZE) struct rte_graph_rq_head *rq;\n+\t\t\t\t/* The run-queue */\n \t\t\tstruct rte_graph_rq_head rq_head; /* The head for run-queue list */\n \n \t\t\tunsigned int lcore_id; /**< The graph running Lcore. */\n@@ -77,14 +80,14 @@ struct rte_graph {\n \tuint64_t nb_pkt_to_capture;\n \tchar pcap_filename[RTE_GRAPH_PCAP_FILE_SZ]; /**< Pcap filename. */\n \tuint64_t fence;\t\t\t/**< Fence. */\n-} __rte_cache_aligned;\n+};\n \n /**\n * @internal\n *\n * Data structure to hold node data.\n */\n-struct rte_node {\n+struct __rte_cache_aligned rte_node {\n \t/* Slow path area */\n \tuint64_t fence;\t\t/**< Fence. */\n \trte_graph_off_t next;\t/**< Index to next node. */\n@@ -109,7 +112,7 @@ struct rte_node {\n \t};\n \t/* Fast path area */\n #define RTE_NODE_CTX_SZ 16\n-\tuint8_t ctx[RTE_NODE_CTX_SZ] __rte_cache_aligned; /**< Node Context. */\n+\talignas(RTE_CACHE_LINE_SIZE) uint8_t ctx[RTE_NODE_CTX_SZ]; /**< Node Context. */\n \tuint16_t size;\t\t/**< Total number of objects available. */\n \tuint16_t idx;\t\t/**< Number of objects used. */\n \trte_graph_off_t off;\t/**< Offset of node in the graph reel. */\n@@ -124,8 +127,8 @@ struct rte_node {\n \t\t\trte_node_process_t process; /**< Process function. */\n \t\t\tuint64_t process_u64;\n \t\t};\n-\tstruct rte_node *nodes[] __rte_cache_min_aligned; /**< Next nodes. */\n-} __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_MIN_SIZE) struct rte_node *nodes[]; /**< Next nodes. */\n+};\n \n /**\n * @internal\n", "prefixes": [ "v5", "38/39" ] }