Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137075/?format=api
{ "id": 137075, "url": "http://patches.dpdk.org/api/patches/137075/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240223024217.3052031-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240223024217.3052031-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240223024217.3052031-2-chaoyong.he@corigine.com", "date": "2024-02-23T02:42:14", "name": "[v2,1/4] ethdev: add function to check representor port", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d4a82fc5636c0b3a4a8d130fd2ad7d785a141937", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240223024217.3052031-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31191, "url": "http://patches.dpdk.org/api/series/31191/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31191", "date": "2024-02-23T02:42:13", "name": "add support of MARK and RSS flow action", "version": 2, "mbox": "http://patches.dpdk.org/series/31191/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137075/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3DD643B91;\n\tFri, 23 Feb 2024 03:42:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D684140EE2;\n\tFri, 23 Feb 2024 03:42:48 +0100 (CET)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2115.outbound.protection.outlook.com [40.107.244.115])\n by mails.dpdk.org (Postfix) with ESMTP id 15D45402BD\n for <dev@dpdk.org>; Fri, 23 Feb 2024 03:42:45 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SA1PR13MB6645.namprd13.prod.outlook.com (2603:10b6:806:3e6::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Fri, 23 Feb\n 2024 02:42:41 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::8e02:f738:570a:f8aa]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::8e02:f738:570a:f8aa%7]) with mapi id 15.20.7316.023; Fri, 23 Feb 2024\n 02:42:41 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cD+f0QTsykdpk/oQZ9bSBqLO9ghHWZ7uZEqEU4RuA8E730k4ELTYBGEcWQtTgFBjkNkaGvGSzkALO3+XaQdplxaHGJ1YP6ogpc8ag5oLz8iTm9Ljnfod6P1o2+tcNZviqoPHAW2xQVKGhAX4/8f6zojQzzVXuGTojdIGdsL/Ex9dVb10n7WBSTxxxPy6614V+DDTobdl2TIdi93N1wXpMlN+pEyMxNs8HqzshPlRgZAnysVw2FxWPlNb+yvKOLdjqfr60EglRTjT/SsZW4j2LMq8IG5HBsvyuCVkbyjQnNqPSoxt3cx//Og9W6y5adicmbto4LdJ8sk/kC9GIfG/+A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=JFH4wKvSx9giSwoPGwdQLywUY6V4dcBXkPTxyndNlv4=;\n b=lK5CtOZtX7Tz14oLAriA6NcMsgbgLeb3770EyOCEpRM6VQVugsnHvuVWqr8ZLxfMnk1X4RWISD1JI7m9S2+o9E1CvlJR44t+FLMTOHtBCt/RTNfKnH0Kb5uJyYpV0whNkSiyZ3ovYj4zJNZXbprv6AaZ58S4GLwfC1H1oTACgwYwFhSD+ose7RrkW+i5cZ/YS5kCjKUll89Msp2/M55JAuiPxJuOifASHldM4ed4YoFmPT70r88m1QC95u+o/xK3rWbFmzu9/uJoTKXljS0Hix38Aq8Tq58XFsPcP4nrDsCQO74A3jRvQeDLEtsB5empCut6siLCwCOh0dtreF//Kw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=JFH4wKvSx9giSwoPGwdQLywUY6V4dcBXkPTxyndNlv4=;\n b=Z4WmUWh29ox7r0hgYmo5s9Uz3GJqYEM+qx/0IA0aYS/NwBce9NhsjNTAIH8M7wkyB3AKgVYkIBfpq0+BJ7R7vHipOgsCSpvaq9rqX5TjUgpzCiO75otcdNVzld5lgG2OMJUYVKw55Qya1OpVmlOaDEM9r18Za6AqkyvA6FUv+JA=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,\n Chaoyong He <chaoyong.he@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v2 1/4] ethdev: add function to check representor port", "Date": "Fri, 23 Feb 2024 10:42:14 +0800", "Message-Id": "<20240223024217.3052031-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240223024217.3052031-1-chaoyong.he@corigine.com>", "References": "<20240210104214.1248772-1-chaoyong.he@corigine.com>\n <20240223024217.3052031-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR13CA0040.namprd13.prod.outlook.com\n (2603:10b6:a03:2c2::15) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SA1PR13MB6645:EE_", "X-MS-Office365-Filtering-Correlation-Id": "d036617a-cfbd-44f5-517b-08dc34191926", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 70TZKbiPmbiFJmSBBENKSK0IXFuuom6GvtzjgI1IWS7vqqn8DjBt87iqg7hZW2BU9OZDDoDnIGIFGK0aBXIQsBf149ZcfAX2sRfSU3e/ZXy4Fe2gOUDVQstjomqtBJ23AddUcUbfdMKx4q6DQJnXV76QT1GYuv/jRJRE9DU2/zvi3oyoLwgABOD5ppmDJK7WOpheHAOLfCYRWksw3IrcJK0AUiKXBOGESdbUlg66dXAkg++TEAR4ccqFyYKsMLViHkD5tLLmghXeSHPraihTNWSsvI5Qj5i80NPXBUDLnQX71voJpLoY94VsDLEStGCKVv7gUEI0qrcGBxqUCb25+W9IEj2aX437k5MefoTq6tmU87u5onlN70bdKYx1YnXX7pYP1YJqwBtv5yypjRK9UEmZOi2e3spXmi6+/2WIclH5BRTp4fi8y+c2027uFLW4cVvpfEnTxDYMCC7y89jOQPXaNqYuSc4vuHiCEo8lC/4hC1TQEyPm0UBNIuzyECGiHBZH5gF2UrjLofFBQ6mLNak73xGYlgE7TloOQFBL7BdqY/IzwXXKqtcpTxuaTqSJomiy39MqtiPWhbK4D0c+4nrzmu3RA+xOhzTeyc4Ub5z9SErqpSVRGTgD40NFe5Kv", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(38350700005); DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n Z/GIMLNckanP+g6vjWgqNwKoW5U7NfsdSEjy3MM9CYA23pVz8WQtgbkgldZBMk60ltEgAwEobRrRBLtIQNcUg/23Vfa4CXXn99jcQz0ycf5Zd2JmJW9y5WVPaA8VALK4pPI+hK46S3y9/zjJeDbsC9vDdOxkNBzZ+IlQGNZg6XOe4/zrkPpgjPSWHs60ETzk/Et/CrC/QA43JoH0/Sa8AAeBSz9kH8DyIZPEzvOgipWG/j0wfm9z48FBg0iLdov6Oh91QoZXUTRCmavA433pr2k00dv9QArh4YAXPFyJA042Uf8we2EqQYuLMgrz3S3z2r798dC9Gv/OWjweKK4TvCWQTJ2GpxnDMLXQm4mrhw4u+xgjjIUyxf9Xjp+tbYH/TRMHM5PHRH+9oOWZBVhL8A0jnJL2TWa13kVZFYyBimjsunXdNi5BxEcDxEUgO8X6orpxgOsAIX4V1E1aOYPbRewRLqDaCydwY8T5+vN/s5Rk+Kwbve9x/kmS2OQ/xtvABUhDxC8XHBS1wC1oiShXjZ4IDP3y1/5YGI7s3HbveCPJZTJOep4N9Cf0CA7vWMasXgOYpfWwBq/DiKif0YzCDmqMphIO1i/xtYBFLBoeyCs1lxWlkhRv8pLs4Pw7mw8UueM7nPyAOVQB3zuWPwY440u8qIMjjPd4od4on5ujFzR/pG38eGLa2n+Qv+tri04tnRD4d7Wt1hsU09hkBS8ijOZs7GxJ1YjY2iBt5VNKPWKV9437xYNHl2AyIpeYsroG4y4UX/s21iZnmr6JhUftiI7JTXcnKJyhpLsRIfIe8ruh4xPXtSEV4IOywvEaujRdjHOB8BRnP7ObW9z776cjYE0Les2sxssIXWsGH9+UWqLqmaomeDRZa10JoKF6wlAgHrmet93AparqZqnVx/ZfnwxCWdyenstvkxDfoOz5mFaI0eCvmz3nowrz3HdZpmn11RRAxXxh3zU1oc0VPZ2Evo9ornbJfEMRmjSg1UrteKC7LgLY41TKBdPqVsDVp/3V721C+YLNUdqGZRyJNZbkSQU0YczCGMx7t9tJKsWOMnppIB+wyYjSMYTbwNZl08x4CjNTRkEjY+gSDZR/3jxF1equ6Cge6F+UVoKB1bzRhXYiAE3aP9Bh3IryULDu9unQ6RIpg+XHS68gGGaPl1jKzd8Hm0ENAD0aWoItVmc8Qn0X1plZ/S+dyH6ccGmkymMdrg3cimGTYXnFxsip7hDxyZ/A87JMpEgTumLupsvFTyePUuvE8ed+meiyfsQG9uoljEYMWZu/VhvwYlTIHKtkbdHz/8NHZ1c6qJEuwTiyektHJ4b1CWtcLdTvzbLiyaXKqrCyB3cb3KX73ZbX05G+716ygigjPYddnd5HrBAKQXcEH/0Jn2EKWZg9L5YsijCYiiljV6Av1YYo/jbTju+KG2RQgIWUKKHLhw0iHXUTJPtF6Dlvlka65Lt8g/3icepTkY+6U4YsVoiKZglky7MexCd+AgYigzIz00UA0AgSzSeq+Zj4iVTO87YExfTdiW60fn6QeRqZ51ZKfbFtJFafy20ydL41z+oK3z3Y+WU31k6M2JKJCEIa2J0sAwOocLMq7wr44kPSnbItd8uCZDwG/g==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d036617a-cfbd-44f5-517b-08dc34191926", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Feb 2024 02:42:38.3606 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n Ch6W/0PEG0SjY3AdWyGqCxRwOfG/e1j9Dkj5/wcLEEzrtTdyZgZZO3oPqhSxi/XJ4/4GMwkbdkysPr85eM3S/XRTgIxMC/MlvMvLNuIeSus=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA1PR13MB6645", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nAdd a function to check if a device is representor port, also\nmodified the related codes for PMDs.\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 3 +++\n drivers/net/bnxt/bnxt.h | 3 ---\n drivers/net/bnxt/bnxt_ethdev.c | 4 ++--\n drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c | 12 ++++++------\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 4 ++--\n drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 4 ++--\n drivers/net/cpfl/cpfl_representor.c | 2 +-\n drivers/net/enic/enic.h | 5 -----\n drivers/net/enic/enic_ethdev.c | 2 +-\n drivers/net/enic/enic_fm_flow.c | 20 ++++++++++----------\n drivers/net/enic/enic_main.c | 4 ++--\n drivers/net/i40e/i40e_ethdev.c | 2 +-\n drivers/net/ice/ice_dcf_ethdev.c | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-\n drivers/net/nfp/flower/nfp_flower_flow.c | 2 +-\n drivers/net/nfp/nfp_mtr.c | 2 +-\n drivers/net/nfp/nfp_net_common.c | 4 ++--\n drivers/net/nfp/nfp_net_flow.c | 2 +-\n lib/ethdev/ethdev_driver.h | 17 +++++++++++++++++\n 19 files changed, 54 insertions(+), 42 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex 879bb4944c..8178417b98 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -185,6 +185,9 @@ API Changes\n * ethdev: Renamed structure ``rte_flow_action_modify_data`` to be\n ``rte_flow_field_data`` for more generic usage.\n \n+* ethdev: Add new function ``rte_eth_dev_is_repr()`` to check if a device is\n+ representor port.\n+\n \n ABI Changes\n -----------\ndiff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex fcf2b8be97..82036a16a1 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -1204,9 +1204,6 @@ extern const struct rte_flow_ops bnxt_flow_meter_ops;\n \t} \\\n } while (0)\n \n-#define\tBNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)\t\\\n-\t\t((eth_dev)->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n-\n extern int bnxt_logtype_driver;\n #define RTE_LOGTYPE_BNXT bnxt_logtype_driver\n #define PMD_DRV_LOG_RAW(level, fmt, args...) \\\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex f8d83662f4..825e9c1941 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3525,7 +3525,7 @@ bnxt_flow_ops_get_op(struct rte_eth_dev *dev,\n \tif (!bp)\n \t\treturn -EIO;\n \n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(dev)) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tstruct bnxt_representor *vfr = dev->data->dev_private;\n \t\tbp = vfr->parent_dev->data->dev_private;\n \t\t/* parent is deleted while children are still valid */\n@@ -6781,7 +6781,7 @@ static int bnxt_pci_remove(struct rte_pci_device *pci_dev)\n \n \tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d pci remove\\n\", eth_dev->data->port_id);\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\tif (eth_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\t\tif (rte_eth_dev_is_repr(eth_dev))\n \t\t\treturn rte_eth_dev_destroy(eth_dev,\n \t\t\t\t\t\t bnxt_representor_uninit);\n \t\telse\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c b/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c\nindex 239191e14e..96d61c3ed2 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c\n@@ -202,7 +202,7 @@ bnxt_pmd_get_svif(uint16_t port_id, bool func_svif,\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -260,7 +260,7 @@ bnxt_pmd_get_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -285,7 +285,7 @@ bnxt_pmd_get_fw_func_id(uint16_t port, enum bnxt_ulp_intf_type type)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -308,7 +308,7 @@ bnxt_pmd_get_interface_type(uint16_t port)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev))\n+\tif (rte_eth_dev_is_repr(eth_dev))\n \t\treturn BNXT_ULP_INTF_TYPE_VF_REP;\n \n \tbp = eth_dev->data->dev_private;\n@@ -330,7 +330,7 @@ bnxt_pmd_get_phy_port_id(uint16_t port_id)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tvfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -350,7 +350,7 @@ bnxt_pmd_get_parif(uint16_t port_id, enum bnxt_ulp_intf_type type)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex 274e935a1f..33028c470f 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -1559,7 +1559,7 @@ bnxt_ulp_destroy_vfr_default_rules(struct bnxt *bp, bool global)\n \tstruct rte_eth_dev *vfr_eth_dev;\n \tstruct bnxt_representor *vfr_bp;\n \n-\tif (!BNXT_TRUFLOW_EN(bp) || BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))\n+\tif (!BNXT_TRUFLOW_EN(bp) || rte_eth_dev_is_repr(bp->eth_dev))\n \t\treturn;\n \n \tif (!bp->ulp_ctx || !bp->ulp_ctx->cfg_data)\n@@ -2316,7 +2316,7 @@ bnxt_ulp_eth_dev_ptr2_cntxt_get(struct rte_eth_dev\t*dev)\n {\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(dev)) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tstruct bnxt_representor *vfr = dev->data->dev_private;\n \n \t\tbp = vfr->parent_dev->data->dev_private;\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\nindex fe1f65deb9..8237dbd294 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n@@ -449,7 +449,7 @@ bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)\n \tuint16_t port_id;\n \n \tif (!BNXT_TRUFLOW_EN(bp) ||\n-\t BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))\n+\t rte_eth_dev_is_repr(bp->eth_dev))\n \t\treturn;\n \n \tif (!bp->ulp_ctx || !bp->ulp_ctx->cfg_data)\n@@ -514,7 +514,7 @@ bnxt_ulp_create_df_rules(struct bnxt *bp)\n \tint rc = 0;\n \n \tif (!BNXT_TRUFLOW_EN(bp) ||\n-\t BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev) || !bp->ulp_ctx)\n+\t rte_eth_dev_is_repr(bp->eth_dev) || !bp->ulp_ctx)\n \t\treturn 0;\n \n \tport_id = bp->eth_dev->data->port_id;\ndiff --git a/drivers/net/cpfl/cpfl_representor.c b/drivers/net/cpfl/cpfl_representor.c\nindex e2ed9eda04..60b72b5ec1 100644\n--- a/drivers/net/cpfl/cpfl_representor.c\n+++ b/drivers/net/cpfl/cpfl_representor.c\n@@ -339,7 +339,7 @@ cpfl_repr_link_update(struct rte_eth_dev *ethdev,\n \tstruct cpfl_vport_id vi;\n \tint ret;\n \n-\tif (!(ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)) {\n+\tif (!rte_eth_dev_is_repr(ethdev)) {\n \t\tPMD_INIT_LOG(ERR, \"This ethdev is not representor.\");\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h\nindex 78778704f2..f46903ea9e 100644\n--- a/drivers/net/enic/enic.h\n+++ b/drivers/net/enic/enic.h\n@@ -233,11 +233,6 @@ struct enic_vf_representor {\n #define VF_ENIC_TO_VF_REP(vf_enic) \\\n \tcontainer_of(vf_enic, struct enic_vf_representor, enic)\n \n-static inline int enic_is_vf_rep(struct enic *enic)\n-{\n-\treturn !!(enic->rte_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR);\n-}\n-\n /* Compute ethdev's max packet size from MTU */\n static inline uint32_t enic_mtu_to_max_rx_pktlen(uint32_t mtu)\n {\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex 7e040c36c4..cad8db2f6f 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -1386,7 +1386,7 @@ static int eth_enic_pci_remove(struct rte_pci_device *pci_dev)\n \tethdev = rte_eth_dev_allocated(pci_dev->device.name);\n \tif (!ethdev)\n \t\treturn -ENODEV;\n-\tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(ethdev))\n \t\treturn rte_eth_dev_destroy(ethdev, enic_vf_representor_uninit);\n \telse\n \t\treturn rte_eth_dev_destroy(ethdev, eth_enic_dev_uninit);\ndiff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c\nindex 90027dc676..8988148454 100644\n--- a/drivers/net/enic/enic_fm_flow.c\n+++ b/drivers/net/enic/enic_fm_flow.c\n@@ -1535,14 +1535,14 @@ vf_egress_port_id_action(struct enic_flowman *fm,\n \tENICPMD_FUNC_TRACE();\n \tsrc_enic = fm->user_enic;\n \tdst_enic = pmd_priv(dst_dev);\n-\tif (!(src_enic->rte_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)) {\n+\tif (!rte_eth_dev_is_repr(src_enic->rte_dev)) {\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\tNULL, \"source port is not VF representor\");\n \t}\n \n \t/* VF -> PF uplink. dst is not VF representor */\n-\tif (!(dst_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)) {\n+\tif (!rte_eth_dev_is_repr(dst_dev)) {\n \t\t/* PF is the VF's PF? Then nothing to do */\n \t\tvf = VF_ENIC_TO_VF_REP(src_enic);\n \t\tif (vf->pf == dst_enic) {\n@@ -1954,7 +1954,7 @@ enic_fm_copy_action(struct enic_flowman *fm,\n \tif (!(overlap & (FATE | PASSTHRU | COUNT | PORT_ID)))\n \t\tgoto unsupported;\n \t/* Egress from VF: need implicit WQ match */\n-\tif (enic_is_vf_rep(enic) && !ingress) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev) && !ingress) {\n \t\tfmt->ftm_data.fk_wq_id = 0;\n \t\tfmt->ftm_mask.fk_wq_id = 0xffff;\n \t\tfmt->ftm_data.fk_wq_vnic = enic->fm_vnic_handle;\n@@ -3226,7 +3226,7 @@ enic_fm_init(struct enic *enic)\n \t\treturn 0;\n \tENICPMD_FUNC_TRACE();\n \t/* Get vnic handle and save for port-id action */\n-\tif (enic_is_vf_rep(enic))\n+\tif (rte_eth_dev_is_repr(enic->rte_dev))\n \t\taddr = &VF_ENIC_TO_VF_REP(enic)->bdf;\n \telse\n \t\taddr = &RTE_ETH_DEV_TO_PCI(enic->rte_dev)->addr;\n@@ -3240,7 +3240,7 @@ enic_fm_init(struct enic *enic)\n \tenic->fm_vnic_uif = vnic_dev_uif(enic->vdev);\n \tENICPMD_LOG(DEBUG, \"uif %u\", enic->fm_vnic_uif);\n \t/* Nothing else to do for representor. It will share the PF flowman */\n-\tif (enic_is_vf_rep(enic))\n+\tif (rte_eth_dev_is_repr(enic->rte_dev))\n \t\treturn 0;\n \tfm = calloc(1, sizeof(*fm));\n \tif (fm == NULL) {\n@@ -3321,7 +3321,7 @@ enic_fm_destroy(struct enic *enic)\n \tstruct enic_fm_fet *fet;\n \n \tENICPMD_FUNC_TRACE();\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tdelete_rep_flows(enic);\n \t\treturn;\n \t}\n@@ -3358,7 +3358,7 @@ enic_fm_allocate_switch_domain(struct enic *pf)\n \tint ret;\n \n \tENICPMD_FUNC_TRACE();\n-\tif (enic_is_vf_rep(pf))\n+\tif (rte_eth_dev_is_repr(pf->rte_dev))\n \t\treturn -EINVAL;\n \tcur = pf;\n \tcur_a = &RTE_ETH_DEV_TO_PCI(cur->rte_dev)->addr;\n@@ -3367,7 +3367,7 @@ enic_fm_allocate_switch_domain(struct enic *pf)\n \t\tdev = &rte_eth_devices[pid];\n \t\tif (!dev_is_enic(dev))\n \t\t\tcontinue;\n-\t\tif (dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\t\tif (rte_eth_dev_is_repr(dev))\n \t\t\tcontinue;\n \t\tif (dev == cur->rte_dev)\n \t\t\tcontinue;\n@@ -3597,7 +3597,7 @@ delete_rep_flows(struct enic *enic)\n \tstruct rte_eth_dev *dev;\n \tuint32_t i;\n \n-\tRTE_ASSERT(enic_is_vf_rep(enic));\n+\tRTE_ASSERT(rte_eth_dev_is_repr(enic->rte_dev));\n \tvf = VF_ENIC_TO_VF_REP(enic);\n \tdev = vf->pf->rte_dev;\n \tfor (i = 0; i < ARRAY_SIZE(vf->vf2rep_flow); i++) {\n@@ -3617,7 +3617,7 @@ begin_fm(struct enic *enic)\n \tstruct enic_flowman *fm;\n \n \t/* Representor uses PF flowman */\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tvf = VF_ENIC_TO_VF_REP(enic);\n \t\tfm = vf->pf->fm;\n \t} else {\ndiff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex a6aaa760ca..2f681315b6 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -824,7 +824,7 @@ int enic_alloc_rq(struct enic *enic, uint16_t queue_idx,\n \t * Representor uses a reserved PF queue. Translate representor\n \t * queue number to PF queue number.\n \t */\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tRTE_ASSERT(queue_idx == 0);\n \t\tvf = VF_ENIC_TO_VF_REP(enic);\n \t\tsop_queue_idx = vf->pf_rq_sop_idx;\n@@ -1053,7 +1053,7 @@ int enic_alloc_wq(struct enic *enic, uint16_t queue_idx,\n \t * Representor uses a reserved PF queue. Translate representor\n \t * queue number to PF queue number.\n \t */\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tRTE_ASSERT(queue_idx == 0);\n \t\tvf = VF_ENIC_TO_VF_REP(enic);\n \t\tqueue_idx = vf->pf_wq_idx;\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 4d21341382..ddbc2962bc 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -706,7 +706,7 @@ static int eth_i40e_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!ethdev)\n \t\treturn 0;\n \n-\tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(ethdev))\n \t\treturn rte_eth_dev_pci_generic_remove(pci_dev,\n \t\t\t\t\ti40e_vf_representor_uninit);\n \telse\ndiff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex bebf356f4d..d58ec9d907 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -2131,7 +2131,7 @@ eth_ice_dcf_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!eth_dev)\n \t\treturn 0;\n \n-\tif (eth_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(eth_dev))\n \t\treturn rte_eth_dev_pci_generic_remove(pci_dev,\n \t\t\t\t\t\t ice_dcf_vf_repr_uninit);\n \telse\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 0cd3d0b105..c61c52b296 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1842,7 +1842,7 @@ static int eth_ixgbe_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!ethdev)\n \t\treturn 0;\n \n-\tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(ethdev))\n \t\treturn rte_eth_dev_pci_generic_remove(pci_dev,\n \t\t\t\t\tixgbe_vf_representor_uninit);\n \telse\ndiff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c\nindex e26be30d18..501a8d87bd 100644\n--- a/drivers/net/nfp/flower/nfp_flower_flow.c\n+++ b/drivers/net/nfp/flower/nfp_flower_flow.c\n@@ -4321,7 +4321,7 @@ int\n nfp_flow_ops_get(struct rte_eth_dev *dev,\n \t\tconst struct rte_flow_ops **ops)\n {\n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) {\n+\tif (!rte_eth_dev_is_repr(dev)) {\n \t\t*ops = NULL;\n \t\tPMD_DRV_LOG(ERR, \"Port is not a representor.\");\n \t\treturn -EINVAL;\ndiff --git a/drivers/net/nfp/nfp_mtr.c b/drivers/net/nfp/nfp_mtr.c\nindex 255977ec22..6abc6dc9bc 100644\n--- a/drivers/net/nfp/nfp_mtr.c\n+++ b/drivers/net/nfp/nfp_mtr.c\n@@ -1066,7 +1066,7 @@ static const struct rte_mtr_ops nfp_mtr_ops = {\n int\n nfp_net_mtr_ops_get(struct rte_eth_dev *dev, void *arg)\n {\n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) {\n+\tif (!rte_eth_dev_is_repr(dev)) {\n \t\tPMD_DRV_LOG(ERR, \"Port is not a representor\");\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex 99c319eb2d..0ee2811926 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -241,7 +241,7 @@ nfp_net_get_hw(const struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\n \n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tstruct nfp_flower_representor *repr;\n \t\trepr = dev->data->dev_private;\n \t\thw = repr->app_fw_flower->pf_hw;\n@@ -2143,7 +2143,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,\n \n \thw = nfp_net_get_hw(dev);\n \n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tsnprintf(vnic_version, FW_VER_LEN, \"%d.%d.%d.%d\",\n \t\t\thw->ver.extend, hw->ver.class,\n \t\t\thw->ver.major, hw->ver.minor);\ndiff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c\nindex 98e8499756..3b33f3b6e9 100644\n--- a/drivers/net/nfp/nfp_net_flow.c\n+++ b/drivers/net/nfp/nfp_net_flow.c\n@@ -932,7 +932,7 @@ nfp_net_flow_ops_get(struct rte_eth_dev *dev,\n {\n \tstruct nfp_net_hw *hw;\n \n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\t*ops = NULL;\n \t\tPMD_DRV_LOG(ERR, \"Port is a representor.\");\n \t\treturn -EINVAL;\ndiff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex 0e4c1f0743..f46c102558 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -2120,6 +2120,23 @@ struct rte_eth_fdir_conf {\n \tstruct rte_eth_fdir_flex_conf flex_conf;\n };\n \n+/**\n+ * @internal\n+ * Check if the ethdev is a representor port.\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ *\n+ * @return\n+ * false the ethdev is not a representor port.\n+ * true the ethdev is a representor port.\n+ */\n+static inline bool\n+rte_eth_dev_is_repr(const struct rte_eth_dev *dev)\n+{\n+\treturn ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0);\n+}\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v2", "1/4" ] }