Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136921,
    "url": "http://patches.dpdk.org/api/patches/136921/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240220131502.47510-4-fengchengwen@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240220131502.47510-4-fengchengwen@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240220131502.47510-4-fengchengwen@huawei.com",
    "date": "2024-02-20T13:15:01",
    "name": "[3/4] argparse: fix argument flags operate as uint32 type",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fee420c5618379ea3b113ceaaabc5428d4d7a111",
    "submitter": {
        "id": 2146,
        "url": "http://patches.dpdk.org/api/people/2146/?format=api",
        "name": "fengchengwen",
        "email": "fengchengwen@huawei.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240220131502.47510-4-fengchengwen@huawei.com/mbox/",
    "series": [
        {
            "id": 31152,
            "url": "http://patches.dpdk.org/api/series/31152/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31152",
            "date": "2024-02-20T13:15:00",
            "name": "refine argparse library",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/31152/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/136921/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/136921/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DB1743B57;\n\tTue, 20 Feb 2024 14:16:44 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 705B24067C;\n\tTue, 20 Feb 2024 14:16:33 +0100 (CET)",
            "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 1A19C402A7\n for <dev@dpdk.org>; Tue, 20 Feb 2024 14:16:29 +0100 (CET)",
            "from mail.maildlp.com (unknown [172.19.88.194])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4TfKd54QCWzsX1F;\n Tue, 20 Feb 2024 21:14:49 +0800 (CST)",
            "from dggpeml500024.china.huawei.com (unknown [7.185.36.10])\n by mail.maildlp.com (Postfix) with ESMTPS id 070B0140418;\n Tue, 20 Feb 2024 21:16:28 +0800 (CST)",
            "from localhost.localdomain (10.50.165.33) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Tue, 20 Feb 2024 21:16:27 +0800"
        ],
        "From": "Chengwen Feng <fengchengwen@huawei.com>",
        "To": "<thomas@monjalon.net>, <dev@dpdk.org>",
        "Subject": "[PATCH 3/4] argparse: fix argument flags operate as uint32 type",
        "Date": "Tue, 20 Feb 2024 13:15:01 +0000",
        "Message-ID": "<20240220131502.47510-4-fengchengwen@huawei.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20240220131502.47510-1-fengchengwen@huawei.com>",
        "References": "<20240220131502.47510-1-fengchengwen@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggpeml500024.china.huawei.com (7.185.36.10)",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The struct rte_argparse_arg's flags was 64bit type, uint64_t should be\nused instead of uint32_t where the operation happened.\n\nAlso, the flags' bit16 was also unused, so don't test bit16 in testcase\ntest_argparse_invalid_arg_flags.\n\nFixes: 6c5c6571601c (\"argparse: verify argument config\")\nFixes: 31ed9f9f43bb (\"argparse: parse parameters\")\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n app/test/test_argparse.c    | 16 ++++++++--------\n lib/argparse/rte_argparse.c |  4 ++--\n 2 files changed, 10 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/app/test/test_argparse.c b/app/test/test_argparse.c\nindex c98bcee56d..708a575e16 100644\n--- a/app/test/test_argparse.c\n+++ b/app/test/test_argparse.c\n@@ -188,7 +188,7 @@ test_argparse_invalid_arg_help(void)\n static int\n test_argparse_invalid_has_val(void)\n {\n-\tuint32_t set_mask[] = { 0,\n+\tuint64_t set_mask[] = { 0,\n \t\t\t\tRTE_ARGPARSE_ARG_NO_VALUE,\n \t\t\t\tRTE_ARGPARSE_ARG_OPTIONAL_VALUE\n \t\t\t      };\n@@ -197,7 +197,7 @@ test_argparse_invalid_has_val(void)\n \tint ret;\n \n \tobj = test_argparse_init_obj();\n-\tobj->args[0].flags &= ~0x3u;\n+\tobj->args[0].flags &= ~0x3ull;\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n@@ -205,7 +205,7 @@ test_argparse_invalid_has_val(void)\n \t\tobj = test_argparse_init_obj();\n \t\tobj->args[0].name_long = \"abc\";\n \t\tobj->args[0].name_short = NULL;\n-\t\tobj->args[0].flags &= ~0x3u;\n+\t\tobj->args[0].flags &= ~0x3ull;\n \t\tobj->args[0].flags |= set_mask[index];\n \t\tret = rte_argparse_parse(obj, default_argc, default_argv);\n \t\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n@@ -269,7 +269,7 @@ test_argparse_invalid_arg_flags(void)\n \tint ret;\n \n \tobj = test_argparse_init_obj();\n-\tobj->args[0].flags |= ~0x107FFu;\n+\tobj->args[0].flags |= ~0x7FFull;\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n@@ -337,7 +337,7 @@ test_argparse_invalid_option(void)\n static int\n test_argparse_opt_autosave_parse_int_of_no_val(void)\n {\n-\tuint32_t flags = RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n+\tuint64_t flags = RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n \tstruct rte_argparse *obj;\n \tint val_saver = 0;\n \tchar *argv[2];\n@@ -369,7 +369,7 @@ test_argparse_opt_autosave_parse_int_of_no_val(void)\n static int\n test_argparse_opt_autosave_parse_int_of_required_val(void)\n {\n-\tuint32_t flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n+\tuint64_t flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n \tstruct rte_argparse *obj;\n \tint val_saver = 0;\n \tchar *argv[3];\n@@ -410,7 +410,7 @@ test_argparse_opt_autosave_parse_int_of_required_val(void)\n static int\n test_argparse_opt_autosave_parse_int_of_optional_val(void)\n {\n-\tuint32_t flags = RTE_ARGPARSE_ARG_OPTIONAL_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n+\tuint64_t flags = RTE_ARGPARSE_ARG_OPTIONAL_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n \tstruct rte_argparse *obj;\n \tint val_saver = 0;\n \tchar *argv[2];\n@@ -645,7 +645,7 @@ test_argparse_opt_callback_parse_int_of_optional_val(void)\n static int\n test_argparse_pos_autosave_parse_int(void)\n {\n-\tuint32_t flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n+\tuint64_t flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n \tstruct rte_argparse *obj;\n \tint val_saver = 0;\n \tchar *argv[3];\ndiff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c\nindex 6e890cdc0d..9e799a16c5 100644\n--- a/lib/argparse/rte_argparse.c\n+++ b/lib/argparse/rte_argparse.c\n@@ -50,7 +50,7 @@ arg_attr_flag_multi(const struct rte_argparse_arg *arg)\n \treturn RTE_FIELD_GET64(ARG_ATTR_SUPPORT_MULTI_MASK, arg->flags);\n }\n \n-static inline uint32_t\n+static inline uint64_t\n arg_attr_unused_bits(const struct rte_argparse_arg *arg)\n {\n #define USED_BIT_MASK\t(ARG_ATTR_HAS_VAL_MASK | ARG_ATTR_VAL_TYPE_MASK | \\\n@@ -172,7 +172,7 @@ static int\n verify_arg_flags(const struct rte_argparse *obj, uint32_t index)\n {\n \tconst struct rte_argparse_arg *arg = &obj->args[index];\n-\tuint32_t unused_bits = arg_attr_unused_bits(arg);\n+\tuint64_t unused_bits = arg_attr_unused_bits(arg);\n \n \tif (unused_bits != 0) {\n \t\tARGPARSE_LOG(ERR, \"argument %s flags unused bits should not be set!\",\n",
    "prefixes": [
        "3/4"
    ]
}