Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136841/?format=api
{ "id": 136841, "url": "http://patches.dpdk.org/api/patches/136841/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240216034025.47371-1-kumaraparamesh92@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240216034025.47371-1-kumaraparamesh92@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240216034025.47371-1-kumaraparamesh92@gmail.com", "date": "2024-02-16T03:40:25", "name": "[v7] app/testpmd : fix packets not getting flushed in heavy-weight mode API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3425183128f70beae868c05ed04b8f75d035d700", "submitter": { "id": 2391, "url": "http://patches.dpdk.org/api/people/2391/?format=api", "name": "Kumara Parameshwaran", "email": "kumaraparamesh92@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240216034025.47371-1-kumaraparamesh92@gmail.com/mbox/", "series": [ { "id": 31124, "url": "http://patches.dpdk.org/api/series/31124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31124", "date": "2024-02-16T03:40:25", "name": "[v7] app/testpmd : fix packets not getting flushed in heavy-weight mode API", "version": 7, "mbox": "http://patches.dpdk.org/series/31124/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136841/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/136841/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A099A43B24;\n\tFri, 16 Feb 2024 04:41:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6FF5140284;\n\tFri, 16 Feb 2024 04:41:07 +0100 (CET)", "from mail-pj1-f48.google.com (mail-pj1-f48.google.com\n [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 285124027C\n for <dev@dpdk.org>; Fri, 16 Feb 2024 04:41:05 +0100 (CET)", "by mail-pj1-f48.google.com with SMTP id\n 98e67ed59e1d1-297108e7001so1300512a91.1\n for <dev@dpdk.org>; Thu, 15 Feb 2024 19:41:05 -0800 (PST)", "from IDCREDBOX918.fareast.corp.microsoft.com ([167.220.238.89])\n by smtp.gmail.com with ESMTPSA id\n sx6-20020a17090b2cc600b00296a686dd17sm4205916pjb.56.2024.02.15.19.41.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 15 Feb 2024 19:41:03 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1708054864; x=1708659664; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1XJe2qPYqgArwfX1IWFoby2TaS6dpU8KiCeKSwSiE64=;\n b=dH2IuTnflMK6hVtc+LFQcNAyYRMIYDInSLecYhc+m03oBbGkNW/b+GfR4Xe4Milrqh\n PNBTVKTJDk/iWKE7zsJinvyudvL4LtX9qZBViHYjPOp/BZ2c0Q2kZ0dJ7HvA6BVq226C\n omF1AnRU6TZKXTCj8aQC1qnoeGVxDRCv/7uvBQ8OIi613fhqFE8TXPSc5bDGoVCEqWti\n NwaOO0JNc5ck5PQbG8D53AbNlu8XAyfZXsc0evTeRlFytkaVQL9L0leJl0fHQ+SZ/d70\n hnW44/shy2Pi2FvSNjwtcD7Wqd45fWKAfnhXt2fLD+Xgfut9gbQAIpXM1Z/hPBdhYUSW\n gCdA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1708054864; x=1708659664;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=1XJe2qPYqgArwfX1IWFoby2TaS6dpU8KiCeKSwSiE64=;\n b=FACzzOt/NIYqL6EYv2o/13yH1B2sgHZ80+74c+AscLmnC0Zl2wE0h1WkmAhj/gUnL2\n aB7pgE4wI2q1UoOluji2cG7M2xPAnTwN+6WKzWR7C4qv+Dg+FplhnWf+Saqw8cidzg39\n hmk5q9ZVmC7KXUlDktlyV3XqkSO0vIWcYdwgAEUIGlunfHCnrFLxC0x+JyS1ESIMNRFP\n Ar/q3kd24sWYnfHOQPz2VeL89krlRjOuyoYKLdXH1sTI/1BsXm/S8dua7fwwduhTVJkk\n wTM43ha9fmKPos/lfd0czxamAYHIltbFZtR7UxU5rli1m5GL05HGUKCpkw+zGo3/YFmz\n dWuQ==", "X-Gm-Message-State": "AOJu0YywMCbbyi37rnfvePTkGwCMOZypAfOzSC5dTWfWKHM9ck2I4Icn\n 6kL15dTgx0lm9+4+JXpr3+CIZEL96Yeeq/WAfnhJZpC58GuKuVRI", "X-Google-Smtp-Source": "\n AGHT+IEoHQ6K6b2uK/YSRBoIeZVRAoX1Pr73uWahak4474ufhwf9lTtkBLrLGSwJ42FJcxSXfjAhIQ==", "X-Received": "by 2002:a17:90b:234b:b0:299:30eb:f687 with SMTP id\n ms11-20020a17090b234b00b0029930ebf687mr1183105pjb.16.1708054864106;\n Thu, 15 Feb 2024 19:41:04 -0800 (PST)", "From": "Kumara Parameshwaran <kumaraparamesh92@gmail.com>", "To": "hujiayu.hu@foxmail.com", "Cc": "dev@dpdk.org, Kumara Parameshwaran <kumaraparamesh92@gmail.com>,\n jiayu.hu@intel.com", "Subject": "[PATCH v7] app/testpmd : fix packets not getting flushed in\n heavy-weight mode API", "Date": "Fri, 16 Feb 2024 09:10:25 +0530", "Message-Id": "<20240216034025.47371-1-kumaraparamesh92@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240117195228.423261-1-kumaraparamesh92@gmail.com>", "References": "<20240117195228.423261-1-kumaraparamesh92@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In heavy-weight mode GRO which is based on timer, the GRO packets\nwill not be flushed in spite of timer expiry if there is no packet\nin the current poll. If timer mode GRO is enabled the\nrte_gro_timeout_flush API should be invoked.\n\nFixes: b7091f1dcfbc (\"app/testpmd: enable the heavyweight mode TCP/IPv4 GRO\")\nCc: jiayu.hu@intel.com\n\nSigned-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>\n---\nv1:\n Changes to make sure that the GRO flush API is invoked if there are no packets in \n current poll and timer expiry.\n\nv2:\n Fix code organisation issue\n\nv3:\n Fix warnings\n\nv4:\n Fix error and warnings\n\nv5:\n Fix compilation issue when GRO is not defined\n\nv6:\n Address review comments\n\nv7:\n Address review comments\n\n app/test-pmd/csumonly.c | 22 ++++++++++++++++++----\n 1 file changed, 18 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex c103e54111..637a46d92a 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -863,16 +863,29 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)\n \n \t/* receive a burst of packet */\n \tnb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);\n-\tif (unlikely(nb_rx == 0))\n+\tif (unlikely(nb_rx == 0)) {\n+#ifndef RTE_LIB_GRO\n \t\treturn false;\n+#else\n+\t\tgro_enable = gro_ports[fs->rx_port].enable;\n+\t\t/*\n+\t\t * Make sure that in case of Heavyweight mode GRO the packets in\n+\t\t * GRO cache should be flushed as the timer could have expired.\n+\t\t *\n+\t\t * The order of condidtions should be the same as gro_ctx is valid\n+\t\t * only when gro_flush_cycles is not the GRO_DEFAULT_FLUSH_CYCLES which\n+\t\t * indicates ligth weight mode GRO\n+\t\t */\n+\t\tif (!gro_enable || (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES) ||\n+\t\t\t(rte_gro_get_pkt_count(current_fwd_lcore()->gro_ctx) == 0))\n+\t\t\treturn false;\n+#endif\n+\t}\n \n \trx_bad_ip_csum = 0;\n \trx_bad_l4_csum = 0;\n \trx_bad_outer_l4_csum = 0;\n \trx_bad_outer_ip_csum = 0;\n-#ifdef RTE_LIB_GRO\n-\tgro_enable = gro_ports[fs->rx_port].enable;\n-#endif\n \n \ttxp = &ports[fs->tx_port];\n \ttx_offloads = txp->dev_conf.txmode.offloads;\n@@ -1103,6 +1116,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)\n \t}\n \n #ifdef RTE_LIB_GRO\n+\tgro_enable = gro_ports[fs->rx_port].enable;\n \tif (unlikely(gro_enable)) {\n \t\tif (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES) {\n \t\t\tnb_rx = rte_gro_reassemble_burst(pkts_burst, nb_rx,\n", "prefixes": [ "v7" ] }