Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136815/?format=api
{ "id": 136815, "url": "http://patches.dpdk.org/api/patches/136815/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707978080-28859-13-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707978080-28859-13-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707978080-28859-13-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-15T06:21:14", "name": "[v4,12/18] net/hns3: stop using zero sized marker fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2442ba4a6e6941eb30c95826f1f3508a1a9bdd51", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707978080-28859-13-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31113, "url": "http://patches.dpdk.org/api/series/31113/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31113", "date": "2024-02-15T06:21:02", "name": "stop using zero sized marker fields", "version": 4, "mbox": "http://patches.dpdk.org/series/31113/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136815/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136815/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E6FB143B06;\n\tThu, 15 Feb 2024 07:23:21 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 087A0433E2;\n\tThu, 15 Feb 2024 07:21:58 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8228F43388\n for <dev@dpdk.org>; Thu, 15 Feb 2024 07:21:38 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id B317420B2005; Wed, 14 Feb 2024 22:21:36 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com B317420B2005", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707978096;\n bh=BEcsdSNENhlbzYMyQuG0QedzSAJOJYSkQuY2DlRxCjI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=dKdXHD2qrEFLzxmOsZGpUw5svnsTqyC9azdoRfw4wI9sVhK71DjuERl08KN2dwkHI\n Iwlou+wmmybLzls+xCIOZSX380mbW3CE5l/LHSHVW8KNVKmYDSsa4yzgMxN5Psvlby\n MZtEw1K9t+OSowrfljutX1IevOfANrpnU75Sf3/I=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 12/18] net/hns3: stop using zero sized marker fields", "Date": "Wed, 14 Feb 2024 22:21:14 -0800", "Message-Id": "<1707978080-28859-13-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update to reference newly named anonymous union markers supported by\nstandard C and stop referencing zero sized compiler extension markers.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/hns3/hns3_rxtx_vec.c | 22 +++++++++++-----------\n drivers/net/hns3/hns3_rxtx_vec_neon.h | 28 ++++++++++++++--------------\n drivers/net/hns3/hns3_rxtx_vec_sve.c | 6 +++---\n 3 files changed, 28 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx_vec.c b/drivers/net/hns3/hns3_rxtx_vec.c\nindex 9708ec6..4888b3d 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec.c\n+++ b/drivers/net/hns3/hns3_rxtx_vec.c\n@@ -121,27 +121,27 @@\n \tmb_def.port = rxq->port_id;\n \trte_mbuf_refcnt_set(&mb_def, 1);\n \n-\t/* compile-time verifies the rearm_data first 8bytes */\n+\t/* compile-time verifies the mbuf_rearm_data first 8bytes */\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) <\n-\t\t\t offsetof(struct rte_mbuf, rearm_data));\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data));\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, refcnt) <\n-\t\t\t offsetof(struct rte_mbuf, rearm_data));\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data));\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, nb_segs) <\n-\t\t\t offsetof(struct rte_mbuf, rearm_data));\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data));\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, port) <\n-\t\t\t offsetof(struct rte_mbuf, rearm_data));\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data));\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) -\n-\t\t\t offsetof(struct rte_mbuf, rearm_data) > 6);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data) > 6);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, refcnt) -\n-\t\t\t offsetof(struct rte_mbuf, rearm_data) > 6);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data) > 6);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, nb_segs) -\n-\t\t\t offsetof(struct rte_mbuf, rearm_data) > 6);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data) > 6);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, port) -\n-\t\t\t offsetof(struct rte_mbuf, rearm_data) > 6);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data) > 6);\n \n-\t/* prevent compiler reordering: rearm_data covers previous fields */\n+\t/* prevent compiler reordering: mbuf_rearm_data covers previous fields */\n \trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n+\tp = (uintptr_t)&mb_def.mbuf_rearm_data;\n \trxq->mbuf_initializer = *(uint64_t *)p;\n }\n \ndiff --git a/drivers/net/hns3/hns3_rxtx_vec_neon.h b/drivers/net/hns3/hns3_rxtx_vec_neon.h\nindex 0dc6b9f..b1717ae 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_neon.h\n+++ b/drivers/net/hns3/hns3_rxtx_vec_neon.h\n@@ -104,7 +104,7 @@\n \tfor (i = 0; i < bd_vld_num; i++) {\n \t\tpkt = sw_ring[i].mbuf;\n \n-\t\t/* init rte_mbuf.rearm_data last 64-bit */\n+\t\t/* init rte_mbuf.mbuf_rearm_data last 64-bit */\n \t\tpkt->ol_flags = RTE_MBUF_F_RX_RSS_HASH;\n \n \t\tl234_info = rxdp[i].rx.l234_info;\n@@ -139,7 +139,7 @@\n \tuint32_t pos;\n \tint offset;\n \n-\t/* mask to shuffle from desc to mbuf's rx_descriptor_fields1 */\n+\t/* mask to shuffle from desc to mbuf's mbuf_rx_descriptor_fields1 */\n \tuint8x16_t shuf_desc_fields_msk = {\n \t\t0xff, 0xff, 0xff, 0xff, /* packet type init zero */\n \t\t20, 21, 0xff, 0xff, /* rx.pkt_len to rte_mbuf.pkt_len */\n@@ -158,11 +158,11 @@\n \n \t/* compile-time verifies the shuffle mask */\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 4);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 8);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, hash.rss) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 12);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 12);\n \n \tfor (pos = 0; pos < nb_pkts; pos += HNS3_DEFAULT_DESCS_PER_LOOP,\n \t\t\t\t rxdp += HNS3_DEFAULT_DESCS_PER_LOOP) {\n@@ -236,23 +236,23 @@\n \t\tpkt_mb4 = vreinterpretq_u8_u16(tmp);\n \n \t\t/* save packet info to rx_pkts mbuf */\n-\t\tvst1q_u8((void *)&sw_ring[pos + 0].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8((void *)&sw_ring[pos + 0].mbuf->mbuf_rx_descriptor_fields1,\n \t\t\t pkt_mb1);\n-\t\tvst1q_u8((void *)&sw_ring[pos + 1].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8((void *)&sw_ring[pos + 1].mbuf->mbuf_rx_descriptor_fields1,\n \t\t\t pkt_mb2);\n-\t\tvst1q_u8((void *)&sw_ring[pos + 2].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8((void *)&sw_ring[pos + 2].mbuf->mbuf_rx_descriptor_fields1,\n \t\t\t pkt_mb3);\n-\t\tvst1q_u8((void *)&sw_ring[pos + 3].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8((void *)&sw_ring[pos + 3].mbuf->mbuf_rx_descriptor_fields1,\n \t\t\t pkt_mb4);\n \n-\t\t/* store the first 8 bytes of packets mbuf's rearm_data */\n-\t\t*(uint64_t *)&sw_ring[pos + 0].mbuf->rearm_data =\n+\t\t/* store the first 8 bytes of packets mbuf's mbuf_rearm_data */\n+\t\t*(uint64_t *)&sw_ring[pos + 0].mbuf->mbuf_rearm_data =\n \t\t\trxq->mbuf_initializer;\n-\t\t*(uint64_t *)&sw_ring[pos + 1].mbuf->rearm_data =\n+\t\t*(uint64_t *)&sw_ring[pos + 1].mbuf->mbuf_rearm_data =\n \t\t\trxq->mbuf_initializer;\n-\t\t*(uint64_t *)&sw_ring[pos + 2].mbuf->rearm_data =\n+\t\t*(uint64_t *)&sw_ring[pos + 2].mbuf->mbuf_rearm_data =\n \t\t\trxq->mbuf_initializer;\n-\t\t*(uint64_t *)&sw_ring[pos + 3].mbuf->rearm_data =\n+\t\t*(uint64_t *)&sw_ring[pos + 3].mbuf->mbuf_rearm_data =\n \t\t\trxq->mbuf_initializer;\n \n \t\trte_prefetch_non_temporal(rxdp + HNS3_DEFAULT_DESCS_PER_LOOP);\ndiff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c\nindex 8aa4448..57aeca9 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c\n+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c\n@@ -33,7 +33,7 @@\n \tint ret, i;\n \n \tfor (i = 0; i < (int)bd_vld_num; i++) {\n-\t\t/* init rte_mbuf.rearm_data last 64-bit */\n+\t\t/* init rte_mbuf.mbuf_rearm_data last 64-bit */\n \t\trx_pkts[i]->ol_flags = RTE_MBUF_F_RX_RSS_HASH;\n \t\trx_pkts[i]->hash.rss = rxdp[i].rx.rss_hash;\n \t\trx_pkts[i]->pkt_len = rte_le_to_cpu_16(rxdp[i].rx.pkt_len) -\n@@ -123,9 +123,9 @@\n \t\tmbuf_init = svdup_n_u64(rxq->mbuf_initializer);\n \t\t/* save mbuf_initializer */\n \t\tsvst1_scatter_u64base_offset_u64(PG64_256BIT, mbp1st,\n-\t\t\toffsetof(struct rte_mbuf, rearm_data), mbuf_init);\n+\t\t\toffsetof(struct rte_mbuf, mbuf_rearm_data), mbuf_init);\n \t\tsvst1_scatter_u64base_offset_u64(PG64_256BIT, mbp2st,\n-\t\t\toffsetof(struct rte_mbuf, rearm_data), mbuf_init);\n+\t\t\toffsetof(struct rte_mbuf, mbuf_rearm_data), mbuf_init);\n \n \t\tnext_rxdp = rxdp + HNS3_SVE_DEFAULT_DESCS_PER_LOOP;\n \t\trte_prefetch_non_temporal(next_rxdp);\n", "prefixes": [ "v4", "12/18" ] }