Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13675/?format=api
{ "id": 13675, "url": "http://patches.dpdk.org/api/patches/13675/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1465921044-25700-1-git-send-email-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465921044-25700-1-git-send-email-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1465921044-25700-1-git-send-email-ferruh.yigit@intel.com", "date": "2016-06-14T16:17:24", "name": "[dpdk-dev,v3] mlx: fix icc compilation error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9c91cf48b790fbbf168a6a2f5751eed3fec8a1df", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 10, "url": "http://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1465921044-25700-1-git-send-email-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/13675/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/13675/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5097F9AAA;\n\tTue, 14 Jun 2016 18:17:31 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id DDA779A9C\n\tfor <dev@dpdk.org>; Tue, 14 Jun 2016 18:17:29 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP; 14 Jun 2016 09:17:30 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jun 2016 09:17:28 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tu5EGHRjk026148; Tue, 14 Jun 2016 17:17:27 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id u5EGHQXl025735;\n\tTue, 14 Jun 2016 17:17:26 +0100", "(from fyigit@localhost)\n\tby sivswdev02.ir.intel.com with id u5EGHQAV025731;\n\tTue, 14 Jun 2016 17:17:26 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,471,1459839600\"; d=\"scan'208\";a=\"997465356\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tFerruh Yigit <ferruh.yigit@intel.com>", "Date": "Tue, 14 Jun 2016 17:17:24 +0100", "Message-Id": "<1465921044-25700-1-git-send-email-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1465917730-10713-1-git-send-email-ferruh.yigit@intel.com>", "References": "<1465917730-10713-1-git-send-email-ferruh.yigit@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] mlx: fix icc compilation error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compilation errors:\nmlx4:\n CC mlx4.o\n .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type\n mixed with another type\n priv->intr_handle.type = 0;\n ^\n\nmlx5:\n CC em_rxtx.o\n.../dpdk/drivers/net/mlx5/mlx5_rxq.c(282):\nerror #188: enumerated type mixed with another type\n enum hash_rxq_type type = 0;\n ^\n\n.../dpdk/drivers/net/mlx5/mlx5_rxq.c(622):\nerror #188: enumerated type mixed with another type\n if (!priv_allow_flow_type(priv, i)) {\n ^\nmore same type of error\n\nFixes: c4da6caa426d (\"mlx4: handle link status interrupts\")\nFixes: 198a3c339a8f (\"mlx5: handle link status interrupts\")\nFixes: 0d2186743d62 (\"mlx5: manage all special flow types at once\")\nFixes: 612ad38209f7 (\"mlx5: fix hash Rx queue type in RSS mode\")\nFixes: 083c2dd31776 (\"mlx5: refactor special flows handling\")\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/net/mlx4/mlx4.c | 2 +-\n drivers/net/mlx5/mlx5_ethdev.c | 2 +-\n drivers/net/mlx5/mlx5_rxmode.c | 8 ++++++--\n drivers/net/mlx5/mlx5_rxq.c | 8 +++++---\n 4 files changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 9ed1491..8c9e713 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -5406,7 +5406,7 @@ priv_dev_interrupt_handler_uninstall(struct priv *priv, struct rte_eth_dev *dev)\n \t\trte_eal_alarm_cancel(mlx4_dev_link_status_handler, dev);\n \tpriv->pending_alarm = 0;\n \tpriv->intr_handle.fd = 0;\n-\tpriv->intr_handle.type = 0;\n+\tpriv->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;\n }\n \n /**\ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 36b369e..6f5ece9 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -1012,7 +1012,7 @@ priv_dev_interrupt_handler_uninstall(struct priv *priv, struct rte_eth_dev *dev)\n \t\trte_eal_alarm_cancel(mlx5_dev_link_status_handler, dev);\n \tpriv->pending_alarm = 0;\n \tpriv->intr_handle.fd = 0;\n-\tpriv->intr_handle.type = 0;\n+\tpriv->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;\n }\n \n /**\ndiff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c\nindex 3a55f63..3e779be 100644\n--- a/drivers/net/mlx5/mlx5_rxmode.c\n+++ b/drivers/net/mlx5/mlx5_rxmode.c\n@@ -355,7 +355,9 @@ priv_special_flow_enable_all(struct priv *priv)\n {\n \tenum hash_rxq_flow_type flow_type;\n \n-\tfor (flow_type = 0; flow_type != HASH_RXQ_FLOW_TYPE_MAC; ++flow_type) {\n+\tfor (flow_type = HASH_RXQ_FLOW_TYPE_PROMISC;\n+\t\t\tflow_type != HASH_RXQ_FLOW_TYPE_MAC;\n+\t\t\t++flow_type) {\n \t\tint ret;\n \n \t\tret = priv_special_flow_enable(priv, flow_type);\n@@ -380,7 +382,9 @@ priv_special_flow_disable_all(struct priv *priv)\n {\n \tenum hash_rxq_flow_type flow_type;\n \n-\tfor (flow_type = 0; flow_type != HASH_RXQ_FLOW_TYPE_MAC; ++flow_type)\n+\tfor (flow_type = HASH_RXQ_FLOW_TYPE_PROMISC;\n+\t\t\tflow_type != HASH_RXQ_FLOW_TYPE_MAC;\n+\t\t\t++flow_type)\n \t\tpriv_special_flow_disable(priv, flow_type);\n }\n \ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex cbb017b..f09ea8f 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -279,7 +279,7 @@ priv_flow_attr(struct priv *priv, struct ibv_exp_flow_attr *flow_attr,\n static enum hash_rxq_type\n hash_rxq_type_from_pos(const struct ind_table_init *table, unsigned int pos)\n {\n-\tenum hash_rxq_type type = 0;\n+\tenum hash_rxq_type type = HASH_RXQ_TCPV4;\n \n \tassert(pos < table->hash_types_n);\n \tdo {\n@@ -616,9 +616,11 @@ priv_allow_flow_type(struct priv *priv, enum hash_rxq_flow_type type)\n int\n priv_rehash_flows(struct priv *priv)\n {\n-\tunsigned int i;\n+\tenum hash_rxq_flow_type i;\n \n-\tfor (i = 0; (i != RTE_DIM((*priv->hash_rxqs)[0].special_flow)); ++i)\n+\tfor (i = HASH_RXQ_FLOW_TYPE_PROMISC;\n+\t\t\ti != RTE_DIM((*priv->hash_rxqs)[0].special_flow);\n+\t\t\t++i)\n \t\tif (!priv_allow_flow_type(priv, i)) {\n \t\t\tpriv_special_flow_disable(priv, i);\n \t\t} else {\n", "prefixes": [ "dpdk-dev", "v3" ] }