Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136416/?format=api
{ "id": 136416, "url": "http://patches.dpdk.org/api/patches/136416/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240206095607.339410-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240206095607.339410-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240206095607.339410-1-david.marchand@redhat.com", "date": "2024-02-06T09:56:07", "name": "net/iavf: remove error logs for vlan offloading", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e646f1ca356638df773deed51180042d171f8117", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240206095607.339410-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 31006, "url": "http://patches.dpdk.org/api/series/31006/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31006", "date": "2024-02-06T09:56:07", "name": "net/iavf: remove error logs for vlan offloading", "version": 1, "mbox": "http://patches.dpdk.org/series/31006/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136416/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8186043A99;\n\tTue, 6 Feb 2024 10:56:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 104AC402C8;\n\tTue, 6 Feb 2024 10:56:31 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 2CAA94021E\n for <dev@dpdk.org>; Tue, 6 Feb 2024 10:56:30 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-653-4BAbNus8MtiKWqG_NOVD0A-1; Tue, 06 Feb 2024 04:56:25 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 993871025620;\n Tue, 6 Feb 2024 09:56:24 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.193])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 08C8A111F9;\n Tue, 6 Feb 2024 09:56:21 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1707213389;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=vBsuaVh10xeiYssYjKmjJgLULY0OcWbM+kkVV63TBl4=;\n b=fhf+zwPyrdvn8XnhrP0hlWO/3kyi7YJKNFsAjd2c+MHFkFIN0fQuIGh0dQS6Xl+G+J8OGk\n CuXaUrywym0moiZceYKfNzhCJJEZE7zib17mi5B20cfhL/ln6e6oeYUqoZ46shLZJmkLs1\n NTDkPLy8nsSe+uhHC/ZFRbywExN0Urw=", "X-MC-Unique": "4BAbNus8MtiKWqG_NOVD0A-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, stable@dpdk.org,\n Jingjing Wu <jingjing.wu@intel.com>, Haiyue Wang <haiyue.wang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Qiming Yang <qiming.yang@intel.com>", "Subject": "[PATCH] net/iavf: remove error logs for vlan offloading", "Date": "Tue, 6 Feb 2024 10:56:07 +0100", "Message-ID": "<20240206095607.339410-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This was reported by RH QE.\n\nWhen a vlan is enforced on a VF via an administrative configuration on\nthe PF side, the net/iavf driver logs two error messages.\nThose error messages have no consequence on the rest of the port\ninitialisation and packet processing works fine.\n\n[root@toto ~] # ip l set enp94s0 vf 0 vlan 2\n[root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i\n...\nConfiguring Port 0 (socket 0)\niavf_dev_init_vlan(): Failed to update vlan offload\niavf_dev_configure(): configure VLAN failed: -95\niavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set\n\trx_pkt_burst as legacy for all queues\n\nThe first change is to remove the error log in iavf_dev_init_vlan().\nThis log is unneeded since all error path are covered by a dedicated log\nmessage already.\n\nThen, in iavf_dev_init_vlan(), requesting all possible VLAN offloading\nmust not trigger an ERROR level log message. This is simply confusing,\nas the application may not have requested such vlan offloading.\nThe reason why the driver requests all offloading is unclear so keep it\nas is. Instead, rephrase the log message and lower its level to INFO.\n\nFixes: 1c301e8c3cff (\"net/iavf: support new VLAN capabilities\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 1fb876e827..fc92cdf146 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -631,7 +631,7 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev)\n \t\t\t\t\tRTE_ETH_VLAN_FILTER_MASK |\n \t\t\t\t\tRTE_ETH_VLAN_EXTEND_MASK);\n \tif (err) {\n-\t\tPMD_DRV_LOG(ERR, \"Failed to update vlan offload\");\n+\t\tPMD_DRV_LOG(INFO, \"There is no support or the PF refused VLAN offloading\");\n \t\treturn err;\n \t}\n \n@@ -707,9 +707,7 @@ iavf_dev_configure(struct rte_eth_dev *dev)\n \t\tvf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT;\n \t}\n \n-\tret = iavf_dev_init_vlan(dev);\n-\tif (ret)\n-\t\tPMD_DRV_LOG(ERR, \"configure VLAN failed: %d\", ret);\n+\tiavf_dev_init_vlan(dev);\n \n \tif (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) {\n \t\tif (iavf_init_rss(ad) != 0) {\n", "prefixes": [] }