Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135695/?format=api
{ "id": 135695, "url": "http://patches.dpdk.org/api/patches/135695/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240103035605.720256-1-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240103035605.720256-1-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240103035605.720256-1-suanmingm@nvidia.com", "date": "2024-01-03T03:56:04", "name": "[1/2] app/test-crypto-perf: fix invalid memcmp results", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13f6e09fbd31d0d3c68c816bcd027a129adc6f94", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240103035605.720256-1-suanmingm@nvidia.com/mbox/", "series": [ { "id": 30706, "url": "http://patches.dpdk.org/api/series/30706/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30706", "date": "2024-01-03T03:56:04", "name": "[1/2] app/test-crypto-perf: fix invalid memcmp results", "version": 1, "mbox": "http://patches.dpdk.org/series/30706/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135695/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8C9043804;\n\tWed, 3 Jan 2024 04:56:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 933B0402BC;\n\tWed, 3 Jan 2024 04:56:42 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58])\n by mails.dpdk.org (Postfix) with ESMTP id 104D4402A3\n for <dev@dpdk.org>; Wed, 3 Jan 2024 04:56:41 +0100 (CET)", "from BLAPR03CA0039.namprd03.prod.outlook.com (2603:10b6:208:32d::14)\n by MW4PR12MB7237.namprd12.prod.outlook.com (2603:10b6:303:22a::6)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan\n 2024 03:56:38 +0000", "from MN1PEPF0000ECD9.namprd02.prod.outlook.com\n (2603:10b6:208:32d:cafe::24) by BLAPR03CA0039.outlook.office365.com\n (2603:10b6:208:32d::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.22 via Frontend\n Transport; Wed, 3 Jan 2024 03:56:38 +0000", "from mail.nvidia.com (216.228.117.161) by\n MN1PEPF0000ECD9.mail.protection.outlook.com (10.167.242.138) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 03:56:37 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 2 Jan 2024\n 19:56:22 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 2 Jan 2024\n 19:56:20 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=L4DtOlRP+CI8Penc9XClQTa5vYemfpUnhfZ/uwc09GUzo3gGsjQJm/9DrH5EHQjamQb0rXkRNdpkMkb889blvrekinjGYFSZZ+85PzhIADnFrq565bhngPjUjXCQHRPsx5hp2FszbQ5jnH4pEVocE3u5BwUbqa7StgbXdkY0xpxbp4UQtVlrRKP4j5ImS83g+u3yZcmhAJNJuPTeMrCCfFZQR+q9mKOBzAqtgbucm2fZ3Cy5FT0TVPd0kVa8Bkf+F3DKGalW0Ew5dD9EdcIt+rdot2T4AP7iz/asNMOT/jvxbMAtkVa316TNdCvEoWsiPWx/H/sEXa605VAlOC/WSQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=WOJaWQMIt4YqpP2RxRB0tw2kguMZarYUypphVAB7vUo=;\n b=QvNvk0oPH7sCLPuGWl3xXuucfVfhKvpbTAMjIGpQ52IpfdTuGDC3dwOQ41tZ2aHdZ99IxJN0aEVfWgZdwAcLOrFp0qCXcBFAQ9tAios+cPnnoT42bWJsBu6hAHu90HLlwwPa50nE2WpvLm8Rf6GnF/SaAwWH/3G32ZnyX7Ihmt//k6p/+sATzF07svv9U6wD7pRG5xTAQV+k07qn0hTBJtMtmhcipc1mdbURZqrLqUFlY2u7ZKCpFrfL3oEjolXxjcL9mURCAmB7+3yTrjDfWdrfTO8GDqS01pekP3ZExjxKQ4JU0b9knMyWqdCUVoGjLoB3VVyzMr82HWB2Os4wEA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WOJaWQMIt4YqpP2RxRB0tw2kguMZarYUypphVAB7vUo=;\n b=DqjnxqDX0Wnc9jvjxlXPw2BO1ZAo2/W6zbusiYLKM39UTAqh7nqdhORy84kUp9GKD/d/ij+YtYXdKvrA4OpXne7sED8V1/KItxnDP1m+4VJpgPzLKAtHVtPM42mtDDSVird9Ras81uQT89sCl8gHxC8SD3HDzDBMKOdp08zfBmg6ESshgFYorXTAPkhohx9rDCvNiEw4xr3TPY05awSNWHXGEvpM6db0aUO2FWXb3yFmayg2DIaanSo4vmmLwk2sY6mcOy4eUDeMtoMPL8RberuxtCSjpEG4+CJciGFgy/vhuROjvMhZKf+sByi2R1tmBuOJSA6vVMnkwD6QDc+uew==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "Ciara Power <ciara.power@intel.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 1/2] app/test-crypto-perf: fix invalid memcmp results", "Date": "Wed, 3 Jan 2024 11:56:04 +0800", "Message-ID": "<20240103035605.720256-1-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MN1PEPF0000ECD9:EE_|MW4PR12MB7237:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c9b3c592-84b5-4457-937d-08dc0c0ffc83", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n D6jFPh74mJ8LrIJHSr7OhAgnmJVspYES+qRYp5G/f8tm1K1ZH4OCFAvX9hBlEzK9yjBdsm53AJSlhmTe2hcrLwqUHQEclKPPFXlARMp9csHmVhQh2rXDyLNaNIP7KrmiR+NOSe5wUgRWTbpest/xKP409rhTxOFMqkXaarJ17PMFql79bl6I+YTMAeW0wsDqaB8RW/dL9/K2vxxx5f/gKCr2nJRdJwP597j0MhYfH6JOYdBxwnDLKSp3ys/3cuM3p55umZuBPYejihUzb29uQnIBng1imoqio6NSzDxzS7oDdv7aOo667jSDgbTb1Fp3uhwZrCwqD2knnb9lRJmyOoMhvBJTNp52GNVK2Vs0Ds2TYufXHmTVUbb7OeUs0uoPLned4pza0q5jIuZmH9bYDCCXbwvpVaDcyF3ft4iNH6W2l393hwCwctIxXrr04FsGDxSmRc0fKZM3oRUx/rFo2fIF9HsvjuxX41YnWkroeD3PgQTKViLPKO2cAxakn3BSQgpjREP/WHXMi+G/SkBxxZKSKDiQ1iN2kd5xvL4pEdmU/75hjxAK/yboJcElsQtxgjPCJI3swFg56gNLqGDP3Id2ihWP0BWVEemQ6njjZQsvz8/Vrc8XXIOS+7MKZNimzZzepN++aasbvpbFr0R7Xs8vpsJvXyJyuTFRwrGOksb5xAZfbeIQ7P/iJgDAVAM899bf4O0GHmFtB7J8XWets1goCxX34CEW9iyLlg6ES1DpKAS77X6/eSXh9KDzHEC1uvzqOD03clJkw4Rz8htDfQ==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(346002)(39860400002)(136003)(376002)(396003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(82310400011)(46966006)(40470700004)(36840700001)(426003)(1076003)(6286002)(26005)(336012)(2616005)(16526019)(36860700001)(356005)(7636003)(82740400003)(83380400001)(70586007)(70206006)(47076005)(36756003)(316002)(6916009)(478600001)(86362001)(55016003)(5660300002)(2906002)(8676002)(8936002)(4326008)(40460700003)(40480700001)(6666004)(7696005)(41300700001)(309714004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Jan 2024 03:56:37.8416 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c9b3c592-84b5-4457-937d-08dc0c0ffc83", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MN1PEPF0000ECD9.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW4PR12MB7237", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function memcmp() returns an integer less than, equal to,\nor greater than zero. In current code, if the first memcmp()\nreturns less than zero and the second memcmp() returns greater\nthan zero, the sum of results may still be 0 and indicates\nverify succussed.\n\nThis commit converts the return value to be zero or greater\nthan zero. That will make sure the sum of results be correct.\n\nFixes: df52cb3b6e13 (\"app/crypto-perf: move verify as single test type\")\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\n---\n app/test-crypto-perf/cperf_test_verify.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c\nindex a6c0ffe813..8aa714b969 100644\n--- a/app/test-crypto-perf/cperf_test_verify.c\n+++ b/app/test-crypto-perf/cperf_test_verify.c\n@@ -186,18 +186,18 @@ cperf_verify_op(struct rte_crypto_op *op,\n \n \tif (cipher == 1) {\n \t\tif (options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT)\n-\t\t\tres += memcmp(data + cipher_offset,\n+\t\t\tres += !!memcmp(data + cipher_offset,\n \t\t\t\t\tvector->ciphertext.data,\n \t\t\t\t\toptions->test_buffer_size);\n \t\telse\n-\t\t\tres += memcmp(data + cipher_offset,\n+\t\t\tres += !!memcmp(data + cipher_offset,\n \t\t\t\t\tvector->plaintext.data,\n \t\t\t\t\toptions->test_buffer_size);\n \t}\n \n \tif (auth == 1) {\n \t\tif (options->auth_op == RTE_CRYPTO_AUTH_OP_GENERATE)\n-\t\t\tres += memcmp(data + auth_offset,\n+\t\t\tres += !!memcmp(data + auth_offset,\n \t\t\t\t\tvector->digest.data,\n \t\t\t\t\toptions->digest_sz);\n \t}\n", "prefixes": [ "1/2" ] }