Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135453/?format=api
{ "id": 135453, "url": "http://patches.dpdk.org/api/patches/135453/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231221123545.510-22-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231221123545.510-22-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231221123545.510-22-anoobj@marvell.com", "date": "2023-12-21T12:35:42", "name": "[21/24] crypto/cnxk: use a single function for opad ipad", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f18568f9ae542ee36619efa84d60b061a5b94a1a", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231221123545.510-22-anoobj@marvell.com/mbox/", "series": [ { "id": 30646, "url": "http://patches.dpdk.org/api/series/30646/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30646", "date": "2023-12-21T12:35:21", "name": "Fixes and improvements in crypto cnxk", "version": 1, "mbox": "http://patches.dpdk.org/series/30646/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135453/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BA0043750;\n\tThu, 21 Dec 2023 13:38:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 453DF42EEA;\n\tThu, 21 Dec 2023 13:37:02 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 9C0F242EBC\n for <dev@dpdk.org>; Thu, 21 Dec 2023 13:36:55 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 3BLCVS39019305 for <dev@dpdk.org>; Thu, 21 Dec 2023 04:36:54 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3v4nekg0k0-4\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 21 Dec 2023 04:36:54 -0800 (PST)", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 21 Dec 2023 04:36:45 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 21 Dec 2023 04:36:45 -0800", "from BG-LT92004.corp.innovium.com (unknown [10.193.71.152])\n by maili.marvell.com (Postfix) with ESMTP id 0135D3F7073;\n Thu, 21 Dec 2023 04:36:42 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=XopYekZuDL9WlxgM+U/L8z58g2Uyw0c9/nU2RwVloRw=; b=VhK\n rA8q/WqwVMwAnWZntRiLQL8dXirWiL13cfYjJ6BkoV06Yf9SmZiBeG/wgiOZB939\n TesqpAS5ONRH+dJl9tB7sO6xKHFYvMeI09wF9OIQM/wUn+1kveFH9jHcGt6SJv6F\n ff4TDup18JCOD69PGMopuZ6yny7J/ia7+fff6ID7Ysav8dU1Sodt80sS7w5fRiDn\n KUS9HuU9d0RkMkntA9Aq5B4q7p3Rkymg6RAJ3o9u8uUXiI/ubN9wO4bCrXTvQOkz\n wijVrt3kuVVgPvasKynNejrFHW6O/swTzVhtOGVNbFGHl8JfqmQZ/IAFj4SH1laN\n 4lD0IBcYlM4cdWr0AbA==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Vidya Sagar Velumuri <vvelumuri@marvell.com>, Jerin Jacob\n <jerinj@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 21/24] crypto/cnxk: use a single function for opad ipad", "Date": "Thu, 21 Dec 2023 18:05:42 +0530", "Message-ID": "<20231221123545.510-22-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231221123545.510-1-anoobj@marvell.com>", "References": "<20231221123545.510-1-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "KfltbpXu-F_RZ9B7-7YcIsOwQmcs-f3B", "X-Proofpoint-ORIG-GUID": "KfltbpXu-F_RZ9B7-7YcIsOwQmcs-f3B", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n\nUse a single function for opad and ipad generation for IPsec, TLS and\nflexi crypto.\n\nSigned-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n---\n drivers/common/cnxk/cnxk_security.c | 65 ++++++-----------------------\n drivers/common/cnxk/cnxk_security.h | 5 ---\n drivers/common/cnxk/roc_se.c | 48 ++++++++++++++-------\n drivers/common/cnxk/roc_se.h | 9 ++++\n drivers/common/cnxk/version.map | 2 +-\n drivers/crypto/cnxk/cn10k_tls.c | 8 +++-\n 6 files changed, 61 insertions(+), 76 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers/common/cnxk/cnxk_security.c\nindex bdb04fe142..64c901a57a 100644\n--- a/drivers/common/cnxk/cnxk_security.c\n+++ b/drivers/common/cnxk/cnxk_security.c\n@@ -8,55 +8,9 @@\n \n #include \"roc_api.h\"\n \n-void\n-cnxk_sec_opad_ipad_gen(struct rte_crypto_sym_xform *auth_xform, uint8_t *hmac_opad_ipad,\n-\t\t bool is_tls)\n-{\n-\tconst uint8_t *key = auth_xform->auth.key.data;\n-\tuint32_t length = auth_xform->auth.key.length;\n-\tuint8_t opad[128] = {[0 ... 127] = 0x5c};\n-\tuint8_t ipad[128] = {[0 ... 127] = 0x36};\n-\tuint32_t i;\n-\n-\t/* HMAC OPAD and IPAD */\n-\tfor (i = 0; i < 128 && i < length; i++) {\n-\t\topad[i] = opad[i] ^ key[i];\n-\t\tipad[i] = ipad[i] ^ key[i];\n-\t}\n-\n-\t/* Precompute hash of HMAC OPAD and IPAD to avoid\n-\t * per packet computation\n-\t */\n-\tswitch (auth_xform->auth.algo) {\n-\tcase RTE_CRYPTO_AUTH_MD5_HMAC:\n-\t\troc_hash_md5_gen(opad, (uint32_t *)&hmac_opad_ipad[0]);\n-\t\troc_hash_md5_gen(ipad, (uint32_t *)&hmac_opad_ipad[is_tls ? 64 : 24]);\n-\t\tbreak;\n-\tcase RTE_CRYPTO_AUTH_SHA1_HMAC:\n-\t\troc_hash_sha1_gen(opad, (uint32_t *)&hmac_opad_ipad[0]);\n-\t\troc_hash_sha1_gen(ipad, (uint32_t *)&hmac_opad_ipad[is_tls ? 64 : 24]);\n-\t\tbreak;\n-\tcase RTE_CRYPTO_AUTH_SHA256_HMAC:\n-\t\troc_hash_sha256_gen(opad, (uint32_t *)&hmac_opad_ipad[0], 256);\n-\t\troc_hash_sha256_gen(ipad, (uint32_t *)&hmac_opad_ipad[64], 256);\n-\t\tbreak;\n-\tcase RTE_CRYPTO_AUTH_SHA384_HMAC:\n-\t\troc_hash_sha512_gen(opad, (uint64_t *)&hmac_opad_ipad[0], 384);\n-\t\troc_hash_sha512_gen(ipad, (uint64_t *)&hmac_opad_ipad[64], 384);\n-\t\tbreak;\n-\tcase RTE_CRYPTO_AUTH_SHA512_HMAC:\n-\t\troc_hash_sha512_gen(opad, (uint64_t *)&hmac_opad_ipad[0], 512);\n-\t\troc_hash_sha512_gen(ipad, (uint64_t *)&hmac_opad_ipad[64], 512);\n-\t\tbreak;\n-\tdefault:\n-\t\tbreak;\n-\t}\n-}\n-\n static int\n-ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,\n-\t\t\t uint8_t *cipher_key, uint8_t *salt_key,\n-\t\t\t uint8_t *hmac_opad_ipad,\n+ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2, uint8_t *cipher_key,\n+\t\t\t uint8_t *salt_key, uint8_t *hmac_opad_ipad,\n \t\t\t struct rte_security_ipsec_xform *ipsec_xfrm,\n \t\t\t struct rte_crypto_sym_xform *crypto_xfrm)\n {\n@@ -192,7 +146,9 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,\n \t\t\tconst uint8_t *auth_key = auth_xfrm->auth.key.data;\n \t\t\troc_aes_xcbc_key_derive(auth_key, hmac_opad_ipad);\n \t\t} else {\n-\t\t\tcnxk_sec_opad_ipad_gen(auth_xfrm, hmac_opad_ipad, false);\n+\t\t\troc_se_hmac_opad_ipad_gen(w2->s.auth_type, auth_xfrm->auth.key.data,\n+\t\t\t\t\t\t auth_xfrm->auth.key.length, &hmac_opad_ipad[0],\n+\t\t\t\t\t\t ROC_SE_IPSEC);\n \t\t}\n \n \t\ttmp_key = (uint64_t *)hmac_opad_ipad;\n@@ -741,7 +697,8 @@ onf_ipsec_sa_common_param_fill(struct roc_ie_onf_sa_ctl *ctl, uint8_t *salt,\n \t\tkey = cipher_xfrm->cipher.key.data;\n \t\tlength = cipher_xfrm->cipher.key.length;\n \n-\t\tcnxk_sec_opad_ipad_gen(auth_xfrm, hmac_opad_ipad, false);\n+\t\troc_se_hmac_opad_ipad_gen(ctl->auth_type, auth_xfrm->auth.key.data,\n+\t\t\t\t\t auth_xfrm->auth.key.length, hmac_opad_ipad, ROC_SE_IPSEC);\n \t}\n \n \tswitch (length) {\n@@ -1374,7 +1331,9 @@ cnxk_on_ipsec_outb_sa_create(struct rte_security_ipsec_xform *ipsec,\n \n \t\t\troc_aes_xcbc_key_derive(auth_key, hmac_opad_ipad);\n \t\t} else if (auth_xform->auth.algo != RTE_CRYPTO_AUTH_NULL) {\n-\t\t\tcnxk_sec_opad_ipad_gen(auth_xform, hmac_opad_ipad, false);\n+\t\t\troc_se_hmac_opad_ipad_gen(\n+\t\t\t\tout_sa->common_sa.ctl.auth_type, auth_xform->auth.key.data,\n+\t\t\t\tauth_xform->auth.key.length, &hmac_opad_ipad[0], ROC_SE_IPSEC);\n \t\t}\n \t}\n \n@@ -1441,7 +1400,9 @@ cnxk_on_ipsec_inb_sa_create(struct rte_security_ipsec_xform *ipsec,\n \n \t\t\troc_aes_xcbc_key_derive(auth_key, hmac_opad_ipad);\n \t\t} else if (auth_xform->auth.algo != RTE_CRYPTO_AUTH_NULL) {\n-\t\t\tcnxk_sec_opad_ipad_gen(auth_xform, hmac_opad_ipad, false);\n+\t\t\troc_se_hmac_opad_ipad_gen(\n+\t\t\t\tin_sa->common_sa.ctl.auth_type, auth_xform->auth.key.data,\n+\t\t\t\tauth_xform->auth.key.length, &hmac_opad_ipad[0], ROC_SE_IPSEC);\n \t\t}\n \t}\n \ndiff --git a/drivers/common/cnxk/cnxk_security.h b/drivers/common/cnxk/cnxk_security.h\nindex 86ec657cb0..b323b8b757 100644\n--- a/drivers/common/cnxk/cnxk_security.h\n+++ b/drivers/common/cnxk/cnxk_security.h\n@@ -68,9 +68,4 @@ int __roc_api cnxk_on_ipsec_inb_sa_create(struct rte_security_ipsec_xform *ipsec\n int __roc_api cnxk_on_ipsec_outb_sa_create(struct rte_security_ipsec_xform *ipsec,\n \t\t\t\t\t struct rte_crypto_sym_xform *crypto_xform,\n \t\t\t\t\t struct roc_ie_on_outb_sa *out_sa);\n-\n-__rte_internal\n-void cnxk_sec_opad_ipad_gen(struct rte_crypto_sym_xform *auth_xform, uint8_t *hmac_opad_ipad,\n-\t\t\t bool is_tls);\n-\n #endif /* _CNXK_SECURITY_H__ */\ndiff --git a/drivers/common/cnxk/roc_se.c b/drivers/common/cnxk/roc_se.c\nindex 4e00268149..5a3ed0b647 100644\n--- a/drivers/common/cnxk/roc_se.c\n+++ b/drivers/common/cnxk/roc_se.c\n@@ -157,14 +157,29 @@ cpt_ciph_aes_key_type_set(struct roc_se_context *fctx, uint16_t key_len)\n \tfctx->enc.aes_key = aes_key_type;\n }\n \n-static void\n-cpt_hmac_opad_ipad_gen(roc_se_auth_type auth_type, const uint8_t *key, uint16_t length,\n-\t\t struct roc_se_hmac_context *hmac)\n+void\n+roc_se_hmac_opad_ipad_gen(roc_se_auth_type auth_type, const uint8_t *key, uint16_t length,\n+\t\t\t uint8_t *opad_ipad, roc_se_op_type op_type)\n {\n \tuint8_t opad[128] = {[0 ... 127] = 0x5c};\n \tuint8_t ipad[128] = {[0 ... 127] = 0x36};\n+\tuint8_t ipad_offset, opad_offset;\n \tuint32_t i;\n \n+\tif (op_type == ROC_SE_IPSEC) {\n+\t\tif ((auth_type == ROC_SE_MD5_TYPE) || (auth_type == ROC_SE_SHA1_TYPE))\n+\t\t\tipad_offset = 24;\n+\t\telse\n+\t\t\tipad_offset = 64;\n+\t\topad_offset = 0;\n+\t} else if (op_type == ROC_SE_TLS) {\n+\t\tipad_offset = 64;\n+\t\topad_offset = 0;\n+\t} else {\n+\t\tipad_offset = 0;\n+\t\topad_offset = 64;\n+\t}\n+\n \t/* HMAC OPAD and IPAD */\n \tfor (i = 0; i < 128 && i < length; i++) {\n \t\topad[i] = opad[i] ^ key[i];\n@@ -176,28 +191,28 @@ cpt_hmac_opad_ipad_gen(roc_se_auth_type auth_type, const uint8_t *key, uint16_t\n \t */\n \tswitch (auth_type) {\n \tcase ROC_SE_MD5_TYPE:\n-\t\troc_hash_md5_gen(opad, (uint32_t *)hmac->opad);\n-\t\troc_hash_md5_gen(ipad, (uint32_t *)hmac->ipad);\n+\t\troc_hash_md5_gen(opad, (uint32_t *)&opad_ipad[opad_offset]);\n+\t\troc_hash_md5_gen(ipad, (uint32_t *)&opad_ipad[ipad_offset]);\n \t\tbreak;\n \tcase ROC_SE_SHA1_TYPE:\n-\t\troc_hash_sha1_gen(opad, (uint32_t *)hmac->opad);\n-\t\troc_hash_sha1_gen(ipad, (uint32_t *)hmac->ipad);\n+\t\troc_hash_sha1_gen(opad, (uint32_t *)&opad_ipad[opad_offset]);\n+\t\troc_hash_sha1_gen(ipad, (uint32_t *)&opad_ipad[ipad_offset]);\n \t\tbreak;\n \tcase ROC_SE_SHA2_SHA224:\n-\t\troc_hash_sha256_gen(opad, (uint32_t *)hmac->opad, 224);\n-\t\troc_hash_sha256_gen(ipad, (uint32_t *)hmac->ipad, 224);\n+\t\troc_hash_sha256_gen(opad, (uint32_t *)&opad_ipad[opad_offset], 224);\n+\t\troc_hash_sha256_gen(ipad, (uint32_t *)&opad_ipad[ipad_offset], 224);\n \t\tbreak;\n \tcase ROC_SE_SHA2_SHA256:\n-\t\troc_hash_sha256_gen(opad, (uint32_t *)hmac->opad, 256);\n-\t\troc_hash_sha256_gen(ipad, (uint32_t *)hmac->ipad, 256);\n+\t\troc_hash_sha256_gen(opad, (uint32_t *)&opad_ipad[opad_offset], 256);\n+\t\troc_hash_sha256_gen(ipad, (uint32_t *)&opad_ipad[ipad_offset], 256);\n \t\tbreak;\n \tcase ROC_SE_SHA2_SHA384:\n-\t\troc_hash_sha512_gen(opad, (uint64_t *)hmac->opad, 384);\n-\t\troc_hash_sha512_gen(ipad, (uint64_t *)hmac->ipad, 384);\n+\t\troc_hash_sha512_gen(opad, (uint64_t *)&opad_ipad[opad_offset], 384);\n+\t\troc_hash_sha512_gen(ipad, (uint64_t *)&opad_ipad[ipad_offset], 384);\n \t\tbreak;\n \tcase ROC_SE_SHA2_SHA512:\n-\t\troc_hash_sha512_gen(opad, (uint64_t *)hmac->opad, 512);\n-\t\troc_hash_sha512_gen(ipad, (uint64_t *)hmac->ipad, 512);\n+\t\troc_hash_sha512_gen(opad, (uint64_t *)&opad_ipad[opad_offset], 512);\n+\t\troc_hash_sha512_gen(ipad, (uint64_t *)&opad_ipad[ipad_offset], 512);\n \t\tbreak;\n \tdefault:\n \t\tbreak;\n@@ -401,7 +416,8 @@ roc_se_auth_key_set(struct roc_se_ctx *se_ctx, roc_se_auth_type type, const uint\n \t\tif (chained_op) {\n \t\t\tmemset(fctx->hmac.ipad, 0, sizeof(fctx->hmac.ipad));\n \t\t\tmemset(fctx->hmac.opad, 0, sizeof(fctx->hmac.opad));\n-\t\t\tcpt_hmac_opad_ipad_gen(type, key, key_len, &fctx->hmac);\n+\t\t\troc_se_hmac_opad_ipad_gen(type, key, key_len, &fctx->hmac.ipad[0],\n+\t\t\t\t\t\t ROC_SE_FC);\n \t\t\tfctx->enc.auth_input_type = 0;\n \t\t} else {\n \t\t\tse_ctx->hmac = 1;\ndiff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h\nindex d62c40b310..ddcf6bdb44 100644\n--- a/drivers/common/cnxk/roc_se.h\n+++ b/drivers/common/cnxk/roc_se.h\n@@ -191,6 +191,12 @@ typedef enum {\n \tROC_SE_PDCP_MAC_LEN_128_BIT = 0x3\n } roc_se_pdcp_mac_len_type;\n \n+typedef enum {\n+\tROC_SE_IPSEC = 0x0,\n+\tROC_SE_TLS = 0x1,\n+\tROC_SE_FC = 0x2,\n+} roc_se_op_type;\n+\n struct roc_se_enc_context {\n \tuint64_t iv_source : 1;\n \tuint64_t aes_key : 2;\n@@ -401,4 +407,7 @@ int __roc_api roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, roc_se_cipher_type\n void __roc_api roc_se_ctx_swap(struct roc_se_ctx *se_ctx);\n void __roc_api roc_se_ctx_init(struct roc_se_ctx *se_ctx);\n \n+void __roc_api roc_se_hmac_opad_ipad_gen(roc_se_auth_type auth_type, const uint8_t *key,\n+\t\t\t\t\t uint16_t length, uint8_t *opad_ipad,\n+\t\t\t\t\t roc_se_op_type op_type);\n #endif /* __ROC_SE_H__ */\ndiff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map\nindex 15fd5710d2..b8b0478848 100644\n--- a/drivers/common/cnxk/version.map\n+++ b/drivers/common/cnxk/version.map\n@@ -1,7 +1,6 @@\n INTERNAL {\n \tglobal:\n \n-\tcnxk_sec_opad_ipad_gen;\n \tcnxk_ipsec_icvlen_get;\n \tcnxk_ipsec_ivlen_get;\n \tcnxk_ipsec_outb_rlens_get;\n@@ -472,6 +471,7 @@ INTERNAL {\n \troc_plt_init;\n \troc_plt_init_cb_register;\n \troc_plt_lmt_validate;\n+\troc_se_hmac_opad_ipad_gen;\n \troc_sso_dev_fini;\n \troc_sso_dev_init;\n \troc_sso_dump;\ndiff --git a/drivers/crypto/cnxk/cn10k_tls.c b/drivers/crypto/cnxk/cn10k_tls.c\nindex fa3ce3e758..5baea181e8 100644\n--- a/drivers/crypto/cnxk/cn10k_tls.c\n+++ b/drivers/crypto/cnxk/cn10k_tls.c\n@@ -376,7 +376,9 @@ tls_read_sa_fill(struct roc_ie_ot_tls_read_sa *read_sa,\n \telse\n \t\treturn -EINVAL;\n \n-\tcnxk_sec_opad_ipad_gen(auth_xfrm, read_sa->opad_ipad, true);\n+\troc_se_hmac_opad_ipad_gen(read_sa->w2.s.mac_select, auth_xfrm->auth.key.data,\n+\t\t\t\t auth_xfrm->auth.key.length, read_sa->opad_ipad, ROC_SE_TLS);\n+\n \ttmp = (uint64_t *)read_sa->opad_ipad;\n \tfor (i = 0; i < (int)(ROC_CTX_MAX_OPAD_IPAD_LEN / sizeof(uint64_t)); i++)\n \t\ttmp[i] = rte_be_to_cpu_64(tmp[i]);\n@@ -503,7 +505,9 @@ tls_write_sa_fill(struct roc_ie_ot_tls_write_sa *write_sa,\n \t\telse\n \t\t\treturn -EINVAL;\n \n-\t\tcnxk_sec_opad_ipad_gen(auth_xfrm, write_sa->opad_ipad, true);\n+\t\troc_se_hmac_opad_ipad_gen(write_sa->w2.s.mac_select, auth_xfrm->auth.key.data,\n+\t\t\t\t\t auth_xfrm->auth.key.length, write_sa->opad_ipad,\n+\t\t\t\t\t ROC_SE_TLS);\n \t}\n \n \ttmp_key = (uint64_t *)write_sa->opad_ipad;\n", "prefixes": [ "21/24" ] }