Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135267/?format=api
{ "id": 135267, "url": "http://patches.dpdk.org/api/patches/135267/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231218143805.1500121-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231218143805.1500121-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231218143805.1500121-5-david.marchand@redhat.com", "date": "2023-12-18T14:37:53", "name": "[v4,04/14] lib: add newline in logs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "53ce98058d0b2a5a6676cbd52867f08bc0eb00bb", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231218143805.1500121-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 30589, "url": "http://patches.dpdk.org/api/series/30589/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30589", "date": "2023-12-18T14:37:50", "name": "Detect superfluous newline in logs", "version": 4, "mbox": "http://patches.dpdk.org/series/30589/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135267/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135267/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 28E5C43735;\n\tMon, 18 Dec 2023 15:38:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 761B9427DF;\n\tMon, 18 Dec 2023 15:38:47 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 81625427DC\n for <dev@dpdk.org>; Mon, 18 Dec 2023 15:38:43 +0100 (CET)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-cLhJumP0MMWYMwwkwNqFtw-1; Mon,\n 18 Dec 2023 09:38:36 -0500", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7AA8E3C0E649;\n Mon, 18 Dec 2023 14:38:26 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.218])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 094062166B34;\n Mon, 18 Dec 2023 14:38:23 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1702910323;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=vQysxv3qLbq7WNMbIOYnzA0SY6O58s0UPXLB4pPkIjo=;\n b=HFYf+wo7t8GLIM5i0695V3036X8NmAFhE7c8Gkn5pqRiS/MLUiyjJk0EL+T8SKkWGmATXF\n vqxq3ynz44Smv19/RhTjOyMPUFR1H4bsI/eWG6Rhl7EZ63CFjjVNTblmKUexDRZh57+s56\n LFu5iWEwDa+yGPb/1qsEos7GAY6pz7U=", "X-MC-Unique": "cLhJumP0MMWYMwwkwNqFtw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com,\n stephen@networkplumber.org, mb@smartsharesystems.com, stable@dpdk.org,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Harman Kalra <hkalra@marvell.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n David Hunt <david.hunt@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "Subject": "[PATCH v4 04/14] lib: add newline in logs", "Date": "Mon, 18 Dec 2023 15:37:53 +0100", "Message-ID": "<20231218143805.1500121-5-david.marchand@redhat.com>", "In-Reply-To": "<20231218143805.1500121-1-david.marchand@redhat.com>", "References": "<20231117131824.1977792-1-david.marchand@redhat.com>\n <20231218143805.1500121-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.6", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix places leading to a log message not terminated with a newline.\n\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n lib/eal/common/eal_common_options.c | 2 +-\n lib/eal/linux/eal_hugepage_info.c | 2 +-\n lib/eal/linux/eal_interrupts.c | 2 +-\n lib/ethdev/ethdev_pci.h | 2 +-\n lib/ethdev/rte_ethdev.c | 40 ++++++++++++++---------------\n lib/lpm/rte_lpm6.c | 6 ++---\n lib/power/guest_channel.c | 2 +-\n lib/power/rte_power_pmd_mgmt.c | 6 ++---\n 8 files changed, 31 insertions(+), 31 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c\nindex a6d21f1cba..e9ba01fb89 100644\n--- a/lib/eal/common/eal_common_options.c\n+++ b/lib/eal/common/eal_common_options.c\n@@ -2141,7 +2141,7 @@ rte_vect_set_max_simd_bitwidth(uint16_t bitwidth)\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\n \tif (internal_conf->max_simd_bitwidth.forced) {\n-\t\tRTE_LOG(NOTICE, EAL, \"Cannot set max SIMD bitwidth - user runtime override enabled\");\n+\t\tRTE_LOG(NOTICE, EAL, \"Cannot set max SIMD bitwidth - user runtime override enabled\\n\");\n \t\treturn -EPERM;\n \t}\n \ndiff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c\nindex 581d9dfc91..36a495fb1f 100644\n--- a/lib/eal/linux/eal_hugepage_info.c\n+++ b/lib/eal/linux/eal_hugepage_info.c\n@@ -403,7 +403,7 @@ inspect_hugedir_cb(const struct walk_hugedir_data *whd)\n \tstruct stat st;\n \n \tif (fstat(whd->file_fd, &st) < 0)\n-\t\tRTE_LOG(DEBUG, EAL, \"%s(): stat(\\\"%s\\\") failed: %s\",\n+\t\tRTE_LOG(DEBUG, EAL, \"%s(): stat(\\\"%s\\\") failed: %s\\n\",\n \t\t\t\t__func__, whd->file_name, strerror(errno));\n \telse\n \t\t(*total_size) += st.st_size;\ndiff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c\nindex d4919dff45..eabac24992 100644\n--- a/lib/eal/linux/eal_interrupts.c\n+++ b/lib/eal/linux/eal_interrupts.c\n@@ -1542,7 +1542,7 @@ rte_intr_efd_enable(struct rte_intr_handle *intr_handle, uint32_t nb_efd)\n \t\t/* only check, initialization would be done in vdev driver.*/\n \t\tif ((uint64_t)rte_intr_efd_counter_size_get(intr_handle) >\n \t\t sizeof(union rte_intr_read_buffer)) {\n-\t\t\tRTE_LOG(ERR, EAL, \"the efd_counter_size is oversized\");\n+\t\t\tRTE_LOG(ERR, EAL, \"the efd_counter_size is oversized\\n\");\n \t\t\treturn -EINVAL;\n \t\t}\n \t} else {\ndiff --git a/lib/ethdev/ethdev_pci.h b/lib/ethdev/ethdev_pci.h\nindex 320e3e0093..ddb559aa95 100644\n--- a/lib/ethdev/ethdev_pci.h\n+++ b/lib/ethdev/ethdev_pci.h\n@@ -31,7 +31,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev,\n \tstruct rte_pci_device *pci_dev)\n {\n \tif ((eth_dev == NULL) || (pci_dev == NULL)) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"NULL pointer eth_dev=%p pci_dev=%p\",\n+\t\tRTE_ETHDEV_LOG(ERR, \"NULL pointer eth_dev=%p pci_dev=%p\\n\",\n \t\t\t(void *)eth_dev, (void *)pci_dev);\n \t\treturn;\n \t}\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 3858983fcc..b9d99ece15 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -724,7 +724,7 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id)\n \tuint16_t pid;\n \n \tif (name == NULL) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"Cannot get port ID from NULL name\");\n+\t\tRTE_ETHDEV_LOG(ERR, \"Cannot get port ID from NULL name\\n\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -2394,41 +2394,41 @@ rte_eth_rx_hairpin_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\tnb_rx_desc = cap.max_nb_desc;\n \tif (nb_rx_desc > cap.max_nb_desc) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Invalid value for nb_rx_desc(=%hu), should be: <= %hu\",\n+\t\t\t\"Invalid value for nb_rx_desc(=%hu), should be: <= %hu\\n\",\n \t\t\tnb_rx_desc, cap.max_nb_desc);\n \t\treturn -EINVAL;\n \t}\n \tif (conf->peer_count > cap.max_rx_2_tx) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Invalid value for number of peers for Rx queue(=%u), should be: <= %hu\",\n+\t\t\t\"Invalid value for number of peers for Rx queue(=%u), should be: <= %hu\\n\",\n \t\t\tconf->peer_count, cap.max_rx_2_tx);\n \t\treturn -EINVAL;\n \t}\n \tif (conf->use_locked_device_memory && !cap.rx_cap.locked_device_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to use locked device memory for Rx queue, which is not supported\");\n+\t\t\t\"Attempt to use locked device memory for Rx queue, which is not supported\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->use_rte_memory && !cap.rx_cap.rte_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to use DPDK memory for Rx queue, which is not supported\");\n+\t\t\t\"Attempt to use DPDK memory for Rx queue, which is not supported\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->use_locked_device_memory && conf->use_rte_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to use mutually exclusive memory settings for Rx queue\");\n+\t\t\t\"Attempt to use mutually exclusive memory settings for Rx queue\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->force_memory &&\n \t !conf->use_locked_device_memory &&\n \t !conf->use_rte_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to force Rx queue memory settings, but none is set\");\n+\t\t\t\"Attempt to force Rx queue memory settings, but none is set\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->peer_count == 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Invalid value for number of peers for Rx queue(=%u), should be: > 0\",\n+\t\t\t\"Invalid value for number of peers for Rx queue(=%u), should be: > 0\\n\",\n \t\t\tconf->peer_count);\n \t\treturn -EINVAL;\n \t}\n@@ -2438,7 +2438,7 @@ rte_eth_rx_hairpin_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \t\t\tcount++;\n \t}\n \tif (count > cap.max_nb_queues) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"To many Rx hairpin queues max is %d\",\n+\t\tRTE_ETHDEV_LOG(ERR, \"To many Rx hairpin queues max is %d\\n\",\n \t\tcap.max_nb_queues);\n \t\treturn -EINVAL;\n \t}\n@@ -2597,41 +2597,41 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \t\tnb_tx_desc = cap.max_nb_desc;\n \tif (nb_tx_desc > cap.max_nb_desc) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Invalid value for nb_tx_desc(=%hu), should be: <= %hu\",\n+\t\t\t\"Invalid value for nb_tx_desc(=%hu), should be: <= %hu\\n\",\n \t\t\tnb_tx_desc, cap.max_nb_desc);\n \t\treturn -EINVAL;\n \t}\n \tif (conf->peer_count > cap.max_tx_2_rx) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Invalid value for number of peers for Tx queue(=%u), should be: <= %hu\",\n+\t\t\t\"Invalid value for number of peers for Tx queue(=%u), should be: <= %hu\\n\",\n \t\t\tconf->peer_count, cap.max_tx_2_rx);\n \t\treturn -EINVAL;\n \t}\n \tif (conf->use_locked_device_memory && !cap.tx_cap.locked_device_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to use locked device memory for Tx queue, which is not supported\");\n+\t\t\t\"Attempt to use locked device memory for Tx queue, which is not supported\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->use_rte_memory && !cap.tx_cap.rte_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to use DPDK memory for Tx queue, which is not supported\");\n+\t\t\t\"Attempt to use DPDK memory for Tx queue, which is not supported\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->use_locked_device_memory && conf->use_rte_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to use mutually exclusive memory settings for Tx queue\");\n+\t\t\t\"Attempt to use mutually exclusive memory settings for Tx queue\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->force_memory &&\n \t !conf->use_locked_device_memory &&\n \t !conf->use_rte_memory) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Attempt to force Tx queue memory settings, but none is set\");\n+\t\t\t\"Attempt to force Tx queue memory settings, but none is set\\n\");\n \t\treturn -EINVAL;\n \t}\n \tif (conf->peer_count == 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Invalid value for number of peers for Tx queue(=%u), should be: > 0\",\n+\t\t\t\"Invalid value for number of peers for Tx queue(=%u), should be: > 0\\n\",\n \t\t\tconf->peer_count);\n \t\treturn -EINVAL;\n \t}\n@@ -2641,7 +2641,7 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \t\t\tcount++;\n \t}\n \tif (count > cap.max_nb_queues) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"To many Tx hairpin queues max is %d\",\n+\t\tRTE_ETHDEV_LOG(ERR, \"To many Tx hairpin queues max is %d\\n\",\n \t\tcap.max_nb_queues);\n \t\treturn -EINVAL;\n \t}\n@@ -6716,7 +6716,7 @@ rte_eth_ip_reassembly_capability_get(uint16_t port_id,\n \t}\n \n \tif (reassembly_capa == NULL) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"Cannot get reassembly capability to NULL\");\n+\t\tRTE_ETHDEV_LOG(ERR, \"Cannot get reassembly capability to NULL\\n\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -6752,7 +6752,7 @@ rte_eth_ip_reassembly_conf_get(uint16_t port_id,\n \t}\n \n \tif (conf == NULL) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"Cannot get reassembly info to NULL\");\n+\t\tRTE_ETHDEV_LOG(ERR, \"Cannot get reassembly info to NULL\\n\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -6780,7 +6780,7 @@ rte_eth_ip_reassembly_conf_set(uint16_t port_id,\n \tif (dev->data->dev_configured == 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n \t\t\t\"Device with port_id=%u is not configured.\\n\"\n-\t\t\t\"Cannot set IP reassembly configuration\",\n+\t\t\t\"Cannot set IP reassembly configuration\\n\",\n \t\t\tport_id);\n \t\treturn -EINVAL;\n \t}\ndiff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c\nindex 873cc8bc26..24ce7dd022 100644\n--- a/lib/lpm/rte_lpm6.c\n+++ b/lib/lpm/rte_lpm6.c\n@@ -280,7 +280,7 @@ rte_lpm6_create(const char *name, int socket_id,\n \n \trules_tbl = rte_hash_create(&rule_hash_tbl_params);\n \tif (rules_tbl == NULL) {\n-\t\tRTE_LOG(ERR, LPM, \"LPM rules hash table allocation failed: %s (%d)\",\n+\t\tRTE_LOG(ERR, LPM, \"LPM rules hash table allocation failed: %s (%d)\\n\",\n \t\t\t\t rte_strerror(rte_errno), rte_errno);\n \t\tgoto fail_wo_unlock;\n \t}\n@@ -290,7 +290,7 @@ rte_lpm6_create(const char *name, int socket_id,\n \t\t\tsizeof(uint32_t) * config->number_tbl8s,\n \t\t\tRTE_CACHE_LINE_SIZE);\n \tif (tbl8_pool == NULL) {\n-\t\tRTE_LOG(ERR, LPM, \"LPM tbl8 pool allocation failed: %s (%d)\",\n+\t\tRTE_LOG(ERR, LPM, \"LPM tbl8 pool allocation failed: %s (%d)\\n\",\n \t\t\t\t rte_strerror(rte_errno), rte_errno);\n \t\trte_errno = ENOMEM;\n \t\tgoto fail_wo_unlock;\n@@ -301,7 +301,7 @@ rte_lpm6_create(const char *name, int socket_id,\n \t\t\tsizeof(struct rte_lpm_tbl8_hdr) * config->number_tbl8s,\n \t\t\tRTE_CACHE_LINE_SIZE);\n \tif (tbl8_hdrs == NULL) {\n-\t\tRTE_LOG(ERR, LPM, \"LPM tbl8 headers allocation failed: %s (%d)\",\n+\t\tRTE_LOG(ERR, LPM, \"LPM tbl8 headers allocation failed: %s (%d)\\n\",\n \t\t\t\t rte_strerror(rte_errno), rte_errno);\n \t\trte_errno = ENOMEM;\n \t\tgoto fail_wo_unlock;\ndiff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c\nindex cc05347425..a6f2097d5b 100644\n--- a/lib/power/guest_channel.c\n+++ b/lib/power/guest_channel.c\n@@ -90,7 +90,7 @@ guest_channel_host_connect(const char *path, unsigned int lcore_id)\n \tflags |= O_NONBLOCK;\n \tif (fcntl(fd, F_SETFL, flags) < 0) {\n \t\tRTE_LOG(ERR, GUEST_CHANNEL, \"Failed on setting non-blocking mode for \"\n-\t\t\t\t\"file %s\", fd_path);\n+\t\t\t\t\"file %s\\n\", fd_path);\n \t\tgoto error;\n \t}\n \t/* QEMU needs a delay after connection */\ndiff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c\nindex 38f8384085..6f18ed0adf 100644\n--- a/lib/power/rte_power_pmd_mgmt.c\n+++ b/lib/power/rte_power_pmd_mgmt.c\n@@ -686,7 +686,7 @@ int\n rte_power_pmd_mgmt_set_pause_duration(unsigned int duration)\n {\n \tif (duration == 0) {\n-\t\tRTE_LOG(ERR, POWER, \"Pause duration must be greater than 0, value unchanged\");\n+\t\tRTE_LOG(ERR, POWER, \"Pause duration must be greater than 0, value unchanged\\n\");\n \t\treturn -EINVAL;\n \t}\n \tpause_duration = duration;\n@@ -709,7 +709,7 @@ rte_power_pmd_mgmt_set_scaling_freq_min(unsigned int lcore, unsigned int min)\n \t}\n \n \tif (min > scale_freq_max[lcore]) {\n-\t\tRTE_LOG(ERR, POWER, \"Invalid min frequency: Cannot be greater than max frequency\");\n+\t\tRTE_LOG(ERR, POWER, \"Invalid min frequency: Cannot be greater than max frequency\\n\");\n \t\treturn -EINVAL;\n \t}\n \tscale_freq_min[lcore] = min;\n@@ -729,7 +729,7 @@ rte_power_pmd_mgmt_set_scaling_freq_max(unsigned int lcore, unsigned int max)\n \tif (max == 0)\n \t\tmax = UINT32_MAX;\n \tif (max < scale_freq_min[lcore]) {\n-\t\tRTE_LOG(ERR, POWER, \"Invalid max frequency: Cannot be less than min frequency\");\n+\t\tRTE_LOG(ERR, POWER, \"Invalid max frequency: Cannot be less than min frequency\\n\");\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "v4", "04/14" ] }