Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135185/?format=api
{ "id": 135185, "url": "http://patches.dpdk.org/api/patches/135185/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231214065857.2142565-3-zhichaox.zeng@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231214065857.2142565-3-zhichaox.zeng@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231214065857.2142565-3-zhichaox.zeng@intel.com", "date": "2023-12-14T06:58:56", "name": "[v2,2/3] net/iavf: support Tx LLDP on AVX512", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "208d209b79871601085044905f2aae740152ed7f", "submitter": { "id": 2644, "url": "http://patches.dpdk.org/api/people/2644/?format=api", "name": "Zhichao Zeng", "email": "zhichaox.zeng@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231214065857.2142565-3-zhichaox.zeng@intel.com/mbox/", "series": [ { "id": 30547, "url": "http://patches.dpdk.org/api/series/30547/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30547", "date": "2023-12-14T06:58:54", "name": "net/iavf: support Tx LLDP on scalar and AVX512", "version": 2, "mbox": "http://patches.dpdk.org/series/30547/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135185/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0C44436E9;\n\tThu, 14 Dec 2023 07:49:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DE53742FCD;\n\tThu, 14 Dec 2023 07:49:48 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.10])\n by mails.dpdk.org (Postfix) with ESMTP id A8F6242FC7\n for <dev@dpdk.org>; Thu, 14 Dec 2023 07:49:47 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Dec 2023 22:49:47 -0800", "from unknown (HELO zhichao-dpdk..) ([10.239.252.103])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Dec 2023 22:49:43 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1702536588; x=1734072588;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=PayMww13vDvNi9bb4nWgNitpz+PJ+v4H6/fs66VXX3g=;\n b=bLrWBnSIBN5w0LZSgnjsa0mdepVs8AGaCDMGllTwtRpi+FC2rTqxZb86\n ZMUG/tQZdNQHDHcRYEfOfskrLzYL3zaJJRiwGoGylmQf6gCL2cQrahu9C\n GDt43nGuFZY+FxmwOdegRyvVxgnZryghL+gG/f+9AnEy61f7LyX6MdVd/\n XxECftBxu5xWJ+jowJepU9WsQWtqreVhvI+Af7XBOXGYsefx1PF2QBNmz\n j+uBBVbA2SJ4WysA1f2PWYeylNwqgwuBsB497Ln3rEe1g/R0B5JcArUIE\n xAJ4MJTT3FPZMRwGCwqEQv2QZbXPc+UstkTsQ+oPxUhQpETiDmx53dKgh w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10923\"; a=\"8440328\"", "E=Sophos;i=\"6.04,274,1695711600\";\n d=\"scan'208\";a=\"8440328\"", "E=McAfee;i=\"6600,9927,10923\"; a=\"1105584469\"", "E=Sophos;i=\"6.04,274,1695711600\"; d=\"scan'208\";a=\"1105584469\"" ], "X-ExtLoop1": "1", "From": "Zhichao Zeng <zhichaox.zeng@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Zhichao Zeng <zhichaox.zeng@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[PATCH v2 2/3] net/iavf: support Tx LLDP on AVX512", "Date": "Thu, 14 Dec 2023 14:58:56 +0800", "Message-Id": "<20231214065857.2142565-3-zhichaox.zeng@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231214065857.2142565-1-zhichaox.zeng@intel.com>", "References": "<20231206060828.3310347-1-zhichaox.zeng@intel.com>\n <20231214065857.2142565-1-zhichaox.zeng@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds an avx512 ctx Tx path that supports context descriptor,\nfilling in the SWTCH_UPLINK bit based on mbuf dynflag IAVF_TX_LLDP_DYNFLAG\nto support sending LLDP packet.\n\nSigned-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>\n---\n drivers/net/iavf/iavf_rxtx.c | 5 +++++\n drivers/net/iavf/iavf_rxtx.h | 3 +++\n drivers/net/iavf/iavf_rxtx_vec_avx512.c | 17 +++++++++++++++++\n drivers/net/iavf/iavf_rxtx_vec_common.h | 6 ++++++\n 4 files changed, 31 insertions(+)", "diff": "diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex c986fa944a..a588b769a8 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -4044,6 +4044,11 @@ iavf_set_tx_function(struct rte_eth_dev *dev)\n \t\t\t\tdev->tx_pkt_prepare = iavf_prep_pkts;\n \t\t\t\tPMD_DRV_LOG(DEBUG, \"Using AVX512 OFFLOAD Vector Tx (port %d).\",\n \t\t\t\t\t dev->data->port_id);\n+\t\t\t} else if (check_ret == IAVF_VECTOR_CTX_PATH) {\n+\t\t\t\tdev->tx_pkt_burst = iavf_xmit_pkts_vec_avx512_ctx;\n+\t\t\t\tdev->tx_pkt_prepare = iavf_prep_pkts;\n+\t\t\t\tPMD_DRV_LOG(DEBUG, \"Using AVX512 CONTEXT Vector Tx (port %d).\",\n+\t\t\t\t\t dev->data->port_id);\n \t\t\t} else {\n \t\t\t\tdev->tx_pkt_burst = iavf_xmit_pkts_vec_avx512_ctx_offload;\n \t\t\t\tdev->tx_pkt_prepare = iavf_prep_pkts;\ndiff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h\nindex f432f9d956..ee52864915 100644\n--- a/drivers/net/iavf/iavf_rxtx.h\n+++ b/drivers/net/iavf/iavf_rxtx.h\n@@ -66,6 +66,7 @@\n #define IAVF_VECTOR_PATH 0\n #define IAVF_VECTOR_OFFLOAD_PATH 1\n #define IAVF_VECTOR_CTX_OFFLOAD_PATH 2\n+#define IAVF_VECTOR_CTX_PATH 3\n \n #define DEFAULT_TX_RS_THRESH 32\n #define DEFAULT_TX_FREE_THRESH 32\n@@ -752,6 +753,8 @@ uint16_t iavf_xmit_pkts_vec_avx512_offload(void *tx_queue,\n \t\t\t\t\t uint16_t nb_pkts);\n uint16_t iavf_xmit_pkts_vec_avx512_ctx_offload(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t uint16_t nb_pkts);\n+uint16_t iavf_xmit_pkts_vec_avx512_ctx(void *tx_queue, struct rte_mbuf **tx_pkts,\n+\t\t\t\t uint16_t nb_pkts);\n int iavf_txq_vec_setup_avx512(struct iavf_tx_queue *txq);\n \n uint8_t iavf_proto_xtr_type_to_rxdid(uint8_t xtr_type);\ndiff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iavf_rxtx_vec_avx512.c\nindex 7a7df6d258..dc3354f331 100644\n--- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c\n+++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c\n@@ -2,6 +2,7 @@\n * Copyright(c) 2020 Intel Corporation\n */\n \n+#include \"rte_pmd_iavf.h\"\n #include \"iavf_rxtx_vec_common.h\"\n \n #include <rte_vect.h>\n@@ -2206,6 +2207,9 @@ ctx_vtx1(volatile struct iavf_tx_desc *txdp, struct rte_mbuf *pkt,\n \t\t\tlow_ctx_qw |= (uint64_t)pkt->vlan_tci << IAVF_TXD_CTX_QW0_L2TAG2_PARAM;\n \t\t}\n \t}\n+\tif (rte_mbuf_dynflag_lookup(IAVF_TX_LLDP_DYNFLAG, NULL) > 0)\n+\t\thigh_ctx_qw |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \tuint64_t high_data_qw = (IAVF_TX_DESC_DTYPE_DATA |\n \t\t\t\t((uint64_t)flags << IAVF_TXD_QW1_CMD_SHIFT) |\n \t\t\t\t((uint64_t)pkt->data_len << IAVF_TXD_QW1_TX_BUF_SZ_SHIFT));\n@@ -2258,6 +2262,9 @@ ctx_vtx(volatile struct iavf_tx_desc *txdp,\n \t\t\t\t\t(uint64_t)pkt[1]->vlan_tci << IAVF_TXD_QW1_L2TAG1_SHIFT;\n \t\t\t}\n \t\t}\n+\t\tif (rte_mbuf_dynflag_lookup(IAVF_TX_LLDP_DYNFLAG, NULL) > 0)\n+\t\t\thi_ctx_qw1 |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \n \t\tif (pkt[0]->ol_flags & RTE_MBUF_F_TX_VLAN) {\n \t\t\tif (vlan_flag & IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) {\n@@ -2270,6 +2277,9 @@ ctx_vtx(volatile struct iavf_tx_desc *txdp,\n \t\t\t\t\t(uint64_t)pkt[0]->vlan_tci << IAVF_TXD_QW1_L2TAG1_SHIFT;\n \t\t\t}\n \t\t}\n+\t\tif (rte_mbuf_dynflag_lookup(IAVF_TX_LLDP_DYNFLAG, NULL) > 0)\n+\t\t\thi_ctx_qw0 |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \n \t\tif (offload) {\n \t\t\tiavf_txd_enable_offload(pkt[1], &hi_data_qw1);\n@@ -2520,3 +2530,10 @@ iavf_xmit_pkts_vec_avx512_ctx_offload(void *tx_queue, struct rte_mbuf **tx_pkts,\n {\n \treturn iavf_xmit_pkts_vec_avx512_ctx_cmn(tx_queue, tx_pkts, nb_pkts, true);\n }\n+\n+uint16_t\n+iavf_xmit_pkts_vec_avx512_ctx(void *tx_queue, struct rte_mbuf **tx_pkts,\n+\t\t\t\t uint16_t nb_pkts)\n+{\n+\treturn iavf_xmit_pkts_vec_avx512_ctx_cmn(tx_queue, tx_pkts, nb_pkts, false);\n+}\ndiff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h\nindex e18cdc3f11..87e1d6c306 100644\n--- a/drivers/net/iavf/iavf_rxtx_vec_common.h\n+++ b/drivers/net/iavf/iavf_rxtx_vec_common.h\n@@ -10,6 +10,7 @@\n \n #include \"iavf.h\"\n #include \"iavf_rxtx.h\"\n+#include \"rte_pmd_iavf.h\"\n \n #ifndef __INTEL_COMPILER\n #pragma GCC diagnostic ignored \"-Wcast-qual\"\n@@ -249,6 +250,11 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq)\n \tif (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS)\n \t\treturn -1;\n \n+\tif (rte_mbuf_dynflag_lookup(IAVF_TX_LLDP_DYNFLAG, NULL) > 0) {\n+\t\ttxq->use_ctx = 1;\n+\t\treturn IAVF_VECTOR_CTX_PATH;\n+\t}\n+\n \t/**\n \t * Vlan tci needs to be inserted via ctx desc, if the vlan_flag is L2TAG2.\n \t * Tunneling parameters and other fields need be configured in ctx desc\n", "prefixes": [ "v2", "2/3" ] }