Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135042/?format=api
{ "id": 135042, "url": "http://patches.dpdk.org/api/patches/135042/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231211172437.61958-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231211172437.61958-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231211172437.61958-2-stephen@networkplumber.org", "date": "2023-12-11T17:23:23", "name": "[1/3] testpmd: replace EAL logtype with fprintf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "409ae7e176a2e4f123476af6fd38a36eda8a37c4", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231211172437.61958-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 30512, "url": "http://patches.dpdk.org/api/series/30512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30512", "date": "2023-12-11T17:23:22", "name": "replace use of EAL logtype", "version": 1, "mbox": "http://patches.dpdk.org/series/30512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135042/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135042/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6D7B436C8;\n\tMon, 11 Dec 2023 18:24:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C137A42D9F;\n\tMon, 11 Dec 2023 18:24:50 +0100 (CET)", "from mail-pg1-f170.google.com (mail-pg1-f170.google.com\n [209.85.215.170])\n by mails.dpdk.org (Postfix) with ESMTP id 32729415D7\n for <dev@dpdk.org>; Mon, 11 Dec 2023 18:24:49 +0100 (CET)", "by mail-pg1-f170.google.com with SMTP id\n 41be03b00d2f7-5c68da9d639so2679046a12.3\n for <dev@dpdk.org>; Mon, 11 Dec 2023 09:24:49 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n f16-20020aa782d0000000b006ce6878b274sm6494425pfn.216.2023.12.11.09.24.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 11 Dec 2023 09:24:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702315488;\n x=1702920288; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AdSOLFN0uWyvnObgF5SQIQtC2oO59IGu1ZJzjaCxHHo=;\n b=piS/E1mz8MgncGPlgSkumWgbeP1TtuR4Lo6JkCJ3/gK7/kbH0ujjDn6BVlqIHPPGEv\n CmW6sEWsqLXJX2IVYZUkvnEirSWKUfwET8UTBj2LobHFOoPwUOiSwyImfTeevdj1EA49\n tdWlya06f5SP/LHCwNDzRZLVQ38VTOQ3GrcHFVUm2awH4NETLjHFgeLxiGfXLlLziRkl\n R9G9XRW270Y6HXc5pCrmKONnrMutdIFEsev2HR1bBnyjvwSce4dV0Q4LapyP9p52y1xx\n jRMZhA/CmrWlHZUWIQYl7irjtGpr7Bnysa3WYsDdYlJ3e2uHOnZ97etB5N7Q+ohs/QHF\n F7IA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702315488; x=1702920288;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=AdSOLFN0uWyvnObgF5SQIQtC2oO59IGu1ZJzjaCxHHo=;\n b=pmpuqB7Q/p5t850fgprZAJAZh+FqAJQaC6+vJXCt+SN67BbGgjVD/UHcW/rmCcVu/b\n LRrFnq6zi7SdqDWgbRltwt8EoPOGGMAKKdO0rwZUiWBImilLTbOj8jMUOyL9wnBSb3U6\n qagC1oiuGq80IP+a67kfz27gmWRvFPs7maZHlxYWTdCvz4TB4CjCoRX4IGzFuPNIaXZj\n PLo9l+qAOGgqFXmeElLmqN5sBT/6RyrdlygLaZzMxyFU1aXty5Z0Ysxhup4db9ixgbAt\n wdBNeZANyRU+GgHpzUGUbTF5dDe9fJfFHrAiY5j1YUUqVxiUrjZ+/MJt8xsBuabLu3yD\n 1p2Q==", "X-Gm-Message-State": "AOJu0YwJIv5k4pWtfwp2d4PhYTuszboOdV5TSFkKvutgW/OtE3eCXReS\n Q26dxWjZPfibiYrjLJ42txS6N2DHz3SBL/HXXO9bjQ==", "X-Google-Smtp-Source": "\n AGHT+IE3OSGZTGbNbzMYVEj7VohlMVAxN3MBcqkiaiZ37h4meu6+vLGAP17fkdyF09Xp9hfcLcbJww==", "X-Received": "by 2002:a05:6a20:a111:b0:190:17a6:24b7 with SMTP id\n q17-20020a056a20a11100b0019017a624b7mr2666450pzk.19.1702315488316;\n Mon, 11 Dec 2023 09:24:48 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>", "Subject": "[PATCH 1/3] testpmd: replace EAL logtype with fprintf", "Date": "Mon, 11 Dec 2023 09:23:23 -0800", "Message-ID": "<20231211172437.61958-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231211172437.61958-1-stephen@networkplumber.org>", "References": "<20231211172437.61958-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Testpmd is misusing EAL logtype for its own errors.\nSince the code directly calls fprintf in other places,\nchange to use that everywhere. This has the added benefit\nof not having testpmd output clutter up syslog().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-pmd/testpmd.c | 33 +++++++++++----------------------\n 1 file changed, 11 insertions(+), 22 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 9e4e99e53b9a..aa350d61e451 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3413,8 +3413,7 @@ stop_port(portid_t pid)\n \n \t\tret = eth_dev_stop_mp(pi);\n \t\tif (ret != 0) {\n-\t\t\tRTE_LOG(ERR, EAL, \"rte_eth_dev_stop failed for port %u\\n\",\n-\t\t\t\tpi);\n+\t\t\tfprintf(stderr, \"rte_eth_dev_stop failed for port %u\\n\", pi);\n \t\t\t/* Allow to retry stopping the port. */\n \t\t\tport->port_status = RTE_PORT_STARTED;\n \t\t\tcontinue;\n@@ -3812,23 +3811,20 @@ pmd_test_exit(void)\n \tif (hot_plug) {\n \t\tret = rte_dev_event_monitor_stop();\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to stop device event monitor.\");\n+\t\t\tfprintf(stderr, \"fail to stop device event monitor.\");\n \t\t\treturn;\n \t\t}\n \n \t\tret = rte_dev_event_callback_unregister(NULL,\n \t\t\tdev_event_callback, NULL);\n \t\tif (ret < 0) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to unregister device event callback.\\n\");\n+\t\t\tfprintf(stderr, \"fail to unregister device event callback.\\n\");\n \t\t\treturn;\n \t\t}\n \n \t\tret = rte_dev_hotplug_handle_disable();\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to disable hotplug handling.\\n\");\n+\t\t\tfprintf(stderr, \"fail to disable hotplug handling.\\n\");\n \t\t\treturn;\n \t\t}\n \t}\n@@ -4062,12 +4058,10 @@ dev_event_callback(const char *device_name, enum rte_dev_event_type type,\n \n \tswitch (type) {\n \tcase RTE_DEV_EVENT_REMOVE:\n-\t\tRTE_LOG(DEBUG, EAL, \"The device: %s has been removed!\\n\",\n-\t\t\tdevice_name);\n+\t\tfprintf(stderr, \"The device: %s has been removed!\\n\", device_name);\n \t\tret = rte_eth_dev_get_port_by_name(device_name, &port_id);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, EAL, \"can not get port by device %s!\\n\",\n-\t\t\t\tdevice_name);\n+\t\t\tfprintf(stderr, \"Can not get port by device %s!\\n\", device_name);\n \t\t\treturn;\n \t\t}\n \t\t/*\n@@ -4081,12 +4075,10 @@ dev_event_callback(const char *device_name, enum rte_dev_event_type type,\n \t\t */\n \t\tif (rte_eal_alarm_set(100000,\n \t\t\t\trmv_port_callback, (void *)(intptr_t)port_id))\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"Could not set up deferred device removal\\n\");\n+\t\t\tfprintf(stderr, \"Could not set up deferred device removal\\n\");\n \t\tbreak;\n \tcase RTE_DEV_EVENT_ADD:\n-\t\tRTE_LOG(ERR, EAL, \"The device: %s has been added!\\n\",\n-\t\t\tdevice_name);\n+\t\tfprintf(stderr, \"The device: %s has been added!\\n\", device_name);\n \t\t/* TODO: After finish kernel driver binding,\n \t\t * begin to attach port.\n \t\t */\n@@ -4632,23 +4624,20 @@ main(int argc, char** argv)\n \tif (hot_plug) {\n \t\tret = rte_dev_hotplug_handle_enable();\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to enable hotplug handling.\");\n+\t\t\tfprintf(stderr, \"fail to enable hotplug handling.\");\n \t\t\treturn -1;\n \t\t}\n \n \t\tret = rte_dev_event_monitor_start();\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to start device event monitoring.\");\n+\t\t\tfprintf(stderr, \"fail to start device event monitoring.\");\n \t\t\treturn -1;\n \t\t}\n \n \t\tret = rte_dev_event_callback_register(NULL,\n \t\t\tdev_event_callback, NULL);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to register device event callback\\n\");\n+\t\t\tfprintf(stderr, \"fail to register device event callback\\n\");\n \t\t\treturn -1;\n \t\t}\n \t}\n", "prefixes": [ "1/3" ] }