Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134573/?format=api
{ "id": 134573, "url": "http://patches.dpdk.org/api/patches/134573/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231123151344.162812-8-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231123151344.162812-8-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/20231123151344.162812-8-juraj.linkes@pantheon.tech", "date": "2023-11-23T15:13:30", "name": "[v8,07/21] dts: dts runner and main docstring update", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "25dcbcb1d17dda72ac9f830613febdb35a6e6c13", "submitter": { "id": 1626, "url": "http://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231123151344.162812-8-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 30375, "url": "http://patches.dpdk.org/api/series/30375/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30375", "date": "2023-11-23T15:13:23", "name": "dts: docstrings update", "version": 8, "mbox": "http://patches.dpdk.org/series/30375/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134573/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78B07433AC;\n\tThu, 23 Nov 2023 16:14:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1997F42FE3;\n\tThu, 23 Nov 2023 16:14:05 +0100 (CET)", "from mail-wr1-f45.google.com (mail-wr1-f45.google.com\n [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id 0B99F42FCD\n for <dev@dpdk.org>; Thu, 23 Nov 2023 16:13:56 +0100 (CET)", "by mail-wr1-f45.google.com with SMTP id\n ffacd0b85a97d-332e3ad436cso380935f8f.3\n for <dev@dpdk.org>; Thu, 23 Nov 2023 07:13:56 -0800 (PST)", "from jlinkes-PT-Latitude-5530.. ([84.245.121.10])\n by smtp.gmail.com with ESMTPSA id\n q4-20020adfea04000000b003296b488961sm1870143wrm.31.2023.11.23.07.13.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Nov 2023 07:13:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=pantheon.tech; s=google; t=1700752436; x=1701357236; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6i4bo/AJKOFxXNVyyjE//kxyMsAoBQPx3oSImSMe8yo=;\n b=s8svDtUZEV0ucTE+CbduWfPDaIaj15gilnOJEJyWJgmql50Z+rBCcSMoZJ2LAUarlU\n HxvZl/3rRUqhvquXkA+nUYWBOZHVdTwyKFwyzJllWNyK3MRJu0o6PA6xIXpkepKlU/bf\n SNTZNxXY1BdYE/4YhPlijNY4vtDmWhUw4MpoGtN6sxTItdmUKPEqNRHkbkj5Jvdn7zU8\n yjqZUeCG+xfZObQs4aQ+kMOdykFaroqLoE2Alup6RDa6T+P7i3sUMbrf2awpBbbkrvWe\n jX4k+zkBf5UFG/5PLVJQnAhXIKBcE2AIq5/nN3nDFtM0O1MrjKKW+Rn8Znve5pr8Sgpq\n GT5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1700752436; x=1701357236;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6i4bo/AJKOFxXNVyyjE//kxyMsAoBQPx3oSImSMe8yo=;\n b=F4lQjbRzsHbP0mbQhXOs2Rc8daB8c0eD2BWzusYQYtMhPcNWWQmFazABGl+1FiWyI+\n WUJre0VGi3k4n7/DIch1awFKo+YBved/ZhBNl6WJQSg8Bk1qjYG1x2MADe7JNbnP56jZ\n AVQOiovmJQ3eShe3ggPtivdLJhl3JZu1A1c4fXsqfrFjVV/QAK+x7thcoYuPm9AndGiN\n xaqsm2Tgo66saG3QV0dsx6YBWL3aFw/f/jokwBDxqmAY7NNpmRqDizk5ETbM2u5TnTbn\n buAdoAsuWixqYK5PXG9Kz4diOvkJyn69vYwj3jbPk4npsZSw4eOfhDH/KUQ5kDSkuwEK\n gQpg==", "X-Gm-Message-State": "AOJu0YzmH8fdFx2gpneRoC9eZ9MX9LS2eC2ZCmLlcb/Cy75V3jLiSdEj\n 6C0ZCDMcBWsQtYmtoPVfGJUZp4Zhk4t8XHLajh646g==", "X-Google-Smtp-Source": "\n AGHT+IHKY56vFtNyn6yV0X9Q3jvJW6xVjA2rtYnCwlNbu3EaNpW2NsA+V02MzqlKxtvg/VAFJJkNjA==", "X-Received": "by 2002:a05:6000:b8a:b0:332:e62e:f0ba with SMTP id\n dl10-20020a0560000b8a00b00332e62ef0bamr803746wrb.18.1700752435742;\n Thu, 23 Nov 2023 07:13:55 -0800 (PST)", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu,\n probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com,\n Luca.Vizzarro@arm.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Subject": "[PATCH v8 07/21] dts: dts runner and main docstring update", "Date": "Thu, 23 Nov 2023 16:13:30 +0100", "Message-Id": "<20231123151344.162812-8-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231123151344.162812-1-juraj.linkes@pantheon.tech>", "References": "<20231115130959.39420-1-juraj.linkes@pantheon.tech>\n <20231123151344.162812-1-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Format according to the Google format and PEP257, with slight\ndeviations.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\n---\n dts/framework/dts.py | 131 ++++++++++++++++++++++++++++++++++++-------\n dts/main.py | 10 ++--\n 2 files changed, 116 insertions(+), 25 deletions(-)", "diff": "diff --git a/dts/framework/dts.py b/dts/framework/dts.py\nindex 356368ef10..e16d4578a0 100644\n--- a/dts/framework/dts.py\n+++ b/dts/framework/dts.py\n@@ -3,6 +3,33 @@\n # Copyright(c) 2022-2023 PANTHEON.tech s.r.o.\n # Copyright(c) 2022-2023 University of New Hampshire\n \n+r\"\"\"Test suite runner module.\n+\n+A DTS run is split into stages:\n+\n+ #. Execution stage,\n+ #. Build target stage,\n+ #. Test suite stage,\n+ #. Test case stage.\n+\n+The module is responsible for running tests on testbeds defined in the test run configuration.\n+Each setup or teardown of each stage is recorded in a :class:`~.test_result.DTSResult` or\n+one of its subclasses. The test case results are also recorded.\n+\n+If an error occurs, the current stage is aborted, the error is recorded and the run continues in\n+the next iteration of the same stage. The return code is the highest `severity` of all\n+:class:`~.exception.DTSError`\\s.\n+\n+Example:\n+ An error occurs in a build target setup. The current build target is aborted and the run\n+ continues with the next build target. If the errored build target was the last one in the given\n+ execution, the next execution begins.\n+\n+Attributes:\n+ dts_logger: The logger instance used in this module.\n+ result: The top level result used in the module.\n+\"\"\"\n+\n import sys\n \n from .config import (\n@@ -23,9 +50,38 @@\n \n \n def run_all() -> None:\n- \"\"\"\n- The main process of DTS. Runs all build targets in all executions from the main\n- config file.\n+ \"\"\"Run all build targets in all executions from the test run configuration.\n+\n+ Before running test suites, executions and build targets are first set up.\n+ The executions and build targets defined in the test run configuration are iterated over.\n+ The executions define which tests to run and where to run them and build targets define\n+ the DPDK build setup.\n+\n+ The tests suites are set up for each execution/build target tuple and each scheduled\n+ test case within the test suite is set up, executed and torn down. After all test cases\n+ have been executed, the test suite is torn down and the next build target will be tested.\n+\n+ All the nested steps look like this:\n+\n+ #. Execution setup\n+\n+ #. Build target setup\n+\n+ #. Test suite setup\n+\n+ #. Test case setup\n+ #. Test case logic\n+ #. Test case teardown\n+\n+ #. Test suite teardown\n+\n+ #. Build target teardown\n+\n+ #. Execution teardown\n+\n+ The test cases are filtered according to the specification in the test run configuration and\n+ the :option:`--test-cases` command line argument or\n+ the :envvar:`DTS_TESTCASES` environment variable.\n \"\"\"\n global dts_logger\n global result\n@@ -87,6 +143,8 @@ def run_all() -> None:\n \n \n def _check_dts_python_version() -> None:\n+ \"\"\"Check the required Python version - v3.10.\"\"\"\n+\n def RED(text: str) -> str:\n return f\"\\u001B[31;1m{str(text)}\\u001B[0m\"\n \n@@ -109,9 +167,16 @@ def _run_execution(\n execution: ExecutionConfiguration,\n result: DTSResult,\n ) -> None:\n- \"\"\"\n- Run the given execution. This involves running the execution setup as well as\n- running all build targets in the given execution.\n+ \"\"\"Run the given execution.\n+\n+ This involves running the execution setup as well as running all build targets\n+ in the given execution. After that, execution teardown is run.\n+\n+ Args:\n+ sut_node: The execution's SUT node.\n+ tg_node: The execution's TG node.\n+ execution: An execution's test run configuration.\n+ result: The top level result object.\n \"\"\"\n dts_logger.info(f\"Running execution with SUT '{execution.system_under_test_node.name}'.\")\n execution_result = result.add_execution(sut_node.config)\n@@ -144,8 +209,18 @@ def _run_build_target(\n execution: ExecutionConfiguration,\n execution_result: ExecutionResult,\n ) -> None:\n- \"\"\"\n- Run the given build target.\n+ \"\"\"Run the given build target.\n+\n+ This involves running the build target setup as well as running all test suites\n+ in the given execution the build target is defined in.\n+ After that, build target teardown is run.\n+\n+ Args:\n+ sut_node: The execution's SUT node.\n+ tg_node: The execution's TG node.\n+ build_target: A build target's test run configuration.\n+ execution: The build target's execution's test run configuration.\n+ execution_result: The execution level result object associated with the execution.\n \"\"\"\n dts_logger.info(f\"Running build target '{build_target.name}'.\")\n build_target_result = execution_result.add_build_target(build_target)\n@@ -177,10 +252,20 @@ def _run_all_suites(\n execution: ExecutionConfiguration,\n build_target_result: BuildTargetResult,\n ) -> None:\n- \"\"\"\n- Use the given build_target to run execution's test suites\n- with possibly only a subset of test cases.\n- If no subset is specified, run all test cases.\n+ \"\"\"Run the execution's (possibly a subset) test suites using the current build target.\n+\n+ The function assumes the build target we're testing has already been built on the SUT node.\n+ The current build target thus corresponds to the current DPDK build present on the SUT node.\n+\n+ If a blocking test suite (such as the smoke test suite) fails, the rest of the test suites\n+ in the current build target won't be executed.\n+\n+ Args:\n+ sut_node: The execution's SUT node.\n+ tg_node: The execution's TG node.\n+ execution: The execution's test run configuration associated with the current build target.\n+ build_target_result: The build target level result object associated\n+ with the current build target.\n \"\"\"\n end_build_target = False\n if not execution.skip_smoke_tests:\n@@ -206,16 +291,22 @@ def _run_single_suite(\n build_target_result: BuildTargetResult,\n test_suite_config: TestSuiteConfig,\n ) -> None:\n- \"\"\"Runs a single test suite.\n+ \"\"\"Run all test suite in a single test suite module.\n+\n+ The function assumes the build target we're testing has already been built on the SUT node.\n+ The current build target thus corresponds to the current DPDK build present on the SUT node.\n \n Args:\n- sut_node: Node to run tests on.\n- execution: Execution the test case belongs to.\n- build_target_result: Build target configuration test case is run on\n- test_suite_config: Test suite configuration\n+ sut_node: The execution's SUT node.\n+ tg_node: The execution's TG node.\n+ execution: The execution's test run configuration associated with the current build target.\n+ build_target_result: The build target level result object associated\n+ with the current build target.\n+ test_suite_config: Test suite test run configuration specifying the test suite module\n+ and possibly a subset of test cases of test suites in that module.\n \n Raises:\n- BlockingTestSuiteError: If a test suite that was marked as blocking fails.\n+ BlockingTestSuiteError: If a blocking test suite fails.\n \"\"\"\n try:\n full_suite_path = f\"tests.TestSuite_{test_suite_config.test_suite}\"\n@@ -239,9 +330,7 @@ def _run_single_suite(\n \n \n def _exit_dts() -> None:\n- \"\"\"\n- Process all errors and exit with the proper exit code.\n- \"\"\"\n+ \"\"\"Process all errors and exit with the proper exit code.\"\"\"\n result.process()\n \n if dts_logger:\ndiff --git a/dts/main.py b/dts/main.py\nindex 5d4714b0c3..b856ba86be 100755\n--- a/dts/main.py\n+++ b/dts/main.py\n@@ -1,12 +1,10 @@\n #!/usr/bin/env python3\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n-# Copyright(c) 2022 PANTHEON.tech s.r.o.\n+# Copyright(c) 2022-2023 PANTHEON.tech s.r.o.\n # Copyright(c) 2022 University of New Hampshire\n \n-\"\"\"\n-A test framework for testing DPDK.\n-\"\"\"\n+\"\"\"The DTS executable.\"\"\"\n \n import logging\n \n@@ -17,6 +15,10 @@ def main() -> None:\n \"\"\"Set DTS settings, then run DTS.\n \n The DTS settings are taken from the command line arguments and the environment variables.\n+ The settings object is stored in the module-level variable settings.SETTINGS which the entire\n+ framework uses. After importing the module (or the variable), any changes to the variable are\n+ not going to be reflected without a re-import. This means that the SETTINGS variable must\n+ be modified before the settings module is imported anywhere else in the framework.\n \"\"\"\n settings.SETTINGS = settings.get_settings()\n from framework import dts\n", "prefixes": [ "v8", "07/21" ] }