Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134247/?format=api
{ "id": 134247, "url": "http://patches.dpdk.org/api/patches/134247/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114084133.3573959-17-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114084133.3573959-17-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114084133.3573959-17-haijie1@huawei.com", "date": "2023-11-14T08:41:27", "name": "[v2,16/22] common/cnxk: replace strtok with reentrant version", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5fbf016eaca616078961bc8741f48cd6600f55d6", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114084133.3573959-17-haijie1@huawei.com/mbox/", "series": [ { "id": 30286, "url": "http://patches.dpdk.org/api/series/30286/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30286", "date": "2023-11-14T08:41:12", "name": "replace strtok with reentrant version", "version": 2, "mbox": "http://patches.dpdk.org/series/30286/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134247/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6E3E43325;\n\tTue, 14 Nov 2023 09:48:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 34E7E40E8A;\n\tTue, 14 Nov 2023 09:47:33 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 4B7E74068A\n for <dev@dpdk.org>; Tue, 14 Nov 2023 09:47:20 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SV0Dq0Y5wzPpLN;\n Tue, 14 Nov 2023 16:43:07 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 16:47:18 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>, Jerin Jacob <jerinj@marvell.com>, Gowrishankar\n Muthukrishnan <gmuthukrishn@marvell.com>, Harman Kalra <hkalra@marvell.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v2 16/22] common/cnxk: replace strtok with reentrant version", "Date": "Tue, 14 Nov 2023 16:41:27 +0800", "Message-ID": "<20231114084133.3573959-17-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114084133.3573959-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114084133.3573959-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: af75aac78978 (\"common/cnxk: support telemetry for NIX\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/common/cnxk/cnxk_telemetry_nix.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/cnxk_telemetry_nix.c b/drivers/common/cnxk/cnxk_telemetry_nix.c\nindex ccae5d7853af..eff1517951e9 100644\n--- a/drivers/common/cnxk/cnxk_telemetry_nix.c\n+++ b/drivers/common/cnxk/cnxk_telemetry_nix.c\n@@ -761,7 +761,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char *params,\n \t\t\t struct plt_tel_data *d)\n {\n \tstruct nix_tel_node *node;\n-\tchar *name, *param;\n+\tchar *name, *param, *sp = NULL;\n \tchar buf[1024];\n \tint rc = -1;\n \n@@ -769,11 +769,11 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char *params,\n \t\tgoto exit;\n \n \tplt_strlcpy(buf, params, PCI_PRI_STR_SIZE + 1);\n-\tname = strtok(buf, \",\");\n+\tname = strtok_s(buf, \",\", &sp);\n \tif (name == NULL)\n \t\tgoto exit;\n \n-\tparam = strtok(NULL, \"\\0\");\n+\tparam = strtok_s(NULL, \"\\0\", &sp);\n \n \tnode = nix_tel_node_get_by_pcidev_name(name);\n \tif (!node)\n@@ -782,7 +782,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char *params,\n \tplt_tel_data_start_dict(d);\n \n \tif (strstr(cmd, \"rq\")) {\n-\t\tchar *tok = strtok(param, \",\");\n+\t\tchar *tok = strtok_s(param, \",\", &sp);\n \t\tint rq;\n \n \t\tif (!tok)\n@@ -798,7 +798,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char *params,\n \t\t\trc = cnxk_tel_nix_rq(node->rqs[rq], d);\n \n \t} else if (strstr(cmd, \"cq\")) {\n-\t\tchar *tok = strtok(param, \",\");\n+\t\tchar *tok = strtok_s(param, \",\", &sp);\n \t\tint cq;\n \n \t\tif (!tok)\n@@ -814,7 +814,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char *params,\n \t\t\trc = cnxk_tel_nix_cq(node->cqs[cq], d);\n \n \t} else if (strstr(cmd, \"sq\")) {\n-\t\tchar *tok = strtok(param, \",\");\n+\t\tchar *tok = strtok_s(param, \",\", &sp);\n \t\tint sq;\n \n \t\tif (!tok)\n", "prefixes": [ "v2", "16/22" ] }