Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134221/?format=api
{ "id": 134221, "url": "http://patches.dpdk.org/api/patches/134221/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-37-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114082539.1858594-37-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114082539.1858594-37-huangdengdui@huawei.com", "date": "2023-11-14T08:25:32", "name": "[36/43] net/sfc: use rte strerror", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b7b1e03be1d6aff60acd1fdc5c20ac098526306", "submitter": { "id": 3066, "url": "http://patches.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-37-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30285, "url": "http://patches.dpdk.org/api/series/30285/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30285", "date": "2023-11-14T08:25:01", "name": "replace strerror", "version": 1, "mbox": "http://patches.dpdk.org/series/30285/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134221/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24FA043325;\n\tTue, 14 Nov 2023 09:29:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7B7E427DD;\n\tTue, 14 Nov 2023 09:26:21 +0100 (CET)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 892CA4067D\n for <dev@dpdk.org>; Tue, 14 Nov 2023 09:25:46 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.56])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4STzmz5Swxz1P8Kg;\n Tue, 14 Nov 2023 16:22:27 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 16:25:45 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH 36/43] net/sfc: use rte strerror", "Date": "Tue, 14 Nov 2023 16:25:32 +0800", "Message-ID": "<20231114082539.1858594-37-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114082539.1858594-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/sfc/sfc_flow.c | 2 +-\n drivers/net/sfc/sfc_flow_tunnel.c | 2 +-\n drivers/net/sfc/sfc_mae.c | 58 +++++++++++++++----------------\n 3 files changed, 31 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 1b50aefe5c..304628026d 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -1403,7 +1403,7 @@ sfc_flow_parse_pattern(struct sfc_adapter *sa,\n \t\trc = item->parse(pattern, parse_ctx, error);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"failed to parse item %s: %s\",\n-\t\t\t\titem->name, strerror(-rc));\n+\t\t\t\titem->name, rte_strerror(-rc));\n \t\t\treturn rc;\n \t\t}\n \ndiff --git a/drivers/net/sfc/sfc_flow_tunnel.c b/drivers/net/sfc/sfc_flow_tunnel.c\nindex 889fee569a..898d00dd6d 100644\n--- a/drivers/net/sfc/sfc_flow_tunnel.c\n+++ b/drivers/net/sfc/sfc_flow_tunnel.c\n@@ -120,7 +120,7 @@ sfc_ft_tunnel_rule_detect(struct sfc_adapter *sa,\n \t\tif (rc != 0) {\n \t\t\t/* The loop above might have spotted wrong actions. */\n \t\t\tsfc_err(sa, \"FT: TUNNEL: invalid actions: %s\",\n-\t\t\t\tstrerror(rc));\n+\t\t\t\trte_strerror(rc));\n \t\t\tgoto fail;\n \t\t}\n \ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex e5ec0ae49d..accde9bcb0 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -429,7 +429,7 @@ sfc_mae_outer_rule_enable(struct sfc_adapter *sa,\n \t\t\t\t\t &fw_rsrc->rule_id);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"failed to enable outer_rule=%p: %s\",\n-\t\t\t\trule, strerror(rc));\n+\t\t\t\trule, rte_strerror(rc));\n \t\t\treturn rc;\n \t\t}\n \t}\n@@ -446,7 +446,7 @@ sfc_mae_outer_rule_enable(struct sfc_adapter *sa,\n \t\t\tfw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;\n \t\t}\n \n-\t\tsfc_err(sa, \"can't match on outer rule ID: %s\", strerror(rc));\n+\t\tsfc_err(sa, \"can't match on outer rule ID: %s\", rte_strerror(rc));\n \n \t\treturn rc;\n \t}\n@@ -485,7 +485,7 @@ sfc_mae_outer_rule_disable(struct sfc_adapter *sa,\n \t\t\t\t\t\t &invalid_rule_id);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"cannot restore match on invalid outer rule ID: %s\",\n-\t\t\tstrerror(rc));\n+\t\t\trte_strerror(rc));\n \t\treturn;\n \t}\n \n@@ -504,7 +504,7 @@ sfc_mae_outer_rule_disable(struct sfc_adapter *sa,\n \t\t\t\trule, fw_rsrc->rule_id.id);\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable outer_rule=%p with OR_ID=0x%08x: %s\",\n-\t\t\t\trule, fw_rsrc->rule_id.id, strerror(rc));\n+\t\t\t\trule, fw_rsrc->rule_id.id, rte_strerror(rc));\n \t\t}\n \t\tfw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;\n \t}\n@@ -618,7 +618,7 @@ sfc_mae_mac_addr_enable(struct sfc_adapter *sa,\n \t\t\t\t\t &fw_rsrc->mac_id);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"failed to enable mac_addr=%p: %s\",\n-\t\t\t\tmac_addr, strerror(rc));\n+\t\t\t\tmac_addr, rte_strerror(rc));\n \t\t\treturn rc;\n \t\t}\n \t}\n@@ -644,7 +644,7 @@ sfc_mae_mac_addr_enable(struct sfc_adapter *sa,\n \t\t}\n \n \t\tsfc_err(sa, \"cannot fill in MAC address entry ID: %s\",\n-\t\t\tstrerror(rc));\n+\t\t\trte_strerror(rc));\n \n \t\treturn rc;\n \t}\n@@ -687,7 +687,7 @@ sfc_mae_mac_addr_disable(struct sfc_adapter *sa,\n \t\t\t\tmac_addr, fw_rsrc->mac_id.id);\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable mac_addr=%p with MAC_ID=0x%08x: %s\",\n-\t\t\t\tmac_addr, fw_rsrc->mac_id.id, strerror(rc));\n+\t\t\t\tmac_addr, fw_rsrc->mac_id.id, rte_strerror(rc));\n \t\t}\n \t\tfw_rsrc->mac_id.id = EFX_MAE_RSRC_ID_INVALID;\n \t}\n@@ -820,7 +820,7 @@ sfc_mae_encap_header_update(struct sfc_adapter *sa,\n \t\t\t\t\t\t bounce_eh->size);\n \t\tif (ret != 0) {\n \t\t\tsfc_err(sa, \"failed to update encap_header=%p: %s\",\n-\t\t\t\tencap_header, strerror(ret));\n+\t\t\t\tencap_header, rte_strerror(ret));\n \t\t\trte_free(buf);\n \t\t\treturn ret;\n \t\t}\n@@ -861,7 +861,7 @@ sfc_mae_encap_header_enable(struct sfc_adapter *sa,\n \t\t\t\t\t\t&fw_rsrc->eh_id);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"failed to enable encap_header=%p: %s\",\n-\t\t\t\tencap_header, strerror(rc));\n+\t\t\t\tencap_header, rte_strerror(rc));\n \t\t\treturn rc;\n \t\t}\n \t}\n@@ -875,7 +875,7 @@ sfc_mae_encap_header_enable(struct sfc_adapter *sa,\n \t\t\tfw_rsrc->eh_id.id = EFX_MAE_RSRC_ID_INVALID;\n \t\t}\n \n-\t\tsfc_err(sa, \"can't fill in encap. header ID: %s\", strerror(rc));\n+\t\tsfc_err(sa, \"can't fill in encap. header ID: %s\", rte_strerror(rc));\n \n \t\treturn rc;\n \t}\n@@ -918,7 +918,7 @@ sfc_mae_encap_header_disable(struct sfc_adapter *sa,\n \t\t\t\tencap_header, fw_rsrc->eh_id.id);\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable encap_header=%p with EH_ID=0x%08x: %s\",\n-\t\t\t\tencap_header, fw_rsrc->eh_id.id, strerror(rc));\n+\t\t\t\tencap_header, fw_rsrc->eh_id.id, rte_strerror(rc));\n \t\t}\n \t\tfw_rsrc->eh_id.id = EFX_MAE_RSRC_ID_INVALID;\n \t}\n@@ -1023,7 +1023,7 @@ sfc_mae_counter_enable(struct sfc_adapter *sa, struct sfc_mae_counter *counter,\n \t\t\t}\n \n \t\t\tsfc_err(sa, \"cannot fill in counter ID: %s\",\n-\t\t\t\tstrerror(rc));\n+\t\t\t\trte_strerror(rc));\n \t\t\treturn rc;\n \t\t}\n \t}\n@@ -1067,7 +1067,7 @@ sfc_mae_counter_disable(struct sfc_adapter *sa, struct sfc_mae_counter *counter)\n \t\t\t\tcounter, counter->type, counter_id);\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable counter=%p with COUNTER_ID=0x%x-#%u: %s\",\n-\t\t\t\tcounter, counter->type, counter_id, strerror(rc));\n+\t\t\t\tcounter, counter->type, counter_id, rte_strerror(rc));\n \t\t}\n \n \t\tfw_rsrc->counter_id.id = EFX_MAE_RSRC_ID_INVALID;\n@@ -1242,7 +1242,7 @@ sfc_mae_action_set_enable(struct sfc_adapter *sa,\n \t\t\t\t\t &fw_rsrc->aset_id);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"failed to enable action_set=%p: %s\",\n-\t\t\t\taction_set, strerror(rc));\n+\t\t\t\taction_set, rte_strerror(rc));\n \n \t\t\tsfc_mae_encap_header_disable(sa, encap_header);\n \t\t\tsfc_mae_mac_addr_disable(sa, src_mac_addr);\n@@ -1290,7 +1290,7 @@ sfc_mae_action_set_disable(struct sfc_adapter *sa,\n \t\t\t\taction_set, fw_rsrc->aset_id.id);\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable action_set=%p with AS_ID=0x%08x: %s\",\n-\t\t\t\taction_set, fw_rsrc->aset_id.id, strerror(rc));\n+\t\t\t\taction_set, fw_rsrc->aset_id.id, rte_strerror(rc));\n \t\t}\n \t\tfw_rsrc->aset_id.id = EFX_MAE_RSRC_ID_INVALID;\n \n@@ -1446,7 +1446,7 @@ sfc_mae_action_set_list_enable(struct sfc_adapter *sa,\n \t\t\t\t\t\t&fw_rsrc->aset_list_id);\n \t\tif (rc != 0) {\n \t\t\tsfc_err(sa, \"failed to enable action_set_list=%p: %s\",\n-\t\t\t\taction_set_list, strerror(rc));\n+\t\t\t\taction_set_list, rte_strerror(rc));\n \t\t\tgoto fail_action_set_list_alloc;\n \t\t}\n \n@@ -1499,7 +1499,7 @@ sfc_mae_action_set_list_disable(struct sfc_adapter *sa,\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable action_set_list=%p with ASL_ID=0x%08x: %s\",\n \t\t\t\taction_set_list, fw_rsrc->aset_list_id.id,\n-\t\t\t\tstrerror(rc));\n+\t\t\t\trte_strerror(rc));\n \t\t}\n \t\tfw_rsrc->aset_list_id.id = EFX_MAE_RSRC_ID_INVALID;\n \n@@ -1710,7 +1710,7 @@ sfc_mae_action_rule_enable(struct sfc_adapter *sa,\n \t\t\t\t\tas_idp, &fw_rsrc->rule_id);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to enable action_rule=%p: %s\",\n-\t\t\trule, strerror(rc));\n+\t\t\trule, rte_strerror(rc));\n \t\tgoto fail_action_rule_insert;\n \t}\n \n@@ -1761,7 +1761,7 @@ sfc_mae_action_rule_disable(struct sfc_adapter *sa,\n \t\t\t\trule, fw_rsrc->rule_id.id);\n \t\t} else {\n \t\t\tsfc_err(sa, \"failed to disable action_rule=%p with AR_ID=0x%08x: %s\",\n-\t\t\t\trule, fw_rsrc->rule_id.id, strerror(rc));\n+\t\t\t\trule, fw_rsrc->rule_id.id, rte_strerror(rc));\n \t\t}\n \n \t\tfw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;\n@@ -4398,7 +4398,7 @@ sfc_mae_rule_parse_action_mark(struct sfc_adapter *sa,\n \n \trc = efx_mae_action_set_populate_mark(spec, conf->id);\n \tif (rc != 0)\n-\t\tsfc_err(sa, \"failed to request action MARK: %s\", strerror(rc));\n+\t\tsfc_err(sa, \"failed to request action MARK: %s\", rte_strerror(rc));\n \n \treturn rc;\n }\n@@ -4570,14 +4570,14 @@ sfc_mae_rule_parse_action_pf_vf(struct sfc_adapter *sa,\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to convert PF %u VF %d to m-port: %s\",\n \t\t\tencp->enc_pf, (vf != EFX_PCI_VF_INVALID) ? (int)vf : -1,\n-\t\t\tstrerror(rc));\n+\t\t\trte_strerror(rc));\n \t\treturn rc;\n \t}\n \n \trc = efx_mae_action_set_populate_deliver(spec, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to request action DELIVER with m-port selector 0x%08x: %s\",\n-\t\t\tmport.sel, strerror(rc));\n+\t\t\tmport.sel, rte_strerror(rc));\n \t}\n \n \treturn rc;\n@@ -4606,14 +4606,14 @@ sfc_mae_rule_parse_action_port_id(struct sfc_adapter *sa,\n \t\t\t\t\t port_id, type_mask, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to get m-port for the given ethdev (port_id=%u): %s\",\n-\t\t\tport_id, strerror(rc));\n+\t\t\tport_id, rte_strerror(rc));\n \t\treturn rc;\n \t}\n \n \trc = efx_mae_action_set_populate_deliver(spec, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to request action DELIVER with m-port selector 0x%08x: %s\",\n-\t\t\tmport.sel, strerror(rc));\n+\t\t\tmport.sel, rte_strerror(rc));\n \t}\n \n \treturn rc;\n@@ -4632,14 +4632,14 @@ sfc_mae_rule_parse_action_port_representor(struct sfc_adapter *sa,\n \t\t\t\t\t conf->port_id, type_mask, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to get m-port for the given ethdev (port_id=%u): %s\",\n-\t\t\tconf->port_id, strerror(rc));\n+\t\t\tconf->port_id, rte_strerror(rc));\n \t\treturn rc;\n \t}\n \n \trc = efx_mae_action_set_populate_deliver(spec, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to request action DELIVER with m-port selector 0x%08x: %s\",\n-\t\t\tmport.sel, strerror(rc));\n+\t\t\tmport.sel, rte_strerror(rc));\n \t}\n \n \treturn rc;\n@@ -4658,14 +4658,14 @@ sfc_mae_rule_parse_action_represented_port(struct sfc_adapter *sa,\n \t\t\t\t\t conf->port_id, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to get m-port for the given ethdev (port_id=%u): %s\",\n-\t\t\tconf->port_id, strerror(rc));\n+\t\t\tconf->port_id, rte_strerror(rc));\n \t\treturn rc;\n \t}\n \n \trc = efx_mae_action_set_populate_deliver(spec, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to request action DELIVER with m-port selector 0x%08x: %s\",\n-\t\t\tmport.sel, strerror(rc));\n+\t\t\tmport.sel, rte_strerror(rc));\n \t}\n \n \treturn rc;\n@@ -4758,7 +4758,7 @@ sfc_mae_rule_parse_action_rc(struct sfc_adapter *sa,\n \n \t\t\tif (action_name != NULL) {\n \t\t\t\tsfc_err(sa, \"action %s was rejected: %s\",\n-\t\t\t\t\taction_name, strerror(rc));\n+\t\t\t\t\taction_name, rte_strerror(rc));\n \t\t\t}\n \t\t}\n \t\trc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ACTION,\n", "prefixes": [ "36/43" ] }