Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134194,
    "url": "http://patches.dpdk.org/api/patches/134194/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-9-huangdengdui@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231114082539.1858594-9-huangdengdui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231114082539.1858594-9-huangdengdui@huawei.com",
    "date": "2023-11-14T08:25:04",
    "name": "[08/43] telemetry: replace strerror",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "02f2fe895a57c66b04344f862786bd69bed44844",
    "submitter": {
        "id": 3066,
        "url": "http://patches.dpdk.org/api/people/3066/?format=api",
        "name": "huangdengdui",
        "email": "huangdengdui@huawei.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-9-huangdengdui@huawei.com/mbox/",
    "series": [
        {
            "id": 30285,
            "url": "http://patches.dpdk.org/api/series/30285/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30285",
            "date": "2023-11-14T08:25:01",
            "name": "replace strerror",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/30285/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/134194/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/134194/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 556F443325;\n\tTue, 14 Nov 2023 09:26:18 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C0444406B6;\n\tTue, 14 Nov 2023 09:25:50 +0100 (CET)",
            "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 95483402E4\n for <dev@dpdk.org>; Tue, 14 Nov 2023 09:25:42 +0100 (CET)",
            "from dggpeml500011.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4STzls4110zPpC5;\n Tue, 14 Nov 2023 16:21:29 +0800 (CST)",
            "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 16:25:41 +0800"
        ],
        "From": "Dengdui Huang <huangdengdui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>",
        "Subject": "[PATCH 08/43] telemetry: replace strerror",
        "Date": "Tue, 14 Nov 2023 16:25:04 +0800",
        "Message-ID": "<20231114082539.1858594-9-huangdengdui@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20231114082539.1858594-1-huangdengdui@huawei.com>",
        "References": "<20231114082539.1858594-1-huangdengdui@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml500011.china.huawei.com (7.185.36.84)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses strerror_r() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/telemetry/telemetry.c        | 28 ++++++++++++++++++++++------\n lib/telemetry/telemetry_legacy.c |  5 ++++-\n 2 files changed, 26 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 92982842a8..03be0d342a 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -411,6 +411,9 @@ client_handler(void *sock_id)\n static void *\n socket_listener(void *socket)\n {\n+#define ERR_BUFF_SZ 256\n+\tchar err_buf[ERR_BUFF_SZ] = {0};\n+\n \twhile (1) {\n \t\tpthread_t th;\n \t\tint rc;\n@@ -433,8 +436,9 @@ socket_listener(void *socket)\n \t\trc = pthread_create(&th, NULL, s->fn,\n \t\t\t\t    (void *)(uintptr_t)s_accepted);\n \t\tif (rc != 0) {\n+\t\t\tstrerror_r(rc, err_buf, sizeof(err_buf));\n \t\t\tTMTY_LOG(ERR, \"Error with create client thread: %s\\n\",\n-\t\t\t\t strerror(rc));\n+\t\t\t\t err_buf);\n \t\t\tclose(s_accepted);\n \t\t\tif (s->num_clients != NULL)\n \t\t\t\trte_atomic_fetch_sub_explicit(s->num_clients, 1,\n@@ -467,9 +471,13 @@ unlink_sockets(void)\n static int\n create_socket(char *path)\n {\n+#define ERR_BUFF_SZ 256\n+\tchar err_buf[ERR_BUFF_SZ] = {0};\n+\n \tint sock = socket(AF_UNIX, SOCK_SEQPACKET, 0);\n \tif (sock < 0) {\n-\t\tTMTY_LOG(ERR, \"Error with socket creation, %s\\n\", strerror(errno));\n+\t\tstrerror_r(errno, err_buf, sizeof(err_buf));\n+\t\tTMTY_LOG(ERR, \"Error with socket creation, %s\\n\", err_buf);\n \t\treturn -1;\n \t}\n \n@@ -499,14 +507,16 @@ create_socket(char *path)\n \t\tTMTY_LOG(DEBUG, \"Attempting unlink and retrying bind\\n\");\n \t\tunlink(sun.sun_path);\n \t\tif (bind(sock, (void *) &sun, sizeof(sun)) < 0) {\n-\t\t\tTMTY_LOG(ERR, \"Error binding socket: %s\\n\", strerror(errno));\n+\t\t\tstrerror_r(errno, err_buf, sizeof(err_buf));\n+\t\t\tTMTY_LOG(ERR, \"Error binding socket: %s\\n\", err_buf);\n \t\t\tclose(sock);\n \t\t\treturn -errno; /* if unlink failed, this will be -EADDRINUSE as above */\n \t\t}\n \t}\n \n \tif (listen(sock, 1) < 0) {\n-\t\tTMTY_LOG(ERR, \"Error calling listen for socket: %s\\n\", strerror(errno));\n+\t\tstrerror_r(errno, err_buf, sizeof(err_buf));\n+\t\tTMTY_LOG(ERR, \"Error calling listen for socket: %s\\n\", err_buf);\n \t\tunlink(sun.sun_path);\n \t\tclose(sock);\n \t\treturn -errno;\n@@ -531,6 +541,8 @@ set_thread_name(pthread_t id __rte_unused, const char *name __rte_unused)\n static int\n telemetry_legacy_init(void)\n {\n+#define ERR_BUFF_SZ 256\n+\tchar err_buf[ERR_BUFF_SZ] = {0};\n \tpthread_t t_old;\n \tint rc;\n \n@@ -552,8 +564,9 @@ telemetry_legacy_init(void)\n \t}\n \trc = pthread_create(&t_old, NULL, socket_listener, &v1_socket);\n \tif (rc != 0) {\n+\t\tstrerror_r(rc, err_buf, sizeof(err_buf));\n \t\tTMTY_LOG(ERR, \"Error with create legacy socket thread: %s\\n\",\n-\t\t\t strerror(rc));\n+\t\t\t err_buf);\n \t\tclose(v1_socket.sock);\n \t\tv1_socket.sock = -1;\n \t\tunlink(v1_socket.path);\n@@ -570,7 +583,9 @@ telemetry_legacy_init(void)\n static int\n telemetry_v2_init(void)\n {\n+#define ERR_BUFF_SZ 256\n \tchar spath[sizeof(v2_socket.path)];\n+\tchar err_buf[ERR_BUFF_SZ] = {0};\n \tpthread_t t_new;\n \tshort suffix = 0;\n \tint rc;\n@@ -606,8 +621,9 @@ telemetry_v2_init(void)\n \t}\n \trc = pthread_create(&t_new, NULL, socket_listener, &v2_socket);\n \tif (rc != 0) {\n+\t\tstrerror_r(rc, err_buf, sizeof(err_buf));\n \t\tTMTY_LOG(ERR, \"Error with create socket thread: %s\\n\",\n-\t\t\t strerror(rc));\n+\t\t\t err_buf);\n \t\tclose(v2_socket.sock);\n \t\tv2_socket.sock = -1;\n \t\tunlink(v2_socket.path);\ndiff --git a/lib/telemetry/telemetry_legacy.c b/lib/telemetry/telemetry_legacy.c\nindex 4c1d1c353a..3253dd9c1f 100644\n--- a/lib/telemetry/telemetry_legacy.c\n+++ b/lib/telemetry/telemetry_legacy.c\n@@ -81,6 +81,8 @@ register_client(const char *cmd __rte_unused, const char *params,\n \t\tchar *buffer __rte_unused, int buf_len __rte_unused)\n {\n #ifndef RTE_EXEC_ENV_WINDOWS\n+#define ERR_BUFF_SZ 256\n+\tchar err_buf[ERR_BUFF_SZ] = {0};\n \tpthread_t th;\n \tchar data[BUF_SIZE];\n \tint fd;\n@@ -117,8 +119,9 @@ register_client(const char *cmd __rte_unused, const char *params,\n \trc = pthread_create(&th, NULL, &legacy_client_handler,\n \t\t\t\t(void *)(uintptr_t)fd);\n \tif (rc != 0) {\n+\t\tstrerror_r(rc, err_buf, sizeof(err_buf));\n \t\tfprintf(stderr, \"Failed to create legacy client thread: %s\\n\",\n-\t\t\tstrerror(rc));\n+\t\t\terr_buf);\n \t\tclose(fd);\n \t\treturn -1;\n \t}\n",
    "prefixes": [
        "08/43"
    ]
}