Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134175/?format=api
{ "id": 134175, "url": "http://patches.dpdk.org/api/patches/134175/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113170605.408281-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113170605.408281-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113170605.408281-4-stephen@networkplumber.org", "date": "2023-11-13T17:06:05", "name": "[v2,3/3] eal: replace out of bounds VLA with static_assert", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3da2415629547cabed85a30ea750f3aa4b697af8", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113170605.408281-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 30277, "url": "http://patches.dpdk.org/api/series/30277/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30277", "date": "2023-11-13T17:06:02", "name": "use static_assertion for build errors", "version": 2, "mbox": "http://patches.dpdk.org/series/30277/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134175/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/134175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E34B24331D;\n\tMon, 13 Nov 2023 18:06:36 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8B50940DDA;\n\tMon, 13 Nov 2023 18:06:22 +0100 (CET)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id 50A4040A7F\n for <dev@dpdk.org>; Mon, 13 Nov 2023 18:06:19 +0100 (CET)", "by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-1cc68c1fac2so41235165ad.0\n for <dev@dpdk.org>; Mon, 13 Nov 2023 09:06:19 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l4-20020a170902eb0400b001c61901ed2esm4232051plb.219.2023.11.13.09.06.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Nov 2023 09:06:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699895178;\n x=1700499978; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uxAfJ8vzwr1WQklSqEm+Tn8oVVCx3fo3M3Y1fw61Dbk=;\n b=oTBcDuzhKMfQ+zpnRFmbOpyFBqwDmhye+TW7gz1RjiKsvE4kRhmhZDbYImeud1gUeZ\n SuyP+xRn2S0d+b11VpiOlR0PFQE/U4zGL0SMPBwBXPQYJqdg3huP7/VAAHyIhKfYWHUJ\n aL8UnQ0slMBQ7+pU/UuX/Eb/RbT0S7pXyMBMXB4IKxIgleVMgy5k0wAYuWf3OvLl/Y/L\n hbFm2UbHoQ5nQkyxahlSl9fBZn4aGVO9pQzryyvgX8GJT31C1rjp+Hxn3WsLlqUQ7z/u\n UJoGod4kJ4df3+Qf8WU/RgvfsS7FAIIQFsMFwUIFg+Z7aL1+hF8BkwToT0AB8k54N+Ox\n 5Qpw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1699895178; x=1700499978;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uxAfJ8vzwr1WQklSqEm+Tn8oVVCx3fo3M3Y1fw61Dbk=;\n b=XEFLTB6LvvwKVt0mf1De956ib5qilVSXHzt9oFSe4cAfM5Ns6FW5RlGpomQOvHKTS5\n 0QVOAzB3nhv8RadkvWYGCnH4aHu+sIthWpuazNkWjhwWc2Ez0eIJvRiYD+nF5Z/WSx++\n Ll9g+f3FyWMcMnqkhssDiuHGad2ZN1XsKO1slRhuH0a+2KRljPSA/ohwPipRWgGekKqT\n 7bFuj6gFw8lmYCTOjybbGOlE9cLKFdrRthBdugPytu0JUDMma1lb9XD1UgANfCZ9o11x\n yn4eWpR7pj2yM2kWMzCAes5RVb91NGb+hZMqkutQa+WW9uhOEsuIfdOO5FTgoOc3NUNe\n a3Lw==", "X-Gm-Message-State": "AOJu0YxlYk0sVrJTKaWnoaxPfc6iYTxi1RE4WApWo4Vcsrhy/NsROgIl\n /HYERJv2To2VsLIaKbSWNDn3oDxz1Lq6jDRg2MU=", "X-Google-Smtp-Source": "\n AGHT+IFSev4AIALLL5RjGSCN3tKRu0FNAqquV/Bm1UPyo1InUaV83jjm8OgAff4v7FydUo4Xpk1Nqw==", "X-Received": "by 2002:a17:902:ab89:b0:1cc:5e1b:98b5 with SMTP id\n f9-20020a170902ab8900b001cc5e1b98b5mr116768plr.66.1699895178214;\n Mon, 13 Nov 2023 09:06:18 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br?=\n\t=?utf-8?q?=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 3/3] eal: replace out of bounds VLA with static_assert", "Date": "Mon, 13 Nov 2023 09:06:05 -0800", "Message-Id": "<20231113170605.408281-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231113170605.408281-1-stephen@networkplumber.org>", "References": "<20231111172153.57461-1-stephen@networkplumber.org>\n <20231113170605.408281-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Both Gcc, clang and MSVC have better way to do compile time\nassertions rather than using out of bounds array access.\nThe old method would fail if -Wvla is enabled because compiler\ncan't determine size in that code. Also, the use of new\n_Static_assert will catch broken code that is passing non-constant\nexpression to RTE_BUILD_BUG_ON().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/include/rte_common.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h\nindex c1ba32d00e47..bea7c0e57d5e 100644\n--- a/lib/eal/include/rte_common.h\n+++ b/lib/eal/include/rte_common.h\n@@ -16,6 +16,7 @@\n extern \"C\" {\n #endif\n \n+#include <assert.h>\n #include <stdint.h>\n #include <limits.h>\n \n@@ -495,7 +496,7 @@ rte_is_aligned(const void * const __rte_restrict ptr, const unsigned int align)\n /**\n * Triggers an error at compilation time if the condition is true.\n */\n-#define RTE_BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))\n+#define RTE_BUILD_BUG_ON(condition) static_assert(!(condition), #condition)\n \n /*********** Cache line related macros ********/\n \n", "prefixes": [ "v2", "3/3" ] }