Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134155/?format=api
{ "id": 134155, "url": "http://patches.dpdk.org/api/patches/134155/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113124136.8071-1-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113124136.8071-1-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113124136.8071-1-bingz@nvidia.com", "date": "2023-11-13T12:41:36", "name": "net/mlx5: fix the LACP redirection in Rx domain", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b3091dc208844cb94c8af1bda62655637fba542b", "submitter": { "id": 1976, "url": "http://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113124136.8071-1-bingz@nvidia.com/mbox/", "series": [ { "id": 30267, "url": "http://patches.dpdk.org/api/series/30267/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30267", "date": "2023-11-13T12:41:36", "name": "net/mlx5: fix the LACP redirection in Rx domain", "version": 1, "mbox": "http://patches.dpdk.org/series/30267/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134155/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134155/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 129E6432D3;\n\tMon, 13 Nov 2023 13:42:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F2E53402F2;\n\tMon, 13 Nov 2023 13:42:00 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57])\n by mails.dpdk.org (Postfix) with ESMTP id 871FC4026C;\n Mon, 13 Nov 2023 13:41:59 +0100 (CET)", "from CY8PR12CA0042.namprd12.prod.outlook.com (2603:10b6:930:49::21)\n by DM6PR12MB4481.namprd12.prod.outlook.com (2603:10b6:5:2af::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Mon, 13 Nov\n 2023 12:41:56 +0000", "from CY4PEPF0000FCC3.namprd03.prod.outlook.com\n (2603:10b6:930:49:cafe::8b) by CY8PR12CA0042.outlook.office365.com\n (2603:10b6:930:49::21) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31 via Frontend\n Transport; Mon, 13 Nov 2023 12:41:56 +0000", "from mail.nvidia.com (216.228.117.160) by\n CY4PEPF0000FCC3.mail.protection.outlook.com (10.167.242.105) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7002.13 via Frontend Transport; Mon, 13 Nov 2023 12:41:55 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 13 Nov\n 2023 04:41:54 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 13 Nov\n 2023 04:41:51 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=AuwpP8sa2QiKv1wBBc6/e4HwqO6lsCnmlyMSVhRR2QZr1DYM5FG2GkA4w3JNKt5O/ZMwrJJA4ypTWHoOixZVL5rUOR02J4diGBJ0ztLZw/ahno4Fpr4T/lNzGJ/EzCCNNuZ+Tu41Xl8MP4fYmOZUd3tmt6hluclEIH/tgAk1oAO9nrkKB6XbxuySEDSurDm7BaeWWQtm61MQSYtpillb9SFaYGD7K5u+m9Z26C3DfhBe+hIp/EdNwzKu5WLM66aqj04PISbNMgJcLBLdzIZwWe9BOuHZ7swHWhccYjNvrBLnYOzlwdVjVLrvVi1ImrOUOkCvoxuvMePno8ht4XbMvQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=sT8x0OsdQpLd+RQjQZo13CH1WS//7dRXtdn0j/00IGA=;\n b=Pw1FFTokdFtA0/pzRSLt67xx5GX5RxOmWibXowzgObCUQxi8QXatyXhxg4xKbc1+N9UD5omXeZkK2O8R0t3utjv+7P8fH+7rZASIPb8T2zPhwTNildYFhQesj4ttdd+Pjj18hc2QUWQku351jbXpLF12st0Ohfsosw1m99+Cu6ojx90RXHbJxJQfrVZLEs48DOot0UROCm+vC+ZRTo8BbptXuCxElYjLwzuDaH8mjR07mGZSP9RW1gLZeV9QD37BUife5Gn+JVqJBPx4ay7nbBSxC95/+C4InqzdCJBZOe0it9nr6gb7XynefNeAuN+9BRo8Ali/p9DElJxDTgF8yg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=sT8x0OsdQpLd+RQjQZo13CH1WS//7dRXtdn0j/00IGA=;\n b=XzjJhcMC5WFyg/jbNL3MMvnt5zwYuecqTF/5KPQjc2gEwfGxCKj07rsauhAiEB4tdCCgzl0APNQqK/4SxRbBWHdhvlYTm1TXTrzP75OtR7PS31YK6iqIbAi/iiAUiyimZ3nwMtTeUVcuL6901ykd6Giyaan+Cow1jAfJp7gjpdsyS8xlLpiBbNzj9fbBGwVO1BS2RxQ0yxCnCK2baEJHFT5wAKIrV45DzSp/CSw0QIoTEeMFUC+hIcAzi/wgA3oGn5IiML94GJq0o2wltqCvqjqhJdq1s85knMo1zuSI82a4Cn/O675txzl1iwT6j8iNs+H2w69HPGGpnNSMasmJFw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <rasland@nvidia.com>,\n <suanmingm@nvidia.com>, <orika@nvidia.com>", "CC": "<dev@dpdk.org>, <dsosnowski@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH] net/mlx5: fix the LACP redirection in Rx domain", "Date": "Mon, 13 Nov 2023 14:41:36 +0200", "Message-ID": "<20231113124136.8071-1-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000FCC3:EE_|DM6PR12MB4481:EE_", "X-MS-Office365-Filtering-Correlation-Id": "27d437e2-123b-49c5-ac02-08dbe445ebb5", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n H1a01g4Nm8zyc4YLxoZjWbMsh58drUJriY1wkr6FdBTvZKZgm0NvHbLZ7aEQhN7PIRg4nJXmZ1OdyNqwYazoZAUK0BgLoOtQzDExI0wnt0VeNJHcKzpDJ0BjWaiCZesqPFisFhT1DMMZGS5Tof/5V/QMHjoFvZV9Yw2H+1Fqmx4LcPF3t5irJWQIW9gai7G4/ikbacKWnn3UWe9Vm09I4xACfxLIaeYmrpCKRSXQQhwEQUcvfKRs1kJ97IixdRjgUjVeYAvar3LwGetv/FdgN4OzRvFkhYcMFP0gLUKdL5omBQRnR/hL0Cv1/pYkEj6Whw84+1Tlu2dTaQGbV0CXRRSD7XxBkTE0lR7+ogJcvVRvbwwRVl8WN8ZZpS47GRfFJpoDX680wWWQJWGgtOJqTiMlQomTjvYiARb25wVqoyy0PQ003k9Py1rt82QXH2bA7WEBn4JPKITSnniIhcAKsoFGDup4Hjsv/XlMf45fvdRDvaKQQkV9JI7LJbBikgTW8Cox8AU308DhSJHIdjXFGx3pnVpp976mdGar4gmiTqFWCwSARlUt3s+kdvXnNGbp7g2NlBKbRaMn3x/C0NO3wZ1AiB3rsVij4loMzqdx9f3brMHHOI1hY22vn1F4LX+ZDYQMsOY+a/xQtlGCzj/FLZr1SGNTX7KOWfXICx+pfAtX9N0YQYib7xLbl7FVQZ3wEAW42IVNglnC+kUx3TmEEfWFySBTKLwJ/imClbOEd6mbAGxj8iWfzKk4HA5v1NHsY673SITWIJOUuvH8bWw0hVyWtp8OOw786drRi1xVEdY=", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(346002)(396003)(376002)(136003)(230922051799003)(230273577357003)(230173577357003)(451199024)(82310400011)(186009)(1800799009)(64100799003)(46966006)(36840700001)(40470700004)(36756003)(36860700001)(7636003)(356005)(426003)(336012)(41300700001)(40460700003)(83380400001)(47076005)(4326008)(7696005)(30864003)(1076003)(40480700001)(70206006)(70586007)(110136005)(55016003)(54906003)(316002)(6636002)(2616005)(5660300002)(86362001)(8936002)(6666004)(450100002)(478600001)(8676002)(6286002)(26005)(16526019)(82740400003)(2906002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Nov 2023 12:41:55.9922 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 27d437e2-123b-49c5-ac02-08dbe445ebb5", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000FCC3.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4481", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the \"lacp_by_user\" is not set from the application in bond\nmode, the LACP traffic should be handled by the kernel driver by\ndefault.\n\nThis commit adds the missing support in the template API when\n\"dv_flow_en=2\". The behavior will be the same as that in the DV\nmode with \"dv_flow_en=1\". The LACP packets will be redirected to the\nkernel when starting the steering in the NIC Rx domain.\n\nWith this commit, the DEFAULT_MISS action usage is refactored a bit.\nIn the HWS, one unique action can be created with supported bits set\nin the \"flag\" per port. The *ROOT_FDB and *HWS_FDB flag bits will\nonly be set when the port is in switchdev mode and working as the\nE-Switch manager proxy port. The SF/VF and all other representors\nwon't have the FDB flag bits when creating the DEFAULT_MISS action.\n\nFixes: 9fa7c1cddb85 (\"net/mlx5: create control flow rules with HWS\")\nCc: dsosnowski@nvidia.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 8 +-\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_flow.h | 1 +\n drivers/net/mlx5/mlx5_flow_hw.c | 249 +++++++++++++++++++++++++++++--\n drivers/net/mlx5/mlx5_trigger.c | 3 +\n 5 files changed, 249 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 07f31de5ae..ae82e1e5d8 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -474,6 +474,10 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv)\n \terr = mlx5_alloc_table_hash_list(priv);\n \tif (err)\n \t\tgoto error;\n+\tsh->default_miss_action =\n+\t\t\tmlx5_glue->dr_create_flow_action_default_miss();\n+\tif (!sh->default_miss_action)\n+\t\tDRV_LOG(WARNING, \"Default miss action is not supported.\");\n \t/* The resources below are only valid with DV support. */\n #ifdef HAVE_IBV_FLOW_DV_SUPPORT\n \t/* Init shared flex parsers list, no need lcore_share */\n@@ -600,10 +604,6 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv)\n \n \t__mlx5_discovery_misc5_cap(priv);\n #endif /* HAVE_MLX5DV_DR */\n-\tsh->default_miss_action =\n-\t\t\tmlx5_glue->dr_create_flow_action_default_miss();\n-\tif (!sh->default_miss_action)\n-\t\tDRV_LOG(WARNING, \"Default miss action is not supported.\");\n \tLIST_INIT(&sh->shared_rxqs);\n \treturn 0;\n error:\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 795748eddc..f0d63a0ba5 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1860,6 +1860,7 @@ struct mlx5_priv {\n \tstruct rte_flow_template_table *hw_esw_sq_miss_tbl;\n \tstruct rte_flow_template_table *hw_esw_zero_tbl;\n \tstruct rte_flow_template_table *hw_tx_meta_cpy_tbl;\n+\tstruct rte_flow_template_table *hw_lacp_rx_tbl;\n \tstruct rte_flow_pattern_template *hw_tx_repr_tagging_pt;\n \tstruct rte_flow_actions_template *hw_tx_repr_tagging_at;\n \tstruct rte_flow_template_table *hw_tx_repr_tagging_tbl;\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 8c0b9a4b60..6dde9de688 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -2880,6 +2880,7 @@ int mlx5_flow_hw_esw_destroy_sq_miss_flow(struct rte_eth_dev *dev,\n int mlx5_flow_hw_esw_create_default_jump_flow(struct rte_eth_dev *dev);\n int mlx5_flow_hw_create_tx_default_mreg_copy_flow(struct rte_eth_dev *dev);\n int mlx5_flow_hw_tx_repr_matching_flow(struct rte_eth_dev *dev, uint32_t sqn, bool external);\n+int mlx5_flow_hw_lacp_rx_flow(struct rte_eth_dev *dev);\n int mlx5_flow_actions_validate(struct rte_eth_dev *dev,\n \t\tconst struct rte_flow_actions_template_attr *attr,\n \t\tconst struct rte_flow_action actions[],\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex c35064518a..d72f0a66fb 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -2454,6 +2454,15 @@ __flow_hw_actions_translate(struct rte_eth_dev *dev,\n \t\t\t\t\t\t\t\t dr_pos))\n \t\t\t\tgoto err;\n \t\t\tbreak;\n+\t\tcase MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS:\n+\t\t\t/* Internal, can be skipped. */\n+\t\t\tif (!!attr->group) {\n+\t\t\t\tDRV_LOG(ERR, \"DEFAULT MISS action is only\"\n+\t\t\t\t\t\" supported in root table.\");\n+\t\t\t\tgoto err;\n+\t\t\t}\n+\t\t\tacts->rule_acts[dr_pos].action = priv->hw_def_miss;\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_END:\n \t\t\tactions_end = true;\n \t\t\tbreak;\n@@ -5531,6 +5540,34 @@ flow_hw_validate_action_push_vlan(struct rte_eth_dev *dev,\n #undef X_FIELD\n }\n \n+static int\n+flow_hw_validate_action_default_miss(struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_actions_template_attr *attr,\n+\t\t\t\t uint64_t action_flags,\n+\t\t\t\t struct rte_flow_error *error)\n+{\n+\t/*\n+\t * The private DEFAULT_MISS action is used internally for LACP in control\n+\t * flows. So this validation can be ignored. It can be kept right now since\n+\t * the validation will be done only once.\n+\t */\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\n+\tif (!attr->ingress || attr->egress || attr->transfer)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"DEFAULT MISS is only supported in ingress.\");\n+\tif (!priv->hw_def_miss)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"DEFAULT MISS action does not exist.\");\n+\tif (action_flags & MLX5_FLOW_FATE_ACTIONS)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"DEFAULT MISS should be the only termination.\");\n+\treturn 0;\n+}\n+\n static int\n mlx5_flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\t\t const struct rte_flow_actions_template_attr *attr,\n@@ -5568,7 +5605,7 @@ mlx5_flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t\t\t action,\n \t\t\t\t\t\t \"mask type does not match action type\");\n-\t\tswitch (action->type) {\n+\t\tswitch ((int)action->type) {\n \t\tcase RTE_FLOW_ACTION_TYPE_VOID:\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_INDIRECT_LIST:\n@@ -5735,6 +5772,13 @@ mlx5_flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\tcase RTE_FLOW_ACTION_TYPE_END:\n \t\t\tactions_end = true;\n \t\t\tbreak;\n+\t\tcase MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS:\n+\t\t\tret = flow_hw_validate_action_default_miss(dev, attr,\n+\t\t\t\t\t\t\t\t action_flags, error);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\taction_flags |= MLX5_FLOW_ACTION_DEFAULT_MISS;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n@@ -5754,8 +5798,7 @@ flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\t\t const struct rte_flow_action masks[],\n \t\t\t struct rte_flow_error *error)\n {\n-\treturn mlx5_flow_hw_actions_validate(dev, attr, actions, masks, NULL,\n-\t\t\t\t\t error);\n+\treturn mlx5_flow_hw_actions_validate(dev, attr, actions, masks, NULL, error);\n }\n \n \n@@ -5907,7 +5950,7 @@ flow_hw_dr_actions_template_create(struct rte_eth_dev *dev,\n \n \t\tif (curr_off >= MLX5_HW_MAX_ACTS)\n \t\t\tgoto err_actions_num;\n-\t\tswitch (at->actions[i].type) {\n+\t\tswitch ((int)at->actions[i].type) {\n \t\tcase RTE_FLOW_ACTION_TYPE_VOID:\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_INDIRECT_LIST:\n@@ -5998,6 +6041,10 @@ flow_hw_dr_actions_template_create(struct rte_eth_dev *dev,\n \t\t\t}\n \t\t\tat->dr_off[i] = cnt_off;\n \t\t\tbreak;\n+\t\tcase MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS:\n+\t\t\tat->dr_off[i] = curr_off;\n+\t\t\taction_types[curr_off++] = MLX5DR_ACTION_TYP_MISS;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\ttype = mlx5_hw_dr_action_types[at->actions[i].type];\n \t\t\tat->dr_off[i] = curr_off;\n@@ -7773,6 +7820,42 @@ flow_hw_create_tx_default_mreg_copy_pattern_template(struct rte_eth_dev *dev,\n \treturn flow_hw_pattern_template_create(dev, &tx_pa_attr, eth_all, error);\n }\n \n+/*\n+ * Creating a flow pattern template with all LACP packets matching, only for NIC\n+ * ingress domain.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * Pointer to flow pattern template on success, NULL otherwise.\n+ */\n+static struct rte_flow_pattern_template *\n+flow_hw_create_lacp_rx_pattern_template(struct rte_eth_dev *dev, struct rte_flow_error *error)\n+{\n+\tstruct rte_flow_pattern_template_attr pa_attr = {\n+\t\t.relaxed_matching = 0,\n+\t\t.ingress = 1,\n+\t};\n+\tstruct rte_flow_item_eth lacp_mask = {\n+\t\t.dst.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n+\t\t.src.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n+\t\t.type = 0xFFFF,\n+\t};\n+\tstruct rte_flow_item eth_all[] = {\n+\t\t[0] = {\n+\t\t\t.type = RTE_FLOW_ITEM_TYPE_ETH,\n+\t\t\t.mask = &lacp_mask,\n+\t\t},\n+\t\t[1] = {\n+\t\t\t.type = RTE_FLOW_ITEM_TYPE_END,\n+\t\t},\n+\t};\n+\treturn flow_hw_pattern_template_create(dev, &pa_attr, eth_all, error);\n+}\n+\n /**\n * Creates a flow actions template with modify field action and masked jump action.\n * Modify field action sets the least significant bit of REG_C_0 (usable by user-space)\n@@ -8042,6 +8125,38 @@ flow_hw_create_tx_default_mreg_copy_actions_template(struct rte_eth_dev *dev,\n \t\t\t\t\t masks, error);\n }\n \n+/*\n+ * Creating an actions template to use default miss to re-route packets to the\n+ * kernel driver stack.\n+ * On root table, only DEFAULT_MISS action can be used.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * Pointer to flow actions template on success, NULL otherwise.\n+ */\n+static struct rte_flow_actions_template *\n+flow_hw_create_lacp_rx_actions_template(struct rte_eth_dev *dev, struct rte_flow_error *error)\n+{\n+\tstruct rte_flow_actions_template_attr act_attr = {\n+\t\t.ingress = 1,\n+\t};\n+\tconst struct rte_flow_action actions[] = {\n+\t\t[0] = {\n+\t\t\t.type = (enum rte_flow_action_type)\n+\t\t\t\tMLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,\n+\t\t},\n+\t\t[1] = {\n+\t\t\t.type = RTE_FLOW_ACTION_TYPE_END,\n+\t\t},\n+\t};\n+\n+\treturn flow_hw_actions_template_create(dev, &act_attr, actions, actions, error);\n+}\n+\n /**\n * Creates a control flow table used to transfer traffic from E-Switch Manager\n * and TX queues from group 0 to group 1.\n@@ -8200,6 +8315,43 @@ flow_hw_create_ctrl_jump_table(struct rte_eth_dev *dev,\n \treturn flow_hw_table_create(dev, &cfg, &it, 1, &at, 1, error);\n }\n \n+/*\n+ * Create a table on the root group to for the LACP traffic redirecting.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param it\n+ * Pointer to flow pattern template.\n+ * @param at\n+ * Pointer to flow actions template.\n+ *\n+ * @return\n+ * Pointer to flow table on success, NULL otherwise.\n+ */\n+static struct rte_flow_template_table *\n+flow_hw_create_lacp_rx_table(struct rte_eth_dev *dev,\n+\t\t\t struct rte_flow_pattern_template *it,\n+\t\t\t struct rte_flow_actions_template *at,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tstruct rte_flow_template_table_attr attr = {\n+\t\t.flow_attr = {\n+\t\t\t.group = 0,\n+\t\t\t.priority = 0,\n+\t\t\t.ingress = 1,\n+\t\t\t.egress = 0,\n+\t\t\t.transfer = 0,\n+\t\t},\n+\t\t.nb_flows = 1,\n+\t};\n+\tstruct mlx5_flow_template_table_cfg cfg = {\n+\t\t.attr = attr,\n+\t\t.external = false,\n+\t};\n+\n+\treturn flow_hw_table_create(dev, &cfg, &it, 1, &at, 1, error);\n+}\n+\n /**\n * Creates a set of flow tables used to create control flows used\n * when E-Switch is engaged.\n@@ -8220,10 +8372,12 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *error\n \tstruct rte_flow_pattern_template *regc_sq_items_tmpl = NULL;\n \tstruct rte_flow_pattern_template *port_items_tmpl = NULL;\n \tstruct rte_flow_pattern_template *tx_meta_items_tmpl = NULL;\n+\tstruct rte_flow_pattern_template *lacp_rx_items_tmpl = NULL;\n \tstruct rte_flow_actions_template *regc_jump_actions_tmpl = NULL;\n \tstruct rte_flow_actions_template *port_actions_tmpl = NULL;\n \tstruct rte_flow_actions_template *jump_one_actions_tmpl = NULL;\n \tstruct rte_flow_actions_template *tx_meta_actions_tmpl = NULL;\n+\tstruct rte_flow_actions_template *lacp_rx_actions_tmpl = NULL;\n \tuint32_t xmeta = priv->sh->config.dv_xmeta_en;\n \tuint32_t repr_matching = priv->sh->config.repr_matching;\n \tint ret;\n@@ -8319,6 +8473,28 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *error\n \t\t\tgoto err;\n \t\t}\n \t}\n+\t/* Create LACP default miss table. */\n+\tif (!priv->sh->config.lacp_by_user && priv->pf_bond >= 0) {\n+\t\tlacp_rx_items_tmpl = flow_hw_create_lacp_rx_pattern_template(dev, error);\n+\t\tif (!lacp_rx_items_tmpl) {\n+\t\t\tDRV_LOG(ERR, \"port %u failed to create pattern template\"\n+\t\t\t\t\" for LACP Rx traffic\", dev->data->port_id);\n+\t\t\tgoto err;\n+\t\t}\n+\t\tlacp_rx_actions_tmpl = flow_hw_create_lacp_rx_actions_template(dev, error);\n+\t\tif (!lacp_rx_actions_tmpl) {\n+\t\t\tDRV_LOG(ERR, \"port %u failed to create actions template\"\n+\t\t\t\t\" for LACP Rx traffic\", dev->data->port_id);\n+\t\t\tgoto err;\n+\t\t}\n+\t\tpriv->hw_lacp_rx_tbl = flow_hw_create_lacp_rx_table(dev, lacp_rx_items_tmpl,\n+\t\t\t\t\t\t\t\t lacp_rx_actions_tmpl, error);\n+\t\tif (!priv->hw_lacp_rx_tbl) {\n+\t\t\tDRV_LOG(ERR, \"port %u failed to create template table for\"\n+\t\t\t\t\" for LACP Rx traffic\", dev->data->port_id);\n+\t\t\tgoto err;\n+\t\t}\n+\t}\n \treturn 0;\n err:\n \t/* Do not overwrite the rte_errno. */\n@@ -8327,6 +8503,10 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *error\n \t\tret = rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n \t\t\t\t\t \"Failed to create control tables.\");\n+\tif (priv->hw_tx_meta_cpy_tbl) {\n+\t\tflow_hw_table_destroy(dev, priv->hw_tx_meta_cpy_tbl, NULL);\n+\t\tpriv->hw_tx_meta_cpy_tbl = NULL;\n+\t}\n \tif (priv->hw_esw_zero_tbl) {\n \t\tflow_hw_table_destroy(dev, priv->hw_esw_zero_tbl, NULL);\n \t\tpriv->hw_esw_zero_tbl = NULL;\n@@ -8339,6 +8519,8 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *error\n \t\tflow_hw_table_destroy(dev, priv->hw_esw_sq_miss_root_tbl, NULL);\n \t\tpriv->hw_esw_sq_miss_root_tbl = NULL;\n \t}\n+\tif (lacp_rx_actions_tmpl)\n+\t\tflow_hw_actions_template_destroy(dev, lacp_rx_actions_tmpl, NULL);\n \tif (tx_meta_actions_tmpl)\n \t\tflow_hw_actions_template_destroy(dev, tx_meta_actions_tmpl, NULL);\n \tif (jump_one_actions_tmpl)\n@@ -8347,6 +8529,8 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *error\n \t\tflow_hw_actions_template_destroy(dev, port_actions_tmpl, NULL);\n \tif (regc_jump_actions_tmpl)\n \t\tflow_hw_actions_template_destroy(dev, regc_jump_actions_tmpl, NULL);\n+\tif (lacp_rx_items_tmpl)\n+\t\tflow_hw_pattern_template_destroy(dev, lacp_rx_items_tmpl, NULL);\n \tif (tx_meta_items_tmpl)\n \t\tflow_hw_pattern_template_destroy(dev, tx_meta_items_tmpl, NULL);\n \tif (port_items_tmpl)\n@@ -8998,6 +9182,7 @@ flow_hw_configure(struct rte_eth_dev *dev,\n \tstruct rte_flow_queue_attr ctrl_queue_attr = {0};\n \tbool is_proxy = !!(priv->sh->config.dv_esw_en && priv->master);\n \tint ret = 0;\n+\tuint32_t action_flags;\n \n \tif (!port_attr || !nb_queue || !queue_attr) {\n \t\trte_errno = EINVAL;\n@@ -9229,12 +9414,21 @@ flow_hw_configure(struct rte_eth_dev *dev,\n \t\tif (ret)\n \t\t\tgoto err;\n \t}\n+\t/*\n+\t * DEFAULT_MISS action have different behaviors in different domains.\n+\t * In FDB, it will steering the packets to the E-switch manager.\n+\t * In NIC Rx root, it will steering the packet to the kernel driver stack.\n+\t * An action with all bits set in the flag can be created and the HWS\n+\t * layer will translate it properly when being used in different rules.\n+\t */\n+\taction_flags = MLX5DR_ACTION_FLAG_ROOT_RX | MLX5DR_ACTION_FLAG_HWS_RX |\n+\t\t MLX5DR_ACTION_FLAG_ROOT_TX | MLX5DR_ACTION_FLAG_HWS_TX;\n+\tif (is_proxy)\n+\t\taction_flags |= (MLX5DR_ACTION_FLAG_ROOT_FDB | MLX5DR_ACTION_FLAG_HWS_FDB);\n+\tpriv->hw_def_miss = mlx5dr_action_create_default_miss(priv->dr_ctx, action_flags);\n+\tif (!priv->hw_def_miss)\n+\t\tgoto err;\n \tif (is_proxy) {\n-\t\t/* Only supported on proxy port. */\n-\t\tpriv->hw_def_miss = mlx5dr_action_create_default_miss\n-\t\t\t(priv->dr_ctx, MLX5DR_ACTION_FLAG_HWS_FDB);\n-\t\tif (!priv->hw_def_miss)\n-\t\t\tgoto err;\n \t\tret = flow_hw_create_vport_actions(priv);\n \t\tif (ret) {\n \t\t\trte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n@@ -11956,6 +12150,43 @@ mlx5_flow_hw_tx_repr_matching_flow(struct rte_eth_dev *dev, uint32_t sqn, bool e\n \t\t\t\t\titems, 0, actions, 0, &flow_info, external);\n }\n \n+int\n+mlx5_flow_hw_lacp_rx_flow(struct rte_eth_dev *dev)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tstruct rte_flow_item_eth lacp_item = {\n+\t\t.type = RTE_BE16(RTE_ETHER_TYPE_SLOW),\n+\t};\n+\tstruct rte_flow_item eth_lacp[] = {\n+\t\t[0] = {\n+\t\t\t.type = RTE_FLOW_ITEM_TYPE_ETH,\n+\t\t\t.spec = &lacp_item,\n+\t\t\t.mask = &lacp_item,\n+\t\t},\n+\t\t[1] = {\n+\t\t\t.type = RTE_FLOW_ITEM_TYPE_END,\n+\t\t},\n+\t};\n+\tstruct rte_flow_action miss_action[] = {\n+\t\t[0] = {\n+\t\t\t.type = (enum rte_flow_action_type)\n+\t\t\t\tMLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,\n+\t\t},\n+\t\t[1] = {\n+\t\t\t.type = RTE_FLOW_ACTION_TYPE_END,\n+\t\t},\n+\t};\n+\tstruct mlx5_hw_ctrl_flow_info flow_info = {\n+\t\t.type = MLX5_HW_CTRL_FLOW_TYPE_LACP_RX,\n+\t};\n+\n+\tMLX5_ASSERT(priv->master);\n+\tif (!priv->dr_ctx || !priv->hw_lacp_rx_tbl)\n+\t\treturn 0;\n+\treturn flow_hw_create_ctrl_flow(dev, dev, priv->hw_lacp_rx_tbl, eth_lacp, 0,\n+\t\t\t\t\tmiss_action, 0, &flow_info, false);\n+}\n+\n static uint32_t\n __calc_pattern_flags(const enum mlx5_flow_ctrl_rx_eth_pattern_type eth_pattern_type)\n {\ndiff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 35733b0604..5ac25d7e2d 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -1524,6 +1524,9 @@ mlx5_traffic_enable_hws(struct rte_eth_dev *dev)\n \t}\n \tif (priv->isolated)\n \t\treturn 0;\n+\tif (!priv->sh->config.lacp_by_user && priv->pf_bond >= 0)\n+\t\tif (mlx5_flow_hw_lacp_rx_flow(dev))\n+\t\t\tgoto error;\n \tif (dev->data->promiscuous)\n \t\tflags |= MLX5_CTRL_PROMISCUOUS;\n \tif (dev->data->all_multicast)\n", "prefixes": [] }