Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134148/?format=api
{ "id": 134148, "url": "http://patches.dpdk.org/api/patches/134148/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113104550.2138654-18-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113104550.2138654-18-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113104550.2138654-18-haijie1@huawei.com", "date": "2023-11-13T10:45:46", "name": "[17/21] event/cnxk: replace strtok with strtok_r", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8281c1fb4c73df67227495f3aaeca9d0bf307384", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113104550.2138654-18-haijie1@huawei.com/mbox/", "series": [ { "id": 30264, "url": "http://patches.dpdk.org/api/series/30264/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30264", "date": "2023-11-13T10:45:29", "name": "replace strtok with strtok_r", "version": 1, "mbox": "http://patches.dpdk.org/series/30264/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134148/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134148/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2967430AB;\n\tMon, 13 Nov 2023 11:52:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F02FA40ED3;\n\tMon, 13 Nov 2023 11:51:15 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id E04CD40A7F\n for <dev@dpdk.org>; Mon, 13 Nov 2023 11:51:04 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.56])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4STR1d59ZNzMmn1;\n Mon, 13 Nov 2023 18:46:29 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Mon, 13 Nov 2023 18:51:02 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>, Shijith\n Thotton <sthotton@marvell.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH 17/21] event/cnxk: replace strtok with strtok_r", "Date": "Mon, 13 Nov 2023 18:45:46 +0800", "Message-ID": "<20231113104550.2138654-18-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231113104550.2138654-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant function.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/event/cnxk/cnxk_eventdev.c | 10 ++++++----\n drivers/event/cnxk/cnxk_tim_evdev.c | 11 ++++++-----\n 2 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c\nindex 0c61f4c20eec..fe7a86797c25 100644\n--- a/drivers/event/cnxk/cnxk_eventdev.c\n+++ b/drivers/event/cnxk/cnxk_eventdev.c\n@@ -478,7 +478,8 @@ parse_queue_param(char *value, void *opaque)\n \tstruct cnxk_sso_qos queue_qos = {0};\n \tuint16_t *val = (uint16_t *)&queue_qos;\n \tstruct cnxk_sso_evdev *dev = opaque;\n-\tchar *tok = strtok(value, \"-\");\n+\tchar *sp = NULL;\n+\tchar *tok = strtok_r(value, \"-\", &sp);\n \tstruct cnxk_sso_qos *old_ptr;\n \n \tif (!strlen(value))\n@@ -486,7 +487,7 @@ parse_queue_param(char *value, void *opaque)\n \n \twhile (tok != NULL) {\n \t\t*val = atoi(tok);\n-\t\ttok = strtok(NULL, \"-\");\n+\t\ttok = strtok_r(NULL, \"-\", &sp);\n \t\tval++;\n \t}\n \n@@ -514,7 +515,8 @@ parse_stash_param(char *value, void *opaque)\n \tstruct cnxk_sso_stash queue_stash = {0};\n \tstruct cnxk_sso_evdev *dev = opaque;\n \tstruct cnxk_sso_stash *old_ptr;\n-\tchar *tok = strtok(value, \"|\");\n+\tchar *sp = NULL;\n+\tchar *tok = strtok_r(value, \"|\", &sp);\n \tuint16_t *val;\n \n \tif (!strlen(value))\n@@ -523,7 +525,7 @@ parse_stash_param(char *value, void *opaque)\n \tval = (uint16_t *)&queue_stash;\n \twhile (tok != NULL) {\n \t\t*val = atoi(tok);\n-\t\ttok = strtok(NULL, \"|\");\n+\t\ttok = strtok_r(NULL, \"|\", &sp);\n \t\tval++;\n \t}\n \ndiff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cnxk/cnxk_tim_evdev.c\nindex 6d59fdf90983..86ef7dc3d578 100644\n--- a/drivers/event/cnxk/cnxk_tim_evdev.c\n+++ b/drivers/event/cnxk/cnxk_tim_evdev.c\n@@ -420,7 +420,8 @@ cnxk_tim_parse_ring_param(char *value, void *opaque)\n {\n \tstruct cnxk_tim_evdev *dev = opaque;\n \tstruct cnxk_tim_ctl ring_ctl = {0};\n-\tchar *tok = strtok(value, \"-\");\n+\tchar *sp = NULL;\n+\tchar *tok = strtok_r(value, \"-\", &sp);\n \tstruct cnxk_tim_ctl *old_ptr;\n \tuint16_t *val;\n \n@@ -431,7 +432,7 @@ cnxk_tim_parse_ring_param(char *value, void *opaque)\n \n \twhile (tok != NULL) {\n \t\t*val = atoi(tok);\n-\t\ttok = strtok(NULL, \"-\");\n+\t\ttok = strtok_r(NULL, \"-\", &sp);\n \t\tval++;\n \t}\n \n@@ -507,16 +508,16 @@ cnxk_tim_parse_clk_list(const char *value, void *opaque)\n \t\t\t\t ROC_TIM_CLK_SRC_INVALID};\n \tstruct cnxk_tim_evdev *dev = opaque;\n \tchar *str = strdup(value);\n-\tchar *tok;\n+\tchar *tok, *sp = NULL;\n \tint i = 0;\n \n \tif (str == NULL || !strlen(str))\n \t\tgoto free;\n \n-\ttok = strtok(str, \"-\");\n+\ttok = strtok_r(str, \"-\", &sp);\n \twhile (tok != NULL && src[i] != ROC_TIM_CLK_SRC_INVALID) {\n \t\tdev->ext_clk_freq[src[i]] = strtoull(tok, NULL, 10);\n-\t\ttok = strtok(NULL, \"-\");\n+\t\ttok = strtok_r(NULL, \"-\", &sp);\n \t\ti++;\n \t}\n \n", "prefixes": [ "17/21" ] }