Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134138/?format=api
{ "id": 134138, "url": "http://patches.dpdk.org/api/patches/134138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113104550.2138654-8-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113104550.2138654-8-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113104550.2138654-8-haijie1@huawei.com", "date": "2023-11-13T10:45:36", "name": "[07/21] app/dpdk-test-flow-perf: replace strtok with strtok_r", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1d91257510cbc2dc9e037275f73133c4508e9408", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113104550.2138654-8-haijie1@huawei.com/mbox/", "series": [ { "id": 30264, "url": "http://patches.dpdk.org/api/series/30264/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30264", "date": "2023-11-13T10:45:29", "name": "replace strtok with strtok_r", "version": 1, "mbox": "http://patches.dpdk.org/series/30264/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134138/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134138/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB2EA430AB;\n\tMon, 13 Nov 2023 11:51:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 550EF40A7A;\n\tMon, 13 Nov 2023 11:51:03 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 0B7EF4064C\n for <dev@dpdk.org>; Mon, 13 Nov 2023 11:50:59 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.56])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4STR1W6h8LzMmn1;\n Mon, 13 Nov 2023 18:46:23 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Mon, 13 Nov 2023 18:50:57 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Wisam Jaddo <wisamm@nvidia.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH 07/21] app/dpdk-test-flow-perf: replace strtok with strtok_r", "Date": "Mon, 13 Nov 2023 18:45:36 +0800", "Message-ID": "<20231113104550.2138654-8-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231113104550.2138654-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant function.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n app/test-flow-perf/main.c | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex e224ef67983d..36e7c1d72019 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -602,6 +602,7 @@ read_meter_policy(char *prog, char *arg)\n {\n \tchar *token;\n \tsize_t i, j, k;\n+\tchar *sp = NULL;\n \n \tj = 0;\n \tk = 0;\n@@ -612,9 +613,9 @@ read_meter_policy(char *prog, char *arg)\n \t\ttoken = strsep(&arg, \":\\0\");\n \t}\n \tj = 0;\n-\ttoken = strtok(actions_str[0], \",\\0\");\n+\ttoken = strtok_r(actions_str[0], \",\\0\", &sp);\n \twhile (token == NULL && j < RTE_COLORS - 1)\n-\t\ttoken = strtok(actions_str[++j], \",\\0\");\n+\t\ttoken = strtok_r(actions_str[++j], \",\\0\", &sp);\n \twhile (j < RTE_COLORS && token != NULL) {\n \t\tfor (i = 0; i < RTE_DIM(flow_options); i++) {\n \t\t\tif (!strcmp(token, flow_options[i].str)) {\n@@ -628,9 +629,9 @@ read_meter_policy(char *prog, char *arg)\n \t\t\tusage(prog);\n \t\t\trte_exit(EXIT_SUCCESS, \"Invalid colored actions\\n\");\n \t\t}\n-\t\ttoken = strtok(NULL, \",\\0\");\n+\t\ttoken = strtok_r(NULL, \",\\0\", &sp);\n \t\twhile (!token && j < RTE_COLORS - 1) {\n-\t\t\ttoken = strtok(actions_str[++j], \",\\0\");\n+\t\t\ttoken = strtok_r(actions_str[++j], \",\\0\", &sp);\n \t\t\tk = 0;\n \t\t}\n \t}\n@@ -641,6 +642,7 @@ args_parse(int argc, char **argv)\n {\n \tuint64_t pm, seed;\n \tuint64_t hp_conf;\n+\tchar *sp = NULL;\n \tchar **argvopt;\n \tuint32_t prio;\n \tchar *token;\n@@ -804,7 +806,7 @@ args_parse(int argc, char **argv)\n \t\t\t\t\t\tRTE_FLOW_ACTION_TYPE_RAW_ENCAP\n \t\t\t\t\t);\n \n-\t\t\t\ttoken = strtok(optarg, \",\");\n+\t\t\t\ttoken = strtok_r(optarg, \",\", &sp);\n \t\t\t\twhile (token != NULL) {\n \t\t\t\t\tfor (i = 0; i < RTE_DIM(flow_options); i++) {\n \t\t\t\t\t\tif (strcmp(flow_options[i].str, token) == 0) {\n@@ -817,7 +819,7 @@ args_parse(int argc, char **argv)\n \t\t\t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t\t\t\"Invalid encap item: %s\\n\", token);\n \t\t\t\t\t}\n-\t\t\t\t\ttoken = strtok(NULL, \",\");\n+\t\t\t\t\ttoken = strtok_r(NULL, \",\", &sp);\n \t\t\t\t}\n \t\t\t\tprintf(\" / \");\n \t\t\t}\n@@ -828,7 +830,7 @@ args_parse(int argc, char **argv)\n \t\t\t\t\t\tRTE_FLOW_ACTION_TYPE_RAW_DECAP\n \t\t\t\t\t);\n \n-\t\t\t\ttoken = strtok(optarg, \",\");\n+\t\t\t\ttoken = strtok_r(optarg, \",\", &sp);\n \t\t\t\twhile (token != NULL) {\n \t\t\t\t\tfor (i = 0; i < RTE_DIM(flow_options); i++) {\n \t\t\t\t\t\tif (strcmp(flow_options[i].str, token) == 0) {\n@@ -841,7 +843,7 @@ args_parse(int argc, char **argv)\n \t\t\t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t\t\t\"Invalid decap item %s\\n\", token);\n \t\t\t\t\t}\n-\t\t\t\t\ttoken = strtok(NULL, \",\");\n+\t\t\t\t\ttoken = strtok_r(NULL, \",\", &sp);\n \t\t\t\t}\n \t\t\t\tprintf(\" / \");\n \t\t\t}\n@@ -910,10 +912,10 @@ args_parse(int argc, char **argv)\n \t\t\t\tuint16_t port_idx = 0;\n \t\t\t\tchar *token;\n \n-\t\t\t\ttoken = strtok(optarg, \",\");\n+\t\t\t\ttoken = strtok_r(optarg, \",\", &sp);\n \t\t\t\twhile (token != NULL) {\n \t\t\t\t\tdst_ports[port_idx++] = atoi(token);\n-\t\t\t\t\ttoken = strtok(NULL, \",\");\n+\t\t\t\t\ttoken = strtok_r(NULL, \",\", &sp);\n \t\t\t\t}\n \t\t\t}\n \t\t\tif (strcmp(lgopts[opt_idx].name, \"rxq\") == 0) {\n", "prefixes": [ "07/21" ] }