Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134085,
    "url": "http://patches.dpdk.org/api/patches/134085/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231110094938.21171-1-viacheslavo@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231110094938.21171-1-viacheslavo@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231110094938.21171-1-viacheslavo@nvidia.com",
    "date": "2023-11-10T09:49:38",
    "name": "[1/1] net/mlx5: fix inline data length for multisegment packets",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "528f94f7ba85dc0b78da7758475838ce2a4e2061",
    "submitter": {
        "id": 1926,
        "url": "http://patches.dpdk.org/api/people/1926/?format=api",
        "name": "Slava Ovsiienko",
        "email": "viacheslavo@nvidia.com"
    },
    "delegate": {
        "id": 3268,
        "url": "http://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231110094938.21171-1-viacheslavo@nvidia.com/mbox/",
    "series": [
        {
            "id": 30241,
            "url": "http://patches.dpdk.org/api/series/30241/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30241",
            "date": "2023-11-10T09:49:38",
            "name": "[1/1] net/mlx5: fix inline data length for multisegment packets",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/30241/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/134085/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/134085/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96511432F3;\n\tFri, 10 Nov 2023 10:50:18 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7887B40291;\n\tFri, 10 Nov 2023 10:50:18 +0100 (CET)",
            "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2069.outbound.protection.outlook.com [40.107.237.69])\n by mails.dpdk.org (Postfix) with ESMTP id C39F440268;\n Fri, 10 Nov 2023 10:50:17 +0100 (CET)",
            "from CH0PR03CA0021.namprd03.prod.outlook.com (2603:10b6:610:b0::26)\n by CH3PR12MB8511.namprd12.prod.outlook.com (2603:10b6:610:15c::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Fri, 10 Nov\n 2023 09:50:15 +0000",
            "from DS2PEPF0000343C.namprd02.prod.outlook.com\n (2603:10b6:610:b0:cafe::d7) by CH0PR03CA0021.outlook.office365.com\n (2603:10b6:610:b0::26) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19 via Frontend\n Transport; Fri, 10 Nov 2023 09:50:15 +0000",
            "from mail.nvidia.com (216.228.117.161) by\n DS2PEPF0000343C.mail.protection.outlook.com (10.167.18.39) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6977.16 via Frontend Transport; Fri, 10 Nov 2023 09:50:15 +0000",
            "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 10 Nov\n 2023 01:50:04 -0800",
            "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 10 Nov\n 2023 01:50:02 -0800"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hsaOegk1VmQ4R1xgzoWJpo/MQOxMWMLZjEGq/2KnDUX2D12Hf6XzPLT9l/A4VcWF/dcJTbFMDDZrgalpwz9VnYN9swY/lc4bwhe3teSVy6f8dxOoOAwDa71KjEySaVJVLZJKV/wpkl5Ne7gjH1iskMJ034Jnj/DaMguQt5Us46EHxGDghI95IF0rMQ6amr+N84Qf0ZT6/yEFOR1OQEM6OHZE2JHJZEIdPopq4DPuBoIZjmapWg75L+DM+dOQAw1tmqI0jddmEp9p4hh02KBu9nhEoHFUYGZNnniT3N7dkWVh0XC9X41w2EzRpwsd99dLm9+B8mfUqnU924O75x376g==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=gbIC/0J8V17YSVs9N7eJdmkn5yriyPJeFBGsf9sG4do=;\n b=JEZZVq25+ZrZ76aX0LfXLBKzXQHUmFC7iDqLCVx3sAP/FS99G/Y8geAzmwjG5SN6p2uGepNqDmtuz36Mk/b2bhwuA6Dc3EslC1vIJOnyYgqGDyUXuNdf2qmOhkjnuX4lo68YjoqaepUaAjAl5chNa2yfg7HiMlMXiqKFr/VRo5aWLuB4t78OZHL35boBPa+H60CXX8hkGQgCIvhDy8SP6vK/rE/gADjSWgywIun0FIV2tvYxK2/sWDZPWVqNqnCYkB+TuARZC5QsqH/aRMsWom5YB4JnvHudyBWSQCO1i5TmiWXJtDiwBhg+OiefelWokmUa+xvmniH5W61bD98dtg==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=gbIC/0J8V17YSVs9N7eJdmkn5yriyPJeFBGsf9sG4do=;\n b=YcLdLKNgmOIW5xEd+FcO45JCMWVbsuDaMUC5TAezVL2ud4nL9jKUyuEZvEMAUpBb6wQbJPTsQ6e8CqyuU8oGsk3phyMvx7gUIZZG9ib/EeOKSo5GKnT0nQvzPbGdGngxrwZvfswxOwBH/8iHmwF/9WWXKgwErIphN9Ivm9djD0ai4H6a4tAX+mlEDw245FE8iDdI8o8k5jRh/Tlfm8DBBdFKf2I9wZbs6qSOz0J+qaCCZGO+xk1YoRubqqRGHO2537SMoK8rsHgddlyHnyJhg9G1EJ/lcxrvZ0jR4T+mqr+KU/lvy8wxCB3tzhXv+eM9hDwvcBDyD4emOZw62gz49w==",
        "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;",
        "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C",
        "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<rasland@nvidia.com>, <matan@nvidia.com>, <suanmingm@nvidia.com>,\n <stable@dpdk.org>",
        "Subject": "[PATCH 1/1] net/mlx5: fix inline data length for multisegment packets",
        "Date": "Fri, 10 Nov 2023 11:49:38 +0200",
        "Message-ID": "<20231110094938.21171-1-viacheslavo@nvidia.com>",
        "X-Mailer": "git-send-email 2.18.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.126.231.35]",
        "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)",
        "X-EOPAttributedMessage": "0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "DS2PEPF0000343C:EE_|CH3PR12MB8511:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "b6d5cb7f-db18-44de-0be2-08dbe1d270f7",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n 8pLOtN5t8IrPWjaJLV4jeJQalbSYmkaklZ3Ex3Ff9xnjhKo1X0XdNz+S7ihI7rv9GrLB/y+/nDDwjr87RPOK73Gnvr1L9UbOpRDnEZkEZOsjaukEXS6Dvsa7D3kOWPHDLTAsbZSRpyeA/om5uaNoeYKzdcKdTVpZL/sRzXr9w6R4LJH2MXAT3UUkBx641pMcoCjyLgPN2LZ0POyzlWq/iA/x3IMjQ1LfvXdgR/pHP8sZrKWw/n283c7z5OiaNxBS+RIUMxjchTI9m9+KqxXiskEFtlQwQA73jUlqiyV5acFXWwbg0NudKHe+u0jJ1q64ZJ/5S0IXmNUjiIKGs5RDjgvg3DiVF6YvtuQJneIDZxyu9LZkYWEh5L5anRZpdVKeCwPjiwrYBAYFm0rA187QiBPBDAdPCN7zGf/QbPZa9VvuYFxWGoD98wQkAyZZWOyaEcgNk0Gu5MU9bdmL0bLJgajWt0iC8zQqLrU9Ao6HQNqP5W2oeNekSbUXZ36vMIN/HnMF1NX33fwYqWm0tyFguK0fBi7qEFikIVKSHEG98CJ81EgBkNNzB4M86xgfEoePcS0VbbUItuFfAUdG93g5wNd/48sC9DwqN9WcBXEGocGuBTZAvwGaHys4XmXltTfr2GJ+pJEsER1vqpOOpuscGtP68KvsCdOQgs6+xmd3tPkljIwEqRrSN7XF/QgLkiDtzvF1qgLHS8cy1Go+tB3J00wwZ1pPA/dbVkVGLsRkcRCtDfed8YlPB9Eu7r/6D806",
        "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(136003)(39860400002)(346002)(376002)(230922051799003)(451199024)(1800799009)(82310400011)(186009)(64100799003)(40470700004)(46966006)(36840700001)(2906002)(47076005)(36860700001)(40460700003)(82740400003)(7636003)(356005)(478600001)(6916009)(41300700001)(8676002)(450100002)(7696005)(4326008)(54906003)(6666004)(316002)(70586007)(70206006)(8936002)(426003)(336012)(5660300002)(6286002)(26005)(16526019)(2616005)(1076003)(83380400001)(86362001)(36756003)(40480700001)(55016003);\n DIR:OUT; SFP:1101;",
        "X-OriginatorOrg": "Nvidia.com",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Nov 2023 09:50:15.6115 (UTC)",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b6d5cb7f-db18-44de-0be2-08dbe1d270f7",
        "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a",
        "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]",
        "X-MS-Exchange-CrossTenant-AuthSource": "\n DS2PEPF0000343C.namprd02.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH3PR12MB8511",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "If packet data length exceeds the configured limit for packet\nto be inlined in the queue descriptor the driver checks if hardware\nrequires to do minimal data inline or the VLAN insertion offload is\nrequested and not supported in hardware (that means we have to do VLAN\ninsertion in software with inline data). Then driver scans the mbuf\nchain to find the minimal segment amount to satisfy the data needed\nfor minimal inline.\n\nThere was incorrect first segment inline data length calculation\nwith missing VLAN header being inserted, that could lead to the\nsegmentation fault in the mbuf chain scanning, for example for\nthe packets:\n\n  packet:\n    mbuf0 pkt_len = 288, data_len = 156\n    mbuf1 pkt_len = 132, data_len = 132\n\n  txq->inlen_send = 290\n\nThe driver was trying to reach the inlen_send inline data length\nwith missing VLAN header length added and was running out of the\nmbuf chain (there were just not enough data in the packet to satisfy\nthe criteria).\n\nFixes: 18a1c20044c0 (\"net/mlx5: implement Tx burst template\")\nFixes: ec837ad0fc7c (\"net/mlx5: fix multi-segment inline for the first segments\")\nCc: stable@dpdk.org\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\nAcked-by: Suanming Mou <suanmingm@nvidia.com>\n\nwith '#' will be ignored, and an empty message aborts the commit.  # #\nDate:      Fri Nov 10 11:12:14 2023 +0200 # # On branch tx_fix_firstseg\n---\n drivers/net/mlx5/mlx5_tx.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h\nindex 264cc192dc..e59ce37667 100644\n--- a/drivers/net/mlx5/mlx5_tx.h\n+++ b/drivers/net/mlx5/mlx5_tx.h\n@@ -2046,7 +2046,7 @@ mlx5_tx_packet_multi_inline(struct mlx5_txq_data *__rte_restrict txq,\n \t\tuintptr_t start;\n \n \t\tmbuf = loc->mbuf;\n-\t\tnxlen = rte_pktmbuf_data_len(mbuf);\n+\t\tnxlen = rte_pktmbuf_data_len(mbuf) + vlan;\n \t\t/*\n \t\t * Packet length exceeds the allowed inline data length,\n \t\t * check whether the minimal inlining is required.\n",
    "prefixes": [
        "1/1"
    ]
}