Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133943/?format=api
{ "id": 133943, "url": "http://patches.dpdk.org/api/patches/133943/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231107163926.55825-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231107163926.55825-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231107163926.55825-1-bruce.richardson@intel.com", "date": "2023-11-07T16:39:26", "name": "test/eventdev: avoid configuring port or queue twice", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ac38fdd871ca6e519794bbf034269bf5eb9606b9", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231107163926.55825-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30188, "url": "http://patches.dpdk.org/api/series/30188/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30188", "date": "2023-11-07T16:39:26", "name": "test/eventdev: avoid configuring port or queue twice", "version": 1, "mbox": "http://patches.dpdk.org/series/30188/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133943/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B620C432C8;\n\tTue, 7 Nov 2023 17:39:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9A44940E78;\n\tTue, 7 Nov 2023 17:39:37 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id AC3C4402D4\n for <dev@dpdk.org>; Tue, 7 Nov 2023 17:39:35 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Nov 2023 08:39:34 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.164])\n by fmsmga005.fm.intel.com with ESMTP; 07 Nov 2023 08:39:33 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1699375175; x=1730911175;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=9BHwD4IBOLBzj940hvg+YVGHMBA5RMTyBuzozLgcRfk=;\n b=L5Tf9XEMBHh4RPgisefrXWcNr6WmlQ11K+hfD6xaMx0OuJDvYQyeciwp\n mUdD6d9gBrQtJvFmyLfOCArEX9Kfaq5a0k96ulv1cZbNHVOh5uNEfUX47\n prKMGcdct0FTfliWb+Gl+Yr6Idzx1P/vcPqvM9fqEFMacSKdYJonWx2UT\n huC3XK9g6GEGq1lh+mlbVHL3Ky7cxjrtlqe2zrSM6e6Lordz6jeb766TG\n vqo5FkK7QRU067yG5ETmlwJiMCYI8i+bBqcqe6K98G9nMiYyWRcznUvjO\n FFhe6IGPyme/4XLPcwkMNnhzzScNMlh/SFJ5z6F1jqlo6nxHo7fthHAw6 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10887\"; a=\"389354873\"", "E=Sophos;i=\"6.03,284,1694761200\"; d=\"scan'208\";a=\"389354873\"", "E=McAfee;i=\"6600,9927,10887\"; a=\"1094208178\"", "E=Sophos;i=\"6.03,284,1694761200\"; d=\"scan'208\";a=\"1094208178\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Jerin Jacob <jerinj@marvell.com>", "Subject": "[PATCH] test/eventdev: avoid configuring port or queue twice", "Date": "Tue, 7 Nov 2023 16:39:26 +0000", "Message-Id": "<20231107163926.55825-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the basic sanity tests of eventdev for queue and port setup, queue 0\nwas configured separately before running a loop to configure the rest of\nthe queues. This loop started from 0, so reconfigured queue 0, and a\nsimilar reconfiguration happens with port 0 in the later port setup\ntest. While most eventdevs should handle this reconfiguration without\nstop/start correctly, it can cause issues, and should be tested\nseparately from basic config tests.\n\nTherefore, adjust loops to start at 1 rather than 0 and avoid\nconfiguring queue 0 and port 0 twice.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_eventdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c\nindex 993e49af3b..71de947ce4 100644\n--- a/app/test/test_eventdev.c\n+++ b/app/test/test_eventdev.c\n@@ -313,7 +313,7 @@ test_eventdev_queue_setup(void)\n \t\t\t RTE_EVENT_DEV_ATTR_QUEUE_COUNT, &queue_count),\n \t\t\t \"Queue count get failed\");\n \n-\tfor (i = 0; i < (int)queue_count; i++) {\n+\tfor (i = 1; i < (int)queue_count; i++) {\n \t\tret = rte_event_queue_setup(TEST_DEV_ID, i, NULL);\n \t\tTEST_ASSERT_SUCCESS(ret, \"Failed to setup queue%d\", i);\n \t}\n@@ -786,7 +786,7 @@ test_eventdev_port_setup(void)\n \t\t\t\tRTE_EVENT_DEV_ATTR_PORT_COUNT,\n \t\t\t\t&port_count), \"Port count get failed\");\n \n-\tfor (i = 0; i < (int)port_count; i++) {\n+\tfor (i = 1; i < (int)port_count; i++) {\n \t\tret = rte_event_port_setup(TEST_DEV_ID, i, NULL);\n \t\tTEST_ASSERT_SUCCESS(ret, \"Failed to setup port%d\", i);\n \t}\n", "prefixes": [] }