Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133424/?format=api
{ "id": 133424, "url": "http://patches.dpdk.org/api/patches/133424/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231026134313.1165954-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231026134313.1165954-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20231026134313.1165954-2-thomas@monjalon.net", "date": "2023-10-26T13:37:41", "name": "[v4,1/2] eal: add thread yield functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "36f6230be18b81f9af83c0dfc808b13743cc1572", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231026134313.1165954-2-thomas@monjalon.net/mbox/", "series": [ { "id": 30005, "url": "http://patches.dpdk.org/api/series/30005/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30005", "date": "2023-10-26T13:37:40", "name": "allow creating thread with real-time priority", "version": 4, "mbox": "http://patches.dpdk.org/series/30005/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133424/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133424/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B23AA43208;\n\tThu, 26 Oct 2023 15:43:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ADA4342E25;\n\tThu, 26 Oct 2023 15:43:39 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0E6874003C\n for <dev@dpdk.org>; Thu, 26 Oct 2023 15:43:24 +0200 (CEST)", "from compute6.internal (compute6.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id A544E5C0297;\n Thu, 26 Oct 2023 09:43:22 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute6.internal (MEProxy); Thu, 26 Oct 2023 09:43:22 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Thu,\n 26 Oct 2023 09:43:21 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:date:date:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to; s=fm3; t=1698327802; x=\n 1698414202; bh=tJsoq4osbhl3cBjkpLzoGK3txAEtcCtD4Bqu//R44yc=; b=E\n wYHq6HWdzKJHMzJR/fCnQXDgI9HDvjwxCJ95+xN6ab4VU5ly0w/5sJxfZtMI+Gfr\n kTFySAJ+n7TeFwcHMWtqsCG6CVF89QmQrCLILARqqDf2usyf4WhVIAoQepzxuCDX\n HUNNPrOKlN2cDUrvLZAvaDFD9+yiNoAxUrejtrkNrwZrML/EMAh/S2OibitS8Y/m\n vXnCiu9aqVOUm9Rb3N8yBzWledVllThw21XpyLVNXuPPQ/uCOmcQ190IMzdKrA9v\n oARuV6/ga+Ig/frxmNlm7ONwCdsYumQRXhWHClaE6ENr1DASrHn6zKMdWHzEQfHj\n KqKzhh/4KuMzU0NkIgk1Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1698327802; x=\n 1698414202; bh=tJsoq4osbhl3cBjkpLzoGK3txAEtcCtD4Bqu//R44yc=; b=S\n JZ5NOTQ1E6bF1awf0okioEQzq+Yjl4b3BLFgxTl/IoOXe+upxGi4JcK3l31P76jD\n M/d08Sca10etSB8MJvEf8w6RqpaeN+f2iXT3FuAPOpdq3jVUMryGCD5X4NzgXsUm\n GofNNh+tQNXo6o/5zk2DEhSTZjCLRa/uDWMALxeVlpPG0YvQf+yzm96LMH1Uh+rl\n 8BQEHsPRoTu27jm3EGDFj8caHteIu5zqtdVEWfrkn6b0QOjgaEiscLtlZXRqbcBh\n MpTEppv4Na1yZe3oUe6T4hbxW+0GDTTMM50hU57/GU+S3GcRvBnXuEC9oF3Da4Ns\n 5Ugn1aud5ludEN57DlMvw==" ], "X-ME-Sender": "<xms:-mw6ZW-WphtWFaXwcYg2gvTPpAGZcMbjxpHhJ7BWjNjn_ecoJOdGrQ>\n <xme:-mw6ZWvjX6kf249ZIf2n2MjbDd24AIqZTaQcibtaC27mNjAKz_-q5KR1nkPeoFQJL\n _T4gOBCBpablFrTiA>", "X-ME-Received": "\n <xmr:-mw6ZcBOKqw0fPMg7Re_BtxNn-6JanhSuqb5jIDoRKo9rgMw00LQPBCuNmrw6PJgEhJQ3Gd-bq2RPr9McMOnqGZVocKq7rQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvkedrledvgdeikecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek\n hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh\n homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:-mw6Zedzp653_YR_lb9IBiiAEzPt4eLERG8hLtWRV6RnlvBSXUGx5Q>\n <xmx:-mw6ZbOnpTZmzpTJ2xSWGZSUr9qJ375wKyfvur14q0daua000iJQ2g>\n <xmx:-mw6ZYnVHW1AoyCVNce5tutadnoW_LWVCr5GKYjF4lr_JhXuGOj23w>\n <xmx:-mw6ZQqCF2ZSDju7upp6wfhFzhH1X0ylaW1cEBScUgh0gqimySpJoQ>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v4 1/2] eal: add thread yield functions", "Date": "Thu, 26 Oct 2023 15:37:41 +0200", "Message-ID": "<20231026134313.1165954-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231026134313.1165954-1-thomas@monjalon.net>", "References": "<20231024125416.798897-1-thomas@monjalon.net>\n <20231026134313.1165954-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When running real-time threads, we may need to force scheduling\nkernel threads or other real-time threads.\nNew functions are added to address these cases.\n\nThe yield functions should not have any interest for normal threads.\nNote: other purposes may be addressed with rte_pause() or rte_delay_*().\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/eal/include/rte_thread.h | 25 +++++++++++++++++++++++++\n lib/eal/unix/rte_thread.c | 17 +++++++++++++++++\n lib/eal/version.map | 4 ++++\n lib/eal/windows/rte_thread.c | 15 +++++++++++++++\n 4 files changed, 61 insertions(+)", "diff": "diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 8da9d4d3fb..f2581fe152 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -183,6 +183,31 @@ int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr);\n */\n int rte_thread_detach(rte_thread_t thread_id);\n \n+/**\n+ * Allow another thread to run on the same CPU core.\n+ *\n+ * This is a scheduler request, with minimum latency.\n+ * Lower priority threads may not be scheduled.\n+ *\n+ * Especially useful in real-time thread priority\n+ * to schedule other real-time threads.\n+ * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL\n+ */\n+__rte_experimental\n+void rte_thread_yield(void);\n+\n+/**\n+ * Unblock a CPU core running busy in a real-time thread.\n+ *\n+ * This is a sleep call, giving priority to all other threads.\n+ *\n+ * Especially useful in real-time thread priority\n+ * to avoid a busy loop blocking vital threads on a core.\n+ * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL\n+ */\n+__rte_experimental\n+void rte_thread_yield_realtime(void);\n+\n /**\n * Get the id of the calling thread.\n *\ndiff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c\nindex 36a21ab2f9..d0758f23bb 100644\n--- a/lib/eal/unix/rte_thread.c\n+++ b/lib/eal/unix/rte_thread.c\n@@ -5,9 +5,11 @@\n \n #include <errno.h>\n #include <pthread.h>\n+#include <sched.h>\n #include <stdbool.h>\n #include <stdlib.h>\n #include <string.h>\n+#include <time.h>\n \n #include <rte_errno.h>\n #include <rte_log.h>\n@@ -227,6 +229,21 @@ rte_thread_detach(rte_thread_t thread_id)\n \treturn pthread_detach((pthread_t)thread_id.opaque_id);\n }\n \n+void\n+rte_thread_yield(void)\n+{\n+\tsched_yield();\n+}\n+\n+void\n+rte_thread_yield_realtime(void)\n+{\n+\t/* A simple yield may not be enough to schedule kernel threads. */\n+\tstruct timespec wait = {.tv_nsec = 1000};\n+\tnanosleep(&wait, NULL);\n+\tusleep\n+}\n+\n int\n rte_thread_equal(rte_thread_t t1, rte_thread_t t2)\n {\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex e00a844805..b81ac3e3af 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -413,6 +413,10 @@ EXPERIMENTAL {\n \t# added in 23.07\n \trte_memzone_max_get;\n \trte_memzone_max_set;\n+\n+\t# added in 23.11\n+\trte_thread_yield;\n+\trte_thread_yield_realtime;\n };\n \n INTERNAL {\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex acf648456c..ea17b5de3d 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -304,6 +304,21 @@ rte_thread_detach(rte_thread_t thread_id)\n \treturn 0;\n }\n \n+void\n+rte_thread_yield(void)\n+{\n+\tSwitchToThread();\n+}\n+\n+void\n+rte_thread_yield_realtime(void)\n+{\n+\t/* Real-time threads are not causing problems on Windows.\n+\t * A simple sleep should be more than enough.\n+\t */\n+\tSleep(0);\n+}\n+\n int\n rte_thread_equal(rte_thread_t t1, rte_thread_t t2)\n {\n", "prefixes": [ "v4", "1/2" ] }