Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 13334,
    "url": "http://patches.dpdk.org/api/patches/13334/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1465379011-24646-5-git-send-email-nelio.laranjeiro@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1465379011-24646-5-git-send-email-nelio.laranjeiro@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1465379011-24646-5-git-send-email-nelio.laranjeiro@6wind.com",
    "date": "2016-06-08T09:43:28",
    "name": "[dpdk-dev,4/7] mlx5: fix RX VLAN stripping capability check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "15147fa4ed1683060761bfdcd92452a27bad8446",
    "submitter": {
        "id": 243,
        "url": "http://patches.dpdk.org/api/people/243/?format=api",
        "name": "Nélio Laranjeiro",
        "email": "nelio.laranjeiro@6wind.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patches.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1465379011-24646-5-git-send-email-nelio.laranjeiro@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/13334/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/13334/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AA2E59AD6;\n\tWed,  8 Jun 2016 11:44:43 +0200 (CEST)",
            "from mail-wm0-f49.google.com (mail-wm0-f49.google.com\n\t[74.125.82.49]) by dpdk.org (Postfix) with ESMTP id CC8469AC6\n\tfor <dev@dpdk.org>; Wed,  8 Jun 2016 11:44:40 +0200 (CEST)",
            "by mail-wm0-f49.google.com with SMTP id k184so15496211wme.1\n\tfor <dev@dpdk.org>; Wed, 08 Jun 2016 02:44:40 -0700 (PDT)",
            "from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\txw8sm479085wjb.30.2016.06.08.02.44.39\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 08 Jun 2016 02:44:40 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=6ZSnI6UMGq6lCMvXk+MG4tet+2dF7RtFuGi4d1jtBVU=;\n\tb=IdBO1TCtWklDpBYXgMPadXxrIHFgIog72yO/cnuol2aPAmMQmuR42mWUZNBgAA4NjU\n\tBstb6arOuctaW0lAJLQR7QKTurqKlIR65T8smRl1Y/lIEPpoUGMWH1dOKSk/FjCV2BJ7\n\txjGYae1ppeYCt42tfGaeCZb5UTMno0gOIzjGyZ9k9iN74HqvcuPxxTk6sO2ydUQFel1H\n\taNOeeLadOqz3cDFu9BujN5nwAS2Ydic26l8z8/kpEmxubXnZV3oZXLMnTFiL4jSw2a5E\n\tGS/FKqlqqceiHv4wL6U1PUHzdKJk+quzMcIWqBqIePs4Gj4Q4JaO4fh1JduwpyhYBzlq\n\tPnHw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=6ZSnI6UMGq6lCMvXk+MG4tet+2dF7RtFuGi4d1jtBVU=;\n\tb=PIgTQCu4qFItZ+n5vxkE9grvb+OJXZB1K8Lvb4A00wddgUgYhZwCmUT98qPhmINxXH\n\tH3ZyLUeGKqRH0OKr2NP/R+gwULE2bDUFDT0rlZCCCS+2SWdDI6/b+IQDDgKpnodQl74A\n\tWdUEUOjYLkMV0GP58rdZvkvlAjTBDsPRMW2iPqUHJigUw8mK6aFVR6HbAJoa+9BYBv+o\n\tFcnxpqlJMz8nnhujc33191tUbEbPjv74PR54Al4WDlXVgt48q6rf67Qdaj0w//du9QW6\n\tj98ovoiYQ90gsCP+U9uurBXyFZ07XWpVH43EoBipBfs3r+cNmExFQMcmNEL7VOAGwKYH\n\tifKw==",
        "X-Gm-Message-State": "ALyK8tLrrtfxJ/w/lHe4IVSnuEV36A6+WVx1mdBd8kck3MhK4TvhleYzwYyyquL3tOF7WzW1",
        "X-Received": "by 10.194.3.51 with SMTP id 19mr3822485wjz.57.1465379080642;\n\tWed, 08 Jun 2016 02:44:40 -0700 (PDT)",
        "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "Date": "Wed,  8 Jun 2016 11:43:28 +0200",
        "Message-Id": "<1465379011-24646-5-git-send-email-nelio.laranjeiro@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1465379011-24646-1-git-send-email-nelio.laranjeiro@6wind.com>",
        "References": "<1465379011-24646-1-git-send-email-nelio.laranjeiro@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 4/7] mlx5: fix RX VLAN stripping capability check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n\nA hardware capability check is missing before enabling RX VLAN stripping\nduring queue setup.\n\nAlso, while dev_conf.rxmode.hw_vlan_strip is currently a single bit that\ncan be stored in priv->hw_vlan_strip directly, it should be interpreted as\na boolean value for safety.\n\nFixes: f3db9489188a (\"mlx5: support Rx VLAN stripping\")\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxq.c  | 3 ++-\n drivers/net/mlx5/mlx5_vlan.c | 2 +-\n 2 files changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 469ba98..0bcf55b 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1222,7 +1222,8 @@ rxq_setup(struct rte_eth_dev *dev, struct rxq *rxq, uint16_t desc,\n \tDEBUG(\"priv->device_attr.max_sge is %d\",\n \t      priv->device_attr.max_sge);\n \t/* Configure VLAN stripping. */\n-\ttmpl.vlan_strip = dev->data->dev_conf.rxmode.hw_vlan_strip;\n+\ttmpl.vlan_strip = (priv->hw_vlan_strip &&\n+\t\t\t   !!dev->data->dev_conf.rxmode.hw_vlan_strip);\n \tattr.wq = (struct ibv_exp_wq_init_attr){\n \t\t.wq_context = NULL, /* Could be useful in the future. */\n \t\t.wq_type = IBV_EXP_WQT_RQ,\ndiff --git a/drivers/net/mlx5/mlx5_vlan.c b/drivers/net/mlx5/mlx5_vlan.c\nindex ea7af1e..ff40538 100644\n--- a/drivers/net/mlx5/mlx5_vlan.c\n+++ b/drivers/net/mlx5/mlx5_vlan.c\n@@ -218,7 +218,7 @@ mlx5_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \tunsigned int i;\n \n \tif (mask & ETH_VLAN_STRIP_MASK) {\n-\t\tint hw_vlan_strip = dev->data->dev_conf.rxmode.hw_vlan_strip;\n+\t\tint hw_vlan_strip = !!dev->data->dev_conf.rxmode.hw_vlan_strip;\n \n \t\tif (!priv->hw_vlan_strip) {\n \t\t\tERROR(\"VLAN stripping is not supported\");\n",
    "prefixes": [
        "dpdk-dev",
        "4/7"
    ]
}