Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133059/?format=api
{ "id": 133059, "url": "http://patches.dpdk.org/api/patches/133059/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231020084804.3625099-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231020084804.3625099-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231020084804.3625099-2-maxime.coquelin@redhat.com", "date": "2023-10-20T08:47:58", "name": "[v2,1/7] vhost: fix missing vring call check on virtqueue access", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fc25f3b614bd931b10edbba6a491d1790eacd581", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231020084804.3625099-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 29927, "url": "http://patches.dpdk.org/api/series/29927/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29927", "date": "2023-10-20T08:47:58", "name": "vhost: ensure virtqueue access status is checked", "version": 2, "mbox": "http://patches.dpdk.org/series/29927/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133059/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133059/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0995431BA;\n\tFri, 20 Oct 2023 10:48:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8A4AE40A67;\n\tFri, 20 Oct 2023 10:48:15 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 6D4D3402B8\n for <dev@dpdk.org>; Fri, 20 Oct 2023 10:48:14 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-661-JHL_K4SGO7-dEVtVLfPjKg-1; Fri, 20 Oct 2023 04:48:10 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com\n [10.11.54.2])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BE4F88CC4A;\n Fri, 20 Oct 2023 08:48:10 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 1ABE140C6F7B;\n Fri, 20 Oct 2023 08:48:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1697791693;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eLO6Saj0e0DoyVmFRVUdS2pGCnma22zBL/hNYG3nhFA=;\n b=KvLIdjXgoK3bj0naNXaSuZRy9vXFIFzItDgSSuPPHlhJYmTOA2zqzi4n/KI+hcETVWNDq/\n +g5Cyc+eJKzcOVB7bdYgadHrOB1KfUM9FANOdEFujgzhgUfiS7lCN0sR7tKCZ+kBnypJTO\n mg+Qk7Yy54FN4LWN6vf6RwqAGtZzIM0=", "X-MC-Unique": "JHL_K4SGO7-dEVtVLfPjKg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@outlook.com,\n fengli@smartx.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[PATCH v2 1/7] vhost: fix missing vring call check on virtqueue\n access", "Date": "Fri, 20 Oct 2023 10:47:58 +0200", "Message-ID": "<20231020084804.3625099-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20231020084804.3625099-1-maxime.coquelin@redhat.com>", "References": "<20231020084804.3625099-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.2", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Acquiring the access lock is not enough to ensure\nvirtqueue's metadata such as vring pointers are valid.\n\nThe access status must also be checked.\n\nFixes: 6c299bb7322f (\"vhost: introduce vring call API\")\nFixes: c5736998305d (\"vhost: fix missing virtqueue lock protection\")\nFixes: 830f7e790732 (\"vhost: add non-blocking API for posting interrupt\")\nCc: stable@dpdk.org\n\nReported-by: Li Feng <fengli@smartx.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.c | 18 ++++++++++++++++--\n 1 file changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex 7fde412ef3..0d2bc1a48b 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -1330,6 +1330,7 @@ rte_vhost_vring_call(int vid, uint16_t vring_idx)\n {\n \tstruct virtio_net *dev;\n \tstruct vhost_virtqueue *vq;\n+\tint ret = 0;\n \n \tdev = get_device(vid);\n \tif (!dev)\n@@ -1344,14 +1345,20 @@ rte_vhost_vring_call(int vid, uint16_t vring_idx)\n \n \trte_rwlock_read_lock(&vq->access_lock);\n \n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tif (vq_is_packed(dev))\n \t\tvhost_vring_call_packed(dev, vq);\n \telse\n \t\tvhost_vring_call_split(dev, vq);\n \n+out_unlock:\n \trte_rwlock_read_unlock(&vq->access_lock);\n \n-\treturn 0;\n+\treturn ret;\n }\n \n int\n@@ -1359,6 +1366,7 @@ rte_vhost_vring_call_nonblock(int vid, uint16_t vring_idx)\n {\n \tstruct virtio_net *dev;\n \tstruct vhost_virtqueue *vq;\n+\tint ret = 0;\n \n \tdev = get_device(vid);\n \tif (!dev)\n@@ -1374,14 +1382,20 @@ rte_vhost_vring_call_nonblock(int vid, uint16_t vring_idx)\n \tif (rte_rwlock_read_trylock(&vq->access_lock))\n \t\treturn -EAGAIN;\n \n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tif (vq_is_packed(dev))\n \t\tvhost_vring_call_packed(dev, vq);\n \telse\n \t\tvhost_vring_call_split(dev, vq);\n \n+out_unlock:\n \trte_rwlock_read_unlock(&vq->access_lock);\n \n-\treturn 0;\n+\treturn ret;\n }\n \n uint16_t\n", "prefixes": [ "v2", "1/7" ] }