Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132150/?format=api
{ "id": 132150, "url": "http://patches.dpdk.org/api/patches/132150/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230928164959.340575-5-amitprakashs@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230928164959.340575-5-amitprakashs@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230928164959.340575-5-amitprakashs@marvell.com", "date": "2023-09-28T16:49:50", "name": "[v6,04/12] eventdev/dma: support vchan add and delete", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8288774bc5778ecc94edd555f600e9bf40430f4a", "submitter": { "id": 2699, "url": "http://patches.dpdk.org/api/people/2699/?format=api", "name": "Amit Prakash Shukla", "email": "amitprakashs@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230928164959.340575-5-amitprakashs@marvell.com/mbox/", "series": [ { "id": 29686, "url": "http://patches.dpdk.org/api/series/29686/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29686", "date": "2023-09-28T16:49:46", "name": "event DMA adapter library support", "version": 6, "mbox": "http://patches.dpdk.org/series/29686/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132150/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8D2742659;\n\tThu, 28 Sep 2023 18:50:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A218840A7D;\n\tThu, 28 Sep 2023 18:50:39 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 3C382402DD\n for <dev@dpdk.org>; Thu, 28 Sep 2023 18:50:38 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 38SAfcA7003479; Thu, 28 Sep 2023 09:50:37 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3td7y6sd9m-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 28 Sep 2023 09:50:37 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 28 Sep 2023 09:50:35 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 28 Sep 2023 09:50:35 -0700", "from localhost.localdomain (unknown [10.28.36.157])\n by maili.marvell.com (Postfix) with ESMTP id 691FB5C68F4;\n Thu, 28 Sep 2023 09:50:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=/mgE0ZxQDwnYyZ4ZfHx8aUbGHKBzMIh6NfgO0u8XwOE=;\n b=DZOqi/opVzI+N6/JIBSAtCzcDBTPnjBovmy/sils2R4fEF5E/n5f+H+fd/DTmQz+ufgJ\n nuh7+H+n94HmMOLTPnA0351TpDyAqJHo2mtUG31K/mIY63KTgORsY29+n2lHiDTvGjm2\n fd2TL9RMbK4qqE9b3UqSHwceRCT9YFs+wzpUIGsEIDvI9Nac63A5OOGS30nzgNtO1NO5\n NcdA83xEvyrK9GcXrQnHKkHX32h/YM4XIp1v/5CdPF0IxxOeIfGfyUlAaZtPOErulNK8\n 3MFvGR8IuPMnrKmDPKWI4e1I2uHFsYLaa2Wz4d8ddPkwtiiQ53OYr0jNqX6kv0BsxTGb eQ==", "From": "Amit Prakash Shukla <amitprakashs@marvell.com>", "To": "Amit Prakash Shukla <amitprakashs@marvell.com>, Jerin Jacob\n <jerinj@marvell.com>", "CC": "<dev@dpdk.org>, <fengchengwen@huawei.com>, <kevin.laatz@intel.com>,\n <bruce.richardson@intel.com>, <conor.walsh@intel.com>,\n <vattunuru@marvell.com>, <g.singh@nxp.com>,\n <sachin.saxena@oss.nxp.com>, <hemant.agrawal@nxp.com>,\n <cheng1.jiang@intel.com>, <ndabilpuram@marvell.com>,\n <anoobj@marvell.com>, <mb@smartsharesystems.com>", "Subject": "[PATCH v6 04/12] eventdev/dma: support vchan add and delete", "Date": "Thu, 28 Sep 2023 22:19:50 +0530", "Message-ID": "<20230928164959.340575-5-amitprakashs@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230928164959.340575-1-amitprakashs@marvell.com>", "References": "<20230928103623.216287-1-amitprakashs@marvell.com>\n <20230928164959.340575-1-amitprakashs@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "Bz52Ev5rTPlZ2xcLezcjedxPaFhNWPfy", "X-Proofpoint-GUID": "Bz52Ev5rTPlZ2xcLezcjedxPaFhNWPfy", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-09-28_16,2023-09-28_03,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added API support to add and delete vchan's from the DMA adapter. DMA devid\nand vchan are added to the addapter instance by calling\nrte_event_dma_adapter_vchan_add and deleted using\nrte_event_dma_adapter_vchan_del.\n\nSigned-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>\n---\n lib/eventdev/rte_event_dma_adapter.c | 204 +++++++++++++++++++++++++++\n 1 file changed, 204 insertions(+)", "diff": "diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c\nindex e57d8407cb..ec81281bf8 100644\n--- a/lib/eventdev/rte_event_dma_adapter.c\n+++ b/lib/eventdev/rte_event_dma_adapter.c\n@@ -42,8 +42,31 @@ struct dma_ops_circular_buffer {\n \tstruct rte_event_dma_adapter_op **op_buffer;\n } __rte_cache_aligned;\n \n+/* Vchan information */\n+struct dma_vchan_info {\n+\t/* Set to indicate vchan queue is enabled */\n+\tbool vq_enabled;\n+\n+\t/* Circular buffer for batching DMA ops to dma_dev */\n+\tstruct dma_ops_circular_buffer dma_buf;\n+} __rte_cache_aligned;\n+\n /* DMA device information */\n struct dma_device_info {\n+\t/* Pointer to vchan queue info */\n+\tstruct dma_vchan_info *vchanq;\n+\n+\t/* Pointer to vchan queue info.\n+\t * This holds ops passed by application till the\n+\t * dma completion is done.\n+\t */\n+\tstruct dma_vchan_info *tqmap;\n+\n+\t/* If num_vchanq > 0, the start callback will\n+\t * be invoked if not already invoked\n+\t */\n+\tuint16_t num_vchanq;\n+\n \t/* Number of vchans configured for a DMA device. */\n \tuint16_t num_dma_dev_vchan;\n } __rte_cache_aligned;\n@@ -81,6 +104,9 @@ struct event_dma_adapter {\n \n \t/* Set if default_cb is being used */\n \tint default_cb_arg;\n+\n+\t/* No. of vchan queue configured */\n+\tuint16_t nb_vchanq;\n } __rte_cache_aligned;\n \n static struct event_dma_adapter **event_dma_adapter;\n@@ -333,3 +359,181 @@ rte_event_dma_adapter_free(uint8_t id)\n \n \treturn 0;\n }\n+\n+static void\n+edma_update_vchanq_info(struct event_dma_adapter *adapter, struct dma_device_info *dev_info,\n+\t\t\tuint16_t vchan, uint8_t add)\n+{\n+\tstruct dma_vchan_info *vchan_info;\n+\tstruct dma_vchan_info *tqmap_info;\n+\tint enabled;\n+\tuint16_t i;\n+\n+\tif (dev_info->vchanq == NULL)\n+\t\treturn;\n+\n+\tif (vchan == RTE_DMA_ALL_VCHAN) {\n+\t\tfor (i = 0; i < dev_info->num_dma_dev_vchan; i++)\n+\t\t\tedma_update_vchanq_info(adapter, dev_info, i, add);\n+\t} else {\n+\t\ttqmap_info = &dev_info->tqmap[vchan];\n+\t\tvchan_info = &dev_info->vchanq[vchan];\n+\t\tenabled = vchan_info->vq_enabled;\n+\t\tif (add) {\n+\t\t\tadapter->nb_vchanq += !enabled;\n+\t\t\tdev_info->num_vchanq += !enabled;\n+\t\t} else {\n+\t\t\tadapter->nb_vchanq -= enabled;\n+\t\t\tdev_info->num_vchanq -= enabled;\n+\t\t}\n+\t\tvchan_info->vq_enabled = !!add;\n+\t\ttqmap_info->vq_enabled = !!add;\n+\t}\n+}\n+\n+int\n+rte_event_dma_adapter_vchan_add(uint8_t id, int16_t dma_dev_id, uint16_t vchan,\n+\t\t\t\tconst struct rte_event *event)\n+{\n+\tstruct event_dma_adapter *adapter;\n+\tstruct dma_device_info *dev_info;\n+\tstruct rte_eventdev *dev;\n+\tuint32_t cap;\n+\tint ret;\n+\n+\tEVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);\n+\n+\tif (!rte_dma_is_valid(dma_dev_id)) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid dma_dev_id = %\" PRIu8, dma_dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tadapter = edma_id_to_adapter(id);\n+\tif (adapter == NULL)\n+\t\treturn -EINVAL;\n+\n+\tdev = &rte_eventdevs[adapter->eventdev_id];\n+\tret = rte_event_dma_adapter_caps_get(adapter->eventdev_id, dma_dev_id, &cap);\n+\tif (ret) {\n+\t\tRTE_EDEV_LOG_ERR(\"Failed to get adapter caps dev %u dma_dev %u\", id, dma_dev_id);\n+\t\treturn ret;\n+\t}\n+\n+\tif ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) && (event == NULL)) {\n+\t\tRTE_EDEV_LOG_ERR(\"Event can not be NULL for dma_dev_id = %u\", dma_dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev_info = &adapter->dma_devs[dma_dev_id];\n+\tif (vchan != RTE_DMA_ALL_VCHAN && vchan >= dev_info->num_dma_dev_vchan) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid vhcan %u\", vchan);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t/* In case HW cap is RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, no\n+\t * need of service core as HW supports event forward capability.\n+\t */\n+\tif ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||\n+\t (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND &&\n+\t adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW) ||\n+\t (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&\n+\t adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW)) {\n+\t\tif (*dev->dev_ops->dma_adapter_vchan_add == NULL)\n+\t\t\treturn -ENOTSUP;\n+\t\tif (dev_info->vchanq == NULL) {\n+\t\t\tdev_info->vchanq = rte_zmalloc_socket(adapter->mem_name,\n+\t\t\t\t\t\t\tdev_info->num_dma_dev_vchan *\n+\t\t\t\t\t\t\tsizeof(struct dma_vchan_info),\n+\t\t\t\t\t\t\t0, adapter->socket_id);\n+\t\t\tif (dev_info->vchanq == NULL) {\n+\t\t\t\tprintf(\"Queue pair add not supported\\n\");\n+\t\t\t\treturn -ENOMEM;\n+\t\t\t}\n+\t\t}\n+\n+\t\tif (dev_info->tqmap == NULL) {\n+\t\t\tdev_info->tqmap = rte_zmalloc_socket(adapter->mem_name,\n+\t\t\t\t\t\tdev_info->num_dma_dev_vchan *\n+\t\t\t\t\t\tsizeof(struct dma_vchan_info),\n+\t\t\t\t\t\t0, adapter->socket_id);\n+\t\t\tif (dev_info->tqmap == NULL) {\n+\t\t\t\tprintf(\"tq pair add not supported\\n\");\n+\t\t\t\treturn -ENOMEM;\n+\t\t\t}\n+\t\t}\n+\n+\t\tret = (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id, vchan, event);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\telse\n+\t\t\tedma_update_vchanq_info(adapter, &adapter->dma_devs[dma_dev_id], vchan, 1);\n+\t}\n+\n+\treturn 0;\n+}\n+\n+int\n+rte_event_dma_adapter_vchan_del(uint8_t id, int16_t dma_dev_id, uint16_t vchan)\n+{\n+\tstruct event_dma_adapter *adapter;\n+\tstruct dma_device_info *dev_info;\n+\tstruct rte_eventdev *dev;\n+\tuint32_t cap;\n+\tint ret;\n+\n+\tEVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);\n+\n+\tif (!rte_dma_is_valid(dma_dev_id)) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid dma_dev_id = %\" PRIu8, dma_dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tadapter = edma_id_to_adapter(id);\n+\tif (adapter == NULL)\n+\t\treturn -EINVAL;\n+\n+\tdev = &rte_eventdevs[adapter->eventdev_id];\n+\tret = rte_event_dma_adapter_caps_get(adapter->eventdev_id, dma_dev_id, &cap);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tdev_info = &adapter->dma_devs[dma_dev_id];\n+\n+\tif (vchan != RTE_DMA_ALL_VCHAN && vchan >= dev_info->num_dma_dev_vchan) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid vhcan %\" PRIu16, vchan);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||\n+\t (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&\n+\t adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW)) {\n+\t\tif (*dev->dev_ops->dma_adapter_vchan_del == NULL)\n+\t\t\treturn -ENOTSUP;\n+\t\tret = (*dev->dev_ops->dma_adapter_vchan_del)(dev, dma_dev_id, vchan);\n+\t\tif (ret == 0) {\n+\t\t\tedma_update_vchanq_info(adapter, dev_info, vchan, 0);\n+\t\t\tif (dev_info->num_vchanq == 0) {\n+\t\t\t\trte_free(dev_info->vchanq);\n+\t\t\t\tdev_info->vchanq = NULL;\n+\t\t\t}\n+\t\t}\n+\t} else {\n+\t\tif (adapter->nb_vchanq == 0)\n+\t\t\treturn 0;\n+\n+\t\trte_spinlock_lock(&adapter->lock);\n+\t\tedma_update_vchanq_info(adapter, dev_info, vchan, 0);\n+\n+\t\tif (dev_info->num_vchanq == 0) {\n+\t\t\trte_free(dev_info->vchanq);\n+\t\t\trte_free(dev_info->tqmap);\n+\t\t\tdev_info->vchanq = NULL;\n+\t\t\tdev_info->tqmap = NULL;\n+\t\t}\n+\n+\t\trte_spinlock_unlock(&adapter->lock);\n+\t}\n+\n+\treturn ret;\n+}\n", "prefixes": [ "v6", "04/12" ] }