Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132134/?format=api
{ "id": 132134, "url": "http://patches.dpdk.org/api/patches/132134/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230928110450.862698-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230928110450.862698-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230928110450.862698-1-bruce.richardson@intel.com", "date": "2023-09-28T11:04:49", "name": "[1/2] app/test: add support for optional dependencies", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a403bdebe92745be6e88dbb772370469db540aa4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230928110450.862698-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29679, "url": "http://patches.dpdk.org/api/series/29679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29679", "date": "2023-09-28T11:04:49", "name": "[1/2] app/test: add support for optional dependencies", "version": 1, "mbox": "http://patches.dpdk.org/series/29679/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132134/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132134/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB06B42660;\n\tThu, 28 Sep 2023 13:05:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9633740273;\n\tThu, 28 Sep 2023 13:05:01 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 73B734021D\n for <dev@dpdk.org>; Thu, 28 Sep 2023 13:05:00 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Sep 2023 04:04:59 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.155])\n by orsmga007.jf.intel.com with ESMTP; 28 Sep 2023 04:04:58 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695899100; x=1727435100;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=y2sHiM6SI86zzHZjtz+qgRDiSbI5JuaH4wvzvIjgR58=;\n b=cuD+aPeM2fdiejMnD+A06Vw6BnbCRN1Eg7QXWsQNWG+azc1dLW2pZdI5\n rcdDOjZ+cLapA/qt+8IAPuTc0QX4DZCLOtowdjT4891EH0AIAPWDX77zH\n lZPOchjgVpjKbvNxk5LQsJmZ+KX6sJ7pa28aIqA93tT3yPoFwM7l9bzTu\n BTBHiV5rAzYIyUGLEw/6GRGXWISi6Rt8CEV3I8Q78NIdMs+1cW9ngYpot\n /uzyYhIYGaBTC+zC3poTTnS+3SXtGhtzHQZAndiP+V2oKUloCiSPhrJJy\n nJc8wYCKyOIiriNPuRrcq0Rf3mtZtJ2kTrRvwln4j1RRVxsySWgfXq31k w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10846\"; a=\"412944824\"", "E=Sophos;i=\"6.03,183,1694761200\"; d=\"scan'208\";a=\"412944824\"", "E=McAfee;i=\"6600,9927,10846\"; a=\"743038573\"", "E=Sophos;i=\"6.03,183,1694761200\"; d=\"scan'208\";a=\"743038573\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 1/2] app/test: add support for optional dependencies", "Date": "Thu, 28 Sep 2023 12:04:49 +0100", "Message-Id": "<20230928110450.862698-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230928092639.162449-1-bruce.richardson@intel.com>", "References": "<20230928092639.162449-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some tests make optionally use a component but don't require it for\nbuilding. If we include the dependency in the per-file lists, then tests\nmay be unnecessarily omitted, as the dependency is not required.\nOn the other hand, removing the optional dependency from the list can\ncause build failures, as the test case may include the optional code,\nbut then fail to build as the build system won't have added the necessary\npaths for header inclusion, or the necessary libraries for linking.\n\nResolve this by explicitly providing a list of optional dependencies.\nAny items in this list will be added to the dependency list if\navailable, but otherwise won't be involved in enable/disable of specific\ntests.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/meson.build | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 05bae9216d..80b60f68b2 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -5,6 +5,10 @@\n deps += ['cmdline', 'ring', 'mempool', 'mbuf']\n sources += files('commands.c', 'test.c')\n \n+# optional dependencies: some files may use these - and so we should link them in -\n+# but do not explicitly require them so they are not listed in the per-file lists below\n+optional_deps = []\n+\n # some other utility C files, providing functions used by various tests\n # so we need to include these deps in the dependency list for the files using those fns.\n packet_burst_generator_deps = ['net']\n@@ -226,6 +230,12 @@ foreach f, f_deps : source_file_deps\n sources += files(f)\n endif\n endforeach\n+# add the optional dependencies\n+foreach d:optional_deps\n+ if is_variable(def_lib + '_rte_' + d) and d not in deps\n+ deps += d\n+ endif\n+endforeach\n \n if cc.has_argument('-Wno-format-truncation')\n cflags += '-Wno-format-truncation'\n", "prefixes": [ "1/2" ] }