Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132097/?format=api
{ "id": 132097, "url": "http://patches.dpdk.org/api/patches/132097/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230928092553.339452-1-shibin.koikkara.reeny@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230928092553.339452-1-shibin.koikkara.reeny@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230928092553.339452-1-shibin.koikkara.reeny@intel.com", "date": "2023-09-28T09:25:53", "name": "[v3] net/af_xdp: fix missing UMEM feature", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a90d3ce6c170c571be20624a3e5ef985d443064a", "submitter": { "id": 2540, "url": "http://patches.dpdk.org/api/people/2540/?format=api", "name": "Koikkara Reeny, Shibin", "email": "shibin.koikkara.reeny@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230928092553.339452-1-shibin.koikkara.reeny@intel.com/mbox/", "series": [ { "id": 29671, "url": "http://patches.dpdk.org/api/series/29671/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29671", "date": "2023-09-28T09:25:53", "name": "[v3] net/af_xdp: fix missing UMEM feature", "version": 3, "mbox": "http://patches.dpdk.org/series/29671/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132097/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C81094265E;\n\tThu, 28 Sep 2023 11:26:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4696540273;\n\tThu, 28 Sep 2023 11:26:02 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 36B9E40150\n for <dev@dpdk.org>; Thu, 28 Sep 2023 11:26:00 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Sep 2023 02:25:59 -0700", "from silpixa00401350.ir.intel.com ([10.55.128.41])\n by orsmga007.jf.intel.com with ESMTP; 28 Sep 2023 02:25:56 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695893160; x=1727429160;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=25FJAGAA6Z8hYYsFIemIophdfwlq4TjHlfE2SbEHeIY=;\n b=CAquvbbiUiUrX9ojCrMGSpiF9qeOmm+NfHQ/VuAoqWEd7000Tx76xUW2\n SPo8zvaKPqUPZ8PnW+F7ZrK8oJLb9pNLKZlNNay7Kz31iHrrz8OtInpf6\n DoIRsWFxXfh4uzk8Gawo3b4Ks0zCq6wi9wLhqXo8pojJpAG9jQcX7ijNd\n At4MU0T9VRp1XxdZyWAhjUAr4AM6OYBj3U+FkhCOBkAybTmxHJy/VYDDp\n nmiXxxxqGvwpRSb26usepZAwsDOAmQlixua5QXtVnMUl0pM7u0gNqgYTl\n uHLhi62/rJv46v05ZFupOII97I3BwtOsAsID9EWl92PQ9IXmTgImxyXBo Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10846\"; a=\"380896325\"", "E=Sophos;i=\"6.03,183,1694761200\"; d=\"scan'208\";a=\"380896325\"", "E=McAfee;i=\"6600,9927,10846\"; a=\"743017233\"", "E=Sophos;i=\"6.03,183,1694761200\"; d=\"scan'208\";a=\"743017233\"" ], "X-ExtLoop1": "1", "From": "Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>", "To": "dev@dpdk.org,\n\tciara.loftus@intel.com,\n\tbruce.richardson@intel.com", "Cc": "qi.z.zhang@intel.com, john.mcnamara@intel.com,\n Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>", "Subject": "[PATCH v3] net/af_xdp: fix missing UMEM feature", "Date": "Thu, 28 Sep 2023 09:25:53 +0000", "Message-Id": "<20230928092553.339452-1-shibin.koikkara.reeny@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230922093103.58541-1-shibin.koikkara.reeny@intel.com>", "References": "<20230922093103.58541-1-shibin.koikkara.reeny@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Shared UMEM feature is missing in the af_xdp driver build\nafter the commit 33d66940e9ba (\"build: use C11 standard\").\n\nRuntime Error log while using Shared UMEM feature:\nrte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0\ninit_internals(): Shared UMEM feature not available. Check kernel\nand libbpf version\nrte_pmd_af_xdp_probe(): Failed to init internals\nvdev_probe(): failed to initialize net_af_xdp0 device\nEAL: Bus (vdev) probe failed.\n\nReason for the missing UMEM feature is because the C11 standard\ndoesn't include the GNU compiler extensions typeof and asm, used\nby the libbpf and libxdp header files.\n\nMeson error log:\n In file included from\ndpdk/build/meson-private/tmpf74nkhqd/testfile.c:5:\n/usr/local/include/bpf/xsk.h: In function 'xsk_prod_nb_free':\n/usr/local/include/bpf/xsk.h:165:26: error: expected ';' before '___p1'\n 165 | r->cached_cons = libbpf_smp_load_acquire(r->consumer);\n | ^~~~~~~~~~~~~~~~~~~~~~~\n/usr/local/include/bpf/xsk.h:165:26: error: 'asm' undeclared (first use\nin this function)\n...\n/usr/local/include/bpf/xsk.h:199:9: error: unknown type name 'typeof'\n 199 | libbpf_smp_store_release(prod->producer, *prod->producer\n + nb);\n | ^~~~~~~~~~~~~~~~~~~~~~~~\n\nFix is to provide alternative keywords by using Option Controlling C\nDialect [1].\n\nFixes: 33d66940e9ba (\"build: use C11 standard\")\n\n[1] https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html\n\nv3: Used alternative keywords fix.\nv2: Added original commit causing the issue.\nSigned-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>\n---\n drivers/net/af_xdp/meson.build | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build\nindex 9a8dbb4d49..9f33e57fa2 100644\n--- a/drivers/net/af_xdp/meson.build\n+++ b/drivers/net/af_xdp/meson.build\n@@ -48,6 +48,14 @@ endif\n \n if build\n xsk_check_prefix = '''\n+#ifndef typeof\n+#define typeof __typeof__\n+#endif\n+\n+#ifndef asm\n+#define asm __asm__\n+#endif\n+\n #ifdef RTE_NET_AF_XDP_LIBXDP\n #include <xdp/xsk.h>\n #else\n@@ -56,17 +64,17 @@ if build\n '''\n \n if cc.has_function('xsk_socket__create_shared', prefix : xsk_check_prefix,\n- dependencies : ext_deps)\n+ dependencies : ext_deps, args: cflags)\n cflags += ['-DRTE_NET_AF_XDP_SHARED_UMEM']\n endif\n if cc.has_function('bpf_object__next_program',\n prefix : '#include <bpf/libbpf.h>',\n- dependencies : bpf_dep)\n+ dependencies : bpf_dep, args: cflags)\n cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN']\n endif\n if cc.has_function('bpf_xdp_attach',\n prefix : '#include <bpf/libbpf.h>',\n- dependencies : bpf_dep)\n+ dependencies : bpf_dep, args: cflags)\n cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH']\n endif\n endif\n", "prefixes": [ "v3" ] }