Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131751/?format=api
{ "id": 131751, "url": "http://patches.dpdk.org/api/patches/131751/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230920164823.1164930-1-rbhansali@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230920164823.1164930-1-rbhansali@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230920164823.1164930-1-rbhansali@marvell.com", "date": "2023-09-20T16:48:22", "name": "[v3] eventdev/eth_rx: fix timestamp field register in mbuf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9b5efa6cfa1f15d2aa6350af5a0e2f87d492e9db", "submitter": { "id": 2436, "url": "http://patches.dpdk.org/api/people/2436/?format=api", "name": "Rahul Bhansali", "email": "rbhansali@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230920164823.1164930-1-rbhansali@marvell.com/mbox/", "series": [ { "id": 29579, "url": "http://patches.dpdk.org/api/series/29579/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29579", "date": "2023-09-20T16:48:22", "name": "[v3] eventdev/eth_rx: fix timestamp field register in mbuf", "version": 3, "mbox": "http://patches.dpdk.org/series/29579/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131751/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131751/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D9F3425F3;\n\tWed, 20 Sep 2023 18:48:32 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F216D40ED2;\n\tWed, 20 Sep 2023 18:48:31 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 37A724029C;\n Wed, 20 Sep 2023 18:48:30 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 38K9Ghuq017236; Wed, 20 Sep 2023 09:48:29 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3t7u4dan4x-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 20 Sep 2023 09:48:29 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 20 Sep 2023 09:48:27 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 20 Sep 2023 09:48:27 -0700", "from localhost.localdomain (unknown [10.28.36.158])\n by maili.marvell.com (Postfix) with ESMTP id 996A35B6926;\n Wed, 20 Sep 2023 09:48:25 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=5+uCDw23gJjGcj3/uyjsFtM1fSRXmVoAokuwjLotdd8=;\n b=g0f1Z9Mo1GNY4K2IEW0xIndqLY8q7sruGfod/+QH+lc6+pw7IDrep0vlhMON6pNFJOcy\n OUxSkg0vwpu93xyZE81sYxtAJXH+QkYEcDzUm5HMbUS04cC3QNhIinKzM4U77RnVOQjE\n +NFwhtl14DLWijxXKIuTBcv/Gfhg7mo4YRHE1luUZ7kVQji5RCnizSEIAFhE382c0W0S\n f1jyGh2btjDRn+eVY6R2dr16ttRbjocw9RWbg0JxfFDmSg30LSO7o7akYqU/wxcEaZZp\n egCeGve0CZhCrPNDN9HtWB0FvoiABKPaCfUuuxeNaupUUpXq6V1VVce/cRYV16i564XN dQ==", "From": "Rahul Bhansali <rbhansali@marvell.com>", "To": "<dev@dpdk.org>, Naga Harish K S V <s.v.naga.harish.k@intel.com>, \"Jerin\n Jacob\" <jerinj@marvell.com>, Ganapati Kundapura\n <ganapati.kundapura@intel.com>", "CC": "Rahul Bhansali <rbhansali@marvell.com>, <stable@dpdk.org>", "Subject": "[PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf", "Date": "Wed, 20 Sep 2023 22:18:22 +0530", "Message-ID": "<20230920164823.1164930-1-rbhansali@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230918082553.704859-1-rbhansali@marvell.com>", "References": "<20230918082553.704859-1-rbhansali@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "L5m4lMQUnyTqS418LosWQQ4k_Dw-kNAL", "X-Proofpoint-GUID": "L5m4lMQUnyTqS418LosWQQ4k_Dw-kNAL", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26\n definitions=2023-09-20_06,2023-09-20_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For eventdev internal port, timestamp dynamic field registration\nin mbuf is not required as that will be done from net device.\nFor SW eventdev, Rx timestamp field registration will be\ndone during Rxa service initialization.\n\nFixes: 83ab470d1259 (\"eventdev/eth_rx: use timestamp as dynamic mbuf field\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rahul Bhansali <rbhansali@marvell.com>\n---\nv3 changes:\n- timestamp register move before other Rxa init config.\n\nv2 changes:\n- addresses the review comment to have registration in rxa_init_service()\n\n lib/eventdev/rte_event_eth_rx_adapter.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\n--\n2.25.1", "diff": "diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c\nindex 3ebfa5366d..8df92247fa 100644\n--- a/lib/eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/eventdev/rte_event_eth_rx_adapter.c\n@@ -1910,6 +1910,13 @@ rxa_init_service(struct event_eth_rx_adapter *rx_adapter, uint8_t id)\n \tif (rx_adapter->service_inited)\n \t\treturn 0;\n\n+\tif (rte_mbuf_dyn_rx_timestamp_register(\n+\t\t\t&event_eth_rx_timestamp_dynfield_offset,\n+\t\t\t&event_eth_rx_timestamp_dynflag) != 0) {\n+\t\tRTE_EDEV_LOG_ERR(\"Error registering timestamp field in mbuf\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n \tmemset(&service, 0, sizeof(service));\n \tsnprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN,\n \t\t\"rte_event_eth_rx_adapter_%d\", id);\n@@ -2472,13 +2479,6 @@ rxa_create(uint8_t id, uint8_t dev_id,\n \tif (conf_cb == rxa_default_conf_cb)\n \t\trx_adapter->default_cb_arg = 1;\n\n-\tif (rte_mbuf_dyn_rx_timestamp_register(\n-\t\t\t&event_eth_rx_timestamp_dynfield_offset,\n-\t\t\t&event_eth_rx_timestamp_dynflag) != 0) {\n-\t\tRTE_EDEV_LOG_ERR(\"Error registering timestamp field in mbuf\\n\");\n-\t\treturn -rte_errno;\n-\t}\n-\n \trte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,\n \t\tconf_arg);\n \treturn 0;\n", "prefixes": [ "v3" ] }