Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131693/?format=api
{ "id": 131693, "url": "http://patches.dpdk.org/api/patches/131693/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230920072528.14185-19-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230920072528.14185-19-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230920072528.14185-19-syalavarthi@marvell.com", "date": "2023-09-20T07:25:09", "name": "[v2,18/34] ml/cnxk: move error handling to cnxk layer", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1a6946c632c96073241de2912ae1aac68bd2bc3d", "submitter": { "id": 2480, "url": "http://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230920072528.14185-19-syalavarthi@marvell.com/mbox/", "series": [ { "id": 29567, "url": "http://patches.dpdk.org/api/series/29567/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29567", "date": "2023-09-20T07:24:51", "name": "Implemenation of revised ml/cnxk driver", "version": 2, "mbox": "http://patches.dpdk.org/series/29567/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131693/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D277D425E4;\n\tWed, 20 Sep 2023 09:27:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5CAB542D2E;\n\tWed, 20 Sep 2023 09:25:59 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id DDB5A40EE7\n for <dev@dpdk.org>; Wed, 20 Sep 2023 09:25:40 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 38K633lj002294 for <dev@dpdk.org>; Wed, 20 Sep 2023 00:25:40 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3t7u4d89j8-13\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 20 Sep 2023 00:25:39 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 20 Sep 2023 00:25:38 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 20 Sep 2023 00:25:38 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 037F25B6922;\n Wed, 20 Sep 2023 00:25:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=quASSH8B4/AivnqVd89GU4ZF/P7jdg8HD8k5cwNfpdU=;\n b=BfJCEFWboq8TQSgUMUV3b6ZjPGANYmZpOciOaUKbOHjmEHcqgutuL31l8YK9GEKc5zmp\n Ou3EpXwc/tuVN8ldh9kTm3bY9eeLCfRyUtf41MfHDxiq/1DTwwi8h5dPPc1KEeC6p5rG\n JVVnebqPLdGcu8fuSRGE4iZIXaZQwcyB3szWjB2bCtuK09ZNHTYWxwVBqCWI468xw0oK\n ac4EQfwH0+vDwEuuM4VwDrctsbbfUZCc1GN/k5BIORnFzQyZAg9ahjGHQuHDZ3CaJy8k\n i8gkgpDpQ53GlkD2ZZdJEBQ5v3ya7isG6cEqFyJfjwmMCdejAVv3G5YS13WRHK+mz1Dc KQ==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <aprabhu@marvell.com>,\n <ptakkar@marvell.com>", "Subject": "[PATCH v2 18/34] ml/cnxk: move error handling to cnxk layer", "Date": "Wed, 20 Sep 2023 00:25:09 -0700", "Message-ID": "<20230920072528.14185-19-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20230920072528.14185-1-syalavarthi@marvell.com>", "References": "<20230830155927.3566-1-syalavarthi@marvell.com>\n <20230920072528.14185-1-syalavarthi@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "aRJDlZ9Ak1R8RBsDmnK-leOhAgzfAoYs", "X-Proofpoint-GUID": "aRJDlZ9Ak1R8RBsDmnK-leOhAgzfAoYs", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26\n definitions=2023-09-20_02,2023-09-19_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Move error type structures to cnxk layer. cn10k layer to\nhandle fw and hw error sub-types only.\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n drivers/ml/cnxk/cn10k_ml_dev.h | 41 ++++++---------\n drivers/ml/cnxk/cn10k_ml_ops.c | 93 +++++++++++++---------------------\n drivers/ml/cnxk/cnxk_ml_dev.c | 8 +++\n drivers/ml/cnxk/cnxk_ml_dev.h | 18 +++++++\n drivers/ml/cnxk/cnxk_ml_ops.c | 2 +-\n 5 files changed, 78 insertions(+), 84 deletions(-)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_dev.h b/drivers/ml/cnxk/cn10k_ml_dev.h\nindex 94a94d996f..2e7eb6c9ef 100644\n--- a/drivers/ml/cnxk/cn10k_ml_dev.h\n+++ b/drivers/ml/cnxk/cn10k_ml_dev.h\n@@ -52,38 +52,27 @@ struct cnxk_ml_dev;\n struct cnxk_ml_req;\n struct cnxk_ml_qp;\n \n-/* Error types enumeration */\n-enum cn10k_ml_error_etype {\n-\t/* 0x0 */ ML_ETYPE_NO_ERROR = 0, /* No error */\n-\t/* 0x1 */ ML_ETYPE_FW_NONFATAL,\t /* Firmware non-fatal error */\n-\t/* 0x2 */ ML_ETYPE_HW_NONFATAL,\t /* Hardware non-fatal error */\n-\t/* 0x3 */ ML_ETYPE_HW_FATAL,\t /* Hardware fatal error */\n-\t/* 0x4 */ ML_ETYPE_HW_WARNING,\t /* Hardware warning */\n-\t/* 0x5 */ ML_ETYPE_DRIVER,\t /* Driver specific error */\n-\t/* 0x6 */ ML_ETYPE_UNKNOWN,\t /* Unknown error */\n-};\n-\n /* Firmware non-fatal error sub-type */\n enum cn10k_ml_error_stype_fw_nf {\n-\t/* 0x0 */ ML_FW_ERR_NOERR = 0,\t\t /* No error */\n-\t/* 0x1 */ ML_FW_ERR_UNLOAD_ID_NOT_FOUND, /* Model ID not found during load */\n-\t/* 0x2 */ ML_FW_ERR_LOAD_LUT_OVERFLOW,\t /* Lookup table overflow at load */\n-\t/* 0x3 */ ML_FW_ERR_ID_IN_USE,\t\t /* Model ID already in use */\n-\t/* 0x4 */ ML_FW_ERR_INVALID_TILEMASK,\t /* Invalid OCM tilemask */\n-\t/* 0x5 */ ML_FW_ERR_RUN_LUT_OVERFLOW,\t /* Lookup table overflow at run */\n-\t/* 0x6 */ ML_FW_ERR_RUN_ID_NOT_FOUND,\t /* Model ID not found during run */\n-\t/* 0x7 */ ML_FW_ERR_COMMAND_NOTSUP,\t /* Unsupported command */\n-\t/* 0x8 */ ML_FW_ERR_DDR_ADDR_RANGE,\t /* DDR address out of range */\n-\t/* 0x9 */ ML_FW_ERR_NUM_BATCHES_INVALID, /* Invalid number of batches */\n-\t/* 0xA */ ML_FW_ERR_INSSYNC_TIMEOUT,\t /* INS sync timeout */\n+\t/* 0x0 */ ML_CN10K_FW_ERR_NOERR = 0,\t /* No error */\n+\t/* 0x1 */ ML_CN10K_FW_ERR_UNLOAD_ID_NOT_FOUND, /* Model ID not found during load */\n+\t/* 0x2 */ ML_CN10K_FW_ERR_LOAD_LUT_OVERFLOW, /* Lookup table overflow at load */\n+\t/* 0x3 */ ML_CN10K_FW_ERR_ID_IN_USE,\t /* Model ID already in use */\n+\t/* 0x4 */ ML_CN10K_FW_ERR_INVALID_TILEMASK, /* Invalid OCM tilemask */\n+\t/* 0x5 */ ML_CN10K_FW_ERR_RUN_LUT_OVERFLOW, /* Lookup table overflow at run */\n+\t/* 0x6 */ ML_CN10K_FW_ERR_RUN_ID_NOT_FOUND, /* Model ID not found during run */\n+\t/* 0x7 */ ML_CN10K_FW_ERR_COMMAND_NOTSUP, /* Unsupported command */\n+\t/* 0x8 */ ML_CN10K_FW_ERR_DDR_ADDR_RANGE, /* DDR address out of range */\n+\t/* 0x9 */ ML_CN10K_FW_ERR_NUM_BATCHES_INVALID, /* Invalid number of batches */\n+\t/* 0xA */ ML_CN10K_FW_ERR_INSSYNC_TIMEOUT, /* INS sync timeout */\n };\n \n /* Driver error sub-type */\n enum cn10k_ml_error_stype_driver {\n-\t/* 0x0 */ ML_DRIVER_ERR_NOERR = 0, /* No error */\n-\t/* 0x1 */ ML_DRIVER_ERR_UNKNOWN, /* Unable to determine error sub-type */\n-\t/* 0x2 */ ML_DRIVER_ERR_EXCEPTION, /* Firmware exception */\n-\t/* 0x3 */ ML_DRIVER_ERR_FW_ERROR, /* Unknown firmware error */\n+\t/* 0x0 */ ML_CN10K_DRIVER_ERR_NOERR = 0, /* No error */\n+\t/* 0x1 */ ML_CN10K_DRIVER_ERR_UNKNOWN,\t /* Unable to determine error sub-type */\n+\t/* 0x2 */ ML_CN10K_DRIVER_ERR_EXCEPTION, /* Firmware exception */\n+\t/* 0x3 */ ML_CN10K_DRIVER_ERR_FW_ERROR,\t /* Unknown firmware error */\n };\n \n /* Error structure */\ndiff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c\nindex 7d809d25ae..daeb3b712c 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.c\n@@ -26,47 +26,27 @@\n #define ML_FLAGS_POLL_COMPL BIT(0)\n #define ML_FLAGS_SSO_COMPL BIT(1)\n \n-/* Error message length */\n-#define ERRMSG_LEN 32\n-\n-/* Error type database */\n-static const struct cn10k_ml_etype_db {\n-\tenum cn10k_ml_error_etype etype;\n-\tchar name[ERRMSG_LEN];\n-} ml_etype_db[] = {\n-\t{ML_ETYPE_NO_ERROR, \"NO_ERROR\"},\t{ML_ETYPE_FW_NONFATAL, \"FW_NON_FATAL\"},\n-\t{ML_ETYPE_HW_NONFATAL, \"HW_NON_FATAL\"}, {ML_ETYPE_HW_FATAL, \"HW_FATAL\"},\n-\t{ML_ETYPE_HW_WARNING, \"HW_WARNING\"},\t{ML_ETYPE_DRIVER, \"DRIVER_ERROR\"},\n-\t{ML_ETYPE_UNKNOWN, \"UNKNOWN_ERROR\"},\n-};\n-\n /* Hardware non-fatal error subtype database */\n-static const struct cn10k_ml_stype_db_hw_nf {\n-\tenum cn10k_ml_error_stype_fw_nf stype;\n-\tchar msg[ERRMSG_LEN];\n-} ml_stype_db_hw_nf[] = {\n-\t{ML_FW_ERR_NOERR, \"NO ERROR\"},\n-\t{ML_FW_ERR_UNLOAD_ID_NOT_FOUND, \"UNLOAD MODEL ID NOT FOUND\"},\n-\t{ML_FW_ERR_LOAD_LUT_OVERFLOW, \"LOAD LUT OVERFLOW\"},\n-\t{ML_FW_ERR_ID_IN_USE, \"MODEL ID IN USE\"},\n-\t{ML_FW_ERR_INVALID_TILEMASK, \"INVALID TILEMASK\"},\n-\t{ML_FW_ERR_RUN_LUT_OVERFLOW, \"RUN LUT OVERFLOW\"},\n-\t{ML_FW_ERR_RUN_ID_NOT_FOUND, \"RUN MODEL ID NOT FOUND\"},\n-\t{ML_FW_ERR_COMMAND_NOTSUP, \"COMMAND NOT SUPPORTED\"},\n-\t{ML_FW_ERR_DDR_ADDR_RANGE, \"DDR ADDRESS OUT OF RANGE\"},\n-\t{ML_FW_ERR_NUM_BATCHES_INVALID, \"INVALID BATCHES\"},\n-\t{ML_FW_ERR_INSSYNC_TIMEOUT, \"INSSYNC TIMEOUT\"},\n+static struct cnxk_ml_error_db ml_stype_db_hw_nf[] = {\n+\t{ML_CN10K_FW_ERR_NOERR, \"NO ERROR\"},\n+\t{ML_CN10K_FW_ERR_UNLOAD_ID_NOT_FOUND, \"UNLOAD MODEL ID NOT FOUND\"},\n+\t{ML_CN10K_FW_ERR_LOAD_LUT_OVERFLOW, \"LOAD LUT OVERFLOW\"},\n+\t{ML_CN10K_FW_ERR_ID_IN_USE, \"MODEL ID IN USE\"},\n+\t{ML_CN10K_FW_ERR_INVALID_TILEMASK, \"INVALID TILEMASK\"},\n+\t{ML_CN10K_FW_ERR_RUN_LUT_OVERFLOW, \"RUN LUT OVERFLOW\"},\n+\t{ML_CN10K_FW_ERR_RUN_ID_NOT_FOUND, \"RUN MODEL ID NOT FOUND\"},\n+\t{ML_CN10K_FW_ERR_COMMAND_NOTSUP, \"COMMAND NOT SUPPORTED\"},\n+\t{ML_CN10K_FW_ERR_DDR_ADDR_RANGE, \"DDR ADDRESS OUT OF RANGE\"},\n+\t{ML_CN10K_FW_ERR_NUM_BATCHES_INVALID, \"INVALID BATCHES\"},\n+\t{ML_CN10K_FW_ERR_INSSYNC_TIMEOUT, \"INSSYNC TIMEOUT\"},\n };\n \n /* Driver error subtype database */\n-static const struct cn10k_ml_stype_db_driver {\n-\tenum cn10k_ml_error_stype_driver stype;\n-\tchar msg[ERRMSG_LEN];\n-} ml_stype_db_driver[] = {\n-\t{ML_DRIVER_ERR_NOERR, \"NO ERROR\"},\n-\t{ML_DRIVER_ERR_UNKNOWN, \"UNKNOWN ERROR\"},\n-\t{ML_DRIVER_ERR_EXCEPTION, \"FW EXCEPTION\"},\n-\t{ML_DRIVER_ERR_FW_ERROR, \"UNKNOWN FIRMWARE ERROR\"},\n+static struct cnxk_ml_error_db ml_stype_db_driver[] = {\n+\t{ML_CN10K_DRIVER_ERR_NOERR, \"NO ERROR\"},\n+\t{ML_CN10K_DRIVER_ERR_UNKNOWN, \"UNKNOWN ERROR\"},\n+\t{ML_CN10K_DRIVER_ERR_EXCEPTION, \"FW EXCEPTION\"},\n+\t{ML_CN10K_DRIVER_ERR_FW_ERROR, \"UNKNOWN FIRMWARE ERROR\"},\n };\n \n __rte_hot void\n@@ -1166,19 +1146,19 @@ cn10k_ml_result_update(struct cnxk_ml_dev *cnxk_mldev, int qp_id, void *request)\n \n \t\t/* Handle driver error */\n \t\terror_code = (union cn10k_ml_error_code *)&result->error_code;\n-\t\tif (error_code->s.etype == ML_ETYPE_DRIVER) {\n+\t\tif (error_code->s.etype == ML_CNXK_ETYPE_DRIVER) {\n \t\t\tcn10k_mldev = &cnxk_mldev->cn10k_mldev;\n \n \t\t\t/* Check for exception */\n \t\t\tif ((roc_ml_reg_read64(&cn10k_mldev->roc, ML_SCRATCH_EXCEPTION_SP_C0) !=\n \t\t\t 0) ||\n \t\t\t (roc_ml_reg_read64(&cn10k_mldev->roc, ML_SCRATCH_EXCEPTION_SP_C1) != 0))\n-\t\t\t\terror_code->s.stype = ML_DRIVER_ERR_EXCEPTION;\n+\t\t\t\terror_code->s.stype = ML_CN10K_DRIVER_ERR_EXCEPTION;\n \t\t\telse if ((roc_ml_reg_read64(&cn10k_mldev->roc, ML_CORE_INT_LO) != 0) ||\n \t\t\t\t (roc_ml_reg_read64(&cn10k_mldev->roc, ML_CORE_INT_HI) != 0))\n-\t\t\t\terror_code->s.stype = ML_DRIVER_ERR_FW_ERROR;\n+\t\t\t\terror_code->s.stype = ML_CN10K_DRIVER_ERR_FW_ERROR;\n \t\t\telse\n-\t\t\t\terror_code->s.stype = ML_DRIVER_ERR_UNKNOWN;\n+\t\t\t\terror_code->s.stype = ML_CN10K_DRIVER_ERR_UNKNOWN;\n \t\t}\n \n \t\top->impl_opaque = result->error_code;\n@@ -1219,7 +1199,7 @@ cn10k_ml_enqueue_single(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_op *op, ui\n \n \tmemset(&req->cn10k_req.result, 0, sizeof(struct cn10k_ml_result));\n \terror_code = (union cn10k_ml_error_code *)&req->cn10k_req.result.error_code;\n-\terror_code->s.etype = ML_ETYPE_UNKNOWN;\n+\terror_code->s.etype = ML_CNXK_ETYPE_UNKNOWN;\n \treq->cn10k_req.result.user_ptr = op->user_ptr;\n \n \tcnxk_ml_set_poll_ptr(req);\n@@ -1236,30 +1216,29 @@ __rte_hot int\n cn10k_ml_op_error_get(struct rte_ml_dev *dev, struct rte_ml_op *op, struct rte_ml_op_error *error)\n {\n \tunion cn10k_ml_error_code *error_code;\n-\tchar msg[RTE_ML_STR_MAX];\n \n \tPLT_SET_USED(dev);\n \n \terror_code = (union cn10k_ml_error_code *)&op->impl_opaque;\n \n-\t/* Copy error message */\n-\tplt_strlcpy(msg, ml_etype_db[error_code->s.etype].name, sizeof(msg));\n-\n \t/* Copy sub error message */\n-\tif (error_code->s.etype == ML_ETYPE_HW_NONFATAL) {\n-\t\tstrcat(msg, \" : \");\n+\tif (error_code->s.etype == ML_CNXK_ETYPE_HW_NONFATAL) {\n \t\tif (error_code->s.stype < PLT_DIM(ml_stype_db_hw_nf))\n-\t\t\tstrcat(msg, ml_stype_db_hw_nf[error_code->s.stype].msg);\n+\t\t\tsnprintf(error->message, RTE_ML_STR_MAX, \"%s : %s\",\n+\t\t\t\t ml_etype_db[error_code->s.etype].str,\n+\t\t\t\t ml_stype_db_hw_nf[error_code->s.stype].str);\n \t\telse\n-\t\t\tstrcat(msg, \"UNKNOWN ERROR\");\n-\t}\n-\n-\tif (error_code->s.etype == ML_ETYPE_DRIVER) {\n-\t\tstrcat(msg, \" : \");\n-\t\tstrcat(msg, ml_stype_db_driver[error_code->s.stype].msg);\n+\t\t\tsnprintf(error->message, RTE_ML_STR_MAX, \"%s : UNKNOWN ERROR\",\n+\t\t\t\t ml_etype_db[error_code->s.etype].str);\n+\t} else if (error_code->s.etype == ML_CNXK_ETYPE_DRIVER) {\n+\t\tsnprintf(error->message, RTE_ML_STR_MAX, \"%s : %s\",\n+\t\t\t ml_etype_db[error_code->s.etype].str,\n+\t\t\t ml_stype_db_driver[error_code->s.stype].str);\n+\t} else {\n+\t\tsnprintf(error->message, RTE_ML_STR_MAX, \"%s\",\n+\t\t\t ml_etype_db[error_code->s.etype].str);\n \t}\n \n-\tplt_strlcpy(error->message, msg, sizeof(error->message));\n \terror->errcode = error_code->u64;\n \n \treturn 0;\n@@ -1297,7 +1276,7 @@ cn10k_ml_inference_sync(void *device, uint16_t index, void *input, void *output,\n \n \tmemset(&req->cn10k_req.result, 0, sizeof(struct cn10k_ml_result));\n \terror_code = (union cn10k_ml_error_code *)&req->cn10k_req.result.error_code;\n-\terror_code->s.etype = ML_ETYPE_UNKNOWN;\n+\terror_code->s.etype = ML_CNXK_ETYPE_UNKNOWN;\n \treq->cn10k_req.result.user_ptr = NULL;\n \n \tcnxk_ml_set_poll_ptr(req);\ndiff --git a/drivers/ml/cnxk/cnxk_ml_dev.c b/drivers/ml/cnxk/cnxk_ml_dev.c\nindex 2a5c17c973..63d1c9e417 100644\n--- a/drivers/ml/cnxk/cnxk_ml_dev.c\n+++ b/drivers/ml/cnxk/cnxk_ml_dev.c\n@@ -9,3 +9,11 @@\n \n /* Dummy operations for ML device */\n struct rte_ml_dev_ops ml_dev_dummy_ops = {0};\n+\n+/* Error type database */\n+struct cnxk_ml_error_db ml_etype_db[] = {\n+\t{ML_CNXK_ETYPE_NO_ERROR, \"NO_ERROR\"},\t {ML_CNXK_ETYPE_FW_NONFATAL, \"FW_NON_FATAL\"},\n+\t{ML_CNXK_ETYPE_HW_NONFATAL, \"HW_NON_FATAL\"}, {ML_CNXK_ETYPE_HW_FATAL, \"HW_FATAL\"},\n+\t{ML_CNXK_ETYPE_HW_WARNING, \"HW_WARNING\"}, {ML_CNXK_ETYPE_DRIVER, \"DRIVER_ERROR\"},\n+\t{ML_CNXK_ETYPE_UNKNOWN, \"UNKNOWN_ERROR\"},\n+};\ndiff --git a/drivers/ml/cnxk/cnxk_ml_dev.h b/drivers/ml/cnxk/cnxk_ml_dev.h\nindex 3ce9338f1f..382fca64be 100644\n--- a/drivers/ml/cnxk/cnxk_ml_dev.h\n+++ b/drivers/ml/cnxk/cnxk_ml_dev.h\n@@ -18,6 +18,22 @@\n #define ML_CNXK_POLL_JOB_START\t0\n #define ML_CNXK_POLL_JOB_FINISH 1\n \n+/* Error types enumeration */\n+enum cnxk_ml_error_etype {\n+\t/* 0x0 */ ML_CNXK_ETYPE_NO_ERROR = 0, /* No error */\n+\t/* 0x1 */ ML_CNXK_ETYPE_FW_NONFATAL, /* Firmware non-fatal error */\n+\t/* 0x2 */ ML_CNXK_ETYPE_HW_NONFATAL, /* Hardware non-fatal error */\n+\t/* 0x3 */ ML_CNXK_ETYPE_HW_FATAL, /* Hardware fatal error */\n+\t/* 0x4 */ ML_CNXK_ETYPE_HW_WARNING, /* Hardware warning */\n+\t/* 0x5 */ ML_CNXK_ETYPE_DRIVER,\t /* Driver specific error */\n+\t/* 0x6 */ ML_CNXK_ETYPE_UNKNOWN, /* Unknown error */\n+};\n+\n+struct cnxk_ml_error_db {\n+\tuint64_t code;\n+\tchar str[RTE_ML_STR_MAX];\n+};\n+\n /* Device configuration state enum */\n enum cnxk_ml_dev_state {\n \t/* Probed and not configured */\n@@ -78,4 +94,6 @@ struct cnxk_ml_dev {\n \tstruct cnxk_ml_index_map *index_map;\n };\n \n+extern struct cnxk_ml_error_db ml_etype_db[];\n+\n #endif /* _CNXK_ML_DEV_H_ */\ndiff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.c\nindex 923e603e8e..e6c67c71f5 100644\n--- a/drivers/ml/cnxk/cnxk_ml_ops.c\n+++ b/drivers/ml/cnxk/cnxk_ml_ops.c\n@@ -1433,7 +1433,7 @@ cnxk_ml_dequeue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op *\n \t\tif (plt_tsc_cycles() < req->timeout)\n \t\t\tgoto empty_or_active;\n \t\telse /* Timeout, set indication of driver error */\n-\t\t\tmodel->set_error_code(req, ML_ETYPE_DRIVER, 0);\n+\t\t\tmodel->set_error_code(req, ML_CNXK_ETYPE_DRIVER, 0);\n \t}\n \n \tmodel->result_update(cnxk_mldev, qp->id, req);\n", "prefixes": [ "v2", "18/34" ] }