Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 131540,
    "url": "http://patches.dpdk.org/api/patches/131540/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230918024612.1600536-7-chaoyong.he@corigine.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230918024612.1600536-7-chaoyong.he@corigine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230918024612.1600536-7-chaoyong.he@corigine.com",
    "date": "2023-09-18T02:45:52",
    "name": "[v4,06/26] net/nfp: adjust the log statement",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "cf32b4a6a467e1c542594f265d7f268749f429af",
    "submitter": {
        "id": 2554,
        "url": "http://patches.dpdk.org/api/people/2554/?format=api",
        "name": "Chaoyong He",
        "email": "chaoyong.he@corigine.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230918024612.1600536-7-chaoyong.he@corigine.com/mbox/",
    "series": [
        {
            "id": 29531,
            "url": "http://patches.dpdk.org/api/series/29531/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29531",
            "date": "2023-09-18T02:45:46",
            "name": "refact the nfpcore module",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/29531/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/131540/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/131540/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0AC6425C9;\n\tMon, 18 Sep 2023 04:48:10 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 36FC640ECF;\n\tMon, 18 Sep 2023 04:47:29 +0200 (CEST)",
            "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2101.outbound.protection.outlook.com [40.107.244.101])\n by mails.dpdk.org (Postfix) with ESMTP id AAF8D40DC9\n for <dev@dpdk.org>; Mon, 18 Sep 2023 04:47:24 +0200 (CEST)",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6435.namprd13.prod.outlook.com (2603:10b6:510:2ea::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep\n 2023 02:47:22 +0000",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd%6]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023\n 02:47:22 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=njfirGVx+o66vxBzjutlUW4gEdDRgqKKpzLs8LjS/HM1vvpqxNiq922oJPA9Y9Gi17PEj+WD//WtDWYZ0xb7ed8QrYdeSzKrnSOwPduiDQpIjrx1aOrIELEZn3lW1z+vqfvTVzfWZAEuaULY5cPy0T4Nq2PZYi4TQKV6ZxK553007ACcxwtOrBd6ZNXhfQtbGYUOtdhkp+s9i0q+BiCMLpcA8yceV98jDo2qyEz68muQGKbrzypTKknOhM3EurY8py/TFtMDQwz+yKBbKHo/nF4aCETQGZ3cfdhg/FXP9CAvCJ9fdFSNWjYy0ntcGfSBxqDDE62Mgnm6BM0/eleGWQ==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=P+egFwu2VaKd2IPzhwAunRRJgKBSVUVl1m3jfWok2y0=;\n b=QX4fimJucUkDX9gsOreZd3dd4O8Y/ZqmwMBXiR9LTBefN8a5gi64oINS8ItmrBewwKyVGXI0hK9rHK1ktngvIYSmctpeBpfoJedwNqkiQi/tef/OFsDFUKWDJb6dJY2Y7k9Rcx13cch29RTCQrEdyJrkbFGL3PmGPmmDNunQBausz8Dij4n/BVSFg8hxne10hA6Q39LMKAH4XfbLpghnkYo6E/PJbz4GhWUPbQEUDApb9A59/RjwSk/KkcCEEkk/poahu3+0PvXCuFm3c1EF1UmblLayFTcAya7PDuOmPfEed2RC6fkgn6rkidaCoe1ZORo5OYunlevlY7uxa3Dz1Q==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=P+egFwu2VaKd2IPzhwAunRRJgKBSVUVl1m3jfWok2y0=;\n b=OlVp6pKWbxQHTeMeLAY2E+GMPfLjqb1QOS72uq7yc77MrrwgWhHo9O79md6vaVCd6oySaZXnifinwvnVz7bsp++BtnDKhGmKUQPQdy4dD6JuIUA9EetpL4O2xETqXorCUC1oO+kmcHV34WtwDO16YeScGpRzAPx1FpiLfgzeFgA=",
        "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;",
        "From": "Chaoyong He <chaoyong.he@corigine.com>",
        "To": "dev@dpdk.org",
        "Cc": "Chaoyong He <chaoyong.he@corigine.com>,\n =?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com>",
        "Subject": "[PATCH v4 06/26] net/nfp: adjust the log statement",
        "Date": "Mon, 18 Sep 2023 10:45:52 +0800",
        "Message-Id": "<20230918024612.1600536-7-chaoyong.he@corigine.com>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20230918024612.1600536-1-chaoyong.he@corigine.com>",
        "References": "<20230915091551.1459606-1-chaoyong.he@corigine.com>\n <20230918024612.1600536-1-chaoyong.he@corigine.com>",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-ClientProxiedBy": "SE2P216CA0016.KORP216.PROD.OUTLOOK.COM\n (2603:1096:101:114::20) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)",
        "MIME-Version": "1.0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6435:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "64ebf28e-43d2-4631-38a7-08dbb7f1958d",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n +lYEt1ycRUIsX6Py3zE4BTNvt8QOzoqTLTQFJM2zkJLtzej6kUH+RtY0srOaTA9GgOnAuv/MhSHkOOwqOjyiy/mGCAcmSobv573C4+MKo7ImDIrr4tpE0rop3rPiq8qaI1DaTIVR0abDciLQeT5eSb+eJfQy7W7vRWpziDJT6oTCXdcBKHm+5USMzfZgEaSbOZJSRbTLkNtX3DXIfLQHPSUnNSEF8dgEgEiGDW4Hx7DhMTwccCf/qEGm6BjS+wSwLNwBTfGq1Kdm/eX4tnKYQm+r3Rgac7UYv0eGRzs0939aEmsg7EcmAsASFYsEVV30DZ447W3M0amIzZADq47e5JiQwApK43yIXCBoNy8nd2H0LVo35nlni2Mq1qanZbxaFoOaay2j+iXtu058aCzYaDbmVqGEPcRt3e5m74j9UMeFoY5ryv2ZiOEDH6sLovtmN+A4j6y5bhtl1N49iBrqUh6HhWANAHUHuCmPZQJfvJ4WbT/BuPFX1miGM4blNrsQ8xl+8YVA+SBg2i2gAxEOixtGSiBsbWzN+4EzNdWk1CTFibw8YEqI5L4WDAEdABnhWgq11of8AtAO3Dk8VD0EwItmkaYs8fSdEUR9EzHJtoZDMhRHfbBw2U1XX1FAehzDcHl7uM+S36y2uqxjkCPTczzYeyRvDFtruRyWKULPFOU=",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39830400003)(136003)(346002)(366004)(376002)(396003)(1800799009)(451199024)(186009)(54906003)(66476007)(66946007)(66574015)(41300700001)(6916009)(316002)(8676002)(4326008)(8936002)(52116002)(6506007)(6486002)(6512007)(478600001)(6666004)(83380400001)(26005)(1076003)(2616005)(107886003)(86362001)(2906002)(30864003)(44832011)(38100700002)(38350700002)(5660300002)(36756003)(66556008);\n DIR:OUT; SFP:1102;",
        "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1",
        "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?7U0hiVAhXCn9+iPykQHZUv39/9K/?=\n\t=?utf-8?q?MJ+cdvTXgArmFizykvTjTiIt3MZW5S3TkVaqOPdl9KHpFsDGqx3dBzOQFEdAmkMgk?=\n\t=?utf-8?q?U2QiIVuvZPDaJpYfriJlQwlIGuVcKCsxXIfdAFDAhiY356ELXlQS104hUglyQdDhn?=\n\t=?utf-8?q?OrGQis4SIqdzXGnovJMcGplKfVZg2/Wgz5p1b0+1EKlq32FHWZiMqJfmVwPWrelDI?=\n\t=?utf-8?q?i6Qi5b6OiP/RxnRKmr9/xATgI1coTKThNJqGxgVgAArBxTlOpGViAw/ymD5jdbgEk?=\n\t=?utf-8?q?DHlGeWDBP1s/AKLoordWIILScrGEVE3+cGp3I6CnnoHNHg2OaoopJx5e+nrND6DCx?=\n\t=?utf-8?q?p+WyZwJDAPMnkiyfdI0/1oAiBfTHZlPsWsvCOOt5VBUq8ASqwIkVxndvChiRrjRLk?=\n\t=?utf-8?q?J70IRflkMW8ZB3Td/pzFdGYv8ap+TD1EeGNqKOVtmcq343R4oBG/HD/jlliWYCv/c?=\n\t=?utf-8?q?LuBDZOJQ/BgOMo+0yhpo6RfwdfBI6mEWChC3+nMywyLVJk1Xjomw7OrHoB8171kpj?=\n\t=?utf-8?q?BH0St7Isw//DwgWgrnU3R7cUvnNbyd0meR/ROnyyHmejdp8eTeJuWlGFQSr2PVYB0?=\n\t=?utf-8?q?9a32JLYvmihE9l1GnvN0IICYJZFY1rvKFsWi9BBuwoV/uvoSC5ytJ3QRd6l8Aji4l?=\n\t=?utf-8?q?f1Np/ZDvqrGlvR2F26as31BxqhD9FRIcukJSp5hmm2UnnWyLBtfeNLECOd+LZawwm?=\n\t=?utf-8?q?w3BPkiRdKs6KVcONHQkUEDutCvV7ls169M8To6swiM2XxosqRbCE7SrNv3kjRcKkG?=\n\t=?utf-8?q?71L8PXA5snYytumSUOK5+x9DWtsvQgBfYyWUpU/JLS0baailxHnv+8bmbdqWXpiBj?=\n\t=?utf-8?q?r4Gpdqj5ImqUjsJ2npmobRH9VrTQpKUM+BpKHl2IA+wcgmUoZtKqkUOnDKiI6eTji?=\n\t=?utf-8?q?srHlIxzqXsuvohtJK+NlExEkUnMNss/+FMsA8xHv8Ut8Bn0kzXTJlUwrRlYtppgeo?=\n\t=?utf-8?q?aQl35pQFpUSdmi3+wLWvdYRESJ+tXx1ES53Bsf/ilcjmNzwn8n6NHfjqX5PsTHFAc?=\n\t=?utf-8?q?BAHgGn5bcM6O/lZjFMAxfbWY7KyVe4+/wtBGlcFBqq2xKb4oxAB5p7HVlCaKmQcYx?=\n\t=?utf-8?q?qBJDyaGxL3O776juOODamTDkp9x+qYP/1v72xrzN27bQlyG6HkWTXqkAqeiibB4RM?=\n\t=?utf-8?q?2+NpQw6Oxe61Keucd/Ab+8z6mk+ZflRW0KfF4+3IE33szexiiv/cllgfwl5KIep2Q?=\n\t=?utf-8?q?t9kq4YriS1UYJAjkBLp2vLRsCTgpdjtNJWs//OxiRvimkAe6KiLhMQXbtdiferPJo?=\n\t=?utf-8?q?1xdb49RLRRtaaiHBsHkc/YmE33RpE1+frzCuimUcAYBuVhprUvfbdq2B2hhqMiFQN?=\n\t=?utf-8?q?moSl35EC7gFGW0oLLc0ZtzYKdmlYQmZJxstljBpfTnLjhvdkemszaLZnqI+A3a1nk?=\n\t=?utf-8?q?B3bn0MwyQ/5XTCxX3qbPI6DBY54q1z6kzlVmH1ZDEstYKaWVPKiTlwF1NAmAR6UbU?=\n\t=?utf-8?q?T07ylvYHihvk2P+sDJkUEkpoQ5d9OkuiWYIhkAha970hk84DpIBRNNuIBzUaoANU+?=\n\t=?utf-8?q?k6voWx5clV6qgSt2ayQrRg0qG4motKjHag=3D=3D?=",
        "X-OriginatorOrg": "corigine.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 64ebf28e-43d2-4631-38a7-08dbb7f1958d",
        "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Sep 2023 02:47:22.8883 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n dhSJWEp0E2nH0X8Fc17PlA8pwMGtHncpieW5rrw+bX7esWcDqJiRpgSA4Kh2cN/eN1msnuqDWmLh/WRbx0pMrG3sDgrMumsmmcyE2YigV9Q=",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6435",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Add log statement to the important control logic, which means\nmore strict check of the return value of function call.\nAlso remove some verbose info log statement.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 37 ++++++----------------\n drivers/net/nfp/nfpcore/nfp_cppcore.c      | 20 +++++++++---\n drivers/net/nfp/nfpcore/nfp_hwinfo.c       | 28 ++++++++--------\n drivers/net/nfp/nfpcore/nfp_mip.c          |  7 ++--\n drivers/net/nfp/nfpcore/nfp_mutex.c        |  5 +--\n drivers/net/nfp/nfpcore/nfp_nffw.c         |  9 ++++--\n drivers/net/nfp/nfpcore/nfp_nsp.c          | 25 +++++++++++----\n drivers/net/nfp/nfpcore/nfp_nsp_eth.c      | 10 +++---\n drivers/net/nfp/nfpcore/nfp_resource.c     | 17 +++++++---\n drivers/net/nfp/nfpcore/nfp_rtsym.c        | 14 +++-----\n 10 files changed, 92 insertions(+), 80 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\nindex 78beee07ef..bdf4a658f5 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n@@ -174,18 +174,10 @@ nfp_compute_bar(const struct nfp_bar *bar,\n \t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_ACTION_BASEADDRESS(act);\n \t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TOKEN_BASEADDRESS(tok);\n \n-\t\tif ((offset & mask) != ((offset + size - 1) & mask)) {\n-\t\t\tPMD_DRV_LOG(ERR, \"BAR%d: Won't use for Fixed mapping <%#llx,%#llx>, action=%d BAR too small (0x%llx)\",\n-\t\t\t\t\tbar->index, (unsigned long long)offset,\n-\t\t\t\t\t(unsigned long long)(offset + size), act,\n-\t\t\t\t\t(unsigned long long)mask);\n+\t\tif ((offset & mask) != ((offset + size - 1) & mask))\n \t\t\treturn -EINVAL;\n-\t\t}\n-\t\toffset &= mask;\n \n-\t\tPMD_DRV_LOG(DEBUG, \"BAR%d: Created Fixed mapping %d:%d:%d:0x%#llx-0x%#llx>\",\n-\t\t\t\tbar->index, tgt, act, tok, (unsigned long long)offset,\n-\t\t\t\t(unsigned long long)(offset + mask));\n+\t\toffset &= mask;\n \n \t\tbitsize = 40 - 16;\n \t} else {\n@@ -198,30 +190,16 @@ nfp_compute_bar(const struct nfp_bar *bar,\n \t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TARGET_BASEADDRESS(tgt);\n \t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TOKEN_BASEADDRESS(tok);\n \n-\t\tif ((offset & mask) != ((offset + size - 1) & mask)) {\n-\t\t\tPMD_DRV_LOG(ERR, \"BAR%d: Won't use for bulk mapping <%#llx,%#llx> target=%d, token=%d BAR too small (%#llx) - (%#llx != %#llx).\",\n-\t\t\t\t\tbar->index, (unsigned long long)offset,\n-\t\t\t\t\t(unsigned long long)(offset + size),\n-\t\t\t\t\ttgt, tok, (unsigned long long)mask,\n-\t\t\t\t\t(unsigned long long)(offset & mask),\n-\t\t\t\t\t(unsigned long long)(offset + size - 1) & mask);\n+\t\tif ((offset & mask) != ((offset + size - 1) & mask))\n \t\t\treturn -EINVAL;\n-\t\t}\n \n \t\toffset &= mask;\n \n-\t\tPMD_DRV_LOG(DEBUG, \"BAR%d: Created bulk mapping %d:x:%d:%#llx-%#llx\",\n-\t\t\t\tbar->index, tgt, tok, (unsigned long long)offset,\n-\t\t\t\t(unsigned long long)(offset + ~mask));\n-\n \t\tbitsize = 40 - 21;\n \t}\n \n-\tif (bar->bitsize < bitsize) {\n-\t\tPMD_DRV_LOG(ERR, \"BAR%d: Too small for %d:%d:%d\", bar->index,\n-\t\t\t\ttgt, tok, act);\n+\tif (bar->bitsize < bitsize)\n \t\treturn -EINVAL;\n-\t}\n \n \tnewcfg |= offset >> bitsize;\n \n@@ -254,7 +232,6 @@ nfp_bar_write(struct nfp_pcie_user *nfp,\n \t*(uint32_t *)(bar->csr) = newcfg;\n \n \tbar->barcfg = newcfg;\n-\tPMD_DRV_LOG(DEBUG, \"BAR%d: updated to 0x%08x\", bar->index, newcfg);\n \n \treturn 0;\n }\n@@ -795,7 +772,11 @@ nfp6000_init(struct nfp_cpp *cpp,\n \tdesc->cfg = dev->mem_resource[0].addr;\n \tdesc->dev_id = dev->addr.function & 0x7;\n \n-\tnfp_enable_bars(desc);\n+\tret = nfp_enable_bars(desc);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Enable bars failed\");\n+\t\treturn -1;\n+\t}\n \n \tnfp_cpp_priv_set(cpp, desc);\n \ndiff --git a/drivers/net/nfp/nfpcore/nfp_cppcore.c b/drivers/net/nfp/nfpcore/nfp_cppcore.c\nindex 2e5a4e7349..e2af888a28 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cppcore.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cppcore.c\n@@ -200,6 +200,7 @@ nfp_cpp_area_alloc_with_name(struct nfp_cpp *cpp,\n \n \terr = cpp->op->area_init(area, dest, address, size);\n \tif (err < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Area init op failed\");\n \t\tfree(area);\n \t\treturn NULL;\n \t}\n@@ -243,10 +244,13 @@ nfp_cpp_area_alloc_acquire(struct nfp_cpp *cpp,\n \tstruct nfp_cpp_area *area;\n \n \tarea = nfp_cpp_area_alloc(cpp, destination, address, size);\n-\tif (area == NULL)\n+\tif (area == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to allocate CPP area\");\n \t\treturn NULL;\n+\t}\n \n \tif (nfp_cpp_area_acquire(area) != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to acquire CPP area\");\n \t\tnfp_cpp_area_free(area);\n \t\treturn NULL;\n \t}\n@@ -294,8 +298,10 @@ nfp_cpp_area_acquire(struct nfp_cpp_area *area)\n \tif (area->cpp->op->area_acquire != NULL) {\n \t\tint err = area->cpp->op->area_acquire(area);\n \n-\t\tif (err < 0)\n+\t\tif (err < 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Area acquire op failed\");\n \t\t\treturn -1;\n+\t\t}\n \t}\n \n \treturn 0;\n@@ -662,7 +668,7 @@ nfp_cpp_read(struct nfp_cpp *cpp,\n \n \tarea = nfp_cpp_area_alloc_acquire(cpp, destination, address, length);\n \tif (area == NULL) {\n-\t\tPMD_DRV_LOG(ERR, \"Area allocation/acquire failed\");\n+\t\tPMD_DRV_LOG(ERR, \"Area allocation/acquire failed for read\");\n \t\treturn -1;\n \t}\n \n@@ -691,8 +697,10 @@ nfp_cpp_write(struct nfp_cpp *cpp,\n \tstruct nfp_cpp_area *area;\n \n \tarea = nfp_cpp_area_alloc_acquire(cpp, destination, address, length);\n-\tif (area == NULL)\n+\tif (area == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"Area allocation/acquire failed for write\");\n \t\treturn -1;\n+\t}\n \n \terr = nfp_cpp_area_write(area, 0, kernel_vaddr, length);\n \n@@ -746,8 +754,10 @@ nfp_cpp_map_area(struct nfp_cpp *cpp,\n \tuint8_t *res;\n \n \t*area = nfp_cpp_area_alloc_acquire(cpp, cpp_id, addr, size);\n-\tif (*area == NULL)\n+\tif (*area == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"Area allocation/acquire failed for map\");\n \t\tgoto err_eio;\n+\t}\n \n \tres = nfp_cpp_area_iomem(*area);\n \tif (res == NULL)\ndiff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c\nindex 819761eda0..b658b5e900 100644\n--- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c\n+++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c\n@@ -74,7 +74,7 @@ nfp_hwinfo_db_validate(struct nfp_hwinfo *db,\n \tnew_crc = nfp_crc32_posix((char *)db, size);\n \tcrc = (uint32_t *)(db->start + size);\n \tif (new_crc != *crc) {\n-\t\tPMD_DRV_LOG(ERR, \"Corrupt hwinfo table (CRC mismatch) calculated 0x%x, expected 0x%x\",\n+\t\tPMD_DRV_LOG(ERR, \"CRC mismatch, calculated %#x, expected %#x\",\n \t\t\t\tnew_crc, *crc);\n \t\treturn -EINVAL;\n \t}\n@@ -94,34 +94,36 @@ nfp_hwinfo_try_fetch(struct nfp_cpp *cpp,\n \tstruct nfp_hwinfo *header;\n \n \tres = nfp_resource_acquire(cpp, NFP_RESOURCE_NFP_HWINFO);\n-\tif (res) {\n-\t\tcpp_id = nfp_resource_cpp_id(res);\n-\t\tcpp_addr = nfp_resource_address(res);\n-\t\t*cpp_size = nfp_resource_size(res);\n+\tif (res == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"HWInfo - acquire resource failed\");\n+\t\treturn NULL;\n+\t}\n \n-\t\tnfp_resource_release(res);\n+\tcpp_id = nfp_resource_cpp_id(res);\n+\tcpp_addr = nfp_resource_address(res);\n+\t*cpp_size = nfp_resource_size(res);\n \n-\t\tif (*cpp_size < HWINFO_SIZE_MIN)\n-\t\t\treturn NULL;\n-\t} else {\n+\tnfp_resource_release(res);\n+\n+\tif (*cpp_size < HWINFO_SIZE_MIN)\n \t\treturn NULL;\n-\t}\n \n \tdb = malloc(*cpp_size + 1);\n \tif (db == NULL)\n \t\treturn NULL;\n \n \terr = nfp_cpp_read(cpp, cpp_id, cpp_addr, db, *cpp_size);\n-\tif (err != (int)*cpp_size)\n+\tif (err != (int)*cpp_size) {\n+\t\tPMD_DRV_LOG(ERR, \"HWInfo - CPP read error %d\", err);\n \t\tgoto exit_free;\n+\t}\n \n \theader = (void *)db;\n-\tPMD_DRV_LOG(DEBUG, \"NFP HWINFO header: %#08x\", *(uint32_t *)header);\n \tif (nfp_hwinfo_is_updating(header))\n \t\tgoto exit_free;\n \n \tif (header->version != NFP_HWINFO_VERSION_2) {\n-\t\tPMD_DRV_LOG(DEBUG, \"Unknown HWInfo version: 0x%08x\",\n+\t\tPMD_DRV_LOG(ERR, \"Unknown HWInfo version: %#08x\",\n \t\t\t\theader->version);\n \t\tgoto exit_free;\n \t}\ndiff --git a/drivers/net/nfp/nfpcore/nfp_mip.c b/drivers/net/nfp/nfpcore/nfp_mip.c\nindex 1e601313b4..086e82db70 100644\n--- a/drivers/net/nfp/nfpcore/nfp_mip.c\n+++ b/drivers/net/nfp/nfpcore/nfp_mip.c\n@@ -46,16 +46,16 @@ nfp_mip_try_read(struct nfp_cpp *cpp,\n \n \tret = nfp_cpp_read(cpp, cpp_id, addr, mip, sizeof(*mip));\n \tif (ret != sizeof(*mip)) {\n-\t\tPMD_DRV_LOG(ERR, \"Failed to read MIP data (%d, %zu)\", ret, sizeof(*mip));\n+\t\tPMD_DRV_LOG(ERR, \"Failed to read MIP data\");\n \t\treturn -EIO;\n \t}\n \tif (mip->signature != NFP_MIP_SIGNATURE) {\n-\t\tPMD_DRV_LOG(ERR, \"Incorrect MIP signature (0x%08x)\",\n+\t\tPMD_DRV_LOG(ERR, \"Incorrect MIP signature %#08x\",\n \t\t\t\trte_le_to_cpu_32(mip->signature));\n \t\treturn -EINVAL;\n \t}\n \tif (mip->mip_version != NFP_MIP_VERSION) {\n-\t\tPMD_DRV_LOG(ERR, \"Unsupported MIP version (%d)\",\n+\t\tPMD_DRV_LOG(ERR, \"Unsupported MIP version %d\",\n \t\t\t\trte_le_to_cpu_32(mip->mip_version));\n \t\treturn -EINVAL;\n \t}\n@@ -109,6 +109,7 @@ nfp_mip_open(struct nfp_cpp *cpp)\n \n \terr = nfp_mip_read_resource(cpp, mip);\n \tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to read MIP resource\");\n \t\tfree(mip);\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/net/nfp/nfpcore/nfp_mutex.c b/drivers/net/nfp/nfpcore/nfp_mutex.c\nindex 5be437b354..82919d8270 100644\n--- a/drivers/net/nfp/nfpcore/nfp_mutex.c\n+++ b/drivers/net/nfp/nfpcore/nfp_mutex.c\n@@ -221,10 +221,7 @@ nfp_cpp_mutex_lock(struct nfp_cpp_mutex *mutex)\n \t\tif (err < 0 && err != -EBUSY)\n \t\t\treturn err;\n \t\tif (time(NULL) >= warn_at) {\n-\t\t\tPMD_DRV_LOG(ERR, \"Warning: waiting for NFP mutex usage:%u depth:%hd] \"\n-\t\t\t\t\t\"target:%d key:%08x] addr:%\" PRIx64,\n-\t\t\t\t\tmutex->usage, mutex->depth, mutex->target,\n-\t\t\t\t\tmutex->key, mutex->address);\n+\t\t\tPMD_DRV_LOG(WARNING, \"Waiting for NFP mutex...\");\n \t\t\twarn_at = time(NULL) + 60;\n \t\t}\n \t\tsched_yield();\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nffw.c b/drivers/net/nfp/nfpcore/nfp_nffw.c\nindex 9123fc742a..b5a354137d 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nffw.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nffw.c\n@@ -3,6 +3,7 @@\n  * All rights reserved.\n  */\n \n+#include \"../nfp_logs.h\"\n #include \"nfp_cpp.h\"\n #include \"nfp_nffw.h\"\n #include \"nfp_mip.h\"\n@@ -132,8 +133,10 @@ nfp_nffw_info_open(struct nfp_cpp *cpp)\n \tmemset(state, 0, sizeof(*state));\n \n \tstate->res = nfp_resource_acquire(cpp, NFP_RESOURCE_NFP_NFFW);\n-\tif (state->res == NULL)\n+\tif (state->res == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"NFFW - acquire resource failed\");\n \t\tgoto err_free;\n+\t}\n \n \tfwinf = &state->fwinf;\n \n@@ -143,8 +146,10 @@ nfp_nffw_info_open(struct nfp_cpp *cpp)\n \terr = nfp_cpp_read(cpp, nfp_resource_cpp_id(state->res),\n \t\t\tnfp_resource_address(state->res),\n \t\t\tfwinf, sizeof(*fwinf));\n-\tif (err < (int)sizeof(*fwinf))\n+\tif (err < (int)sizeof(*fwinf)) {\n+\t\tPMD_DRV_LOG(ERR, \"NFFW - CPP read error %d\", err);\n \t\tgoto err_release;\n+\t}\n \n \tif (nffw_res_flg_init_get(fwinf) == 0)\n \t\tgoto err_release;\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp.c b/drivers/net/nfp/nfpcore/nfp_nsp.c\nindex 4861772a98..ff19446173 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp.c\n@@ -82,8 +82,10 @@ nfp_nsp_check(struct nfp_nsp *state)\n \tnsp_status = nfp_resource_address(state->res) + NSP_STATUS;\n \n \terr = nfp_cpp_readq(cpp, nsp_cpp, nsp_status, &reg);\n-\tif (err < 0)\n+\tif (err < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"NSP - CPP readq failed %d\", err);\n \t\treturn err;\n+\t}\n \n \tif (FIELD_GET(NSP_STATUS_MAGIC, reg) != NSP_MAGIC) {\n \t\tPMD_DRV_LOG(ERR, \"Cannot detect NFP Service Processor\");\n@@ -119,8 +121,10 @@ nfp_nsp_open(struct nfp_cpp *cpp)\n \tstruct nfp_resource *res;\n \n \tres = nfp_resource_acquire(cpp, NFP_RESOURCE_NSP);\n-\tif (res == NULL)\n+\tif (res == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"NSP - resource acquire failed\");\n \t\treturn NULL;\n+\t}\n \n \tstate = malloc(sizeof(*state));\n \tif (state == NULL) {\n@@ -133,6 +137,7 @@ nfp_nsp_open(struct nfp_cpp *cpp)\n \n \terr = nfp_nsp_check(state);\n \tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"NSP - check failed\");\n \t\tnfp_nsp_close(state);\n \t\treturn NULL;\n \t}\n@@ -180,8 +185,10 @@ nfp_nsp_wait_reg(struct nfp_cpp *cpp,\n \n \tfor (;;) {\n \t\terr = nfp_cpp_readq(cpp, nsp_cpp, addr, reg);\n-\t\tif (err < 0)\n+\t\tif (err < 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"NSP - CPP readq failed\");\n \t\t\treturn err;\n+\t\t}\n \n \t\tif ((*reg & mask) == val)\n \t\t\treturn 0;\n@@ -234,8 +241,10 @@ nfp_nsp_command(struct nfp_nsp *state,\n \tnsp_buffer = nsp_base + NSP_BUFFER;\n \n \terr = nfp_nsp_check(state);\n-\tif (err != 0)\n+\tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Check NSP command failed\");\n \t\treturn err;\n+\t}\n \n \tif (!FIELD_FIT(NSP_BUFFER_CPP, buff_cpp >> 8) ||\n \t\t\t!FIELD_FIT(NSP_BUFFER_ADDRESS, buff_addr)) {\n@@ -261,7 +270,7 @@ nfp_nsp_command(struct nfp_nsp *state,\n \terr = nfp_nsp_wait_reg(cpp, &reg, nsp_cpp, nsp_command,\n \t\t\tNSP_COMMAND_START, 0);\n \tif (err != 0) {\n-\t\tPMD_DRV_LOG(ERR, \"Error %d waiting for code 0x%04x to start\",\n+\t\tPMD_DRV_LOG(ERR, \"Error %d waiting for code %#04x to start\",\n \t\t\t\terr, code);\n \t\treturn err;\n \t}\n@@ -270,7 +279,7 @@ nfp_nsp_command(struct nfp_nsp *state,\n \terr = nfp_nsp_wait_reg(cpp, &reg, nsp_cpp, nsp_status,\n \t\t\tNSP_STATUS_BUSY, 0);\n \tif (err != 0) {\n-\t\tPMD_DRV_LOG(ERR, \"Error %d waiting for code 0x%04x to start\",\n+\t\tPMD_DRV_LOG(ERR, \"Error %d waiting for code %#04x to complete\",\n \t\t\t\terr, code);\n \t\treturn err;\n \t}\n@@ -352,8 +361,10 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp,\n \t}\n \n \tret = nfp_nsp_command(nsp, code, option, cpp_id, cpp_buf);\n-\tif (ret < 0)\n+\tif (ret < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"NSP command failed\");\n \t\treturn ret;\n+\t}\n \n \tif (out_buf != NULL && out_size > 0) {\n \t\terr = nfp_cpp_read(cpp, cpp_id, cpp_buf, out_buf, out_size);\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp_eth.c b/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\nindex 9b7c8aa7f8..74daa92aed 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\n@@ -260,7 +260,7 @@ __nfp_eth_read_ports(struct nfp_nsp *nsp)\n \tmemset(entries, 0, NSP_ETH_TABLE_SIZE);\n \tret = nfp_nsp_read_eth_table(nsp, entries, NSP_ETH_TABLE_SIZE);\n \tif (ret < 0) {\n-\t\tPMD_DRV_LOG(ERR, \"reading port table failed %d\", ret);\n+\t\tPMD_DRV_LOG(ERR, \"Reading port table failed %d\", ret);\n \t\tgoto err;\n \t}\n \n@@ -279,7 +279,7 @@ __nfp_eth_read_ports(struct nfp_nsp *nsp)\n \t * above.\n \t */\n \tif (ret != 0 && ret != cnt) {\n-\t\tPMD_DRV_LOG(ERR, \"table entry count (%d) unmatch entries present (%d)\",\n+\t\tPMD_DRV_LOG(ERR, \"Table entry count (%d) unmatch entries present (%d)\",\n \t\t\t\tret, cnt);\n \t\tgoto err;\n \t}\n@@ -358,12 +358,12 @@ nfp_eth_config_start(struct nfp_cpp *cpp,\n \n \tret = nfp_nsp_read_eth_table(nsp, entries, NSP_ETH_TABLE_SIZE);\n \tif (ret < 0) {\n-\t\tPMD_DRV_LOG(ERR, \"reading port table failed %d\", ret);\n+\t\tPMD_DRV_LOG(ERR, \"Reading port table failed %d\", ret);\n \t\tgoto err;\n \t}\n \n \tif ((entries[idx].port & NSP_ETH_PORT_LANES_MASK) == 0) {\n-\t\tPMD_DRV_LOG(ERR, \"trying to set port state on disabled port %d\", idx);\n+\t\tPMD_DRV_LOG(ERR, \"Trying to set port state on disabled port %d\", idx);\n \t\tgoto err;\n \t}\n \n@@ -643,7 +643,7 @@ __nfp_eth_set_speed(struct nfp_nsp *nsp,\n \n \trate = nfp_eth_speed2rate(speed);\n \tif (rate == RATE_INVALID) {\n-\t\tPMD_DRV_LOG(ERR, \"could not find matching lane rate for speed %u\", speed);\n+\t\tPMD_DRV_LOG(ERR, \"Could not find matching lane rate for speed %u\", speed);\n \t\treturn -EINVAL;\n \t}\n \ndiff --git a/drivers/net/nfp/nfpcore/nfp_resource.c b/drivers/net/nfp/nfpcore/nfp_resource.c\nindex fa92f2762e..363f7d6198 100644\n--- a/drivers/net/nfp/nfpcore/nfp_resource.c\n+++ b/drivers/net/nfp/nfpcore/nfp_resource.c\n@@ -118,16 +118,22 @@ nfp_resource_try_acquire(struct nfp_cpp *cpp,\n {\n \tint err;\n \n-\tif (nfp_cpp_mutex_lock(dev_mutex) != 0)\n+\tif (nfp_cpp_mutex_lock(dev_mutex) != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"RESOURCE - CPP mutex lock failed\");\n \t\treturn -EINVAL;\n+\t}\n \n \terr = nfp_cpp_resource_find(cpp, res);\n-\tif (err != 0)\n+\tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"RESOURCE - CPP resource find failed\");\n \t\tgoto err_unlock_dev;\n+\t}\n \n \terr = nfp_cpp_mutex_trylock(res->mutex);\n-\tif (err != 0)\n+\tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"RESOURCE - CPP mutex trylock failed\");\n \t\tgoto err_res_mutex_free;\n+\t}\n \n \tnfp_cpp_mutex_unlock(dev_mutex);\n \n@@ -171,6 +177,7 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \tdev_mutex = nfp_cpp_mutex_alloc(cpp, NFP_RESOURCE_TBL_TARGET,\n \t\t\tNFP_RESOURCE_TBL_BASE, NFP_RESOURCE_TBL_KEY);\n \tif (dev_mutex == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"RESOURCE - CPP mutex alloc failed\");\n \t\tfree(res);\n \t\treturn NULL;\n \t}\n@@ -182,8 +189,10 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \t\terr = nfp_resource_try_acquire(cpp, res, dev_mutex);\n \t\tif (err == 0)\n \t\t\tbreak;\n-\t\tif (err != -EBUSY)\n+\t\tif (err != -EBUSY) {\n+\t\t\tPMD_DRV_LOG(ERR, \"RESOURCE - try acquire failed\");\n \t\t\tgoto err_free;\n+\t\t}\n \n \t\tif (count++ > 1000) {\n \t\t\tPMD_DRV_LOG(ERR, \"Error: resource %s timed out\", name);\ndiff --git a/drivers/net/nfp/nfpcore/nfp_rtsym.c b/drivers/net/nfp/nfpcore/nfp_rtsym.c\nindex a34278beca..d15a920752 100644\n--- a/drivers/net/nfp/nfpcore/nfp_rtsym.c\n+++ b/drivers/net/nfp/nfpcore/nfp_rtsym.c\n@@ -60,8 +60,6 @@ nfp_rtsym_sw_entry_init(struct nfp_rtsym_table *cache,\n \tsw->size = ((uint64_t)fw->size_hi << 32) |\n \t\t\trte_le_to_cpu_32(fw->size_lo);\n \n-\tPMD_INIT_LOG(DEBUG, \"rtsym_entry_init name=%s, addr=%\" PRIx64 \", size=%\" PRIu64 \", target=%d\",\n-\t\t     sw->name, sw->addr, sw->size, sw->target);\n \tswitch (fw->target) {\n \tcase SYM_TGT_LMEM:\n \t\tsw->target = NFP_RTSYM_TARGET_LMEM;\n@@ -227,7 +225,7 @@ nfp_rtsym_size(const struct nfp_rtsym *sym)\n {\n \tswitch (sym->type) {\n \tcase NFP_RTSYM_TYPE_NONE:\n-\t\tPMD_DRV_LOG(ERR, \"rtsym '%s': type NONE\", sym->name);\n+\t\tPMD_DRV_LOG(ERR, \"The type of rtsym '%s' is NONE\", sym->name);\n \t\treturn 0;\n \tcase NFP_RTSYM_TYPE_OBJECT:    /* Fall through */\n \tcase NFP_RTSYM_TYPE_FUNCTION:\n@@ -235,7 +233,7 @@ nfp_rtsym_size(const struct nfp_rtsym *sym)\n \tcase NFP_RTSYM_TYPE_ABS:\n \t\treturn sizeof(uint64_t);\n \tdefault:\n-\t\tPMD_DRV_LOG(ERR, \"rtsym '%s': unknown type: %d\", sym->name, sym->type);\n+\t\tPMD_DRV_LOG(ERR, \"Unknown RTSYM type %u\", sym->type);\n \t\treturn 0;\n \t}\n }\n@@ -366,7 +364,7 @@ nfp_rtsym_read_le(struct nfp_rtsym_table *rtbl,\n \t\terr = nfp_rtsym_readq(rtbl->cpp, sym, NFP_CPP_ACTION_RW, 0, 0, &val);\n \t\tbreak;\n \tdefault:\n-\t\tPMD_DRV_LOG(ERR, \"rtsym '%s' unsupported size: %\" PRId64,\n+\t\tPMD_DRV_LOG(ERR, \"rtsym '%s' unsupported size: %#lx\",\n \t\t\t\tname, sym->size);\n \t\terr = -EINVAL;\n \t\tbreak;\n@@ -396,10 +394,9 @@ nfp_rtsym_map(struct nfp_rtsym_table *rtbl,\n \tuint32_t cpp_id;\n \tconst struct nfp_rtsym *sym;\n \n-\tPMD_DRV_LOG(DEBUG, \"mapping symbol %s\", name);\n \tsym = nfp_rtsym_lookup(rtbl, name);\n \tif (sym == NULL) {\n-\t\tPMD_INIT_LOG(ERR, \"symbol lookup fails for %s\", name);\n+\t\tPMD_DRV_LOG(ERR, \"Symbol lookup fails for %s\", name);\n \t\treturn NULL;\n \t}\n \n@@ -418,10 +415,9 @@ nfp_rtsym_map(struct nfp_rtsym_table *rtbl,\n \n \tmem = nfp_cpp_map_area(rtbl->cpp, cpp_id, addr, sym->size, area);\n \tif (mem == NULL) {\n-\t\tPMD_INIT_LOG(ERR, \"Failed to map symbol %s\", name);\n+\t\tPMD_DRV_LOG(ERR, \"Failed to map symbol %s\", name);\n \t\treturn NULL;\n \t}\n-\tPMD_DRV_LOG(DEBUG, \"symbol %s with address %p\", name, mem);\n \n \treturn mem;\n }\n",
    "prefixes": [
        "v4",
        "06/26"
    ]
}