Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131379/?format=api
{ "id": 131379, "url": "http://patches.dpdk.org/api/patches/131379/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230913103600.1935292-5-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230913103600.1935292-5-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20230913103600.1935292-5-thomas@monjalon.net", "date": "2023-09-13T10:34:23", "name": "[v2,04/11] eal: promote thread API as stable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2ff2a2a00edb2c79a058562372054b545122198f", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230913103600.1935292-5-thomas@monjalon.net/mbox/", "series": [ { "id": 29493, "url": "http://patches.dpdk.org/api/series/29493/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29493", "date": "2023-09-13T10:34:19", "name": "rework thread management", "version": 2, "mbox": "http://patches.dpdk.org/series/29493/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131379/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131379/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7C3042588;\n\tWed, 13 Sep 2023 12:37:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3EE04067C;\n\tWed, 13 Sep 2023 12:37:03 +0200 (CEST)", "from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com\n [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id CB76D402E2\n for <dev@dpdk.org>; Wed, 13 Sep 2023 12:37:01 +0200 (CEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.46])\n by mailout.west.internal (Postfix) with ESMTP id 89510320085B;\n Wed, 13 Sep 2023 06:37:00 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Wed, 13 Sep 2023 06:37:01 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 13 Sep 2023 06:36:58 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:content-type:date\n :date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to; s=fm2; t=\n 1694601420; x=1694687820; bh=hlyDNq+UviAf6NbnW8IY9uFsNlBNIABWbp3\n kCjdFB0g=; b=nwdU12Ly1lLtNE/rBTqKopGguTU3VhpjaB2O0pbEUX5jo2YY8RX\n fomdzta5arSp5j3H7A5/n+wldVCRjV2CjlNBDq0mRF1aeGlPMu3GRkxy8oGEGXxZ\n fXOa8p09jmegmZcRy7FPUb80N1xCVQkKQsagcpmK9DEK3P5OemHpQ9vI3cyce9/Y\n PutpF2B899Z5BjPE05fj2kcIwvOjI8EjyU+1dx2ddfjpWHEAsMT8stgcRDclwFs/\n YcTi0CQdzRdf/NjitUd7BlqxytgBQYfQm0GDZ/o/+pi5Vf0N7IPQ2UqXLNSrau4l\n wIieom8jALca5IxuFM4SU1g3OKn66mg5jfQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:content-type:date:date:feedback-id:feedback-id\n :from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to:x-me-proxy\n :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=\n 1694601420; x=1694687820; bh=hlyDNq+UviAf6NbnW8IY9uFsNlBNIABWbp3\n kCjdFB0g=; b=XeJJlcf8vOGumXVolPG/O1JDdtHYr5t0zMLD2eR9Qj6ZvhOfylO\n Ci0VIwiyakwo/3So4Qn5WTeBklZuuVe5MoiPP9t0SLqfiLI7B3np6Zw//WjrWYMW\n nsbuquUNwJzWRavlG08bVI/PAsmFNF2BV6qAW4kEXfbpZ8+P4Ecvgo9hOrHrDv+p\n psn8tgwwxYPEsoTqWKyq9AmmeSqtfTU5Aisj93eQ81B6jhXlRx7o9amzVg1QtRqf\n WxMmu/muegBWQzaS+a2nR1CFrsrNnFVouCkqBEJmKFF3ggAEzKIjLDq5CXjR9LdC\n dhjZ/AIG94NEPLLvNA7tJR+6xsMv1AtYU3Q==" ], "X-ME-Sender": "<xms:y5ABZd5_XIRXb4m8WhnrMqSEST4gvjApmOT-_8t6po6x5nHN8zS-hQ>\n <xme:y5ABZa4B4iICB61CBNPOJePxSaPNXPJGZyaV0BX6V_S1hYRswaqsgbEfnMy4aqFaA\n lm6swT0vKoJxT2OPw>", "X-ME-Received": "\n <xmr:y5ABZUdjhU-areEUPP6uUO7rrKQ_GHQqFrY5QfoYwa90wkp4vUbDdxP3kr5LJ0PPkPmR3A>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedviedrudeikedgfedtucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhho\n mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne\n cuggftrfgrthhtvghrnheptdeiffffgeefteelhfekueetueduffejgfelvedtieejudek\n gfevheetheehgeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh\n hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:y5ABZWJ7VA_izW7015g0M4tnN-kM4wG2zpawn8qKfKBc2Ui47tycsg>\n <xmx:y5ABZRJZbmQEAAiPg2MAQuUoVIsW0sJBUl0ZMBdqxv0ltQ447NWJ9Q>\n <xmx:y5ABZfy0gCDhIeOlzoJKrWVdoFpCVX7BUl2m6t-_L_X1ItCdYufMwA>\n <xmx:zJABZR0-FLN_1OlfuHiODGCKdthx9pevHJxNmWNh0KE2Cil2o7FXEQ>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@linux.microsoft.com>,\n David Marchand <david.marchand@redhat.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "Subject": "[PATCH v2 04/11] eal: promote thread API as stable", "Date": "Wed, 13 Sep 2023 12:34:23 +0200", "Message-ID": "<20230913103600.1935292-5-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230913103600.1935292-1-thomas@monjalon.net>", "References": "<20230906162226.1618088-1-thomas@monjalon.net>\n <20230913103600.1935292-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_thread API must be used to ease OS porting.\nOne step of this process is to mark the necessary API as stable.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n doc/guides/rel_notes/release_23_11.rst | 1 +\n lib/eal/include/rte_thread.h | 64 --------------------------\n lib/eal/version.map | 40 ++++++++--------\n 3 files changed, 20 insertions(+), 85 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex d3d500f294..d7562fd646 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -115,6 +115,7 @@ API Changes\n \n * eal: The thread API has changed.\n The function ``rte_thread_create_control()`` does not take attributes anymore.\n+ The whole thread API was promoted to stable level.\n \n \n ABI Changes\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 28cc5220a4..dd1f62523f 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -73,9 +73,6 @@ typedef struct {\n typedef struct eal_tls_key *rte_thread_key;\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Create a new thread that will invoke the 'thread_func' routine.\n *\n * @param thread_id\n@@ -94,15 +91,11 @@ typedef struct eal_tls_key *rte_thread_key;\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_create(rte_thread_t *thread_id,\n \t\tconst rte_thread_attr_t *thread_attr,\n \t\trte_thread_func thread_func, void *arg);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Create a control thread.\n *\n * Creates a control thread with the given name and attributes. The\n@@ -124,15 +117,11 @@ int rte_thread_create(rte_thread_t *thread_id,\n * On success, returns 0; on error, it returns a negative value\n * corresponding to the error number.\n */\n-__rte_experimental\n int\n rte_thread_create_control(rte_thread_t *thread, const char *name,\n \t\trte_thread_func thread_func, void *arg);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Waits for the thread identified by 'thread_id' to terminate\n *\n * @param thread_id\n@@ -145,13 +134,9 @@ rte_thread_create_control(rte_thread_t *thread, const char *name,\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Indicate that the return value of the thread is not needed and\n * all thread resources should be release when the thread terminates.\n *\n@@ -162,25 +147,17 @@ int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr);\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_detach(rte_thread_t thread_id);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Get the id of the calling thread.\n *\n * @return\n * Return the thread id of the calling thread.\n */\n-__rte_experimental\n rte_thread_t rte_thread_self(void);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Set the name of the thread.\n * This API is a noop if the underlying platform does not\n * support setting the thread name or the platform-specific\n@@ -193,14 +170,10 @@ rte_thread_t rte_thread_self(void);\n * The name to set. Truncated to RTE_THREAD_NAME_SIZE,\n * including terminating NUL if necessary.\n */\n-__rte_experimental\n void\n rte_thread_set_name(rte_thread_t thread_id, const char *thread_name);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Check if 2 thread ids are equal.\n *\n * @param t1\n@@ -213,13 +186,9 @@ rte_thread_set_name(rte_thread_t thread_id, const char *thread_name);\n * If the ids are equal, return nonzero.\n * Otherwise, return 0.\n */\n-__rte_experimental\n int rte_thread_equal(rte_thread_t t1, rte_thread_t t2);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Initialize the attributes of a thread.\n * These attributes can be passed to the rte_thread_create() function\n * that will create a new thread and set its attributes according to attr.\n@@ -231,13 +200,9 @@ int rte_thread_equal(rte_thread_t t1, rte_thread_t t2);\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_attr_init(rte_thread_attr_t *attr);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Set the thread priority value in the thread attributes pointed to\n * by 'thread_attr'.\n *\n@@ -251,16 +216,12 @@ int rte_thread_attr_init(rte_thread_attr_t *attr);\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_attr_set_priority(rte_thread_attr_t *thread_attr,\n \t\tenum rte_thread_priority priority);\n \n #ifdef RTE_HAS_CPUSET\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Set the CPU affinity value in the thread attributes pointed to\n * by 'thread_attr'.\n *\n@@ -274,14 +235,10 @@ int rte_thread_attr_set_priority(rte_thread_attr_t *thread_attr,\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_attr_set_affinity(rte_thread_attr_t *thread_attr,\n \t\trte_cpuset_t *cpuset);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Get the value of CPU affinity that is set in the thread attributes pointed\n * to by 'thread_attr'.\n *\n@@ -295,14 +252,10 @@ int rte_thread_attr_set_affinity(rte_thread_attr_t *thread_attr,\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_attr_get_affinity(rte_thread_attr_t *thread_attr,\n \t\trte_cpuset_t *cpuset);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Set the affinity of thread 'thread_id' to the cpu set\n * specified by 'cpuset'.\n *\n@@ -316,14 +269,10 @@ int rte_thread_attr_get_affinity(rte_thread_attr_t *thread_attr,\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_set_affinity_by_id(rte_thread_t thread_id,\n \t\tconst rte_cpuset_t *cpuset);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Get the affinity of thread 'thread_id' and store it\n * in 'cpuset'.\n *\n@@ -337,7 +286,6 @@ int rte_thread_set_affinity_by_id(rte_thread_t thread_id,\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_get_affinity_by_id(rte_thread_t thread_id,\n \t\trte_cpuset_t *cpuset);\n \n@@ -364,9 +312,6 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp);\n #endif /* RTE_HAS_CPUSET */\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Get the priority of a thread.\n *\n * @param thread_id\n@@ -379,14 +324,10 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp);\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_get_priority(rte_thread_t thread_id,\n \t\tenum rte_thread_priority *priority);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Set the priority of a thread.\n *\n * @param thread_id\n@@ -399,7 +340,6 @@ int rte_thread_get_priority(rte_thread_t thread_id,\n * On success, return 0.\n * On failure, return a positive errno-style error number.\n */\n-__rte_experimental\n int rte_thread_set_priority(rte_thread_t thread_id,\n \t\tenum rte_thread_priority priority);\n \n@@ -421,7 +361,6 @@ int rte_thread_set_priority(rte_thread_t thread_id,\n * ENOEXEC - Specific OS error.\n */\n \n-__rte_experimental\n int rte_thread_key_create(rte_thread_key *key,\n \t\t\tvoid (*destructor)(void *));\n \n@@ -437,7 +376,6 @@ int rte_thread_key_create(rte_thread_key *key,\n * rte_errno can be: EINVAL - Invalid parameter passed.\n * ENOEXEC - Specific OS error.\n */\n-__rte_experimental\n int rte_thread_key_delete(rte_thread_key key);\n \n /**\n@@ -454,7 +392,6 @@ int rte_thread_key_delete(rte_thread_key key);\n * rte_errno can be: EINVAL - Invalid parameter passed.\n * ENOEXEC - Specific OS error.\n */\n-__rte_experimental\n int rte_thread_value_set(rte_thread_key key, const void *value);\n \n /**\n@@ -469,7 +406,6 @@ int rte_thread_value_set(rte_thread_key key, const void *value);\n * rte_errno can be: EINVAL - Invalid parameter passed.\n * ENOEXEC - Specific OS error.\n */\n-__rte_experimental\n void *rte_thread_value_get(rte_thread_key key);\n \n #ifdef __cplusplus\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 7940431e5a..33b853d7be 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -257,12 +257,31 @@ DPDK_24 {\n \trte_strscpy;\n \trte_strsplit;\n \trte_sys_gettid;\n+\trte_thread_attr_get_affinity;\n+\trte_thread_attr_init;\n+\trte_thread_attr_set_affinity;\n+\trte_thread_attr_set_priority;\n+\trte_thread_create;\n+\trte_thread_create_control;\n+\trte_thread_detach;\n+\trte_thread_equal;\n \trte_thread_get_affinity;\n+\trte_thread_get_affinity_by_id;\n+\trte_thread_get_priority;\n \trte_thread_is_intr;\n+\trte_thread_join;\n+\trte_thread_key_create;\n+\trte_thread_key_delete;\n \trte_thread_register;\n+\trte_thread_self;\n \trte_thread_set_affinity;\n+\trte_thread_set_affinity_by_id;\n+\trte_thread_set_name;\n+\trte_thread_set_priority;\n \trte_thread_setname;\n \trte_thread_unregister;\n+\trte_thread_value_get;\n+\trte_thread_value_set;\n \trte_uuid_compare;\n \trte_uuid_is_null;\n \trte_uuid_parse;\n@@ -368,10 +387,6 @@ EXPERIMENTAL {\n \t# added in 21.05\n \trte_devargs_reset;\n \trte_intr_callback_unregister_sync;\n-\trte_thread_key_create;\n-\trte_thread_key_delete;\n-\trte_thread_value_get;\n-\trte_thread_value_set;\n \trte_version_minor;\n \trte_version_month;\n \trte_version_prefix;\n@@ -392,26 +407,9 @@ EXPERIMENTAL {\n \n \t# added in 22.07\n \trte_drand;\n-\trte_thread_get_affinity_by_id;\n-\trte_thread_get_priority;\n-\trte_thread_self;\n-\trte_thread_set_affinity_by_id;\n-\trte_thread_set_priority;\n-\n-\t# added in 22.11\n-\trte_thread_attr_get_affinity;\n-\trte_thread_attr_init;\n-\trte_thread_attr_set_affinity;\n-\trte_thread_attr_set_priority;\n-\trte_thread_create;\n-\trte_thread_detach;\n-\trte_thread_equal;\n-\trte_thread_join;\n \n \t# added in 23.03\n \trte_lcore_register_usage_cb;\n-\trte_thread_create_control;\n-\trte_thread_set_name;\n \t__rte_eal_trace_generic_blob;\n \n \t# added in 23.07\n", "prefixes": [ "v2", "04/11" ] }