Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131098/?format=api
{ "id": 131098, "url": "http://patches.dpdk.org/api/patches/131098/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230902093708.2474711-1-zhoumin@loongson.cn/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230902093708.2474711-1-zhoumin@loongson.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/20230902093708.2474711-1-zhoumin@loongson.cn", "date": "2023-09-02T09:37:08", "name": "[1/1] drivers/net: fix checking for Tx simple", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b425770ca8e3750ca720a376c4de3874b96d8491", "submitter": { "id": 2394, "url": "http://patches.dpdk.org/api/people/2394/?format=api", "name": "zhoumin", "email": "zhoumin@loongson.cn" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230902093708.2474711-1-zhoumin@loongson.cn/mbox/", "series": [ { "id": 29407, "url": "http://patches.dpdk.org/api/series/29407/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29407", "date": "2023-09-02T09:37:08", "name": "[1/1] drivers/net: fix checking for Tx simple", "version": 1, "mbox": "http://patches.dpdk.org/series/29407/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131098/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131098/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A5F00422DC;\n\tSat, 2 Sep 2023 11:38:20 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DA485402A8;\n\tSat, 2 Sep 2023 11:38:19 +0200 (CEST)", "from mail.loongson.cn (mail.loongson.cn [114.242.206.163])\n by mails.dpdk.org (Postfix) with ESMTP id EA8FA402A1;\n Sat, 2 Sep 2023 11:38:16 +0200 (CEST)", "from loongson.cn (unknown [10.2.5.185])\n by gateway (Coremail) with SMTP id _____8CxNvGFAvNkWwEeAA--.60977S3;\n Sat, 02 Sep 2023 17:38:14 +0800 (CST)", "from localhost.localdomain (unknown [10.2.5.185])\n by localhost.localdomain (Coremail) with SMTP id\n AQAAf8AxX89_AvNk9ZJpAA--.58133S2;\n Sat, 02 Sep 2023 17:38:13 +0800 (CST)" ], "From": "Min Zhou <zhoumin@loongson.cn>", "To": "liudongdong3@huawei.com, yisen.zhuang@huawei.com, Yuying.Zhang@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com,\n ferruh.yigit@intel.com, roretzla@linux.microsoft.com, chenbo.xia@intel.com,\n ajit.khaparde@broadcom.com, jerinj@marvell.com, zhoumin@loongson.cn", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org,\n\tmaobibo@loongson.cn", "Subject": "[PATCH 1/1] drivers/net: fix checking for Tx simple", "Date": "Sat, 2 Sep 2023 17:37:08 +0800", "Message-Id": "<20230902093708.2474711-1-zhoumin@loongson.cn>", "X-Mailer": "git-send-email 2.39.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "AQAAf8AxX89_AvNk9ZJpAA--.58133S2", "X-CM-SenderInfo": "52kr3ztlq6z05rqj20fqof0/1tbiAQACAWTytjUABwA5sp", "X-Coremail-Antispam": "1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7\n ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx\n nUUI43ZEXa7xR_UUUUUUUUU==", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "We have such checking logic for Tx simple in some drivers, such as\ni40e, ice and hns3:\n /* Use a simple Tx queue if possible (only fast free is allowed) */\n ad->tx_simple_allowed =\n (txq->offloads ==\n (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) &&\n txq->tx_rs_thresh >= RTE_PMD_I40E_TX_MAX_BURST);\n\nWhat's confusing is that we will get the same result from above checking if\ntxq->offloads == 0 or txq->offloads == RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE.\nIs this the right checking logic for Tx simple? Besides, I haven't seen the\nsimilar usage to check the offload for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE.\nFix it if the checking logic is wrong.\n\nFixes: 295968d1740 (\"ethdev: add namespace\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Zhou <zhoumin@loongson.cn>\n---\n drivers/net/hns3/hns3_rxtx.c | 2 +-\n drivers/net/i40e/i40e_rxtx.c | 3 +--\n drivers/net/ice/ice_rxtx.c | 3 +--\n 3 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex f3c3b38c55..4c04187ce7 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -4357,7 +4357,7 @@ hns3_tx_check_simple_support(struct rte_eth_dev *dev)\n {\n \tuint64_t offloads = dev->data->dev_conf.txmode.offloads;\n \n-\treturn (offloads == (offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE));\n+\treturn !!(offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE);\n }\n \n static bool\ndiff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex d96bbbb677..c706c73880 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -3421,8 +3421,7 @@ i40e_set_tx_function_flag(struct rte_eth_dev *dev, struct i40e_tx_queue *txq)\n \n \t/* Use a simple Tx queue if possible (only fast free is allowed) */\n \tad->tx_simple_allowed =\n-\t\t(txq->offloads ==\n-\t\t (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) &&\n+\t\t((txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) &&\n \t\t txq->tx_rs_thresh >= RTE_PMD_I40E_TX_MAX_BURST);\n \tad->tx_vec_allowed = (ad->tx_simple_allowed &&\n \t\t\ttxq->tx_rs_thresh <= RTE_I40E_TX_MAX_FREE_BUF_SZ);\ndiff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex e07c6d1f15..3dbf6c592d 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -3640,8 +3640,7 @@ ice_set_tx_function_flag(struct rte_eth_dev *dev, struct ice_tx_queue *txq)\n \n \t/* Use a simple Tx queue if possible (only fast free is allowed) */\n \tad->tx_simple_allowed =\n-\t\t(txq->offloads ==\n-\t\t(txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) &&\n+\t\t((txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) &&\n \t\ttxq->tx_rs_thresh >= ICE_TX_MAX_BURST);\n \n \tif (ad->tx_simple_allowed)\n", "prefixes": [ "1/1" ] }