Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130973/?format=api
{ "id": 130973, "url": "http://patches.dpdk.org/api/patches/130973/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230831121058.725577-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230831121058.725577-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230831121058.725577-2-bruce.richardson@intel.com", "date": "2023-08-31T12:10:56", "name": "[1/3] vhost: fix build for powerpc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6d91e98f91119058abb401cdf7aeac04b470d9b3", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230831121058.725577-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29388, "url": "http://patches.dpdk.org/api/series/29388/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29388", "date": "2023-08-31T12:10:55", "name": "enable PPC in test-meson-builds on ubuntu", "version": 1, "mbox": "http://patches.dpdk.org/series/29388/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130973/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130973/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 724CC41FDD;\n\tThu, 31 Aug 2023 14:11:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6084540294;\n\tThu, 31 Aug 2023 14:11:14 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 5FE654028C;\n Thu, 31 Aug 2023 14:11:13 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Aug 2023 05:11:13 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.14])\n by fmsmga005.fm.intel.com with ESMTP; 31 Aug 2023 05:11:11 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1693483873; x=1725019873;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=MIosQbs1lRbFZdf+vtKScvZzjSFXtBhb0xvLhQkm+fo=;\n b=PVl788CezzLS6PcJGFDg2cDd3Noiwg8APnbPgVFfcP5RE7o17pGW2vcg\n Z5mUwqyRCH957gjcka3JmppJgQvbYIB0NyDL5o9Mg+WQUZADht/XSMtEI\n Pb+gI2SDepxIHXKJgYQX9yisGH6j86ZHvWBloH1A1RNdbFpyO8icry0Y1\n wSlAoW1CL6nlq0bIyGSNNMbLPMjKk65uFmPxjXjSXatD85DW2X066Sv0D\n 05UU6TUVtDVm2/S07RQ+97dRd9Qcq9N9RIUpJPFP6q+yp4vvLcYord9Cw\n ziAeW+LUjefu6EcqsqYO+9DM7489BTKQTpU+PNbTw6MfdmVhM4DbERu5f w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10818\"; a=\"373320661\"", "E=Sophos;i=\"6.02,216,1688454000\"; d=\"scan'208\";a=\"373320661\"", "E=McAfee;i=\"6600,9927,10818\"; a=\"1070238810\"", "E=Sophos;i=\"6.02,216,1688454000\"; d=\"scan'208\";a=\"1070238810\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, maxime.coquelin@redhat.com,\n stable@dpdk.org, Chenbo Xia <chenbo.xia@intel.com>,\n David Marchand <david.marchand@redhat.com>", "Subject": "[PATCH 1/3] vhost: fix build for powerpc", "Date": "Thu, 31 Aug 2023 13:10:56 +0100", "Message-Id": "<20230831121058.725577-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230831121058.725577-1-bruce.richardson@intel.com>", "References": "<20230831121058.725577-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When building on Ubuntu using the packaged powerpc compiler[1], a\nwarning is issued about the print format of the __u64 values.\n\n../../lib/vhost/vduse.c: In function ‘vduse_vring_setup’:\n../../lib/vhost/vhost.h:676:17: error: format ‘%llx’ expects argument of\ntype ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka\n‘long unsigned int’} [-Werror=format=]\n 676 | \"VHOST_CONFIG: (%s) \" fmt, prefix, ##args)\n | ^~~~~~~~~~~~~~~~~~~~~\n\nChanging the format specifier to %lx, or to use PRIx64 breaks other\nbuilds, so the safest solution is to explicitly typecast the printed\nvalues to match the format string.\n\n[1] powerpc64le-linux-gnu-gcc (Ubuntu 12.3.0-1ubuntu1~23.04) 12.3.0\n\nFixes: a9120db8b98b (\"vhost: add VDUSE device startup\")\nCc: maxime.coquelin@redhat.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/vhost/vduse.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c\nindex 73ed424232..e2b6d35d37 100644\n--- a/lib/vhost/vduse.c\n+++ b/lib/vhost/vduse.c\n@@ -162,9 +162,12 @@ vduse_vring_setup(struct virtio_net *dev, unsigned int index)\n \n \tVHOST_LOG_CONFIG(dev->ifname, INFO, \"VQ %u info:\\n\", index);\n \tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tnum: %u\\n\", vq_info.num);\n-\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdesc_addr: %llx\\n\", vq_info.desc_addr);\n-\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdriver_addr: %llx\\n\", vq_info.driver_addr);\n-\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdevice_addr: %llx\\n\", vq_info.device_addr);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdesc_addr: %llx\\n\",\n+\t\t\t(unsigned long long)vq_info.desc_addr);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdriver_addr: %llx\\n\",\n+\t\t\t(unsigned long long)vq_info.driver_addr);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdevice_addr: %llx\\n\",\n+\t\t\t(unsigned long long)vq_info.device_addr);\n \tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tavail_idx: %u\\n\", vq_info.split.avail_index);\n \tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tready: %u\\n\", vq_info.ready);\n \n", "prefixes": [ "1/3" ] }