Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130499/?format=api
{ "id": 130499, "url": "http://patches.dpdk.org/api/patches/130499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230818040139.626967-1-psatheesh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230818040139.626967-1-psatheesh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230818040139.626967-1-psatheesh@marvell.com", "date": "2023-08-18T04:01:39", "name": "common/cnxk: fix ROC naming convention", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "47bc21ecd25565049d6bd2d61b4c742f500ede15", "submitter": { "id": 1663, "url": "http://patches.dpdk.org/api/people/1663/?format=api", "name": "Satheesh Paul Antonysamy", "email": "psatheesh@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230818040139.626967-1-psatheesh@marvell.com/mbox/", "series": [ { "id": 29272, "url": "http://patches.dpdk.org/api/series/29272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29272", "date": "2023-08-18T04:01:39", "name": "common/cnxk: fix ROC naming convention", "version": 1, "mbox": "http://patches.dpdk.org/series/29272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130499/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/130499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2D81A4305F;\n\tFri, 18 Aug 2023 06:01:50 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A7C0440ED9;\n\tFri, 18 Aug 2023 06:01:49 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 555F740395\n for <dev@dpdk.org>; Fri, 18 Aug 2023 06:01:48 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37I1aR5o028723 for <dev@dpdk.org>; Thu, 17 Aug 2023 21:01:47 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3shy4d0ax9-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 17 Aug 2023 21:01:47 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 17 Aug 2023 21:01:45 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 17 Aug 2023 21:01:45 -0700", "from satheeshpaullabpc.. (unknown [10.28.34.33])\n by maili.marvell.com (Postfix) with ESMTP id C1CF23F707E;\n Thu, 17 Aug 2023 21:01:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=G9IcxMwJmmhDbP/b+EcaPFth6Sw+3YWs90g9JfHw2Lc=;\n b=MN7DBTHqpnGbnUGHCeINdkWu4S94XoQqaWUJjgBf5kNZeZQI5Ui2w1W557zvNa2EUL3n\n VJGBRnN6nEO5OIlUOW79hPI+nWn0jvJlG3vnSyQ1ihbwMT6e5SnoE03OAqzmeZQKQOeJ\n 0OwX1x7tBmmdmLSm8URdV+ZbFlBdLHaN358JcruZ9Qp69zcgjn3cAugQ32pZKi1Qkrfy\n SO8/MzRMpPUjDwPGxIwp+tIFL8tJ/dXpO00B+3/BcaoLJsTLZkQKtKitWn8t5ZSu8w49\n 2yYIjjJq6CMFlcWJbEFcTiPwQ0k7FaTKvmkN1YtyV0NIpQ7jUo4KndO4JhMpTzYGJd2I 1w==", "From": "<psatheesh@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Satheesh Paul <psatheesh@marvell.com>, Jerin Jacob\n <jerinj@marvell.com>", "Subject": "[dpdk-dev] [PATCH ] common/cnxk: fix ROC naming convention", "Date": "Fri, 18 Aug 2023 09:31:39 +0530", "Message-ID": "<20230818040139.626967-1-psatheesh@marvell.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "iWxUrE4Ek66QrRjRGatAyoANiXgjxXyx", "X-Proofpoint-GUID": "iWxUrE4Ek66QrRjRGatAyoANiXgjxXyx", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26\n definitions=2023-08-18_03,2023-08-17_02,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Satheesh Paul <psatheesh@marvell.com>\n\nFix ROC code naming convention.\n\nFixes: d110c44d29e7 (\"common/cnxk: support flow aging\")\n\nSigned-off-by: Satheesh Paul <psatheesh@marvell.com>\nReviewed-by: Jerin Jacob <jerinj@marvell.com>\n---\n drivers/common/cnxk/roc_npc.h | 2 +-\n drivers/common/cnxk/roc_npc_aging.c | 14 +++++++++-----\n 2 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_npc.h b/drivers/common/cnxk/roc_npc.h\nindex 2fb0aa7a4e..84c92f4c28 100644\n--- a/drivers/common/cnxk/roc_npc.h\n+++ b/drivers/common/cnxk/roc_npc.h\n@@ -224,7 +224,7 @@ struct roc_npc_action_port_id {\n struct roc_npc_action_age {\n \tuint32_t timeout : 24; /**< Time in seconds. */\n \tuint32_t reserved : 8; /**< Reserved, must be zero. */\n-\t/** The user flow context, NULL means the rte_flow pointer. */\n+\t/** The user flow context, NULL means the flow pointer. */\n \tvoid *context;\n };\n \ndiff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_npc_aging.c\nindex 94126fe9fd..874a7cd4ff 100644\n--- a/drivers/common/cnxk/roc_npc_aging.c\n+++ b/drivers/common/cnxk/roc_npc_aging.c\n@@ -62,7 +62,7 @@ check_timeout_cycles(struct roc_npc *roc_npc, uint32_t mcam_id)\n \tlist = &npc->age_flow_list;\n \tTAILQ_FOREACH(fl_iter, list, next) {\n \t\tif (fl_iter->flow->mcam_id == mcam_id &&\n-\t\t fl_iter->flow->timeout_cycles < rte_get_timer_cycles()) {\n+\t\t fl_iter->flow->timeout_cycles < plt_tsc_cycles()) {\n \t\t\t/* update bitmap */\n \t\t\tplt_bitmap_set(flow_age->aged_flows, mcam_id);\n \t\t\tif (!aging_enabled) {\n@@ -90,8 +90,8 @@ update_timeout_cycles(struct roc_npc *roc_npc, uint32_t mcam_id)\n \tlist = &npc->age_flow_list;\n \tTAILQ_FOREACH(fl_iter, list, next) {\n \t\tif (fl_iter->flow->mcam_id == mcam_id) {\n-\t\t\tfl_iter->flow->timeout_cycles = rte_get_timer_cycles() +\n-\t\t\t\tfl_iter->flow->timeout * rte_get_timer_hz();\n+\t\t\tfl_iter->flow->timeout_cycles = plt_tsc_cycles() +\n+\t\t\t\tfl_iter->flow->timeout * plt_tsc_hz();\n \t\t\tbreak;\n \t\t}\n \t}\n@@ -214,6 +214,11 @@ npc_age_flow_list_entry_add(struct roc_npc *roc_npc, struct roc_npc_flow *flow)\n \tstruct npc_age_flow_entry *new_entry;\n \n \tnew_entry = plt_zmalloc(sizeof(*new_entry), 0);\n+\tif (new_entry == NULL) {\n+\t\tplt_err(\"flow entry alloc failed\");\n+\t\treturn;\n+\t}\n+\n \tnew_entry->flow = flow;\n \troc_npc->flow_age.age_flow_refcnt++;\n \t/* List in ascending order of mcam entries */\n@@ -269,8 +274,7 @@ npc_aging_ctrl_thread_create(struct roc_npc *roc_npc,\n \n \tflow->age_context = age->context == NULL ? flow : age->context;\n \tflow->timeout = age->timeout;\n-\tflow->timeout_cycles = rte_get_timer_cycles() + age->timeout *\n-\t\t\t rte_get_timer_hz();\n+\tflow->timeout_cycles = plt_tsc_cycles() + age->timeout * plt_tsc_hz();\n \n \tif (flow_age->age_flow_refcnt == 0) {\n \t\tflow_age->aged_flows_get_thread_exit = false;\n", "prefixes": [] }